[Ozone/Wayland]Allow nativepixmap handle be imported as dmabuf [chromium/src : main]

0 views
Skip to first unread message

Kramer Ge (Gerrit)

unread,
Aug 19, 2024, 5:56:21 PM8/19/24
to Vasiliy Telezhnikov, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Vasiliy Telezhnikov

Kramer Ge voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Vasiliy Telezhnikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I467c811b48d5d4bd00897e9c23c96ea0b2f64942
Gerrit-Change-Number: 5797623
Gerrit-PatchSet: 1
Gerrit-Owner: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Comment-Date: Mon, 19 Aug 2024 17:56:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Vasiliy Telezhnikov (Gerrit)

unread,
Aug 19, 2024, 6:08:57 PM8/19/24
to Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge

Vasiliy Telezhnikov voted and added 1 comment

Votes added by Vasiliy Telezhnikov

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Vasiliy Telezhnikov . resolved

lgtm, thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I467c811b48d5d4bd00897e9c23c96ea0b2f64942
Gerrit-Change-Number: 5797623
Gerrit-PatchSet: 1
Gerrit-Owner: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Kramer Ge <fang...@chromium.org>
Gerrit-Comment-Date: Mon, 19 Aug 2024 18:08:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Kramer Ge (Gerrit)

unread,
Aug 19, 2024, 7:54:08 PM8/19/24
to Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Kramer Ge voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I467c811b48d5d4bd00897e9c23c96ea0b2f64942
Gerrit-Change-Number: 5797623
Gerrit-PatchSet: 1
Gerrit-Owner: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Comment-Date: Mon, 19 Aug 2024 19:54:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Aug 19, 2024, 7:56:58 PM8/19/24
to Kramer Ge, Vasiliy Telezhnikov, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[Ozone/Wayland]Allow nativepixmap handle be imported as dmabuf

Because linux system gbm cannot create YUV format buffers, it currently
also disallows importing YUV dmabufs as gbm_bo.
Pending Mesa MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23214

But we get YUV buffers from VaapiVideoDecoder, and the EGL/Vulkan driver
in Wayland session also supports importing it as a GPU_READ texture for
compositing. If the Wayland compositor claims support for YUV wl_buffers
it can also be overlaid.

This CL adds NativePixmapDmaBuf as an option for native_pixmap in
OzoneImageBacking. We can add a corresponding wayland wrapper for it
later to make a exportable to the wayland compositor.
Bug: 343352540
Change-Id: I467c811b48d5d4bd00897e9c23c96ea0b2f64942
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Commit-Queue: Kramer Ge <fang...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1343696}
Files:
  • M ui/ozone/platform/wayland/gpu/wayland_surface_factory.cc
Change size: S
Delta: 1 file changed, 18 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Vasiliy Telezhnikov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I467c811b48d5d4bd00897e9c23c96ea0b2f64942
Gerrit-Change-Number: 5797623
Gerrit-PatchSet: 2
Gerrit-Owner: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
open
diffy
satisfied_requirement

Mike Lothian (Gerrit)

unread,
Sep 11, 2024, 11:42:14 AM9/11/24
to Chromium LUCI CQ, Vasiliy Telezhnikov, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Mike Lothian added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Mike Lothian . resolved

Hi

I think this commit is causing the below errors when trying to play some videos in a pure wayland vulkan environment with VAAPI

[32925:12:0911/120606.976184:ERROR:ffmpeg_common.cc(970)] Unsupported pixel format: -1
[32869:26:0911/120609.315668:ERROR:ffmpeg_common.cc(970)] Unsupported pixel format: -1
[32595:32739:0911/120609.317454:ERROR:gbm_pixmap_wayland.cc(82)] Cannot create bo with format= YUV_420_BIPLANAR and usage=SCANOUT_CPU_READ_WRITE
[32595:32739:0911/120609.317517:ERROR:gpu_channel.cc(502)] Buffer Handle is null.
[32869:26:0911/120609.317586:ERROR:shared_image_interface_proxy.cc(134)] Buffer handle is null. Not creating a mailbox from it.
...
...
[32869:26:0911/120610.750868:ERROR:ffmpeg_common.cc(970)] Unsupported pixel format: -1
[33061:13:0911/120610.941878:ERROR:ffmpeg_common.cc(970)] Unsupported pixel format: -1
[0911/121550.813436:ERROR:file_io.cc(94)] ReadExactly: expected 8, observed 0


Everything was working in chromium 128

I've also tried applying the pending MR to Mesa and I'm still seeing the same messages

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I467c811b48d5d4bd00897e9c23c96ea0b2f64942
Gerrit-Change-Number: 5797623
Gerrit-PatchSet: 2
Gerrit-Owner: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-CC: Mike Lothian <mi...@fireburn.co.uk>
Gerrit-Comment-Date: Wed, 11 Sep 2024 11:42:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages