[Ozone/Wayland]Allow nativepixmap handle be imported as dmabuf [chromium/src : main]
Kramer Ge (Gerrit)
Kramer Ge voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Vasiliy Telezhnikov
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
1 comment
Related details
- Kramer Ge
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Kramer Ge voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[Ozone/Wayland]Allow nativepixmap handle be imported as dmabuf
Because linux system gbm cannot create YUV format buffers, it currently
also disallows importing YUV dmabufs as gbm_bo.
Pending Mesa MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23214
But we get YUV buffers from VaapiVideoDecoder, and the EGL/Vulkan driver
in Wayland session also supports importing it as a GPU_READ texture for
compositing. If the Wayland compositor claims support for YUV wl_buffers
it can also be overlaid.
This CL adds NativePixmapDmaBuf as an option for native_pixmap in
OzoneImageBacking. We can add a corresponding wayland wrapper for it
later to make a exportable to the wayland compositor.
- M ui/ozone/platform/wayland/gpu/wayland_surface_factory.cc
Code-Review: +1 by Vasiliy Telezhnikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike Lothian (Gerrit)
Mike Lothian added 1 comment![]( "Open in Gerrit")
Hi
I think this commit is causing the below errors when trying to play some videos in a pure wayland vulkan environment with VAAPI
[32925:12:0911/120606.976184:ERROR:ffmpeg_common.cc(970)] Unsupported pixel format: -1
[32869:26:0911/120609.315668:ERROR:ffmpeg_common.cc(970)] Unsupported pixel format: -1
[32595:32739:0911/120609.317454:ERROR:gbm_pixmap_wayland.cc(82)] Cannot create bo with format= YUV_420_BIPLANAR and usage=SCANOUT_CPU_READ_WRITE
[32595:32739:0911/120609.317517:ERROR:gpu_channel.cc(502)] Buffer Handle is null.
[32869:26:0911/120609.317586:ERROR:shared_image_interface_proxy.cc(134)] Buffer handle is null. Not creating a mailbox from it.
...
...
[32869:26:0911/120610.750868:ERROR:ffmpeg_common.cc(970)] Unsupported pixel format: -1
[33061:13:0911/120610.941878:ERROR:ffmpeg_common.cc(970)] Unsupported pixel format: -1
[0911/121550.813436:ERROR:file_io.cc(94)] ReadExactly: expected 8, observed 0
Everything was working in chromium 128
I've also tried applying the pending MR to Mesa and I'm still seeing the same messages
Related details
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |