gbm_pixmap: Avoid spamming BO create failures [chromium/src : main]

0 views
Skip to first unread message

Thomas Anderson (Gerrit)

unread,
May 13, 2026, 5:01:10 PM (11 days ago) May 13
to Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com
Attention needed from Thomas Lukaszewicz

Thomas Anderson voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id85c79187b5e06f3c91163fb11586d9e38dd1c3c
Gerrit-Change-Number: 7846382
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Wed, 13 May 2026 21:01:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Lukaszewicz (Gerrit)

unread,
May 13, 2026, 5:56:13 PM (11 days ago) May 13
to Thomas Anderson, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com
Attention needed from Thomas Anderson

Thomas Lukaszewicz voted and added 1 comment

Votes added by Thomas Lukaszewicz

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Thomas Lukaszewicz . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Anderson
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id85c79187b5e06f3c91163fb11586d9e38dd1c3c
    Gerrit-Change-Number: 7846382
    Gerrit-PatchSet: 3
    Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Comment-Date: Wed, 13 May 2026 21:56:01 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    May 13, 2026, 11:18:13 PM (11 days ago) May 13
    to Thomas Anderson, Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, ozone-...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    gbm_pixmap: Avoid spamming BO create failures

    Use a set of failed formats to restrict logging and avoid spamming
    the console with redundant error messages for the same format.
    Bug: 512917902
    Change-Id: Id85c79187b5e06f3c91163fb11586d9e38dd1c3c
    Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
    Auto-Submit: Thomas Anderson <thomasa...@chromium.org>
    Commit-Queue: Thomas Lukaszewicz <tl...@chromium.org>
    Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1630397}
    Files:
    • M ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc
    Change size: S
    Delta: 1 file changed, 11 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Thomas Lukaszewicz
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id85c79187b5e06f3c91163fb11586d9e38dd1c3c
    Gerrit-Change-Number: 7846382
    Gerrit-PatchSet: 4
    Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages