gbm_pixmap: Avoid spamming BO create failures [chromium/src : main]

[Thomas Anderson (Gerrit)]

Attention needed from Thomas Lukaszewicz

Thomas Anderson voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

• Thomas Lukaszewicz

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id85c79187b5e06f3c91163fb11586d9e38dd1c3c

Gerrit-Change-Number: 7846382

Gerrit-PatchSet: 3

Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>

Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>

Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-Attention: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-Comment-Date: Wed, 13 May 2026 21:01:01 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Thomas Lukaszewicz (Gerrit)]

Attention needed from Thomas Anderson

Thomas Lukaszewicz voted and added 1 comment

Votes added by Thomas Lukaszewicz

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Thomas Lukaszewicz . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:

• Thomas Anderson

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id85c79187b5e06f3c91163fb11586d9e38dd1c3c

Gerrit-Change-Number: 7846382

Gerrit-PatchSet: 3

Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>

Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>

Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>

Gerrit-Comment-Date: Wed, 13 May 2026 21:56:01 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

gbm_pixmap: Avoid spamming BO create failures

Use a set of failed formats to restrict logging and avoid spamming
the console with redundant error messages for the same format.

Bug: 512917902

Change-Id: Id85c79187b5e06f3c91163fb11586d9e38dd1c3c

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7846382

Commit-Queue: Thomas Anderson <thomasa...@chromium.org>

Auto-Submit: Thomas Anderson <thomasa...@chromium.org>

Commit-Queue: Thomas Lukaszewicz <tl...@chromium.org>

Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1630397}

Files:

• M ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc

Change size: S

Delta: 1 file changed, 11 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Thomas Lukaszewicz

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id85c79187b5e06f3c91163fb11586d9e38dd1c3c

Gerrit-Change-Number: 7846382

Gerrit-PatchSet: 4

Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>

Gerrit-Reviewer: Thomas Lukaszewicz <tl...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>