[tracing] Migrate legacy TRACE_EVENT_API_GET_CATEGORY_GROUP_ENABLED [chromium/src : main]
0 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Aug 7, 2026, 10:23:07 AM (6 days ago) Aug 7
to Geoff Lang, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, geoffla...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, ozone-...@chromium.org, pasko...@chromium.org, scheduler...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
Attention needed from Geoff Lang
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Etienne Pierre-Doray . resolved
+geofflang@ for gpu/command_buffer/
Related details
Attention is currently required from:
- Geoff Lang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Aug 11, 2026, 2:37:25 PM (2 days ago) Aug 11
to Daniel Cheng, Geoff Lang, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, geoffla...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, ozone-...@chromium.org, pasko...@chromium.org, scheduler...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
Attention needed from Daniel Cheng and Geoff Lang
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Daniel Cheng
- Geoff Lang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Geoff Lang (Gerrit)
Aug 11, 2026, 3:15:59 PM (2 days ago) Aug 11
to Etienne Pierre-Doray, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, geoffla...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, ozone-...@chromium.org, pasko...@chromium.org, scheduler...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
Attention needed from Daniel Cheng and Etienne Pierre-Doray
Geoff Lang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Geoff Lang
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Daniel Cheng
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Aug 11, 2026, 6:23:03 PM (2 days ago) Aug 11
to Etienne Pierre-Doray, Daniel Cheng, Geoff Lang, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, geoffla...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, ozone-...@chromium.org, pasko...@chromium.org, scheduler...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
Attention needed from Etienne Pierre-Doray
Daniel Cheng voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Cheng
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Aug 11, 2026, 6:23:51 PM (2 days ago) Aug 11
to Etienne Pierre-Doray, Daniel Cheng, Geoff Lang, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, geoffla...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, ozone-...@chromium.org, pasko...@chromium.org, scheduler...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
Attention needed from Etienne Pierre-Doray
Daniel Cheng voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Cheng
| Owners-Override | +1 |
1 comment
Patchset-level comments
Daniel Cheng . resolved
OO+1 for //ui/latency as well, since it's a fairly trivial cleanup
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Aug 11, 2026, 7:03:15 PM (2 days ago) Aug 11
to Daniel Cheng, Geoff Lang, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, geoffla...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, ozone-...@chromium.org, pasko...@chromium.org, scheduler...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Aug 11, 2026, 8:59:51 PM (2 days ago) Aug 11
to Daniel Cheng, Geoff Lang, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, geoffla...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, ozone-...@chromium.org, pasko...@chromium.org, scheduler...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
Chromium LUCI CQ (Gerrit)
Aug 11, 2026, 9:39:22 PM (2 days ago) Aug 11
to Etienne Pierre-Doray, Daniel Cheng, Geoff Lang, chromium...@chromium.org, agriev...@chromium.org, geoffla...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, ozone-...@chromium.org, pasko...@chromium.org, scheduler...@chromium.org, torne...@chromium.org, yfriedm...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[tracing] Migrate legacy TRACE_EVENT_API_GET_CATEGORY_GROUP_ENABLED
Several callsites stored state as an optimization;
TRACE_EVENT_CATEGORY_ENABLED is the modern equivalent and uses compile
time tricks to convert category string to index, making storing state
unnecessary.
Bug: 432427382
Change-Id: I1529b3902e40bd323afb8fe2a1a80503a4c56870
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Owners-Override: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Geoff Lang <geof...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1677708}
Files:
- M base/android/trace_event_binding.cc
- M base/synchronization/waitable_event.cc
- M base/task/common/task_annotator.cc
- M base/task/sequence_manager/sequence_manager_impl.cc
- M base/task/sequence_manager/thread_controller.cc
- M gpu/command_buffer/service/gles2_cmd_decoder.cc
- M gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
- M gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
- M gpu/command_buffer/service/gpu_tracer.cc
- M gpu/command_buffer/service/gpu_tracer.h
- M gpu/command_buffer/service/gpu_tracer_unittest.cc
- M gpu/command_buffer/service/raster_decoder.cc
- M mojo/public/cpp/bindings/lib/connector.cc
- M mojo/public/cpp/bindings/lib/interface_endpoint_client.cc
- M ui/gl/gl_surface_egl.cc
- M ui/latency/latency_info.cc
Change size: M
Delta: 16 files changed, 45 insertions(+), 94 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Geoff Lang, +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages