RELAND: Migrate GURL::*_piece methods [chromium/src : main]

0 views

Skip to first unread message

Charlie Harrison (Gerrit)

unread,

Oct 3, 2025, 2:55:14 PM (4 days ago) Oct 3

to Daniel Cheng, Chromium LUCI CQ, bfcach...@chromium.org, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Nate Chapin, Javier Fernandez, Kevin McNee, Mike Taylor, Hiroki Nakagawa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Victor Tan, James Maclean, Zijie He, alexmo...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apaselti...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ayman...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cfredri...@chromium.org, chasej...@chromium.org, chikamu...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, cros-enterpris...@chromium.org, cros-print...@google.com, csharris...@chromium.org, derinel+wat...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, fuchsia...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hanxi...@chromium.org, harringt...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jdeblas...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, johnyki...@google.com, keithle...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, knollr+wat...@chromium.org, kuragin+web-ap...@chromium.org, liu+wa...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, marq+...@chromium.org, max+watc...@igalia.com, mdjone...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, milicau+watchlis...@google.com, msrame...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, nicolas...@chromium.org, njeunje+...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, ortuno...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, peilinwa...@google.com, petewi...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, ricea...@chromium.org, rizvis...@google.com, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org, svend+w...@chromium.org, tburkar...@chromium.org, thesals...@google.com, tmartino+tran...@chromium.org, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, xinghui...@chromium.org, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Daniel Cheng

Charlie Harrison added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Charlie Harrison . resolved

I will try to give the previous CL a couple hours to bake before landing.

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Oct 3, 2025, 4:22:23 PM (4 days ago) Oct 3

to Charlie Harrison, Daniel Cheng, Chromium LUCI CQ, bfcach...@chromium.org, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Nate Chapin, Javier Fernandez, Kevin McNee, Mike Taylor, Hiroki Nakagawa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Victor Tan, James Maclean, Zijie He, alexmo...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apaselti...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ayman...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cfredri...@chromium.org, chasej...@chromium.org, chikamu...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, cros-enterpris...@chromium.org, cros-print...@google.com, csharris...@chromium.org, derinel+wat...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, fuchsia...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hanxi...@chromium.org, harringt...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jdeblas...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, johnyki...@google.com, keithle...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, knollr+wat...@chromium.org, kuragin+web-ap...@chromium.org, liu+wa...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, marq+...@chromium.org, max+watc...@igalia.com, mdjone...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, milicau+watchlis...@google.com, msrame...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, nicolas...@chromium.org, njeunje+...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, ortuno...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, peilinwa...@google.com, petewi...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, ricea...@chromium.org, rizvis...@google.com, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org, svend+w...@chromium.org, tburkar...@chromium.org, thesals...@google.com, tmartino+tran...@chromium.org, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, xinghui...@chromium.org, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Charlie Harrison

Daniel Cheng added 1 comment

File url/gurl.h

Line 312, Patchset 2 (Parent): std::string_view scheme_piece() const LIFETIME_BOUND { return scheme(); }

Daniel Cheng . unresolved

I would suggest separating this bit out still, just to make reverts + relands less painful.

Open in Gerrit

Related details

Attention is currently required from:

Charlie Harrison

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Charlie Harrison (Gerrit)

unread,

Oct 3, 2025, 4:24:54 PM (4 days ago) Oct 3

Attention needed from Daniel Cheng

Charlie Harrison added 1 comment

File url/gurl.h

Line 312, Patchset 2 (Parent): std::string_view scheme_piece() const LIFETIME_BOUND { return scheme(); }

Daniel Cheng . resolved

I would suggest separating this bit out still, just to make reverts + relands less painful.

Charlie Harrison

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

satisfied_requirement

unsatisfied_requirement

open

diffy

Charlie Harrison (Gerrit)

unread,

Oct 3, 2025, 4:58:10 PM (4 days ago) Oct 3

Attention needed from Daniel Cheng

Charlie Harrison added 1 comment

File url/gurl.h

Line 312, Patchset 2 (Parent): std::string_view scheme_piece() const LIFETIME_BOUND { return scheme(); }

Daniel Cheng . resolved

I would suggest separating this bit out still, just to make reverts + relands less painful.

Charlie Harrison

Acknowledged

Charlie Harrison

Done.

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

Oct 3, 2025, 5:25:56 PM (4 days ago) Oct 3

Attention needed from Charlie Harrison

Daniel Cheng voted

Code-Review	+1
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

Charlie Harrison

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

satisfied_requirement

open

diffy

Charlie Harrison (Gerrit)

unread,

Oct 3, 2025, 5:44:54 PM (4 days ago) Oct 3

Charlie Harrison voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Oct 3, 2025, 6:49:31 PM (4 days ago) Oct 3

to Charlie Harrison, Daniel Cheng, bfcach...@chromium.org, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Nate Chapin, Javier Fernandez, Kevin McNee, Mike Taylor, Hiroki Nakagawa, Permissions Reviews, Peter Beverloo, prerendering-reviews, Victor Tan, James Maclean, Zijie He, alexmo...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, apaselti...@chromium.org, arc-review...@google.com, armalhotra+a...@google.com, ayman...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cbe-cep-eng...@google.com, cfredri...@chromium.org, chasej...@chromium.org, chikamu...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-ca...@google.com, chromium-a...@chromium.org, core-web-vita...@chromium.org, creis...@chromium.org, cros-enterpris...@chromium.org, cros-print...@google.com, csharris...@chromium.org, derinel+wat...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dimich...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, fuchsia...@chromium.org, gavin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, hanxi...@chromium.org, harringt...@chromium.org, headless...@chromium.org, hidehik...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, jdeblas...@chromium.org, jdh+wa...@chromium.org, jdonnel...@chromium.org, johnyki...@google.com, keithle...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, knollr+wat...@chromium.org, kuragin+web-ap...@chromium.org, liu+wa...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, loyso...@chromium.org, marq+...@chromium.org, max+watc...@igalia.com, mdjone...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, milicau+watchlis...@google.com, msrame...@chromium.org, mtomas...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, nicolas...@chromium.org, njeunje+...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, ortuno...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, peilinwa...@google.com, petewi...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, ricea...@chromium.org, rizvis...@google.com, servicewor...@chromium.org, shgar+aut...@google.com, shimazu+se...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org, svend+w...@chromium.org, tburkar...@chromium.org, thesals...@google.com, tmartino+tran...@chromium.org, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, xinghui...@chromium.org, ydago...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

RELAND: Migrate GURL::*_piece methods

This partially relands crrev.com/c/7003911. Which was reverted
because it depended on crrev.com/c/7003625 which broke some builders.

It's only changes are to add callers in new code since it was first
generated, and to revert the GURL changes to a follow-up, which are
more risky.

Original description:
This CL removes GURL::path_piece() and friends to GURL::path().
All callers are migrated.

This CL was generated with the following command:
git grep -l "host_piece()" | xargs sed -i 's/host_piece()/host()/g'

And the same for scheme, port, password, username, path, query, ref.
This completes phase 1.5 of crbug.com/448174617

The only manual edits were in the following files:
- scanner_action_handler_unittest.cc
- quick_insert_controller_unittest.cc

which use GURL function references.

Bug: 448174617

Change-Id: Ie2c8d1043057fcb28a4e1c06e33ecb72d4976a6c

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7003457

Owners-Override: Daniel Cheng <dch...@chromium.org>

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Commit-Queue: Charlie Harrison <cshar...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1525061}

Files:

M android_webview/browser/safe_browsing/aw_safe_browsing_allowlist_manager.cc
M ash/quick_insert/quick_insert_controller_unittest.cc
M ash/quick_insert/quick_insert_insert_media.cc
M ash/quick_insert/search/quick_insert_search_request.cc
M ash/scanner/scanner_action_handler.cc
M ash/scanner/scanner_action_handler_unittest.cc
M ash/webui/camera_app_ui/camera_app_ui.cc
M chrome/browser/actor/site_policy.cc
M chrome/browser/android/tab_web_contents_delegate_android.cc
M chrome/browser/app_mode/test/fake_origin_test_server_mixin.cc
M chrome/browser/apps/app_service/app_install/app_install_navigation_throttle.cc
M chrome/browser/apps/link_capturing/chromeos_reimpl_navigation_capturing_throttle.cc
M chrome/browser/apps/link_capturing/link_capturing_navigation_throttle.cc
M chrome/browser/ash/app_restore/full_restore_service.cc
M chrome/browser/ash/boca/on_task/on_task_locked_session_navigation_throttle.cc
M chrome/browser/ash/file_system_provider/operation_request_manager.cc
M chrome/browser/ash/fileapi/external_file_url_util.cc
M chrome/browser/ash/image_source/image_source.cc
M chrome/browser/ash/input_method/url_utils.cc
M chrome/browser/ash/system_web_apps/apps/terminal_source.cc
M chrome/browser/ash/system_web_apps/test_support/test_system_web_app_web_ui_controller_factory.cc
M chrome/browser/browser_switcher/browser_switcher_sitelist.cc
M chrome/browser/chrome_worker_browsertest.cc
M chrome/browser/chromeos/tablet_mode/chrome_content_browser_client_tablet_mode_part.cc
M chrome/browser/client_hints/client_hints_browsertest.cc
M chrome/browser/content_language/content_language_browsertest.cc
M chrome/browser/devtools/devtools_ui_bindings.cc
M chrome/browser/devtools/protocol/devtools_protocol_browsertest.cc
M chrome/browser/engagement/important_sites_util.cc
M chrome/browser/enterprise/client_certificates/client_certificates_browsertest.cc
M chrome/browser/enterprise/connectors/connectors_service.cc
M chrome/browser/enterprise/connectors/referrer_cache_utils.cc
M chrome/browser/enterprise/data_protection/data_protection_navigation_observer.cc
M chrome/browser/enterprise/platform_auth/cloud_ap_utils_win.cc
M chrome/browser/enterprise/reporting/security_reporting_browsertest.cc
M chrome/browser/extensions/api/chrome_extensions_api_client.cc
M chrome/browser/extensions/api/notifications/extension_notification_handler.cc
M chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc
M chrome/browser/extensions/api/web_request/web_request_apitest.cc
M chrome/browser/extensions/content_script_apitest.cc
M chrome/browser/extensions/extension_override_apitest.cc
M chrome/browser/extensions/extension_special_storage_policy.cc
M chrome/browser/extensions/extension_tab_util.cc
M chrome/browser/extensions/extension_web_ui.cc
M chrome/browser/extensions/updater/extension_updater_unittest.cc
M chrome/browser/external_protocol/auto_launch_protocols_policy_handler.cc
M chrome/browser/favicon/favicon_utils.cc
M chrome/browser/fingerprinting_protection/canvas_interventions_browsertest.cc
M chrome/browser/fingerprinting_protection/fingerprinting_protection_filter_browser_test_harness.cc
M chrome/browser/navigation_predictor/navigation_predictor.cc
M chrome/browser/optimization_guide/optimization_guide_keyed_service_browsertest.cc
M chrome/browser/page_load_metrics/observers/chrome_gws_page_load_metrics_observer.cc
M chrome/browser/page_load_metrics/observers/core/amp_page_load_metrics_observer.cc
M chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
M chrome/browser/predictors/loading_predictor_browsertest.cc
M chrome/browser/printing/print_preview_dialog_controller.cc
M chrome/browser/reduce_accept_language/reduce_accept_language_browsertest.cc
M chrome/browser/renderer_context_menu/render_view_context_menu.cc
M chrome/browser/safe_browsing/download_protection/deep_scanning_browsertest.cc
M chrome/browser/search/most_visited_iframe_source.cc
M chrome/browser/search/search.cc
M chrome/browser/sessions/chrome_serialized_navigation_driver.cc
M chrome/browser/sessions/session_common_utils.cc
M chrome/browser/sharing/shared_clipboard/remote_copy_message_handler.cc
M chrome/browser/signin/bound_session_credentials/bound_session_cookie_refresh_service_impl.cc
M chrome/browser/signin/bound_session_credentials/bound_session_cookie_refresh_service_impl_unittest.cc
M chrome/browser/signin/bound_session_credentials/bound_session_params_util.cc
M chrome/browser/signin/bound_session_credentials/dice_bound_session_cookie_service.cc
M chrome/browser/ssl/https_first_mode_settings_tracker.cc
M chrome/browser/storage_access_api/api_browsertest.cc
M chrome/browser/storage_access_api/storage_access_grant_permission_context_unittest.cc
M chrome/browser/subresource_filter/subresource_filter_special_subframe_navigations_browsertest.cc
M chrome/browser/supervised_user/supervised_user_browser_utils.cc
M chrome/browser/supervised_user/supervised_user_verification_page.cc
M chrome/browser/tpcd/support/tpcd_support_browsertest.cc
M chrome/browser/ui/android/toolbar/location_bar_model_android.cc
M chrome/browser/ui/ash/quick_insert/quick_insert_interactive_uitest.cc
M chrome/browser/ui/browser.cc
M chrome/browser/ui/extensions/hosted_app_browser_controller.cc
M chrome/browser/ui/extensions/settings_overridden_dialog_browsertest.cc
M chrome/browser/ui/extensions/settings_overridden_params_providers.cc
M chrome/browser/ui/hats/trust_safety_sentiment_service.cc
M chrome/browser/ui/incognito_allowed_url.cc
M chrome/browser/ui/passwords/well_known_change_password_navigation_throttle_browsertest.cc
M chrome/browser/ui/startup/focus/match_candidate.cc
M chrome/browser/ui/startup/startup_tab_provider.cc
M chrome/browser/ui/tabs/tab_strip_model.cc
M chrome/browser/ui/toolbar/chrome_location_bar_model_delegate.cc
M chrome/browser/ui/views/bookmarks/saved_tab_groups/saved_tab_group_interactive_uitest.cc
M chrome/browser/ui/views/page_info/about_this_site_side_panel_coordinator.cc
M chrome/browser/ui/views/page_info/web_view_side_panel_view.cc
M chrome/browser/ui/views/user_education/custom_webui_help_bubble_interactive_uitest.cc
M chrome/browser/ui/web_applications/app_browser_controller.cc
M chrome/browser/ui/webauthn/authenticator_dialog_browsertest.cc
M chrome/browser/ui/webui/about/about_ui.cc
M chrome/browser/ui/webui/app_settings/web_app_settings_navigation_throttle.cc
M chrome/browser/ui/webui/chrome_content_browser_client_webui_part.cc
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
M chrome/browser/ui/webui/devtools/devtools_ui.cc
M chrome/browser/ui/webui/new_tab_page/untrusted_source.cc
M chrome/browser/ui/webui/ntp_microsoft_auth/ntp_microsoft_auth_response_capture_navigation_throttle.cc
M chrome/browser/ui/webui/sanitized_image_source.cc
M chrome/browser/ui/webui/settings/site_settings_handler.cc
M chrome/browser/ui/webui/side_panel/history_clusters/history_clusters_side_panel_ui.cc
M chrome/browser/ui/webui/support_tool/support_tool_ui.cc
M chrome/browser/ui/webui/theme_source.cc
M chrome/browser/ui/webui/whats_new/whats_new_ui.cc
M chrome/browser/web_applications/preinstalled_web_app_manager_browsertest.cc
M chrome/browser/web_applications/web_app_helpers.cc
M chrome/browser/web_applications/web_app_link_capturing_parameterized_browsertest.cc
M chrome/browser/web_applications/web_app_registrar.cc
M chrome/browser/webauthn/fake_security_domain_service.cc
M chrome/renderer/chrome_content_renderer_client.cc
M chrome/renderer/extensions/chrome_extensions_renderer_client.cc
M chrome/test/data/webui/mojo/mojo_file_system_access_browsertest.cc
M chrome/test/data/webui/mojo/mojo_web_ui_controller_browsertest.cc
M chrome/utility/importer/bookmarks_file_importer.cc
M chromeos/ash/experiences/arc/intent_helper/link_handler_model.cc
M components/autofill/core/browser/form_qualifiers.cc
M components/autofill/core/browser/payments/payments_window_manager_util.cc
M components/autofill/core/common/signatures.cc
M components/commerce/core/commerce_feature_list.cc
M components/commerce/core/heuristics/commerce_heuristics_provider.cc
M components/content_settings/core/common/content_settings_pattern.cc
M components/content_settings/core/common/host_indexed_content_settings.cc
M components/custom_handlers/protocol_handler_registry.cc
M components/custom_handlers/register_protocol_handler_permission_request.cc
M components/dom_distiller/content/browser/dom_distiller_viewer_source.cc
M components/dom_distiller/core/url_utils.cc
M components/domain_reliability/config.cc
M components/embedder_support/android/util/cdn_utils.cc
M components/enterprise/connectors/core/content_area_user_provider.cc
M components/facilitated_payments/core/validation/payment_link_validator.cc
M components/feed/core/v2/feed_network_impl.cc
M components/google/core/common/google_util.cc
M components/history/core/browser/url_utils.cc
M components/history/core/browser/visitsegment_database.cc
M components/lookalikes/core/lookalike_url_util.cc
M components/no_state_prefetch/browser/no_state_prefetch_manager.cc
M components/no_state_prefetch/browser/no_state_prefetch_utils.cc
M components/omnibox/browser/autocomplete_match.cc
M components/omnibox/browser/history_match.cc
M components/omnibox/browser/history_url_provider.cc
M components/omnibox/browser/omnibox_text_util.cc
M components/page_load_metrics/browser/metrics_web_contents_observer.cc
M components/page_load_metrics/browser/observers/service_worker_page_load_metrics_observer.cc
M components/page_load_metrics/google/browser/google_url_util.cc
M components/password_manager/core/browser/generation/password_requirements_spec_fetcher_impl.cc
M components/password_manager/core/browser/password_generation_frame_helper_unittest.cc
M components/password_manager/core/browser/password_manager.cc
M components/password_manager/core/browser/password_manager_util.cc
M components/password_manager/core/browser/password_suggestion_generator.cc
M components/policy/core/browser/url_blocklist_manager.cc
M components/safe_browsing/content/browser/triggers/trigger_util.cc
M components/safe_browsing/content/common/file_type_policies_policy_util.cc
M components/safe_browsing/core/browser/utils/safe_browsing_web_app_utils.cc
M components/safe_search_api/safe_search_util.cc
M components/search_engines/default_search_manager_unittest.cc
M components/search_engines/reconciling_template_url_data_holder.cc
M components/search_engines/template_url.cc
M components/search_engines/template_url_service.cc
M components/search_provider_logos/google_logo_api.cc
M components/services/app_service/public/cpp/intent_filter_util.cc
M components/signin/ios/browser/account_consistency_service.mm
M components/subresource_filter/content/shared/browser/child_frame_navigation_filtering_throttle.cc
M components/subresource_filter/core/common/first_party_origin.cc
M components/supervised_user/core/browser/supervised_user_url_filter.cc
M components/ukm/ukm_recorder_impl.cc
M components/url_formatter/elide_url.cc
M components/url_formatter/url_formatter.cc
M components/url_matcher/url_util.cc
M components/webapps/isolated_web_apps/url_loading/utils.cc
M content/browser/attribution_reporting/interop/runner.cc
M content/browser/attribution_reporting/privacy_sandbox_ads_apis_browsertest.cc
M content/browser/btm/btm_bounce_detector_browsertest.cc
M content/browser/btm/btm_bounce_detector_unittest.cc
M content/browser/btm/btm_page_visit_observer_browsertest.cc
M content/browser/child_process_security_policy_impl.cc
M content/browser/devtools/devtools_frontend_host_impl.cc
M content/browser/devtools/render_frame_devtools_agent_host_browsertest.cc
M content/browser/fenced_frame/fenced_frame_url_mapping_unittest.cc
M content/browser/interest_group/ad_auction_service_impl_unittest.cc
M content/browser/interest_group/auction_runner_unittest.cc
M content/browser/interest_group/interest_group_browsertest.cc
M content/browser/origin_trials/origin_trials_browsertest.cc
M content/browser/preloading/prefetch/contamination_delay_browsertest.cc
M content/browser/preloading/prerender/prerender_browsertest.cc
M content/browser/renderer_host/back_forward_cache_impl.cc
M content/browser/renderer_host/debug_urls.cc
M content/browser/renderer_host/navigation_request.cc
M content/browser/renderer_host/render_frame_host_impl.cc
M content/browser/security/coop/cross_origin_opener_policy_browsertest.cc
M content/browser/service_worker/service_worker_browsertest.cc
M content/browser/service_worker/service_worker_context_wrapper.cc
M content/browser/service_worker/service_worker_loader_helpers.cc
M content/browser/site_info.cc
M content/browser/site_per_process_browsertest.cc
M content/browser/webauth/webauth_request_security_checker.cc
M content/browser/webui/web_ui_data_source_impl.cc
M content/browser/webui/web_ui_main_frame_observer.cc
M content/browser/webui/web_ui_url_loader_factory.cc
M content/browser/worker_host/worker_browsertest.cc
M content/public/common/url_utils.cc
M content/public/test/url_loader_interceptor.cc
M content/renderer/local_resource_url_loader_factory.cc
M content/shell/browser/shell_content_browser_client.cc
M content/test/content_browser_test_utils_internal.cc
M device/fido/cable/v2_test_util.cc
M extensions/browser/api/web_request/web_request_permissions.cc
M extensions/browser/content_verifier/content_verify_job_unittest.cc
M extensions/browser/extension_error.cc
M extensions/browser/extension_navigation_throttle.cc
M extensions/browser/extension_protocols.cc
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
M extensions/browser/script_injection_tracker.cc
M extensions/browser/service_worker/service_worker_host.cc
M extensions/browser/test_extension_console_observer.cc
M extensions/browser/url_request_util.cc
M extensions/common/extension_urls.cc
M extensions/common/file_util.cc
M extensions/common/manifest_handlers/web_accessible_resources_info.cc
M extensions/common/url_pattern.cc
M extensions/renderer/api/file_system_natives.cc
M extensions/renderer/resource_request_policy.cc
M fuchsia_web/webengine/browser/content_directory_loader_factory.cc
M headless/test/headless_origin_trials_browsertest.cc
M ios/chrome/browser/download/model/ar_quick_look_tab_helper.mm
M ios/chrome/browser/download/ui/download_list/download_list_item.mm
M ios/chrome/browser/explain_with_gemini/coordinator/explain_with_gemini_mediator_egtest.mm
M ios/chrome/browser/favicon/model/favicon_client_impl.mm
M ios/chrome/browser/https_upgrades/model/https_upgrade_test_helper.mm
M ios/chrome/browser/lens_overlay/coordinator/lens_result_page_mediator.mm
M ios/chrome/browser/location_bar/ui_bundled/location_bar_model_delegate_ios.mm
M ios/chrome/browser/mini_map/model/mini_map_tab_helper.mm
M ios/chrome/browser/passwords/model/well_known_change_password_tab_helper_unittest.mm
M ios/chrome/browser/reader_mode/model/reader_mode_content_tab_helper.mm
M ios/chrome/browser/reader_mode/model/reader_mode_tab_helper.mm
M ios/chrome/browser/search_with/ui_bundled/search_with_mediator_egtest.mm
M ios/chrome/browser/sessions/model/ios_chrome_tab_restore_browser_agent.mm
M ios/chrome/browser/shared/model/url/url_util.mm
M ios/chrome/browser/side_swipe/ui_bundled/side_swipe_util.mm
M ios/chrome/browser/webui/ui_bundled/chrome_web_ui_ios_controller_factory.mm
M ios/chrome/common/x_callback_url.cc
M ios/net/protocol_handler_util_unittest.mm
M ios/testing/embedded_test_server_handlers.cc
M ios/web/content/init/ios_content_browser_client.cc
M media/filters/demuxer_manager.cc
M media/filters/hls_manifest_demuxer_engine.cc
M net/base/mime_sniffer.cc
M net/base/registry_controlled_domains/registry_controlled_domain.cc
M net/base/url_util.cc
M net/cookies/cookie_monster.cc
M net/device_bound_sessions/session.cc
M net/device_bound_sessions/session_inclusion_rules.cc
M net/device_bound_sessions/session_service_impl.cc
M net/dns/mapped_host_resolver.cc
M net/http/http_cache_transaction.cc
M net/http/http_network_transaction.cc
M net/http/http_server_properties_manager.cc
M net/http/http_stream_factory_job.cc
M net/http/http_stream_factory_job_controller.cc
M net/http/http_stream_factory_job_controller_unittest.cc
M net/http/http_stream_parser.cc
M net/http/no_vary_search_cache.cc
M net/http/no_vary_search_cache_unittest.cc
M net/proxy_resolution/proxy_bypass_rules.cc
M net/quic/dedicated_web_transport_http3_client.cc
M net/quic/quic_network_transaction_unittest.cc
M net/quic/quic_session_pool_proxy_job_unittest.cc
M net/reporting/reporting_delivery_agent.cc
M net/spdy/spdy_session.cc
M net/test/embedded_test_server/default_handlers.cc
M net/test/test_doh_server.cc
M net/url_request/redirect_info.cc
M net/url_request/url_request_http_job.cc
M net/url_request/url_request_job_unittest.cc
M net/url_request/url_request_unittest.cc
M net/websockets/websocket_end_to_end_test.cc
M printing/backend/cups_printer.cc
M services/device/geolocation/network_location_provider_unittest.cc
M services/network/cookie_settings.cc
M services/network/network_context_unittest.cc
M services/network/private_network_access_checker.cc
M services/network/public/cpp/is_potentially_trustworthy.cc
M services/network/public/cpp/simple_url_loader_unittest.cc
M services/network/public/cpp/sri_message_signatures.cc
M services/network/url_loader_unittest.cc
M storage/common/file_system/file_system_util.cc
M third_party/blink/renderer/platform/loader/fetch/url_loader/resource_request_sender.cc
M third_party/blink/renderer/platform/weborigin/kurl_test.cc
M ui/base/webui/web_ui_util.cc
M ui/ozone/platform/wayland/host/wayland_exchange_data_provider.cc
M ui/webui/examples/browser/webui_controller_factory.cc
M ui/webui/untrusted_web_ui_controller_factory.cc
M url/gurl.cc
M url/gurl_unittest.cc
M url/origin.cc
M url/scheme_host_port.cc

Change size: XL

Delta: 298 files changed, 687 insertions(+), 734 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Daniel Cheng

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages