Terracotta-Phase-1: Introduce `PushEGLintOrDie()` [chromium/src : main]

0 views

Skip to first unread message

Kalvin Lee (Gerrit)

unread,

Mar 30, 2026, 1:44:19 AM (4 days ago) Mar 30

to Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org

Attention needed from Kramer Ge

Kalvin Lee voted and added 1 comment

Votes added by Kalvin Lee

Auto-Submit

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Kalvin Lee . resolved

Roll d2 on `ui/ozone/OWNERS` -> Kramer to review, please. I will CC you on the bug.

Open in Gerrit

Related details

Attention is currently required from:

Kramer Ge

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kramer Ge (Gerrit)

unread,

Mar 30, 2026, 1:19:24 PM (3 days ago) Mar 30

to Kalvin Lee, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org

Attention needed from Kalvin Lee and Vasiliy Telezhnikov

Kramer Ge added 3 comments

File ui/ozone/common/native_pixmap_egl_binding.cc

Line 194, Patchset 1 (Latest): PushEGLintOrDie(pixmap->GetDmaBufOffset(attrs_plane), attrs);

Kramer Ge . unresolved

From the bug I thought only `offset` is required to perform checked cast. Other usages are safe here.

Line 196, Patchset 1 (Latest): PushEGLintOrDie(pixmap->GetDmaBufPitch(attrs_plane), attrs);

Kramer Ge . unresolved

pitch is already `checked_cast` to 32 bit [here](https://source.chromium.org/chromium/chromium/src/+/main:ui/gfx/linux/native_pixmap_dmabuf.cc;l=38;drc=cf44d078028acbcb97d0fc80630ba9087a9ae620;bpv=0;bpt=1)

Line 216, Patchset 1 (Latest): PushEGLintOrDie(pixmap->GetDmaBufOffset(pixmap_plane), attrs);

Kramer Ge . unresolved

ditto

Open in Gerrit

Related details

Attention is currently required from:

Kalvin Lee
Vasiliy Telezhnikov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages