aura: Clear window tracking state on kMouseExited for child windows [chromium/src : main]
0 views
Skip to first unread message
Michael Wojcicka (Gerrit)
May 15, 2026, 7:07:04 PM (9 days ago) May 15
to Mitsuru Oshima, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Sadrul Chowdhury, Zhe Su, ozone-...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Michael Wojcicka added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 11 (Latest):
Michael Wojcicka . resolved
FYI: I'm going to run the CQ but it will still fail on the previous test because I did not fix it yet. However I added more unit tests, which I want to run on Win/Mac to see if they pass.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Wojcicka (Gerrit)
May 15, 2026, 7:12:42 PM (9 days ago) May 15
to Mitsuru Oshima, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Sadrul Chowdhury, Zhe Su, ozone-...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Michael Wojcicka added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Michael Wojcicka . resolved
FYI: I'm going to run the CQ but it will still fail on the previous test because I did not fix it yet. However I added more unit tests, which I want to run on Win/Mac to see if they pass.
Michael Wojcicka
Sorry, just Windows (since macOS doesn't use Aura).
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
May 18, 2026, 5:38:13 PM (6 days ago) May 18
to Michael Wojcicka, Henrique Ferreiro, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Sadrul Chowdhury, Zhe Su, roblia...@chromium.org, sky+...@chromium.org, ozone-...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Michael Wojcicka
Mitsuru Oshima added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
Line 287, Patchset 12 (Latest):
recording_view->exit_location());Mitsuru Oshima . unresolved
I think you need to test this in interactive_u_tests, which generates actual native events. I also think you need a child (embedded) window as a target of the native window?
Related details
Attention is currently required from:
- Michael Wojcicka
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
May 18, 2026, 6:41:34 PM (6 days ago) May 18
to Michael Wojcicka, Henrique Ferreiro, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Sadrul Chowdhury, Zhe Su, roblia...@chromium.org, sky+...@chromium.org, ozone-...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Michael Wojcicka
Mitsuru Oshima added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Mitsuru Oshima . resolved
youI
Mitsuru Oshima
sorry for incomplete comment. Could you also verify that added tests fails without your patch?
Michael Wojcicka (Gerrit)
May 21, 2026, 6:40:03 PM (3 days ago) May 21
to Mitsuru Oshima, Henrique Ferreiro, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Sadrul Chowdhury, Zhe Su, roblia...@chromium.org, sky+...@chromium.org, ozone-...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Michael Wojcicka added 2 comments![]( "Open in Gerrit")
File ash/wm/native_cursor_manager_ash_unittest.cc
Line 250, Patchset 15 (Latest):
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow(),Michael Wojcicka . unresolved
Apparently `ui_controls` is not supported on ChromeOS.
Oshima-san, is `ui::test::EventGenerator` the recommended approach on CrOS?
File ui/views/widget/desktop_aura/desktop_native_widget_aura_interactive_uitest.cc
Line 214, Patchset 15 (Latest):
base::RunLoop run_loop;Michael Wojcicka . unresolved
Oshima-san, I know `base::RunLoop`'s are generally discouraged in production code, but here it doesn't seem too bad to use. WDYT?
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
May 23, 2026, 12:34:18 AM (yesterday) May 23
to Michael Wojcicka, Henrique Ferreiro, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Sadrul Chowdhury, Zhe Su, roblia...@chromium.org, sky+...@chromium.org, ozone-...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, jbauma...@chromium.org, keithle...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Michael Wojcicka
Mitsuru Oshima added 1 comment![]( "Open in Gerrit")
File ash/wm/native_cursor_manager_ash_unittest.cc
Line 250, Patchset 15 (Latest):
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow(),Michael Wojcicka . unresolved
Apparently `ui_controls` is not supported on ChromeOS.
Oshima-san, is `ui::test::EventGenerator` the recommended approach on CrOS?
Mitsuru Oshima
It is supported. You have to addd test to interactive_ui_tests. please see
ash/drag_drop/drag_drop_interactive_uitest.cc
Related details
Attention is currently required from:
- Michael Wojcicka
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages