Fix some formatting issues in //ui [chromium/src : main]

0 views
Skip to first unread message

Victor Vianna (Gerrit)

unread,
Dec 11, 2025, 12:47:26 AM (11 days ago) Dec 11
to Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, Sadrul Chowdhury, James Su, dcheng+c...@chromium.org, keithle...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, nona+...@chromium.org, ozone-...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Mitsuru Oshima

Victor Vianna voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mitsuru Oshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0c684fb8456c41678ce252a7161156bc9ce2cec4
Gerrit-Change-Number: 7245707
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Comment-Date: Thu, 11 Dec 2025 05:47:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Mitsuru Oshima (Gerrit)

unread,
Dec 11, 2025, 3:08:45 AM (11 days ago) Dec 11
to Victor Vianna, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, Sadrul Chowdhury, James Su, dcheng+c...@chromium.org, keithle...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, nona+...@chromium.org, ozone-...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Victor Vianna

Mitsuru Oshima voted and added 1 comment

Votes added by Mitsuru Oshima

Code-Review-1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Mitsuru Oshima . resolved

The blame history is more important than format for maintenance reasons, and I prefer to land these kind of changes as needed. (I'm fine with updating the lines that become part of CL)

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is blockingCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0c684fb8456c41678ce252a7161156bc9ce2cec4
    Gerrit-Change-Number: 7245707
    Gerrit-PatchSet: 1
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-Attention: Victor Vianna <victor...@google.com>
    Gerrit-Comment-Date: Thu, 11 Dec 2025 08:08:35 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    blocking_requirement
    open
    diffy

    Victor Vianna (Gerrit)

    unread,
    Dec 11, 2025, 6:55:03 AM (11 days ago) Dec 11
    to Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, Sadrul Chowdhury, James Su, dcheng+c...@chromium.org, keithle...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, nona+...@chromium.org, ozone-...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
    Attention needed from Mitsuru Oshima

    Victor Vianna added 1 comment

    Patchset-level comments
    Mitsuru Oshima . resolved

    The blame history is more important than format for maintenance reasons, and I prefer to land these kind of changes as needed. (I'm fine with updating the lines that become part of CL)

    Victor Vianna
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Mitsuru Oshima
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is blockingCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0c684fb8456c41678ce252a7161156bc9ce2cec4
    Gerrit-Change-Number: 7245707
    Gerrit-PatchSet: 1
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Comment-Date: Thu, 11 Dec 2025 11:54:51 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Mitsuru Oshima <osh...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    blocking_requirement
    open
    diffy

    Victor Vianna (Gerrit)

    unread,
    Dec 11, 2025, 6:55:08 AM (11 days ago) Dec 11
    to Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, Sadrul Chowdhury, James Su, dcheng+c...@chromium.org, keithle...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, nona+...@chromium.org, ozone-...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org

    Victor Vianna abandoned this change

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is blockingCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: abandon
    satisfied_requirement
    blocking_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages