Lei Zhang (Gerrit)

unread,

Nov 17, 2025, 12:26:22 PM (14 days ago) Nov 17

to Lei Zhang, Francois Pierre Doray, AyeAye, chromium...@chromium.org, chromotin...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Mathias Bynens, Peter Beverloo, Stephen Chenney, Zijie He, Chromium LUCI CQ, hashimo...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, tmartino+tran...@chromium.org, dmurph+wat...@chromium.org, abigailbk...@google.com, agriev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, headless...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jdeblas...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, media-cro...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, philli...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, vaapi-...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Francois Pierre Doray

Lei Zhang added 1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Lei Zhang . resolved

Please OO+1.

Open in Gerrit

Related details

Attention is currently required from:

Francois Pierre Doray

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Francois Pierre Doray (Gerrit)

unread,

Nov 18, 2025, 10:21:38 AM (13 days ago) Nov 18

to Lei Zhang, AyeAye, chromium...@chromium.org, chromotin...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Mathias Bynens, Peter Beverloo, Stephen Chenney, Zijie He, Chromium LUCI CQ, hashimo...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, tmartino+tran...@chromium.org, dmurph+wat...@chromium.org, abigailbk...@google.com, agriev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, headless...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jdeblas...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, media-cro...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, philli...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, vaapi-...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Lei Zhang

Francois Pierre Doray voted and added 1 comment

Votes added by Francois Pierre Doray

Code-Review	+1
Owners-Override	+1

1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Francois Pierre Doray . resolved

CR+1
OO+1 for mechanical changes outside of //base to adapt to a change in //base

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Nov 18, 2025, 10:24:19 AM (13 days ago) Nov 18

to Lei Zhang, Francois Pierre Doray, AyeAye, chromium...@chromium.org, chromotin...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Mathias Bynens, Peter Beverloo, Stephen Chenney, Zijie He, Chromium LUCI CQ, hashimo...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, tmartino+tran...@chromium.org, dmurph+wat...@chromium.org, abigailbk...@google.com, agriev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, headless...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jdeblas...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, media-cro...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, philli...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, vaapi-...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Lei Zhang voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Nov 18, 2025, 1:21:01 PM (13 days ago) Nov 18

to Lei Zhang, Francois Pierre Doray, AyeAye, Akihiro Ota, chromium...@chromium.org, chromotin...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Mathias Bynens, Peter Beverloo, Stephen Chenney, Zijie He, hashimo...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, tmartino+tran...@chromium.org, dmurph+wat...@chromium.org, abigailbk...@google.com, agriev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, headless...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jdeblas...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, media-cro...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, philli...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, vaapi-...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Move logging::LoggingSettings to base/logging/logging_settings.h

Move struct LoggingSettings, which is only used in a relatively small
number of files, out of base/logging.h and into its own header. Update
direct users and then do IWYU to fix the build. This effectively moves
base/files/file_path.h out of base/logging.h.

Change-Id: I04209f1063051b7399e335d7e30cb7abb9442c94

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7160150

Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>

Commit-Queue: Lei Zhang <the...@chromium.org>

Owners-Override: Francois Pierre Doray <fdo...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1546655}

Files:

M base/BUILD.gn
M base/fuchsia/fidl_event_handler_unittest.cc
M base/fuchsia/fuchsia_logging_unittest.cc
M base/i18n/build_utf8_validator_tables.cc
M base/logging.cc
M base/logging.h
A base/logging/logging_settings.h
M base/logging_unittest.cc
M base/logging_win.cc
M base/test/scoped_logging_settings.h
M base/test/test_suite.cc
M chrome/browser/ash/logging/logging.cc
M chrome/browser/os_crypt/app_bound_encryption_test_main.cc
M chrome/browser/web_applications/chrome_pwa_launcher/chrome_pwa_launcher_main.cc
M chrome/chrome_proxy/chrome_proxy_main_win.cc
M chrome/common/logging_chrome.cc
M chrome/common/logging_chrome.h
M chrome/credential_provider/extension/extension_main.cc
M chrome/credential_provider/gaiacp/gaia_credential_provider_module.cc
M chrome/credential_provider/setup/setup.cc
M chrome/enterprise_companion/enterprise_companion.cc
M chrome/enterprise_companion/test/run_all_integration_tests.cc
M chrome/enterprise_companion/test/run_all_unittests.cc
M chrome/enterprise_companion/test/test_crashpad_embedder.cc
M chrome/installer/gcapi/gcapi_dll.cc
M chrome/installer/util/logging_installer.cc
M chrome/test/accessibility/ax_client/ax_client_main.cc
M chrome/test/base/chromeos/crosier/helper/fake_chrome/fake_chrome_main.cc
M chrome/test/chromedriver/logging.cc
M chrome/updater/test/unit_test_util.cc
M chrome/updater/util/util.cc
M chrome/utility/safe_browsing/mac/dmg_fuzzer.cc
M chrome/windows_services/service_program/logging_support.cc
M chromecast/app/cast_main_delegate.cc
M chromecast/base/init_command_line_shlib.cc
M chromecast/crash/linux/crash_uploader.cc
M chromecast/external_mojo/external_service_support/process_setup.cc
M chromecast/tracing/tracing_service_main.cc
M components/chromeos_camera/jpeg_encode_accelerator_unittest.cc
M components/chromeos_camera/mjpeg_decode_accelerator_unittest.cc
M components/cronet/android/cronet_library_loader.cc
M components/policy/test_support/fake_dmserver.cc
M components/url_formatter/spoof_checks/top_domains/make_top_domain_list_variables.cc
M components/url_formatter/spoof_checks/top_domains/top_domain_generator.cc
M components/webrtc_logging/logging_unittest.cc
M components/wifi/wifi_test.cc
M components/zucchini/zucchini_main.cc
M content/app/android/library_loader_hooks.cc
M content/child/child_thread_impl.cc
M content/shell/app/shell_main_delegate.cc
M content/zygote/zygote_linux.cc
M extensions/shell/app/shell_main_delegate.cc
M fuchsia_web/common/init_logging.cc
M google_apis/gcm/tools/mcs_probe.cc
M headless/lib/headless_content_main_delegate.cc
M ios/chrome/app/startup/ios_chrome_main_delegate.mm
M ios/web_view/internal/web_view_web_main_delegate.mm
M media/gpu/test/video_test_environment.cc
M media/gpu/v4l2/test/v4l2_stateless_decoder.cc
M media/gpu/vaapi/test/decode.cc
M mojo/proxy/main.cc
M net/dns/dns_record_fuzzer.cc
M net/third_party/quiche/overrides/quiche_platform_impl/quiche_command_line_flags_impl.cc
M net/tools/cert_verify_tool/cert_verify_tool.cc
M net/tools/net_watcher/net_watcher.cc
M net/tools/root_store_tool/root_store_tool.cc
M net/tools/stress_cache/stress_cache.cc
M net/tools/testserver/run_testserver.cc
M net/tools/tld_cleanup/tld_cleanup.cc
M net/tools/transport_security_state_generator/transport_security_state_generator.cc
M remoting/base/logging_linux.cc
M remoting/base/logging_mac.cc
M remoting/base/logging_win.cc
M remoting/client/cli/remoting_client_main.cc
M remoting/host/setup/start_host_main.cc
M services/service_manager/public/cpp/service_executable/main.cc
M sql/fuzzers/recovery_lpm_fuzzer.cc
M third_party/blink/renderer/DEPS
M third_party/blink/renderer/platform/fonts/shaping/harfbuzz_shaper_fuzzer.cc
M third_party/crashpad/crashpad/handler/handler_main.cc
M third_party/crashpad/crashpad/test/gtest_main.cc
M third_party/puffin/src/chromium_main.cc
M third_party/win_virtual_display/controller/DEPS
M third_party/win_virtual_display/controller/display_driver_controller_main.cc
M tools/android/forwarder2/daemon.cc
M tools/mac/power/power_sampler/power_sampler_main.cc
M tools/memory/simulator/memory_simulator_main.cc
M ui/ozone/demo/ozone_demo.cc
M ui/ozone/demo/skia/skia_demo.cc
M ui/views_content_client/views_content_main_delegate.cc
M ui/webui/examples/app/main_delegate.cc

Change size: L

Delta: 91 files changed, 195 insertions(+), 82 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Francois Pierre Doray

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Fumitoshi Ukai (Gerrit)

unread,

Nov 18, 2025, 9:37:10 PM (12 days ago) Nov 18

to Lei Zhang, Chromium LUCI CQ, Fumitoshi Ukai, Francois Pierre Doray, AyeAye, chromium...@chromium.org, chromotin...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Mathias Bynens, Peter Beverloo, Stephen Chenney, Zijie He, hashimo...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, tmartino+tran...@chromium.org, dmurph+wat...@chromium.org, abigailbk...@google.com, agriev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, headless...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jdeblas...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, media-cro...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, philli...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, vaapi-...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Fumitoshi Ukai added 1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Fumitoshi Ukai . resolved

break win-chrome?

https://ci.chromium.org/ui/p/chrome/builders/ci/win-chrome/37974/blamelist
```
[87582/96243] CXX obj/chrome/browser/platform_experience/win/unit_tests/scoped_scheduler_for_testing.obj
..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.exe /c ../../chrome/browser/platform_experience/win/scoped_scheduler_for_testing.cc ...(too long)
In file included from ../../chrome/browser/platform_experience/win/scoped_scheduler_for_testing.cc:1:
../..\chrome/browser/platform_experience/win/scoped_scheduler_for_testing.h(22,8): error: no template named 'vector' in namespace 'std'
   22 |   std::vector<ComPtr<IRegisteredTask>> GetRegisteredTasks();
      |   ~~~~~^
../../chrome/browser/platform_experience/win/scoped_scheduler_for_testing.cc(53,6): error: no template named 'vector' in namespace 'std'
   53 | std::vector<ComPtr<IRegisteredTask>>
      | ~~~~~^
../../chrome/browser/platform_experience/win/scoped_scheduler_for_testing.cc(63,8): error: no member named 'vector' in namespace 'std'; did you mean 'hecto'?
   63 |   std::vector<ComPtr<IRegisteredTask>> tasks;
```

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Nov 18, 2025, 9:41:03 PM (12 days ago) Nov 18

to Lei Zhang, Chromium LUCI CQ, Fumitoshi Ukai, Francois Pierre Doray, AyeAye, chromium...@chromium.org, chromotin...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Mathias Bynens, Peter Beverloo, Stephen Chenney, Zijie He, hashimo...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, tmartino+tran...@chromium.org, dmurph+wat...@chromium.org, abigailbk...@google.com, agriev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, headless...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jdeblas...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, media-cro...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, philli...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, vaapi-...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Lei Zhang added 1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Fumitoshi Ukai . resolved

break win-chrome?

https://ci.chromium.org/ui/p/chrome/builders/ci/win-chrome/37974/blamelist
```
[87582/96243] CXX obj/chrome/browser/platform_experience/win/unit_tests/scoped_scheduler_for_testing.obj
..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.exe /c ../../chrome/browser/platform_experience/win/scoped_scheduler_for_testing.cc ...(too long)
In file included from ../../chrome/browser/platform_experience/win/scoped_scheduler_for_testing.cc:1:
../..\chrome/browser/platform_experience/win/scoped_scheduler_for_testing.h(22,8): error: no template named 'vector' in namespace 'std'
   22 |   std::vector<ComPtr<IRegisteredTask>> GetRegisteredTasks();
      |   ~~~~~^
../../chrome/browser/platform_experience/win/scoped_scheduler_for_testing.cc(53,6): error: no template named 'vector' in namespace 'std'
   53 | std::vector<ComPtr<IRegisteredTask>>
      | ~~~~~^
../../chrome/browser/platform_experience/win/scoped_scheduler_for_testing.cc(63,8): error: no member named 'vector' in namespace 'std'; did you mean 'hecto'?
   63 |   std::vector<ComPtr<IRegisteredTask>> tasks;
```

Lei Zhang

Whoops I did it again. I thought I triggered all the try bots, but I guess didn't. Will revert.

satisfied_requirement

open

diffy

Fumitoshi Ukai (Gerrit)

unread,

Nov 18, 2025, 9:41:28 PM (12 days ago) Nov 18

to Lei Zhang, Chromium LUCI CQ, Fumitoshi Ukai, Francois Pierre Doray, AyeAye, chromium...@chromium.org, chromotin...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Mathias Bynens, Peter Beverloo, Stephen Chenney, Zijie He, hashimo...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, tmartino+tran...@chromium.org, dmurph+wat...@chromium.org, abigailbk...@google.com, agriev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, headless...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jdeblas...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, media-cro...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, philli...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, vaapi-...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Fumitoshi Ukai added 1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Fumitoshi Ukai . resolved

break win-chrome?

https://ci.chromium.org/ui/p/chrome/builders/ci/win-chrome/37974/blamelist
```
[87582/96243] CXX obj/chrome/browser/platform_experience/win/unit_tests/scoped_scheduler_for_testing.obj
..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.exe /c ../../chrome/browser/platform_experience/win/scoped_scheduler_for_testing.cc ...(too long)
In file included from ../../chrome/browser/platform_experience/win/scoped_scheduler_for_testing.cc:1:
../..\chrome/browser/platform_experience/win/scoped_scheduler_for_testing.h(22,8): error: no template named 'vector' in namespace 'std'
   22 |   std::vector<ComPtr<IRegisteredTask>> GetRegisteredTasks();
      |   ~~~~~^
../../chrome/browser/platform_experience/win/scoped_scheduler_for_testing.cc(53,6): error: no template named 'vector' in namespace 'std'
   53 | std::vector<ComPtr<IRegisteredTask>>
      | ~~~~~^
../../chrome/browser/platform_experience/win/scoped_scheduler_for_testing.cc(63,8): error: no member named 'vector' in namespace 'std'; did you mean 'hecto'?
   63 |   std::vector<ComPtr<IRegisteredTask>> tasks;
```

Fumitoshi Ukai

https://issuetracker.google.com/461923242 win-chrome failure: ../..\chrome/browser/platform_experience/win/scoped_scheduler_for_testing.h(22,8): error: no template named 'vector' in namespace 'std'

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Nov 18, 2025, 9:41:40 PM (12 days ago) Nov 18

to Lei Zhang, Chromium LUCI CQ, Fumitoshi Ukai, Francois Pierre Doray, AyeAye, chromium...@chromium.org, chromotin...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, (Julie)Jeongeun Kim, Mathias Bynens, Peter Beverloo, Stephen Chenney, Zijie He, hashimo...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, tmartino+tran...@chromium.org, dmurph+wat...@chromium.org, abigailbk...@google.com, agriev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, fuchsia...@chromium.org, fuzzin...@chromium.org, grt+...@chromium.org, halliwe...@chromium.org, headless...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jdeblas...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, marq+...@chromium.org, media-cro...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, philli...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, vaapi-...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

Lei Zhang has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Move logging::LoggingSettings to base/logging/logging_settings.h [chromium/src : main]

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Related details

Francois Pierre Doray (Gerrit)

Francois Pierre Doray voted and added 1 comment

Votes added by Francois Pierre Doray

1 comment

Related details

Lei Zhang (Gerrit)

Lei Zhang voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

Fumitoshi Ukai (Gerrit)

Fumitoshi Ukai added 1 comment

Related details

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Fumitoshi Ukai (Gerrit)

Fumitoshi Ukai added 1 comment

Lei Zhang (Gerrit)

Lei Zhang has created a revert of this change

Related details