chrome-flags/lacros: set up flag for chrome color management [chromium/src : main]

Femi Adegunloye (Gerrit)

unread,

Aug 19, 2022, 7:44:08 PM8/19/22

to Kramer Ge, Mitsuru Oshima, Jim Shargo, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org

Attention is currently required from: Jim Shargo, Kramer Ge, Mitsuru Oshima.

Femi Adegunloye would like Kramer Ge, Mitsuru Oshima and Jim Shargo to review this change.

View Change

chrome-flags/lacros: set up flag for chrome color management

Allow chrome color management wayland protocol to be enabled or disabled
through chrome flags.

BUG=b:216664386

Change-Id: Ibbecce15ae267fcc46e92c91c29e9df0eb8387a0
---
M chrome/browser/about_flags.cc
M chrome/browser/flag-metadata.json
M chrome/browser/flag_descriptions.cc
M chrome/browser/flag_descriptions.h
M chromeos/constants/chromeos_features.cc
M chromeos/constants/chromeos_features.h
M ui/ozone/platform/wayland/host/wayland_zcr_color_manager.cc
7 files changed, 45 insertions(+), 1 deletion(-)

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Femi Adegunloye (Gerrit)

unread,

Aug 19, 2022, 7:44:18 PM8/19/22

to asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Jim Shargo, Kramer Ge, Mitsuru Oshima, chromium...@chromium.org

Attention is currently required from: Jim Shargo, Kramer Ge, Mitsuru Oshima.

View Change

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Mitsuru Oshima (Gerrit)

unread,

Aug 19, 2022, 7:57:21 PM8/19/22

to Femi Adegunloye, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Jim Shargo, Kramer Ge, chromium...@chromium.org

Attention is currently required from: Femi Adegunloye, Jim Shargo, Kramer Ge.

Patch set 1:Code-Review +1

View Change

1 comment:

File ui/ozone/platform/wayland/host/wayland_zcr_color_manager.cc:
- Patch Set #1, Line 31: return;
  maybe not creating the color manage is better way?

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Femi Adegunloye (Gerrit)

unread,

Aug 19, 2022, 9:37:01 PM8/19/22

to asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Mitsuru Oshima, Jim Shargo, Kramer Ge, chromium...@chromium.org

Attention is currently required from: Jim Shargo, Kramer Ge, Mitsuru Oshima.

View Change

1 comment:

File ui/ozone/platform/wayland/host/wayland_zcr_color_manager.cc:

- Patch Set #1, Line 31: return;
  maybe not creating the color manage is better way?

- Sorry not sure what you mean here? If I return early the WaylandZcrColorManager isn't created

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Mitsuru Oshima (Gerrit)

unread,

Aug 20, 2022, 2:29:51 PM8/20/22

to Femi Adegunloye, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Jim Shargo, Kramer Ge, chromium...@chromium.org

Attention is currently required from: Femi Adegunloye, Jim Shargo, Kramer Ge.

View Change

1 comment:

File ui/ozone/platform/wayland/host/wayland_zcr_color_manager.cc:

- Patch Set #1, Line 31: return;

- Sorry not sure what you mean here? If I return early the WaylandZcrColorManager isn't created
  Sorry what I really meant is not to register [1]. slgtm tho.
  [1] https://source.chromium.org/chromium/chromium/src/+/main:ui/ozone/platform/wayland/host/wayland_connection.cc;drc=8f90d2b35c2ae2bf6376493c6fd6aedcd0e2d0d1;l=186

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Kramer Ge (Gerrit)

unread,

Aug 22, 2022, 3:12:32 PM8/22/22

to Femi Adegunloye, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Mitsuru Oshima, Jim Shargo, chromium...@chromium.org

Attention is currently required from: Femi Adegunloye, Jim Shargo.

Patch set 1:Code-Review +1

View Change

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Jim Shargo (Gerrit)

unread,

Aug 24, 2022, 4:16:42 PM8/24/22

to Femi Adegunloye, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Mitsuru Oshima, chromium...@chromium.org

Attention is currently required from: Femi Adegunloye.

Patch set 1:Code-Review +1

View Change

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Femi Adegunloye (Gerrit)

unread,

Sep 2, 2022, 8:46:27 PM9/2/22

to asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Jim Shargo, Kramer Ge, Mitsuru Oshima, chromium...@chromium.org

Attention is currently required from: Jim Shargo, Kramer Ge, Mitsuru Oshima.

View Change

2 comments:

Patchset:
- Patch Set #2:
  I can't import chromeos_features from ui/ozone, so should I switch to ui_base_features? (I will remove chromeos_features code which is currently commentend out)
File ui/ozone/platform/wayland/host/wayland_zcr_color_manager.cc:

- Patch Set #1, Line 31: return;

- Sorry what I really meant is not to register [1]. slgtm tho. […]
  Done

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Mitsuru Oshima (Gerrit)

unread,

Sep 5, 2022, 12:01:36 PM9/5/22

to Femi Adegunloye, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Jim Shargo, Kramer Ge, chromium...@chromium.org

Attention is currently required from: Femi Adegunloye, Jim Shargo, Kramer Ge.

View Change

1 comment:

Patchset:
- Patch Set #2:
  I can't import chromeos_features from ui/ozone, so should I switch to ui_base_features? (I will remo […]
  sgtm

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Femi Adegunloye (Gerrit)

unread,

Sep 6, 2022, 1:35:49 PM9/6/22

to asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Jim Shargo, Kramer Ge, Mitsuru Oshima, chromium...@chromium.org

Attention is currently required from: Jim Shargo, Kramer Ge, Mitsuru Oshima.

Patch set 3:Commit-Queue +1

View Change

2 comments:

Patchset:
- Patch Set #2:
  sgtm
  Done
Patchset:
- Patch Set #3:
  Could everyone look and reapprove? Made a slight change to where the flags were stored.

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Kramer Ge (Gerrit)

unread,

Sep 6, 2022, 1:46:26 PM9/6/22

to Femi Adegunloye, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Chromium LUCI CQ, Jim Shargo, Mitsuru Oshima, chromium...@chromium.org

Attention is currently required from: Femi Adegunloye, Jim Shargo, Mitsuru Oshima.

Patch set 3:Code-Review +1

View Change

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Femi Adegunloye (Gerrit)

unread,

Sep 6, 2022, 3:20:49 PM9/6/22

to asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Chromium LUCI CQ, Jim Shargo, Mitsuru Oshima, chromium...@chromium.org

Attention is currently required from: Jim Shargo, Mitsuru Oshima.

Patch set 4:Commit-Queue +1

View Change

1 comment:

File chrome/browser/about_flags.cc:
- Patch Set #4, Line 7927:
  BUILDFLAG(IS_CHROMEOS)

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Mitsuru Oshima (Gerrit)

unread,

Sep 6, 2022, 5:00:49 PM9/6/22

to Femi Adegunloye, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Chromium LUCI CQ, Jim Shargo, chromium...@chromium.org

Attention is currently required from: Femi Adegunloye, Jim Shargo.

View Change

1 comment:

File chrome/browser/flag-metadata.json:
- Patch Set #4, Line 1355: {
  sort in alphabetical order. (around L4000)

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Femi Adegunloye (Gerrit)

unread,

Sep 6, 2022, 6:26:42 PM9/6/22

to asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Chromium LUCI CQ, Jim Shargo, Mitsuru Oshima, chromium...@chromium.org

Attention is currently required from: Jim Shargo, Mitsuru Oshima.

Patch set 5:Commit-Queue +1

View Change

1 comment:

File chrome/browser/flag-metadata.json:

- Patch Set #4, Line 1355: {

- sort in alphabetical order. […]
  Done

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Mitsuru Oshima (Gerrit)

unread,

Sep 7, 2022, 11:06:33 AM9/7/22

to Femi Adegunloye, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Chromium LUCI CQ, Jim Shargo, chromium...@chromium.org

Attention is currently required from: Femi Adegunloye, Jim Shargo.

Patch set 5:Code-Review +1

View Change

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Femi Adegunloye (Gerrit)

unread,

Sep 7, 2022, 12:55:07 PM9/7/22

to asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Mitsuru Oshima, Kramer Ge, Chromium LUCI CQ, Jim Shargo, chromium...@chromium.org

Attention is currently required from: Jim Shargo, Kramer Ge, Mitsuru Oshima.

Patch set 6:Commit-Queue +1

View Change

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Femi Adegunloye (Gerrit)

unread,

Sep 7, 2022, 1:54:19 PM9/7/22

to asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Mitsuru Oshima, Kramer Ge, Chromium LUCI CQ, Jim Shargo, chromium...@chromium.org

Attention is currently required from: Jim Shargo, Kramer Ge, Mitsuru Oshima.

Patch set 7:Commit-Queue +1

View Change

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Femi Adegunloye (Gerrit)

unread,

Sep 7, 2022, 5:24:53 PM9/7/22

to ccameron chromium, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Mitsuru Oshima, Kramer Ge, Jim Shargo

Attention is currently required from: Jim Shargo, Kramer Ge, Mitsuru Oshima, ccameron chromium.

Femi Adegunloye would like ccameron chromium to review this change.

View Change

chrome-flags/lacros: set up flag for chrome color management

Allow chrome color management wayland protocol to be enabled or disabled
through chrome flags.

BUG=b:216664386

Change-Id: Ibbecce15ae267fcc46e92c91c29e9df0eb8387a0
---
M chrome/browser/about_flags.cc
M chrome/browser/flag-metadata.json
M chrome/browser/flag_descriptions.cc
M chrome/browser/flag_descriptions.h

M tools/metrics/histograms/enums.xml
M ui/base/ui_base_features.cc
M ui/base/ui_base_features.h
M ui/ozone/platform/wayland/host/wayland_connection.cc
M ui/ozone/platform/wayland/host/wayland_zcr_color_manager.cc
9 files changed, 52 insertions(+), 3 deletions(-)

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Kramer Ge (Gerrit)

unread,

Sep 7, 2022, 5:40:34 PM9/7/22

to Femi Adegunloye, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, ccameron chromium, Mitsuru Oshima, Chromium LUCI CQ, Jim Shargo, chromium...@chromium.org

Attention is currently required from: Femi Adegunloye, Jim Shargo, Mitsuru Oshima, ccameron chromium.

Patch set 7:Code-Review +1

View Change

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

ccameron chromium (Gerrit)

unread,

Sep 8, 2022, 6:22:00 AM9/8/22

to Femi Adegunloye, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Mitsuru Oshima, Chromium LUCI CQ, Jim Shargo, chromium...@chromium.org

Attention is currently required from: Femi Adegunloye, Jim Shargo, Mitsuru Oshima.

Patch set 7:Code-Review +1

View Change

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Mitsuru Oshima (Gerrit)

unread,

Sep 8, 2022, 10:37:29 AM9/8/22

to Femi Adegunloye, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, ccameron chromium, Chromium LUCI CQ, Jim Shargo, chromium...@chromium.org

Attention is currently required from: Femi Adegunloye, Jim Shargo.

Patch set 7:Code-Review +1

View Change

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Femi Adegunloye (Gerrit)

unread,

Sep 8, 2022, 11:21:45 AM9/8/22

to asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Mitsuru Oshima, ccameron chromium, Chromium LUCI CQ, Jim Shargo, chromium...@chromium.org

Attention is currently required from: Jim Shargo.

Patch set 7:Commit-Queue +2

View Change

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Sep 8, 2022, 11:26:43 AM9/8/22

to Femi Adegunloye, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Mitsuru Oshima, ccameron chromium, Kramer Ge, Jim Shargo, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Kramer Ge: Looks good to me
  ccameron chromium: Looks good to me
  Mitsuru Oshima: Looks good to me
  Femi Adegunloye: Commit

chrome-flags/lacros: set up flag for chrome color management

Allow chrome color management wayland protocol to be enabled or disabled
through chrome flags.

BUG=b:216664386

Change-Id: Ibbecce15ae267fcc46e92c91c29e9df0eb8387a0

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842915
Commit-Queue: Femi Adegunloye <mrf...@google.com>
Reviewed-by: Mitsuru Oshima <osh...@chromium.org>
Reviewed-by: Kramer Ge <fang...@chromium.org>
Reviewed-by: ccameron chromium <ccam...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1044561}


---
M chrome/browser/about_flags.cc
M chrome/browser/flag-metadata.json
M chrome/browser/flag_descriptions.cc
M chrome/browser/flag_descriptions.h
M tools/metrics/histograms/enums.xml
M ui/base/ui_base_features.cc
M ui/base/ui_base_features.h
M ui/ozone/platform/wayland/host/wayland_connection.cc
M ui/ozone/platform/wayland/host/wayland_zcr_color_manager.cc

9 files changed, 58 insertions(+), 3 deletions(-)

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Jim Shargo (Gerrit)

unread,

Sep 8, 2022, 12:41:39 PM9/8/22

to Femi Adegunloye, asvitki...@chromium.org, jmedle...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, Chromium LUCI CQ, Mitsuru Oshima, ccameron chromium, chromium...@chromium.org

Patch set 7:Code-Review +1

View Change

2 comments:

File chrome/browser/flag-metadata.json:
- Patch Set #7, Line 4139:
  , chromeos-gfx-compositor@google (I think)
File chrome/browser/flag_descriptions.cc:
- Patch Set #7, Line 6238: .
  "When enabled, this should allow for HDR content to be displayed on compatible devices."

To view, visit change 3842915. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward