Reland "[ozone] Refactor GetSupportedFormatsForTexturing" [chromium/src : main]

0 views
Skip to first unread message

Saifuddin Hitawala (Gerrit)

unread,
Jan 12, 2026, 3:59:14 PMJan 12
to AyeAye, Chromium LUCI CQ, Colin Blundell, Vasiliy Telezhnikov, David Worsham, chromium...@chromium.org, Robert Kroeger, emi...@google.com, spang...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, fuchsia...@chromium.org
Attention needed from Colin Blundell and Vasiliy Telezhnikov

Saifuddin Hitawala voted and added 1 comment

Votes added by Saifuddin Hitawala

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1:
Saifuddin Hitawala . resolved

Please take a look. There are no changes here, but in previous CL [1] which has the msan failure fix.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/7451328

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • Vasiliy Telezhnikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie6746c5c9763561309ba40827d08179520971bee
Gerrit-Change-Number: 7456586
Gerrit-PatchSet: 2
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 20:59:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
Jan 12, 2026, 4:12:58 PMJan 12
to Saifuddin Hitawala, Colin Blundell, AyeAye, Chromium LUCI CQ, Vasiliy Telezhnikov, David Worsham, chromium...@chromium.org, Robert Kroeger, emi...@google.com, spang...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, fuchsia...@chromium.org
Attention needed from Saifuddin Hitawala and Vasiliy Telezhnikov

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Colin Blundell . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Saifuddin Hitawala
  • Vasiliy Telezhnikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie6746c5c9763561309ba40827d08179520971bee
Gerrit-Change-Number: 7456586
Gerrit-PatchSet: 2
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 21:12:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Saifuddin Hitawala (Gerrit)

unread,
Jan 12, 2026, 4:23:09 PMJan 12
to Colin Blundell, AyeAye, Chromium LUCI CQ, Vasiliy Telezhnikov, David Worsham, chromium...@chromium.org, Robert Kroeger, emi...@google.com, spang...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, fuchsia...@chromium.org
Attention needed from Vasiliy Telezhnikov

Saifuddin Hitawala voted and added 1 comment

Votes added by Saifuddin Hitawala

Commit-Queue+2

1 comment

Patchset-level comments
Saifuddin Hitawala . resolved

Thanks for reviewing!

Open in Gerrit

Related details

Attention is currently required from:
  • Vasiliy Telezhnikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie6746c5c9763561309ba40827d08179520971bee
Gerrit-Change-Number: 7456586
Gerrit-PatchSet: 2
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 21:23:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 12, 2026, 4:30:18 PMJan 12
to Saifuddin Hitawala, Colin Blundell, AyeAye, Vasiliy Telezhnikov, David Worsham, chromium...@chromium.org, Robert Kroeger, emi...@google.com, spang...@chromium.org, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com, fuchsia...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Reland "[ozone] Refactor GetSupportedFormatsForTexturing"

This is a reland of commit 885892f3daf270b4426363bdf1dd2c66d55cff8d

Original change's description:
> [ozone] Refactor GetSupportedFormatsForTexturing
>
> Refactor GetSupportedFormatsForTexturing to check for specific format
> instead of returning list of all supported formats. This is because
> it is used only for NV12/P010 formats and thus we can avoid checking
> for all BufferFormats. It also helps us get closer to removing
> BufferFormat usages.
>
> Bug: 454067872
> Change-Id: I4f96cf4e4df73c7733eb669cec016abd5a19a1a1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7411933
> Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
> Reviewed-by: Colin Blundell <blun...@chromium.org>
> Commit-Queue: Saifuddin Hitawala <hita...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1567164}
Bug: 454067872
Change-Id: Ie6746c5c9763561309ba40827d08179520971bee
Reviewed-by: Colin Blundell <blun...@chromium.org>
Commit-Queue: Saifuddin Hitawala <hita...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1568032}
Files:
  • M gpu/ipc/service/gpu_init.cc
  • M ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
  • M ui/ozone/platform/drm/gpu/gbm_surface_factory.h
  • M ui/ozone/platform/flatland/flatland_surface_factory.cc
  • M ui/ozone/platform/flatland/flatland_surface_factory.h
  • M ui/ozone/platform/wayland/gpu/wayland_surface_factory.cc
  • M ui/ozone/platform/wayland/gpu/wayland_surface_factory.h
  • M ui/ozone/platform/x11/x11_surface_factory.cc
  • M ui/ozone/platform/x11/x11_surface_factory.h
  • M ui/ozone/public/surface_factory_ozone.cc
  • M ui/ozone/public/surface_factory_ozone.h
Change size: M
Delta: 11 files changed, 88 insertions(+), 119 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Colin Blundell
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie6746c5c9763561309ba40827d08179520971bee
Gerrit-Change-Number: 7456586
Gerrit-PatchSet: 3
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages