Fix touchpad scroll sensitivity on Wayland. [chromium/src : main]

0 views

Skip to first unread message

Thomas Anderson (Gerrit)

unread,

Oct 2, 2025, 10:13:40 PM (5 days ago) Oct 2

to Jamie Walch, AyeAye, Orko Garai, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com

Attention needed from Jamie Walch and Orko Garai

Thomas Anderson voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Jamie Walch
Orko Garai

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Oct 2, 2025, 10:51:52 PM (5 days ago) Oct 2

to Jamie Walch, Thomas Anderson, AyeAye, Orko Garai, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com

Chromium LUCI CQ submitted the change

Change information

Commit message:

Fix touchpad scroll sensitivity on Wayland.

Chrome's scroll sensitivity with a touchpad is much higher on Wayland
than on other OSes. Chrome isn't alone in this--Terminal and several
other applications also scroll much faster than I'd expect--but one
notable exception is the "Test settings" page of the touchpad
configuration UI, the scroll sensitivity of which feels comparable to
using a touchpad on other OSes.

I believe that axis events coming via `OnAxis` should not be scaled at
all. That feels right when using a physical touchpad, but more
importantly, if `ei_device_scroll_delta` is used to inject scroll
events, the magnitude of those events is specified in pixels. The
comment in `OnAxis` (that this CL deletes) mentioned wheel ticks, but
this CL doesn't affect wheel ticks at all, since they are delivered via
`OnAxis120`, which takes precedence.

My ultimate goal is to have CRD host use `ei_device_scroll_delta` so
that we can support smooth scrolling. It's not currently possible due
to https://gitlab.freedesktop.org/libinput/libei/-/issues/88, but this
CL is a prerequisite. In particular, if the `OnAxis120` implementation
is removed in addition to this CL, then I can get the scroll distances
to match on client and host when Chrome Wayland is used at both ends.
Without this CL, Chrome running on the host scrolls 144 times too far
due to scroll distances being multiplied by 12 by Chrome at both ends.

Change-Id: Id576c3a10e3dc1847ab278502b31baf51592ce55

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7004208

Commit-Queue: Thomas Anderson <thomasa...@chromium.org>

Reviewed-by: Thomas Anderson <thomasa...@chromium.org>

Auto-Submit: Jamie Walch <jamie...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1524565}

Files:

M ui/ozone/platform/wayland/host/wayland_pointer.cc
M ui/ozone/platform/wayland/host/wayland_pointer_unittest.cc

Change size: M

Delta: 2 files changed, 40 insertions(+), 10 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Thomas Anderson

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages