[test] Fix test expectation in debug builds [v8/v8 : main]
0 views
Skip to first unread message
Dominik Inführ (Gerrit)
Apr 9, 2026, 5:09:11 AM (11 days ago) Apr 9
to Jakob Kummerow, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Jakob Kummerow
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
Apr 9, 2026, 6:12:51 AM (11 days ago) Apr 9
to Dominik Inführ, Jakob Kummerow, V8 LUCI CQ, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Jakob Kummerow voted![]( "Open in Gerrit")
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Apr 9, 2026, 6:14:33 AM (11 days ago) Apr 9
to Dominik Inführ, Jakob Kummerow, oilpan-r...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[test] Fix test expectation in debug builds
In debug builds CSS can find the TracedHandle on the stack, which
then shows up as a retaining path from the stack. This CL fixes
this by disabling CSS for the snapshot.
Bug: 492402253
Change-Id: Ib56dce84cf453f7a8f55305fc05320df610313ac
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Auto-Submit: Dominik Inführ <dinf...@chromium.org>
Commit-Queue: Jakob Kummerow <jkum...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106348}
Files:
- M test/unittests/heap/cppgc-js/unified-heap-snapshot-unittest.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jakob Kummerow
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages