[test] Fix test expectation in debug builds [v8/v8 : main]

0 views
Skip to first unread message

Dominik Inführ (Gerrit)

unread,
Apr 9, 2026, 5:09:11 AM (11 days ago) Apr 9
to Jakob Kummerow, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow

Dominik Inführ voted and added 1 comment

Votes added by Dominik Inführ

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Dominik Inführ . resolved

Thanks for reporting! PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Jakob Kummerow
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ib56dce84cf453f7a8f55305fc05320df610313ac
Gerrit-Change-Number: 7743261
Gerrit-PatchSet: 2
Gerrit-Owner: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Attention: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Comment-Date: Thu, 09 Apr 2026 09:09:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jakob Kummerow (Gerrit)

unread,
Apr 9, 2026, 6:12:51 AM (11 days ago) Apr 9
to Dominik Inführ, Jakob Kummerow, V8 LUCI CQ, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ

Jakob Kummerow voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Dominik Inführ
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ib56dce84cf453f7a8f55305fc05320df610313ac
Gerrit-Change-Number: 7743261
Gerrit-PatchSet: 2
Gerrit-Owner: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Attention: Dominik Inführ <dinf...@chromium.org>
Gerrit-Comment-Date: Thu, 09 Apr 2026 10:12:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Apr 9, 2026, 6:14:33 AM (11 days ago) Apr 9
to Dominik Inführ, Jakob Kummerow, oilpan-r...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[test] Fix test expectation in debug builds

In debug builds CSS can find the TracedHandle on the stack, which
then shows up as a retaining path from the stack. This CL fixes
this by disabling CSS for the snapshot.
Bug: 492402253
Change-Id: Ib56dce84cf453f7a8f55305fc05320df610313ac
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Auto-Submit: Dominik Inführ <dinf...@chromium.org>
Commit-Queue: Jakob Kummerow <jkum...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106348}
Files:
  • M test/unittests/heap/cppgc-js/unified-heap-snapshot-unittest.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Jakob Kummerow
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ib56dce84cf453f7a8f55305fc05320df610313ac
Gerrit-Change-Number: 7743261
Gerrit-PatchSet: 3
Gerrit-Owner: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages