[profiler] Drop heap-snapshot-generator-inl.h [v8/v8 : main]
0 views
Skip to first unread message
Dominik Inführ (Gerrit)
Mar 25, 2026, 12:50:41 PM (5 days ago) Mar 25
to Michael Lippautz, V8 LUCI CQ, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Michael Lippautz
Dominik Inführ added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Mar 25, 2026, 12:52:43 PM (5 days ago) Mar 25
to Dominik Inführ, V8 LUCI CQ, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Dominik Inführ
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Mar 25, 2026, 12:53:33 PM (5 days ago) Mar 25
to Michael Lippautz, V8 LUCI CQ, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Dominik Inführ voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Mar 25, 2026, 12:53:42 PM (5 days ago) Mar 25
to Michael Lippautz, V8 LUCI CQ, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Dominik Inführ added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Dominik Inführ . resolved
Thanks for the review!
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Mar 25, 2026, 12:55:27 PM (5 days ago) Mar 25
to Dominik Inführ, Michael Lippautz, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[profiler] Drop heap-snapshot-generator-inl.h
This CL moves all those methods into heap-snapshot-generator.cc.
Almost all uses are in there anyways.
Bug: 492402253
Change-Id: Ib9648dad4f8fb42cde67f66f9084a502c4e8e7fe
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106043}
Files:
- M BUILD.bazel
- M BUILD.gn
- M src/api/api.cc
- M src/profiler/allocation-tracker.cc
- M src/profiler/heap-profiler.cc
- D src/profiler/heap-snapshot-generator-inl.h
- M src/profiler/heap-snapshot-generator.cc
- M src/profiler/heap-snapshot-generator.h
- M test/cctest/test-heap-profiler.cc
- M test/unittests/heap/cppgc-js/unified-heap-snapshot-unittest.cc
Change size: M
Delta: 10 files changed, 76 insertions(+), 102 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages