Split Element-derived types into ElementSpace [chromium/src : main]
1 view
Skip to first unread message
chromeperf@appspot.gserviceaccount.com (Gerrit)
Jun 16, 2026, 6:57:58 AMJun 16
to Anton Bikineev, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Anton Bikineev
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/speedometer-main.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/103bdfa2c90000
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Jun 17, 2026, 4:47:34 AMJun 17
to Anton Bikineev, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Anton Bikineev
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bikineev (Gerrit)
Jun 17, 2026, 4:59:45 AMJun 17
to Michael Lippautz, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Anton Bikineev voted and added 1 comment![]( "Open in Gerrit")
Votes added by Anton Bikineev
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 17, 2026, 5:05:26 AMJun 17
to Anton Bikineev, Michael Lippautz, chrom...@appspot.gserviceaccount.com, chromium...@chromium.org, Kentaro Hara, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Split Element-derived types into ElementSpace
DOM style/layout traversal (e.g. ContainerNode::RecalcDescendantStyles)
walks the tree in document order, which is pre-order DFS and matches the
order in which the parser and most subtree builders allocate elements.
This moves Element-derived types out of NodeSpace into a dedicated
ElementSpace, so the pages backing those hot traversals hold pure
Element headers instead of being interspersed with Text/Comment/Attr
nodes. That raises the density of useful payload on the cache lines and
pages the walk touches.
Bug: 524577627
Change-Id: Iec60658edb1c69fa98a94d1e2e4de0b1629e0a23
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Anton Bikineev <biki...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1648161}
Files:
- M third_party/blink/renderer/core/dom/node.h
- M third_party/blink/renderer/platform/heap/custom_spaces.cc
- M third_party/blink/renderer/platform/heap/custom_spaces.h
- M third_party/blink/renderer/platform/heap/thread_state.cc
Change size: S
Delta: 4 files changed, 25 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages