[heap] Implement new Old Generation Heap Size [v8/v8 : main]

[Etienne Pierre-Doray (Gerrit)]

Attention needed from Dominik Inführ and Michael Lippautz

Etienne Pierre-Doray added 1 comment

Patchset-level comments

File-level comment, Patchset 27 (Latest):

Etienne Pierre-Doray . resolved

Ready to review, not that precursor landed

Open in Gerrit

Related details

Attention is currently required from:

• Dominik Inführ
• Michael Lippautz

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I65313ecb8654d97b23459498799e4f22e75963fd

Gerrit-Change-Number: 7069255

Gerrit-PatchSet: 27

Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Attention: Dominik Inführ <dinf...@chromium.org>

Gerrit-Comment-Date: Mon, 10 Nov 2025 19:31:06 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Dominik Inführ (Gerrit)]

Attention needed from Etienne Pierre-Doray and Michael Lippautz

Dominik Inführ added 2 comments

Patchset-level comments

File-level comment, Patchset 27 (Latest):

Dominik Inführ . resolved

LGTM in general modulo the test

File test/unittests/heap/heap-unittest.cc

Line 134, Patchset 27 (Latest):TEST(Heap, NewOldGenerationSizeFromPhysicalMemory) {

Dominik Inführ . unresolved

I would prefer if this test would be a copy of ExpectedDefaultGenerationLimitsForPhysicalMemory for this flag (or maybe integrate it into that test).

Open in Gerrit

Related details

Attention is currently required from:

• Etienne Pierre-Doray
• Michael Lippautz

Submit Requirements:

• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I65313ecb8654d97b23459498799e4f22e75963fd

Gerrit-Change-Number: 7069255

Gerrit-PatchSet: 27

Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-Comment-Date: Thu, 13 Nov 2025 14:29:36 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Etienne Pierre-Doray (Gerrit)]

Attention needed from Dominik Inführ and Michael Lippautz

Etienne Pierre-Doray added 2 comments

Patchset-level comments

File-level comment, Patchset 28 (Latest):

Etienne Pierre-Doray . resolved

PTAnL?

File test/unittests/heap/heap-unittest.cc

Line 134, Patchset 27:TEST(Heap, NewOldGenerationSizeFromPhysicalMemory) {

Dominik Inführ . resolved

I would prefer if this test would be a copy of ExpectedDefaultGenerationLimitsForPhysicalMemory for this flag (or maybe integrate it into that test).

Etienne Pierre-Doray

Good idea done (I think it's easier to make a copy).

Open in Gerrit

Related details

Attention is currently required from:

• Dominik Inführ
• Michael Lippautz

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I65313ecb8654d97b23459498799e4f22e75963fd

Gerrit-Change-Number: 7069255

Gerrit-PatchSet: 28

Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Attention: Dominik Inführ <dinf...@chromium.org>

Gerrit-Comment-Date: Thu, 13 Nov 2025 14:56:27 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Dominik Inführ <dinf...@chromium.org>

[Dominik Inführ (Gerrit)]

Attention needed from Etienne Pierre-Doray and Michael Lippautz

Dominik Inführ voted and added 1 comment

Votes added by Dominik Inführ

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 28 (Latest):

Dominik Inführ . resolved

Thanks, LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Etienne Pierre-Doray
• Michael Lippautz

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I65313ecb8654d97b23459498799e4f22e75963fd

Gerrit-Change-Number: 7069255

Gerrit-PatchSet: 28

Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-Comment-Date: Thu, 13 Nov 2025 15:12:57 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Etienne Pierre-Doray (Gerrit)]

Attention needed from Michael Lippautz

Etienne Pierre-Doray voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• Michael Lippautz

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I65313ecb8654d97b23459498799e4f22e75963fd

Gerrit-Change-Number: 7069255

Gerrit-PatchSet: 28

Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Comment-Date: Thu, 13 Nov 2025 15:24:40 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Dominik Inführ (Gerrit)]

Attention needed from Etienne Pierre-Doray and Michael Lippautz

Dominik Inführ voted and added 2 comments

Votes added by Dominik Inführ

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 33 (Latest):

Dominik Inführ . resolved

Thanks, LGTM

File test/unittests/heap/heap-unittest.cc

Line 352, Patchset 33 (Latest): // Max old generation allocation limit for 64-bit (no pointer compression).

Dominik Inführ . unresolved

Nit: no pointer compression outdated now.

Open in Gerrit

Related details

Attention is currently required from:

• Etienne Pierre-Doray
• Michael Lippautz

Submit Requirements:

• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I65313ecb8654d97b23459498799e4f22e75963fd

Gerrit-Change-Number: 7069255

Gerrit-PatchSet: 33

Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-Comment-Date: Fri, 14 Nov 2025 15:31:56 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Etienne Pierre-Doray (Gerrit)]

Attention needed from Michael Lippautz

Etienne Pierre-Doray added 1 comment

File test/unittests/heap/heap-unittest.cc

Line 352, Patchset 33: // Max old generation allocation limit for 64-bit (no pointer compression).

Dominik Inführ . resolved

Nit: no pointer compression outdated now.

Etienne Pierre-Doray

Done

Open in Gerrit

Related details

Attention is currently required from:

• Michael Lippautz

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I65313ecb8654d97b23459498799e4f22e75963fd

Gerrit-Change-Number: 7069255

Gerrit-PatchSet: 34

Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Comment-Date: Fri, 14 Nov 2025 16:10:33 +0000

[Etienne Pierre-Doray (Gerrit)]

Attention needed from Michael Lippautz

Etienne Pierre-Doray voted Commit-Queue+2

Commit-Queue

+2

Gerrit-Comment-Date: Fri, 14 Nov 2025 16:10:44 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Etienne Pierre-Doray (Gerrit)]

Gerrit-Comment-Date: Fri, 14 Nov 2025 18:04:39 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[V8 LUCI CQ (Gerrit)]

V8 LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

33 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: test/unittests/heap/heap-unittest.cc
Insertions: 1, Deletions: 1.

@@ -349,7 +349,7 @@
     uint64_t physical_memory;
     // Max old generation allocation limit for 32-bit.
     uint64_t arch_32bit;
-    // Max old generation allocation limit for 64-bit (no pointer compression).
+    // Max old generation allocation limit for 64-bit.
     uint64_t arch_64bit;
   };
 
```

Change information

Commit message:

[heap] Implement new Old Generation Heap Size

Behind new_old_generation_heap_size flag, MaxOldGenerationSizeFromPhysicalMemory returns 1\4GB on 32\64bits devices, (4Gb is the cage size), and always use 256Mb lower bound,
which is the old gen size on Android 1Gb devices.

Bug: chromium:454097973

Change-Id: I65313ecb8654d97b23459498799e4f22e75963fd

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7069255

Reviewed-by: Dominik Inführ <dinf...@chromium.org>

Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#103731}

Files:

• M src/flags/flag-definitions.h
• M src/heap/heap.cc
• M test/unittests/heap/heap-unittest.cc

Change size: M

Delta: 3 files changed, 133 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Dominik Inführ

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I65313ecb8654d97b23459498799e4f22e75963fd

Gerrit-Change-Number: 7069255

Gerrit-PatchSet: 35

Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>

Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>

Gerrit-Reviewer: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: Hannes Payer <hpa...@chromium.org>

Gerrit-CC: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>