blink: Make HeapBarrierCallback thread-safe by default [chromium/src : main]
0 views
Skip to first unread message
Nate Chapin (Gerrit)
May 20, 2026, 1:56:10 PM (11 days ago) May 20
to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Eugene Zemtsov
Nate Chapin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
May 20, 2026, 3:22:07 PM (11 days ago) May 20
to Eugene Zemtsov, Nate Chapin, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Eugene Zemtsov voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 20, 2026, 3:25:40 PM (11 days ago) May 20
to Eugene Zemtsov, Nate Chapin, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
blink: Make HeapBarrierCallback thread-safe by default
HeapBarrierCallback was using Persistent to store aggregated results.
Since Persistent handles are thread-affine, destroying or clearing them
on another thread (e.g. when a PostTask fails due to worker thread
shutdown) results in free-list corruption of the calling thread's
PersistentRegion.
This change replaces Persistent with UnwrappingCrossThreadHandle to
ensure safe cross-thread destruction while strictly enforcing that the
underlying vector is only dereferenced on its creation thread,
preventing data races.
Bug: 514715455
Change-Id: I44930a8d0d742a6194c6380c7b94abc8cf03dab7
Reviewed-by: Nate Chapin <jap...@chromium.org>
Commit-Queue: Eugene Zemtsov <eug...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1633752}
Files:
- M third_party/blink/renderer/platform/heap/heap_barrier_callback.h
Change size: S
Delta: 1 file changed, 7 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nate Chapin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages