Fix various typos in comments [v8/v8 : main]
Clemens Backes (Gerrit)
Clemens Backes added 1 comment![]( "Open in Gerrit")
I am not an owner of all the touched directories. I also don't see much value of landing this CL. Does this satisfy any new check or was this flagged by any tool?
Or is it just a random selection of typos you found across the codebase?
Related details
- Amemiya Riya
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Amemiya Riya (Gerrit)
Amemiya Riya added 1 comment![]( "Open in Gerrit")
I am not an owner of all the touched directories. I also don't see much value of landing this CL. Does this satisfy any new check or was this flagged by any tool?
Or is it just a random selection of typos you found across the codebase?
Thanks for the review.
This change is a minor cleanup, resulting from a systematic search for common misspellings in comments to improve their accuracy.
You are right about the ownership. Should I split this CL or add the other owners?
Related details
- Clemens Backes
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Clemens Backes added 1 comment![]( "Open in Gerrit")
Amemiya RiyaI am not an owner of all the touched directories. I also don't see much value of landing this CL. Does this satisfy any new check or was this flagged by any tool?
Or is it just a random selection of typos you found across the codebase?
Thanks for the review.
This change is a minor cleanup, resulting from a systematic search for common misspellings in comments to improve their accuracy.
You are right about the ownership. Should I split this CL or add the other owners?
Michael, what's your opinion here? Worth landing?
If so, can you provide ENG review?
Related details
- Amemiya Riya
- Michael Lippautz
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Michael Lippautz added 2 comments![]( "Open in Gerrit")
Amemiya RiyaI am not an owner of all the touched directories. I also don't see much value of landing this CL. Does this satisfy any new check or was this flagged by any tool?
Or is it just a random selection of typos you found across the codebase?
Clemens BackesThanks for the review.
This change is a minor cleanup, resulting from a systematic search for common misspellings in comments to improve their accuracy.
You are right about the ownership. Should I split this CL or add the other owners?
Michael, what's your opinion here? Worth landing?
If so, can you provide ENG review?
Yeah
I think we presubmit spell checkers there's only old stuff lingering these days
Riya Amemiya <riyaa...@gmail.com>Please keep this lexically sorted.
Related details
- Amemiya Riya
- Clemens Backes
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Amemiya Riya (Gerrit)
Amemiya Riya added 1 comment![]( "Open in Gerrit")
Riya Amemiya <riyaa...@gmail.com>Please keep this lexically sorted.
Thank you for the review.
I've sorted my name into the correct alphabetical order.
If you intended for me to sort the entire file, please let me know, and I'd be happy to take care of it.
Related details
- Clemens Backes
- Michael Lippautz
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Michael Lippautz voted and added 2 comments![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
2 comments
Riya Amemiya <riyaa...@gmail.com>Amemiya RiyaPlease keep this lexically sorted.
Thank you for the review.
I've sorted my name into the correct alphabetical order.
If you intended for me to sort the entire file, please let me know, and I'd be happy to take care of it.
- Amemiya Riya
- Clemens Backes
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Giving the 2nd +1 and submitting since you probably don't have permissions to do it yourself.
Related details
- Amemiya Riya
- Clemens Backes
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Fix various typos in comments
This patch fixes several spelling mistakes in comments across the codebase.
R=clem...@chromium.org
- M AUTHORS
- M src/asmjs/asm-scanner.cc
- M src/builtins/array-reduce-right.tq
- M src/builtins/array-reduce.tq
- M src/codegen/loong64/macro-assembler-loong64.h
- M src/codegen/mips64/macro-assembler-mips64.h
- M src/codegen/shared-ia32-x64/macro-assembler-shared-ia32-x64.cc
- M src/compiler/backend/arm/code-generator-arm.cc
- M src/compiler/backend/arm64/code-generator-arm64.cc
- M src/compiler/backend/ia32/code-generator-ia32.cc
- M src/compiler/backend/instruction.h
- M src/compiler/backend/ppc/code-generator-ppc.cc
- M src/compiler/backend/riscv/code-generator-riscv.cc
- M src/compiler/backend/s390/code-generator-s390.cc
- M src/compiler/backend/x64/code-generator-x64.cc
- M src/heap/cppgc/sweeper.cc
- M src/heap/gc-tracer.cc
Code-Review: +1 by Michael Lippautz, +1 by Darius Mercadier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |