[loong64][mips64][heap/cppgc] Disable guard pages [v8/v8 : main]

0 views
Skip to first unread message

Zhao Jiazhong (Gerrit)

unread,
Jun 6, 2024, 11:12:01 PMJun 6
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-loongar...@chromium.org, v8-mip...@googlegroups.com, v8-re...@googlegroups.com
Attention needed from Michael Lippautz

Zhao Jiazhong voted and added 1 comment

Votes added by Zhao Jiazhong

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Zhao Jiazhong . resolved

PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Iae4af9c21b261b27156fed52b771f04ea3547661
Gerrit-Change-Number: 5606546
Gerrit-PatchSet: 1
Gerrit-Owner: Zhao Jiazhong <zhaojia...@loongson.cn>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Zhao Jiazhong <zhaojia...@loongson.cn>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Fri, 07 Jun 2024 03:11:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
Jun 7, 2024, 2:45:59 AMJun 7
to Zhao Jiazhong, V8 LUCI CQ, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-loongar...@chromium.org, v8-mip...@googlegroups.com, v8-re...@googlegroups.com
Attention needed from Zhao Jiazhong

Michael Lippautz voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Zhao Jiazhong
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Iae4af9c21b261b27156fed52b771f04ea3547661
Gerrit-Change-Number: 5606546
Gerrit-PatchSet: 1
Gerrit-Owner: Zhao Jiazhong <zhaojia...@loongson.cn>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Zhao Jiazhong <zhaojia...@loongson.cn>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Zhao Jiazhong <zhaojia...@loongson.cn>
Gerrit-Comment-Date: Fri, 07 Jun 2024 06:45:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Jun 7, 2024, 4:19:41 AMJun 7
to Zhao Jiazhong, Michael Lippautz, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-loongar...@chromium.org, v8-mip...@googlegroups.com, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[loong64][mips64][heap/cppgc] Disable guard pages

Page size is normally 16k on loongarch64 and mips64 platforms, which
doesn't work well with cppgc's guard pages.
So disable guard pages on loongarch64 and mips64.
Change-Id: Iae4af9c21b261b27156fed52b771f04ea3547661
Auto-Submit: Zhao Jiazhong <zhaojia...@loongson.cn>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#94304}
Files:
  • M include/cppgc/internal/api-constants.h
  • M src/heap/cppgc/globals.h
Change size: XS
Delta: 2 files changed, 5 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michael Lippautz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Iae4af9c21b261b27156fed52b771f04ea3547661
Gerrit-Change-Number: 5606546
Gerrit-PatchSet: 2
Gerrit-Owner: Zhao Jiazhong <zhaojia...@loongson.cn>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages