Replace `std::unordered_set` with `absl::flat_hash_set`. [v8/v8 : main]
0 views
Skip to first unread message
Michael Lippautz (Gerrit)
Jan 14, 2026, 7:03:12 AM (4 days ago) Jan 14
to Jeffrey Yu, Code Review Nudger, V8 LUCI CQ, Hannes Payer, dmercadi...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Jeffrey Yu
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Jeffrey Yu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Jan 14, 2026, 7:48:16 AM (4 days ago) Jan 14
to Jeffrey Yu, Michael Lippautz, Code Review Nudger, V8 LUCI CQ, Hannes Payer, dmercadi...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Jeffrey Yu
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
1 comment
Patchset-level comments
Darius Mercadier . resolved
stamp
Related details
Attention is currently required from:
- Jeffrey Yu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeffrey Yu (Gerrit)
Jan 14, 2026, 12:10:07 PM (4 days ago) Jan 14
to Darius Mercadier, Michael Lippautz, Code Review Nudger, V8 LUCI CQ, Hannes Payer, dmercadi...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Jeffrey Yu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeffrey Yu (Gerrit)
Jan 14, 2026, 2:19:44 PM (3 days ago) Jan 14
to Darius Mercadier, Michael Lippautz, Code Review Nudger, V8 LUCI CQ, Hannes Payer, dmercadi...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Jeffrey Yu voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 14, 2026, 3:09:30 PM (3 days ago) Jan 14
to Jeffrey Yu, Darius Mercadier, Michael Lippautz, Code Review Nudger, Hannes Payer, dmercadi...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Replace `std::unordered_set` with `absl::flat_hash_set`.
The Chromium containers guide
(https://chromium.googlesource.com/chromium/src/+/HEAD/base/containers/README.md)
recommends using `absl::flat_hash_set` as a default map choice instead
of `std::unordered_set` when pointer stability isn't needed, and
`absl::node_hash_set` when it is. Both will still generally perform
better and require less overhead than `std::unordered_set`.
Notably, the guide says: "Note that this advice never suggests the use
of `std::unordered_map` and `std::unordered_set`. These containers
provides similar features to the Abseil flat hash containers but with
worse performance. They should only be used if absolutely required for
compatibility with third-party code.
Bug: 473916362
Change-Id: Iecdb10a930cc2dfd5e7481e4522c27ca0eedc187
Commit-Queue: Jeffrey Yu <yu...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104706}
Files:
- M src/heap/cppgc-js/cpp-snapshot.cc
- M src/heap/cppgc/compactor.cc
- M src/heap/cppgc/marker.cc
- M src/heap/cppgc/marking-state.cc
- M src/heap/cppgc/marking-verifier.h
- M src/heap/cppgc/marking-worklists.h
Change size: S
Delta: 6 files changed, 19 insertions(+), 19 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darius Mercadier, +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages