Revert "[heap] Extract limit computation out of Heap" [v8/v8 : main]
0 views
Skip to first unread message
Deepti Gandluri (Gerrit)
Jan 20, 2026, 7:15:54 PMJan 20
to AyeAye, Rubber Stamper, V8 LUCI CQ, Etienne Pierre-Doray, Dominik Inführ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org
Attention needed from Dominik Inführ and Etienne Pierre-Doray
Deepti Gandluri voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Dominik Inführ
- Etienne Pierre-Doray
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Jan 20, 2026, 7:16:08 PMJan 20
to Deepti Gandluri, AyeAye, V8 LUCI CQ, Etienne Pierre-Doray, Dominik Inführ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org
Attention needed from Dominik Inführ and Etienne Pierre-Doray
Rubber Stamper voted![]( "Open in Gerrit")
| Bot-Commit | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Dominik Inführ
- Etienne Pierre-Doray
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 20, 2026, 7:16:19 PMJan 20
to Deepti Gandluri, Rubber Stamper, AyeAye, Etienne Pierre-Doray, Dominik Inführ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "[heap] Extract limit computation out of Heap"
This reverts commit 5f727f8c89cd515625e68fdba701ed11c2846fa2.
Reason for revert: GC Fails on Linux64 - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64/64977/overview
Original change's description:
> [heap] Extract limit computation out of Heap
>
> This CL is a pure refactor, extracting logic and members out of Heap,
> into a new HeapLimits class within heap-controller.
> I tried to avoid circular dependencies as much as possible,
> making Heap depend on HeapLimit, but not the other way around.
>
> Change-Id: Ic53e148032e209c46b30f1948a0bdef8babf6462
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7270565
> Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
> Reviewed-by: Dominik Inführ <dinf...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#104801}
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ica0b6ebc804b48b2f3d4dc47e317782855153642
Auto-Submit: Deepti Gandluri <gde...@chromium.org>
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#104802}
Files:
- M src/heap/cppgc-js/cpp-heap.cc
- M src/heap/gc-tracer.cc
- M src/heap/gc-tracer.h
- M src/heap/heap-controller.cc
- M src/heap/heap-controller.h
- M src/heap/heap-inl.h
- M src/heap/heap.cc
- M src/heap/heap.h
- M src/heap/incremental-marking.cc
- M src/heap/memory-balancer.cc
- M test/unittests/heap/heap-controller-unittest.cc
- M test/unittests/heap/heap-unittest.cc
Change size: XL
Delta: 12 files changed, 684 insertions(+), 780 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages