[heap] Add StackStartMarker for cppgc [v8/v8 : main]
0 views
Skip to first unread message
Dominik Inführ (Gerrit)
Mar 13, 2026, 9:02:39 AMMar 13
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Dominik Inführ added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Mar 13, 2026, 10:49:36 AMMar 13
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Michael Lippautz added 1 comment![]( "Open in Gerrit")
File include/cppgc/heap.h
Line 38, Patchset 4 (Latest):
class V8_EXPORT StackStartMarker {Michael Lippautz . unresolved
Can you add a test that shows how this should be used? There should be cppgc unittests that can just be extended.
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Mar 16, 2026, 6:15:12 AMMar 16
to AyeAye, Michael Lippautz, V8 LUCI CQ, Hannes Payer, victorgo...@chromium.org, cbruni...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Dominik Inführ added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File include/cppgc/heap.h
Can you add a test that shows how this should be used? There should be cppgc unittests that can just be extended.
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Mar 16, 2026, 8:36:29 AMMar 16
to Dominik Inführ, AyeAye, V8 LUCI CQ, Hannes Payer, victorgo...@chromium.org, cbruni...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
1 comment
File test/unittests/heap/cppgc-js/cpp-heap-stack-start-marker-unittest.cc
Line 22, Patchset 5 (Latest):
TEST_F(CppHeapStackStartMarkerTest, StackStartMarkerIsUsed) {Michael Lippautz . resolved
Nice!
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Mar 16, 2026, 8:38:29 AMMar 16
to Michael Lippautz, AyeAye, V8 LUCI CQ, Hannes Payer, victorgo...@chromium.org, cbruni...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Mar 16, 2026, 8:40:20 AMMar 16
to Dominik Inführ, Michael Lippautz, AyeAye, Hannes Payer, victorgo...@chromium.org, cbruni...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[heap] Add StackStartMarker for cppgc
For conservative stack scanning we currently scan for references up
until the stack top. But this includes stack frames like that of
_start which definitely do not have pointers into the cppgc heap.
This CL adds a StackStartMarker class which embedders can optionally
use to decrease the stack height considered during conservative
stack scanning. This reduces the chance of false positives.
Bug: 492198560
Change-Id: Ic9a7d428684bb835d372873beb821e412e131246
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105816}
Files:
- M include/cppgc/heap.h
- M include/v8-cppgc.h
- M src/heap/base/stack.h
- M src/heap/cppgc-js/cpp-heap.cc
- M src/heap/cppgc-js/cpp-heap.h
- M src/heap/cppgc/heap-base.cc
- M src/heap/cppgc/heap-base.h
- M src/heap/cppgc/heap.cc
- M src/heap/heap.cc
- M test/unittests/BUILD.gn
- A test/unittests/heap/cppgc-js/cpp-heap-stack-start-marker-unittest.cc
- A test/unittests/heap/cppgc/stack-start-marker-unittest.cc
- M test/unittests/heap/cppgc/stack-unittest.cc
Change size: M
Delta: 13 files changed, 151 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages