Add a HeapProfiler function for persisting temporary strings [v8/v8 : main]
0 views
Skip to first unread message
Seth Brenith (Gerrit)
Jun 7, 2024, 2:18:56 PMJun 7
to Camillo Bruni, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Camillo Bruni
Seth Brenith added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Seth Brenith . resolved
Hi Camillo, would you please review this change?
Related details
Attention is currently required from:
- Camillo Bruni
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Camillo Bruni (Gerrit)
Jun 11, 2024, 3:15:56 AMJun 11
to Seth Brenith, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Seth Brenith
Camillo Bruni added 1 comment![]( "Open in Gerrit")
File src/api/api.cc
Line 11471, Patchset 1 (Latest):
const char* HeapProfiler::CopyNameForHeapSnapshot(const char* name) {Camillo Bruni . unresolved
nit: let's add a unittest in [1].
[2] test/unittests/heap/cppgc-js/unified-heap-snapshot-unittest.cc
Related details
Attention is currently required from:
- Seth Brenith
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Seth Brenith (Gerrit)
Jun 11, 2024, 12:18:26 PMJun 11
to Camillo Bruni, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Camillo Bruni
Seth Brenith voted and added 2 comments![]( "Open in Gerrit")
Votes added by Seth Brenith
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Seth Brenith . resolved
Thanks for reviewing! I've added a test as you suggested.
File src/api/api.cc
Line 11471, Patchset 1:
const char* HeapProfiler::CopyNameForHeapSnapshot(const char* name) {Camillo Bruni . resolved
nit: let's add a unittest in [1].
[2] test/unittests/heap/cppgc-js/unified-heap-snapshot-unittest.cc
Attention is currently required from:
- Camillo Bruni
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Camillo Bruni (Gerrit)
Jun 12, 2024, 2:05:42 PMJun 12
to Seth Brenith, Dominik Inführ, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ and Seth Brenith
Camillo Bruni voted and added 1 comment![]( "Open in Gerrit")
Votes added by Camillo Bruni
| Code-Review | +1 |
1 comment
Patchset-level comments
Camillo Bruni . resolved
LGTM from my side, maybe some additional feedback from the GC folks would be welcome.
Related details
Attention is currently required from:
- Dominik Inführ
- Seth Brenith
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Jun 13, 2024, 3:48:26 AMJun 13
to Seth Brenith, Camillo Bruni, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Seth Brenith
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Seth Brenith
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Seth Brenith (Gerrit)
Jun 13, 2024, 10:54:41 AMJun 13
to Dominik Inführ, Camillo Bruni, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Seth Brenith voted and added 1 comment![]( "Open in Gerrit")
Votes added by Seth Brenith
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Seth Brenith . resolved
Thanks for reviewing!
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jun 13, 2024, 11:37:00 AMJun 13
to Seth Brenith, Dominik Inführ, Camillo Bruni, cbruni...@chromium.org, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add a HeapProfiler function for persisting temporary strings
Embedders which implement NameProvider may want to specify formatted
strings as names for objects, rather than static strings. Doing so is
somewhat difficult, because the embedder must manage the lifetime of any
allocated string and ensure it stays alive until V8 is done generating
the snapshot. This change adds a new function so that embedders can
easily transfer a string into the HeapProfiler while it is taking a
snapshot.
Bug: 343341610
Change-Id: I75d0ff37367b9f30c3854c9c807e33d160a10fc4
Commit-Queue: Seth Brenith <seth.b...@microsoft.com>
Reviewed-by: Camillo Bruni <cbr...@chromium.org>
Reviewed-by: Dominik Inführ <dinf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#94444}
Files:
- M include/cppgc/name-provider.h
- M include/v8-profiler.h
- M src/api/api.cc
- M src/profiler/heap-profiler.cc
- M src/profiler/heap-profiler.h
- M test/unittests/heap/cppgc-js/unified-heap-snapshot-unittest.cc
Change size: M
Delta: 6 files changed, 59 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dominik Inführ, +1 by Camillo Bruni
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages