[cppgc] Avoid redundant full-page zeroing in NormalPageMemoryPool [v8/v8 : main]
0 views
Skip to first unread message
chromeperf@appspot.gserviceaccount.com (Gerrit)
Aug 6, 2026, 9:44:46 AM (4 days ago) Aug 6
to Anton Bikineev, Omer Katz, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Anton Bikineev and Omer Katz
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/speedometer3.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/14d00c48a90000
Related details
Attention is currently required from:
- Anton Bikineev
- Omer Katz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Aug 7, 2026, 5:17:19 AM (3 days ago) Aug 7
to Anton Bikineev, chrom...@appspot.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Anton Bikineev
Omer Katz voted and added 2 comments![]( "Open in Gerrit")
Votes added by Omer Katz
| Code-Review | +1 |
2 comments
Patchset-level comments
File src/heap/cppgc-internal/page-memory.cc
Line 114, Patchset 1 (Latest):
#if defined(V8_USE_MEMORY_SANITIZER) || defined(V8_USE_ADDRESS_SANITIZER) || \
DEBUGOmer Katz . unresolved
nit: Can we introduce a `CPPGC_SHOULD_ZAP_MEMORY` macro (or other name) and use it here and in `cppgc-internal/memory.h` to make it easier to keep the conditions in sync?
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bikineev (Gerrit)
Aug 7, 2026, 8:48:59 AM (3 days ago) Aug 7
to Omer Katz, chrom...@appspot.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Omer Katz
Anton Bikineev added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File src/heap/cppgc-internal/page-memory.cc
Line 114, Patchset 1:
#if defined(V8_USE_MEMORY_SANITIZER) || defined(V8_USE_ADDRESS_SANITIZER) || \
DEBUGOmer Katz . resolved
nit: Can we introduce a `CPPGC_SHOULD_ZAP_MEMORY` macro (or other name) and use it here and in `cppgc-internal/memory.h` to make it easier to keep the conditions in sync?
Attention is currently required from:
- Omer Katz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bikineev (Gerrit)
Aug 7, 2026, 8:49:50 AM (3 days ago) Aug 7
to android-bu...@system.gserviceaccount.com, Omer Katz, chrom...@appspot.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Omer Katz
Anton Bikineev voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Omer Katz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Aug 7, 2026, 8:49:58 AM (3 days ago) Aug 7
to Anton Bikineev, android-bu...@system.gserviceaccount.com, chrom...@appspot.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Anton Bikineev
Omer Katz voted![]( "Open in Gerrit")
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Aug 7, 2026, 9:34:15 AM (3 days ago) Aug 7
to Anton Bikineev, Omer Katz, android-bu...@system.gserviceaccount.com, chrom...@appspot.gserviceaccount.com, Hannes Payer, cbruni...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[cppgc] Avoid redundant full-page zeroing in NormalPageMemoryPool
When returning an empty page to NormalPageMemoryPool, all payload memory
from PayloadStart() to PayloadEnd() was already zero-initialized during
sweeping via SetMemoryInaccessible().
In release builds, only zero the page header region (PageHeaderSize())
rather than the entire 128KB page, saving ~127KB of memset traffic per
recycled normal page.
TAG=agy
Change-Id: Ibd0fc0aa4c1191fe035a483f651b8250c55762c0
Auto-Submit: Anton Bikineev <biki...@chromium.org>
Reviewed-by: Omer Katz <omer...@chromium.org>
Commit-Queue: Omer Katz <omer...@chromium.org>
Commit-Queue: Anton Bikineev <biki...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#109133}
Files:
- M src/heap/cppgc-internal/heap-page.h
- M src/heap/cppgc-internal/memory.h
- M src/heap/cppgc-internal/page-memory.cc
Change size: S
Delta: 3 files changed, 19 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Omer Katz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages