Move wtf/stack_util.* to "blink" namespace [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Jul 18, 2025, 3:31:48 AMJul 18
to Kent Tamura, Koji Ishii, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, oilpan-rev...@chromium.org, kouhe...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Koji Ishii

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Kent Tamura . resolved

kojii@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Koji Ishii
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9c26c9d172cb9bc9ce678b0234e9d83fda3a3299
Gerrit-Change-Number: 6768621
Gerrit-PatchSet: 4
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Koji Ishii <ko...@chromium.org>
Gerrit-Comment-Date: Fri, 18 Jul 2025 07:31:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Koji Ishii (Gerrit)

unread,
Jul 18, 2025, 12:18:51 PMJul 18
to Kent Tamura, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, oilpan-rev...@chromium.org, kouhe...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura

Koji Ishii voted and added 1 comment

Votes added by Koji Ishii

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Koji Ishii . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9c26c9d172cb9bc9ce678b0234e9d83fda3a3299
    Gerrit-Change-Number: 6768621
    Gerrit-PatchSet: 4
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Fri, 18 Jul 2025 16:11:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 18, 2025, 12:25:09 PMJul 18
    to Kent Tamura, Koji Ishii, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, oilpan-rev...@chromium.org, kouhe...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Move wtf/stack_util.* to "blink" namespace

    This CL has no behavior changes.
    Bug: 422768753
    Change-Id: I9c26c9d172cb9bc9ce678b0234e9d83fda3a3299
    Auto-Submit: Kent Tamura <tk...@chromium.org>
    Reviewed-by: Koji Ishii <ko...@chromium.org>
    Commit-Queue: Koji Ishii <ko...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1488890}
    Files:
    • M third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
    • M third_party/blink/renderer/bindings/core/v8/world_safe_v8_reference.cc
    • M third_party/blink/renderer/platform/bindings/dom_data_store.h
    • M third_party/blink/renderer/platform/bindings/script_forbidden_scope.h
    • M third_party/blink/renderer/platform/heap/thread_state_storage.h
    • M third_party/blink/renderer/platform/wtf/stack_util.cc
    • M third_party/blink/renderer/platform/wtf/stack_util.h
    • M third_party/blink/renderer/platform/wtf/thread_specific.h
    • M third_party/blink/renderer/platform/wtf/threading.cc
    • M third_party/blink/renderer/platform/wtf/vector.h
    • M third_party/blink/renderer/platform/wtf/wtf.cc
    Change size: S
    Delta: 11 files changed, 18 insertions(+), 18 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Koji Ishii
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9c26c9d172cb9bc9ce678b0234e9d83fda3a3299
    Gerrit-Change-Number: 6768621
    Gerrit-PatchSet: 5
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages