Reland "[heap] Extract limit computation out of Heap" [v8/v8 : main]
0 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Jan 21, 2026, 7:22:46 AMJan 21
to AyeAye, V8 LUCI CQ, Dominik Inführ, Hannes Payer, oilpan-r...@chromium.org, mlippau...@chromium.org
Attention needed from Dominik Inführ
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Jan 21, 2026, 9:11:07 AMJan 21
to Etienne Pierre-Doray, AyeAye, V8 LUCI CQ, Hannes Payer, oilpan-r...@chromium.org, mlippau...@chromium.org
Attention needed from Etienne Pierre-Doray
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jan 21, 2026, 9:28:14 AMJan 21
to Dominik Inführ, AyeAye, V8 LUCI CQ, Hannes Payer, oilpan-r...@chromium.org, mlippau...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 21, 2026, 9:29:39 AMJan 21
to Etienne Pierre-Doray, Dominik Inführ, AyeAye, Hannes Payer, oilpan-r...@chromium.org, mlippau...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reland "[heap] Extract limit computation out of Heap"
This is a reland of commit 5f727f8c89cd515625e68fdba701ed11c2846fa2
Reason for revert: GC Fails on Linux64 - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64/64977/overview
Fix: avoid using uninitialized gc_tracer in SetAllocationLimit(), use
tracing_track directly instead.
Original change's description:
> [heap] Extract limit computation out of Heap
>
> This CL is a pure refactor, extracting logic and members out of Heap,
> into a new HeapLimits class within heap-controller.
> I tried to avoid circular dependencies as much as possible,
> making Heap depend on HeapLimit, but not the other way around.
>
> Change-Id: Ic53e148032e209c46b30f1948a0bdef8babf6462
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7270565
> Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
> Reviewed-by: Dominik Inführ <dinf...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#104801}
Change-Id: I1aabecd90576e6701ac238ba2817c3bf0215dd58
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Reviewed-by: Dominik Inführ <dinf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104818}
Files:
- M src/heap/cppgc-js/cpp-heap.cc
- M src/heap/gc-tracer.cc
- M src/heap/gc-tracer.h
- M src/heap/heap-controller.cc
- M src/heap/heap-controller.h
- M src/heap/heap-inl.h
- M src/heap/heap.cc
- M src/heap/heap.h
- M src/heap/incremental-marking.cc
- M src/heap/memory-balancer.cc
- M test/unittests/heap/heap-controller-unittest.cc
- M test/unittests/heap/heap-unittest.cc
Change size: XL
Delta: 12 files changed, 779 insertions(+), 684 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dominik Inführ
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages