[api] Change EmbedderData to v8::Data [v8/v8 : main]
0 views
Skip to first unread message
Leszek Swirski (Gerrit)
Oct 30, 2025, 8:03:22 AM (12 days ago) Oct 30
to AyeAye, Igor Sheludko, V8 LUCI CQ, oilpan-r...@chromium.org, cbruni...@chromium.org, v8-re...@googlegroups.com
Leszek Swirski voted and added 1 comment![]( "Open in Gerrit")
Votes added by Leszek Swirski
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Oct 30, 2025, 9:06:08 AM (11 days ago) Oct 30
to Leszek Swirski, AyeAye, V8 LUCI CQ, oilpan-r...@chromium.org, cbruni...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Igor Sheludko voted and added 4 comments![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Code-Review | +1 |
4 comments
Patchset-level comments
Igor Sheludko . resolved
lgtm with nits
File GEMINI.md
Line 51, Patchset 2 (Latest):
- `src/parsing/`: The parser and scanner implementation.qIgor Sheludko . unresolved
Typo?
File include/v8-context.h
Line 513, Patchset 2 (Latest):
// dealing with potential endiannes issues.Igor Sheludko . unresolved
Please fix this WARNING reported by Spellchecker: "endiannes" is a possible misspelling of "endianness".
To bypass Spellchecker, ...
"endiannes" is a possible misspelling of "endianness".
To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER
Line 292, Patchset 1:
V8_DEPRECATED("Use GetEmbedderDataV2 instead")Igor Sheludko . resolved
Igor SheludkoWe are breaking the Api change process here. This should be V8_DEPRECATE_SOON for a release, then V8_DEPRECATED for a release and then we can remove it.
Igor SheludkoIn order to keep on testing the old Api until we remove it you can use this approach: https://source.chromium.org/chromium/chromium/src/+/main:v8/test/cctest/test-heap-profiler.cc;l=2195?q=START_ALLOW_USE_DEPRECATED()&ss=chromium
Done
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Nov 5, 2025, 4:26:42 AM (6 days ago) Nov 5
to Igor Sheludko, AyeAye, V8 LUCI CQ, oilpan-r...@chromium.org, cbruni...@chromium.org, v8-re...@googlegroups.com
Attention needed from Igor Sheludko
Leszek Swirski voted and added 3 comments![]( "Open in Gerrit")
Votes added by Leszek Swirski
| Auto-Submit | +1 |
| Commit-Queue | +1 |
3 comments
Patchset-level comments
File GEMINI.md
Line 51, Patchset 2:
- `src/parsing/`: The parser and scanner implementation.qIgor Sheludko . resolved
Leszek SwirskiTypo?
Done
File include/v8-context.h
Please fix this WARNING reported by Spellchecker: "endiannes" is a possible misspelling of "endianness".
To bypass Spellchecker, ...
"endiannes" is a possible misspelling of "endianness".
To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Nov 5, 2025, 4:50:08 AM (6 days ago) Nov 5
to Leszek Swirski, AyeAye, V8 LUCI CQ, oilpan-r...@chromium.org, cbruni...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Igor Sheludko voted![]( "Open in Gerrit")
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Nov 5, 2025, 5:16:14 AM (6 days ago) Nov 5
to Leszek Swirski, Igor Sheludko, AyeAye, oilpan-r...@chromium.org, cbruni...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[api] Change EmbedderData to v8::Data
Context::Get/SetEmbedderData allows any V8 object, not just JS-visible
types. This means it should get/set a v8::Data, not a v8::Value.
Introduce Get/SetEmbedderDataV2 with the updated type, and deprecate the
old ones.
Change-Id: I2ed50339832d0a631d6b760d75ecb5d91ad380e3
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Auto-Submit: Leszek Swirski <les...@chromium.org>
Commit-Queue: Leszek Swirski <les...@chromium.org>
Reviewed-by: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103524}
Files:
- M include/v8-context.h
- M include/v8-external.h
- M src/api/api.cc
- M src/d8/d8.cc
- M test/cctest/test-api.cc
- M test/cctest/test-debug.cc
- M test/cctest/test-serialize.cc
- M test/unittests/heap/cppgc-js/unified-heap-snapshot-unittest.cc
Change size: M
Delta: 8 files changed, 95 insertions(+), 30 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Igor Sheludko
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages