[casting] Remove Tagged/Handle<T>::cast(value) [v8/v8 : main]

0 views
Skip to first unread message

Leszek Swirski (Gerrit)

unread,
Jun 12, 2024, 5:46:44 AMJun 12
to AyeAye, Michael Lippautz, V8 LUCI CQ, Hannes Payer, cbruni...@chromium.org, oilpan-r...@chromium.org, devtools-...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, pthier...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com
Attention needed from Michael Lippautz

Leszek Swirski voted and added 1 comment

Votes added by Leszek Swirski

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Leszek Swirski . resolved

PTAL again after rebase

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Iee0a4b7e084d125cc0f8167d39de2c538469ef69
Gerrit-Change-Number: 5607996
Gerrit-PatchSet: 6
Gerrit-Owner: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Jun 2024 09:46:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
Jun 12, 2024, 6:40:52 AMJun 12
to Leszek Swirski, AyeAye, V8 LUCI CQ, Hannes Payer, cbruni...@chromium.org, oilpan-r...@chromium.org, devtools-...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, pthier...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com
Attention needed from Leszek Swirski

Michael Lippautz voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Leszek Swirski
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Iee0a4b7e084d125cc0f8167d39de2c538469ef69
Gerrit-Change-Number: 5607996
Gerrit-PatchSet: 8
Gerrit-Owner: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Jun 2024 10:40:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Jun 12, 2024, 9:02:10 AMJun 12
to Leszek Swirski, Michael Lippautz, AyeAye, Hannes Payer, cbruni...@chromium.org, oilpan-r...@chromium.org, devtools-...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, pthier...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com

V8 LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

8 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/handles/handles-inl.h
Insertions: 0, Deletions: 6.

@@ -108,12 +108,6 @@
: DirectHandle(object.ptr()) {}

template <typename To, typename From>
-inline DirectHandle<To> Cast(Handle<From> value) {
- DCHECK(Is<To>(*value));
- return DirectHandle<To>(*value.location());
-}
-
-template <typename To, typename From>
inline DirectHandle<To> Cast(DirectHandle<From> value) {
DCHECK(Is<To>(*value));
return DirectHandle<To>(value.obj_);
```
```
The name of the file: src/objects/bigint.cc
Insertions: 24, Deletions: 26.

@@ -76,10 +76,6 @@
New(isolate, 0, allocation).ToHandleChecked());
}

- static Handle<MutableBigInt> Cast(Handle<FreshlyAllocatedBigInt> bigint) {
- SLOW_DCHECK(IsBigInt(*bigint));
- return Cast<MutableBigInt>(bigint);
- }
static Tagged<MutableBigInt> cast(Tagged<Object> o) {
SLOW_DCHECK(IsBigInt(o));
return MutableBigInt::unchecked_cast(o);
@@ -185,7 +181,7 @@
return ThrowBigIntTooBig<MutableBigInt>(isolate);
}
Handle<MutableBigInt> result =
- Cast(isolate->factory()->NewBigInt(length, allocation));
+ Cast<MutableBigInt>(isolate->factory()->NewBigInt(length, allocation));
result->initialize_bitfield(false, length);
#if DEBUG
result->InitializeDigits(length, 0xBF);
@@ -195,7 +191,8 @@

Handle<BigInt> MutableBigInt::NewFromInt(Isolate* isolate, int value) {
if (value == 0) return Zero(isolate);
- Handle<MutableBigInt> result = Cast(isolate->factory()->NewBigInt(1));
+ Handle<MutableBigInt> result =
+ Cast<MutableBigInt>(isolate->factory()->NewBigInt(1));
bool sign = value < 0;
result->initialize_bitfield(sign, 1);
if (!sign) {
@@ -224,7 +221,8 @@
DCHECK_GE(raw_exponent, 0x3FF);
int exponent = raw_exponent - 0x3FF;
int digits = exponent / kDigitBits + 1;
- Handle<MutableBigInt> result = Cast(isolate->factory()->NewBigInt(digits));
+ Handle<MutableBigInt> result =
+ Cast<MutableBigInt>(isolate->factory()->NewBigInt(digits));
result->initialize_bitfield(sign, digits);

// We construct a BigInt from the double {value} by shifting its mantissa
@@ -1244,7 +1242,7 @@
// There is no -0n. Reject corrupted serialized data.
if (length == 0 && sign == true) return {};
Handle<MutableBigInt> result =
- MutableBigInt::Cast(isolate->factory()->NewBigInt(length));
+ Cast<MutableBigInt>(isolate->factory()->NewBigInt(length));
result->initialize_bitfield(sign, length);
UnalignedValueMember<digit_t>* digits = result->raw_digits();
#if defined(V8_TARGET_LITTLE_ENDIAN)
@@ -1320,7 +1318,7 @@
static_assert(kDigitBits == 64 || kDigitBits == 32);
int length = 64 / kDigitBits;
Handle<MutableBigInt> result =
- MutableBigInt::Cast(isolate->factory()->NewBigInt(length));
+ Cast<MutableBigInt>(isolate->factory()->NewBigInt(length));
bool sign = n < 0;
result->initialize_bitfield(sign, length);
uint64_t absolute;
@@ -1342,7 +1340,7 @@
static_assert(kDigitBits == 64 || kDigitBits == 32);
int length = 64 / kDigitBits;
Handle<MutableBigInt> result =
- MutableBigInt::Cast(isolate->factory()->NewBigInt(length));
+ Cast<MutableBigInt>(isolate->factory()->NewBigInt(length));
result->initialize_bitfield(false, length);
result->set_64_bits(n);
return MutableBigInt::MakeImmutable(result);
@@ -1470,7 +1468,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));

bigint::Add(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1488,7 +1486,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));

bigint::Subtract(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1502,7 +1500,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));

Isolate* isolate;
if (!GetIsolateFromHeapObject(x, &isolate)) {
@@ -1526,7 +1524,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));
DCHECK_GE(result->length(),
bigint::DivideResultLength(x->digits(), y->digits()));

@@ -1552,7 +1550,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));

Isolate* isolate;
if (!GetIsolateFromHeapObject(x, &isolate)) {
@@ -1576,7 +1574,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));

bigint::BitwiseAnd_PosPos(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1588,7 +1586,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));

bigint::BitwiseAnd_NegNeg(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1600,7 +1598,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));

bigint::BitwiseAnd_PosNeg(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1612,7 +1610,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));

bigint::BitwiseOr_PosPos(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1624,7 +1622,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));

bigint::BitwiseOr_NegNeg(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1636,7 +1634,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));

bigint::BitwiseOr_PosNeg(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1648,7 +1646,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));

bigint::BitwiseXor_PosPos(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1660,7 +1658,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));

bigint::BitwiseXor_NegNeg(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1672,7 +1670,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));

bigint::BitwiseXor_PosNeg(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1682,7 +1680,7 @@
intptr_t shift) {
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));

bigint::LeftShift(result->rw_digits(), x->digits(), shift);
MutableBigInt::Canonicalize(result);
@@ -1706,7 +1704,7 @@
uint32_t must_round_down) {
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));
bigint::RightShiftState state{must_round_down == 1};
bigint::RightShift(result->rw_digits(), x->digits(), shift, state);
MutableBigInt::Canonicalize(result);
```
```
The name of the file: src/wasm/wasm-js.cc
Insertions: 10, Deletions: 9.

@@ -2160,15 +2160,16 @@
i_isolate};

int num_imported_functions = module->num_imported_functions;
- i::DirectHandle<i::ExposedTrustedObject> ref =
- func_index >= num_imported_functions
- ? trusted_instance_data
- : i::Cast<i::ExposedTrustedObject>(
- i_isolate->factory()->NewWasmApiFunctionRef(direct_handle(
- i::WasmApiFunctionRef::cast(
- trusted_instance_data->dispatch_table_for_imports()
- ->ref(func_index)),
- i_isolate)));
+ i::DirectHandle<i::ExposedTrustedObject> ref;
+ if (func_index >= num_imported_functions) {
+ ref = trusted_instance_data;
+ } else {
+ ref = i_isolate->factory()->NewWasmApiFunctionRef(direct_handle(
+ i::Cast<i::WasmApiFunctionRef>(
+ trusted_instance_data->dispatch_table_for_imports()->ref(
+ func_index)),
+ i_isolate));
+ }

#if V8_ENABLE_SANDBOX
uint64_t signature_hash =
```

Change information

Commit message:
[casting] Remove Tagged/Handle<T>::cast(value)

Replace them both with Cast<T>(value).
Bug: 345640551
Change-Id: Iee0a4b7e084d125cc0f8167d39de2c538469ef69
Auto-Submit: Leszek Swirski <les...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Leszek Swirski <les...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#94394}
Files:
  • M src/api/api-arguments-inl.h
  • M src/api/api-natives.cc
  • M src/api/api.cc
  • M src/asmjs/asm-js.cc
  • M src/ast/ast.cc
  • M src/ast/prettyprinter.cc
  • M src/baseline/baseline-batch-compiler.cc
  • M src/baseline/baseline-compiler.cc
  • M src/builtins/accessors.cc
  • M src/builtins/builtins-api.cc
  • M src/builtins/builtins-array.cc
  • M src/builtins/builtins-arraybuffer.cc
  • M src/builtins/builtins-atomics-synchronization.cc
  • M src/builtins/builtins-bigint.cc
  • M src/builtins/builtins-callsite.cc
  • M src/builtins/builtins-console.cc
  • M src/builtins/builtins-dataview.cc
  • M src/builtins/builtins-date.cc
  • M src/builtins/builtins-error.cc
  • M src/builtins/builtins-function.cc
  • M src/builtins/builtins-intl.cc
  • M src/builtins/builtins-number.cc
  • M src/builtins/builtins-object.cc
  • M src/builtins/builtins-reflect.cc
  • M src/builtins/builtins-regexp.cc
  • M src/builtins/builtins-shadow-realm.cc
  • M src/builtins/builtins-sharedarraybuffer.cc
  • M src/builtins/builtins-struct.cc
  • M src/builtins/builtins-symbol.cc
  • M src/builtins/builtins-trace.cc
  • M src/builtins/builtins-utils.h
  • M src/builtins/builtins-weak-refs.cc
  • M src/builtins/builtins.cc
  • M src/codegen/arm64/assembler-arm64-inl.h
  • M src/codegen/code-stub-assembler.cc
  • M src/codegen/compilation-cache.cc
  • M src/codegen/compiler.cc
  • M src/codegen/ia32/assembler-ia32-inl.h
  • M src/codegen/ia32/macro-assembler-ia32.cc
  • M src/codegen/ppc/assembler-ppc-inl.h
  • M src/codegen/riscv/assembler-riscv-inl.h
  • M src/codegen/s390/assembler-s390-inl.h
  • M src/codegen/x64/assembler-x64-inl.h
  • M src/codegen/x64/macro-assembler-x64.cc
  • M src/compiler/access-info.cc
  • M src/compiler/bytecode-graph-builder.cc
  • M src/compiler/code-assembler.cc
  • M src/compiler/heap-refs.cc
  • M src/compiler/js-heap-broker.cc
  • M src/compiler/js-operator.cc
  • M src/compiler/pipeline.cc
  • M src/compiler/turboshaft/assembler.h
  • M src/compiler/turboshaft/maglev-early-lowering-reducer-inl.h
  • M src/compiler/wasm-compiler.cc
  • M src/d8/async-hooks-wrapper.cc
  • M src/d8/d8.cc
  • M src/debug/debug-coverage.cc
  • M src/debug/debug-evaluate.cc
  • M src/debug/debug-frames.cc
  • M src/debug/debug-interface.cc
  • M src/debug/debug-property-iterator.cc
  • M src/debug/debug-scope-iterator.cc
  • M src/debug/debug-scopes.cc
  • M src/debug/debug-stack-trace-iterator.cc
  • M src/debug/debug-wasm-objects.cc
  • M src/debug/debug.cc
  • M src/debug/wasm/gdb-server/wasm-module-debug.cc
  • M src/deoptimizer/deoptimized-frame-info.cc
  • M src/deoptimizer/deoptimizer.cc
  • M src/deoptimizer/materialized-object-store.cc
  • M src/deoptimizer/translated-state.cc
  • M src/diagnostics/objects-debug.cc
  • M src/diagnostics/objects-printer.cc
  • M src/execution/arguments-inl.h
  • M src/execution/arguments.h
  • M src/execution/execution.cc
  • M src/execution/frames-inl.h
  • M src/execution/frames.cc
  • M src/execution/futex-emulation.cc
  • M src/execution/isolate.cc
  • M src/execution/messages.cc
  • M src/extensions/externalize-string-extension.cc
  • M src/handles/global-handles-inl.h
  • M src/handles/handles-inl.h
  • M src/handles/handles.h
  • M src/handles/maybe-handles-inl.h
  • M src/heap/factory-base-inl.h
  • M src/heap/factory-base.cc
  • M src/heap/factory-inl.h
  • M src/heap/factory.cc
  • M src/heap/heap-inl.h
  • M src/heap/heap.cc
  • M src/heap/mark-compact.cc
  • M src/heap/memory-measurement.cc
  • M src/heap/minor-mark-sweep.cc
  • M src/heap/read-only-promotion.cc
  • M src/heap/setup-heap-internal.cc
  • M src/ic/call-optimization.cc
  • M src/ic/ic.cc
  • M src/init/bootstrapper.cc
  • M src/json/json-parser.cc
  • M src/json/json-parser.h
  • M src/json/json-stringifier.cc
  • M src/logging/log.cc
  • M src/maglev/maglev-graph-builder.cc
  • M src/maglev/maglev-graph-builder.h
  • M src/maglev/maglev-ir.cc
  • M src/numbers/math-random.cc
  • M src/objects/bigint-inl.h
  • M src/objects/bigint.cc
  • M src/objects/bigint.h
  • M src/objects/call-site-info.cc
  • M src/objects/compressed-slots-inl.h
  • M src/objects/contexts.cc
  • M src/objects/debug-objects.cc
  • M src/objects/deoptimization-data.cc
  • M src/objects/dependent-code.cc
  • M src/objects/elements.cc
  • M src/objects/feedback-vector.cc
  • M src/objects/field-type.cc
  • M src/objects/field-type.h
  • M src/objects/fixed-array-inl.h
  • M src/objects/fixed-array.cc
  • M src/objects/intl-objects.cc
  • M src/objects/js-array-buffer-inl.h
  • M src/objects/js-array-buffer.cc
  • M src/objects/js-array-inl.h
  • M src/objects/js-atomics-synchronization.cc
  • M src/objects/js-break-iterator.cc
  • M src/objects/js-collator.cc
  • M src/objects/js-date-time-format.cc
  • M src/objects/js-display-names.cc
  • M src/objects/js-duration-format.cc
  • M src/objects/js-function.cc
  • M src/objects/js-list-format.cc
  • M src/objects/js-locale.cc
  • M src/objects/js-number-format.cc
  • M src/objects/js-objects-inl.h
  • M src/objects/js-objects.cc
  • M src/objects/js-plural-rules.cc
  • M src/objects/js-raw-json.cc
  • M src/objects/js-regexp.cc
  • M src/objects/js-relative-time-format.cc
  • M src/objects/js-segment-iterator.cc
  • M src/objects/js-segmenter.cc
  • M src/objects/js-segments.cc
  • M src/objects/js-struct.cc
  • M src/objects/js-temporal-objects.cc
  • M src/objects/keys.cc
  • M src/objects/literal-objects-inl.h
  • M src/objects/literal-objects.cc
  • M src/objects/lookup-inl.h
  • M src/objects/lookup.cc
  • M src/objects/managed-inl.h
  • M src/objects/map.cc
  • M src/objects/maybe-object-inl.h
  • M src/objects/module.cc
  • M src/objects/name-inl.h
  • M src/objects/objects-inl.h
  • M src/objects/objects.cc
  • M src/objects/option-utils.cc
  • M src/objects/ordered-hash-table.cc
  • M src/objects/property-descriptor.cc
  • M src/objects/prototype-info-inl.h
  • M src/objects/prototype-inl.h
  • M src/objects/prototype.h
  • M src/objects/scope-info.cc
  • M src/objects/script-inl.h
  • M src/objects/slots-inl.h
  • M src/objects/source-text-module.cc
  • M src/objects/string-table.cc
  • M src/objects/string.cc
  • M src/objects/synthetic-module.cc
  • M src/objects/tagged.h
  • M src/objects/templates-inl.h
  • M src/objects/templates.cc
  • M src/objects/transitions.cc
  • M src/objects/value-serializer.cc
  • M src/parsing/scanner-character-streams.cc
  • M src/profiler/heap-snapshot-generator.cc
  • M src/regexp/arm/regexp-macro-assembler-arm.cc
  • M src/regexp/arm64/regexp-macro-assembler-arm64.cc
  • M src/regexp/ia32/regexp-macro-assembler-ia32.cc
  • M src/regexp/loong64/regexp-macro-assembler-loong64.cc
  • M src/regexp/mips64/regexp-macro-assembler-mips64.cc
  • M src/regexp/ppc/regexp-macro-assembler-ppc.cc
  • M src/regexp/regexp.cc
  • M src/regexp/riscv/regexp-macro-assembler-riscv.cc
  • M src/regexp/s390/regexp-macro-assembler-s390.cc
  • M src/regexp/x64/regexp-macro-assembler-x64.cc
  • M src/roots/roots.cc
  • M src/runtime/runtime-array.cc
  • M src/runtime/runtime-atomics.cc
  • M src/runtime/runtime-bigint.cc
  • M src/runtime/runtime-classes.cc
  • M src/runtime/runtime-debug.cc
  • M src/runtime/runtime-forin.cc
  • M src/runtime/runtime-function.cc
  • M src/runtime/runtime-internal.cc
  • M src/runtime/runtime-literals.cc
  • M src/runtime/runtime-object.cc
  • M src/runtime/runtime-promise.cc
  • M src/runtime/runtime-regexp.cc
  • M src/runtime/runtime-scopes.cc
  • M src/runtime/runtime-test-wasm.cc
  • M src/runtime/runtime-test.cc
  • M src/runtime/runtime-typedarray.cc
  • M src/runtime/runtime-wasm.cc
  • M src/snapshot/code-serializer.cc
  • M src/snapshot/context-deserializer.cc
  • M src/snapshot/context-serializer.cc
  • M src/snapshot/deserializer.cc
  • M src/snapshot/object-deserializer.cc
  • M src/snapshot/serializer.cc
  • M src/snapshot/shared-heap-deserializer.cc
  • M src/snapshot/startup-serializer.cc
  • M src/strings/string-builder-inl.h
  • M src/strings/string-builder.cc
  • M src/wasm/c-api.cc
  • M src/wasm/constant-expression-interface.cc
  • M src/wasm/constant-expression.cc
  • M src/wasm/function-compiler.cc
  • M src/wasm/module-instantiate.cc
  • M src/wasm/wasm-debug.cc
  • M src/wasm/wasm-external-refs.cc
  • M src/wasm/wasm-js.cc
  • M src/wasm/wasm-objects-inl.h
  • M src/wasm/wasm-objects.cc
  • M src/wasm/wasm-objects.h
  • M test/cctest/cctest.h
  • M test/cctest/compiler/function-tester.cc
  • M test/cctest/compiler/function-tester.h
  • M test/cctest/compiler/test-concurrent-shared-function-info.cc
  • M test/cctest/compiler/test-linkage.cc
  • M test/cctest/heap/test-array-buffer-tracker.cc
  • M test/cctest/heap/test-concurrent-marking.cc
  • M test/cctest/heap/test-heap.cc
  • M test/cctest/heap/test-mark-compact.cc
  • M test/cctest/heap/test-memory-measurement.cc
  • M test/cctest/test-api.cc
  • M test/cctest/test-code-stub-assembler.cc
  • M test/cctest/test-debug.cc
  • M test/cctest/test-field-type-tracking.cc
  • M test/cctest/test-inobject-slack-tracking.cc
  • M test/cctest/test-js-weak-refs.cc
  • M test/cctest/test-profile-generator.cc
  • M test/cctest/test-serialize.cc
  • M test/cctest/test-shared-strings.cc
  • M test/cctest/test-strings.cc
  • M test/cctest/wasm/test-gc.cc
  • M test/cctest/wasm/test-run-wasm-exceptions.cc
  • M test/cctest/wasm/test-run-wasm-js.cc
  • M test/cctest/wasm/test-run-wasm-wrappers.cc
  • M test/cctest/wasm/test-wasm-serialization.cc
  • M test/cctest/wasm/test-wasm-shared-engine.cc
  • M test/cctest/wasm/test-wasm-stack.cc
  • M test/cctest/wasm/test-wasm-trap-position.cc
  • M test/common/wasm/wasm-module-runner.cc
  • M test/fuzzer/wasm-init-expr.cc
  • M test/unittests/api/access-check-unittest.cc
  • M test/unittests/api/v8-script-unittest.cc
  • M test/unittests/compiler/compiler-unittest.cc
  • M test/unittests/compiler/function-tester.cc
  • M test/unittests/compiler/function-tester.h
  • M test/unittests/compiler/js-call-reducer-unittest.cc
  • M test/unittests/compiler/run-bytecode-graph-builder-unittest.cc
  • M test/unittests/deoptimizer/deoptimization-unittest.cc
  • M test/unittests/execution/microtask-queue-unittest.cc
  • M test/unittests/interpreter/bytecode-expectations-printer.cc
  • M test/unittests/interpreter/constant-array-builder-unittest.cc
  • M test/unittests/interpreter/interpreter-tester.h
  • M test/unittests/interpreter/interpreter-unittest.cc
  • M test/unittests/objects/concurrent-feedback-vector-unittest.cc
  • M test/unittests/objects/concurrent-js-array-unittest.cc
  • M test/unittests/objects/elements-kind-unittest.cc
  • M test/unittests/objects/feedback-vector-unittest.cc
  • M test/unittests/objects/hashcode-unittest.cc
  • M test/unittests/objects/object-unittest.cc
  • M test/unittests/parser/parsing-unittest.cc
  • M test/unittests/parser/scanner-streams-unittest.cc
  • M test/unittests/regexp/regexp-unittest.cc
  • M test/unittests/strings/unicode-unittest.cc
  • M test/unittests/test-utils.h
Change size: XL
Delta: 283 files changed, 2313 insertions(+), 2614 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michael Lippautz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Iee0a4b7e084d125cc0f8167d39de2c538469ef69
Gerrit-Change-Number: 5607996
Gerrit-PatchSet: 12
Gerrit-Owner: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages