Unreviewed changes
8 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/handles/handles-inl.h
Insertions: 0, Deletions: 6.
@@ -108,12 +108,6 @@
: DirectHandle(object.ptr()) {}
template <typename To, typename From>
-inline DirectHandle<To> Cast(Handle<From> value) {
- DCHECK(Is<To>(*value));
- return DirectHandle<To>(*value.location());
-}
-
-template <typename To, typename From>
inline DirectHandle<To> Cast(DirectHandle<From> value) {
DCHECK(Is<To>(*value));
return DirectHandle<To>(value.obj_);
```
```
The name of the file: src/objects/bigint.cc
Insertions: 24, Deletions: 26.
@@ -76,10 +76,6 @@
New(isolate, 0, allocation).ToHandleChecked());
}
- static Handle<MutableBigInt> Cast(Handle<FreshlyAllocatedBigInt> bigint) {
- SLOW_DCHECK(IsBigInt(*bigint));
- return Cast<MutableBigInt>(bigint);
- }
static Tagged<MutableBigInt> cast(Tagged<Object> o) {
SLOW_DCHECK(IsBigInt(o));
return MutableBigInt::unchecked_cast(o);
@@ -185,7 +181,7 @@
return ThrowBigIntTooBig<MutableBigInt>(isolate);
}
Handle<MutableBigInt> result =
- Cast(isolate->factory()->NewBigInt(length, allocation));
+ Cast<MutableBigInt>(isolate->factory()->NewBigInt(length, allocation));
result->initialize_bitfield(false, length);
#if DEBUG
result->InitializeDigits(length, 0xBF);
@@ -195,7 +191,8 @@
Handle<BigInt> MutableBigInt::NewFromInt(Isolate* isolate, int value) {
if (value == 0) return Zero(isolate);
- Handle<MutableBigInt> result = Cast(isolate->factory()->NewBigInt(1));
+ Handle<MutableBigInt> result =
+ Cast<MutableBigInt>(isolate->factory()->NewBigInt(1));
bool sign = value < 0;
result->initialize_bitfield(sign, 1);
if (!sign) {
@@ -224,7 +221,8 @@
DCHECK_GE(raw_exponent, 0x3FF);
int exponent = raw_exponent - 0x3FF;
int digits = exponent / kDigitBits + 1;
- Handle<MutableBigInt> result = Cast(isolate->factory()->NewBigInt(digits));
+ Handle<MutableBigInt> result =
+ Cast<MutableBigInt>(isolate->factory()->NewBigInt(digits));
result->initialize_bitfield(sign, digits);
// We construct a BigInt from the double {value} by shifting its mantissa
@@ -1244,7 +1242,7 @@
// There is no -0n. Reject corrupted serialized data.
if (length == 0 && sign == true) return {};
Handle<MutableBigInt> result =
- MutableBigInt::Cast(isolate->factory()->NewBigInt(length));
+ Cast<MutableBigInt>(isolate->factory()->NewBigInt(length));
result->initialize_bitfield(sign, length);
UnalignedValueMember<digit_t>* digits = result->raw_digits();
#if defined(V8_TARGET_LITTLE_ENDIAN)
@@ -1320,7 +1318,7 @@
static_assert(kDigitBits == 64 || kDigitBits == 32);
int length = 64 / kDigitBits;
Handle<MutableBigInt> result =
- MutableBigInt::Cast(isolate->factory()->NewBigInt(length));
+ Cast<MutableBigInt>(isolate->factory()->NewBigInt(length));
bool sign = n < 0;
result->initialize_bitfield(sign, length);
uint64_t absolute;
@@ -1342,7 +1340,7 @@
static_assert(kDigitBits == 64 || kDigitBits == 32);
int length = 64 / kDigitBits;
Handle<MutableBigInt> result =
- MutableBigInt::Cast(isolate->factory()->NewBigInt(length));
+ Cast<MutableBigInt>(isolate->factory()->NewBigInt(length));
result->initialize_bitfield(false, length);
result->set_64_bits(n);
return MutableBigInt::MakeImmutable(result);
@@ -1470,7 +1468,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));
bigint::Add(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1488,7 +1486,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));
bigint::Subtract(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1502,7 +1500,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));
Isolate* isolate;
if (!GetIsolateFromHeapObject(x, &isolate)) {
@@ -1526,7 +1524,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));
DCHECK_GE(result->length(),
bigint::DivideResultLength(x->digits(), y->digits()));
@@ -1552,7 +1550,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));
Isolate* isolate;
if (!GetIsolateFromHeapObject(x, &isolate)) {
@@ -1576,7 +1574,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));
bigint::BitwiseAnd_PosPos(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1588,7 +1586,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));
bigint::BitwiseAnd_NegNeg(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1600,7 +1598,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));
bigint::BitwiseAnd_PosNeg(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1612,7 +1610,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));
bigint::BitwiseOr_PosPos(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1624,7 +1622,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));
bigint::BitwiseOr_NegNeg(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1636,7 +1634,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));
bigint::BitwiseOr_PosNeg(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1648,7 +1646,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));
bigint::BitwiseXor_PosPos(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1660,7 +1658,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));
bigint::BitwiseXor_NegNeg(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1672,7 +1670,7 @@
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<BigInt> y = BigInt::cast(Tagged<Object>(y_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));
bigint::BitwiseXor_PosNeg(result->rw_digits(), x->digits(), y->digits());
MutableBigInt::Canonicalize(result);
@@ -1682,7 +1680,7 @@
intptr_t shift) {
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));
bigint::LeftShift(result->rw_digits(), x->digits(), shift);
MutableBigInt::Canonicalize(result);
@@ -1706,7 +1704,7 @@
uint32_t must_round_down) {
Tagged<BigInt> x = BigInt::cast(Tagged<Object>(x_addr));
Tagged<MutableBigInt> result =
- MutableBigInt::cast(Tagged<Object>(result_addr));
+ Cast<MutableBigInt>(Tagged<Object>(result_addr));
bigint::RightShiftState state{must_round_down == 1};
bigint::RightShift(result->rw_digits(), x->digits(), shift, state);
MutableBigInt::Canonicalize(result);
```
```
The name of the file: src/wasm/wasm-js.cc
Insertions: 10, Deletions: 9.
@@ -2160,15 +2160,16 @@
i_isolate};
int num_imported_functions = module->num_imported_functions;
- i::DirectHandle<i::ExposedTrustedObject> ref =
- func_index >= num_imported_functions
- ? trusted_instance_data
- : i::Cast<i::ExposedTrustedObject>(
- i_isolate->factory()->NewWasmApiFunctionRef(direct_handle(
- i::WasmApiFunctionRef::cast(
- trusted_instance_data->dispatch_table_for_imports()
- ->ref(func_index)),
- i_isolate)));
+ i::DirectHandle<i::ExposedTrustedObject> ref;
+ if (func_index >= num_imported_functions) {
+ ref = trusted_instance_data;
+ } else {
+ ref = i_isolate->factory()->NewWasmApiFunctionRef(direct_handle(
+ i::Cast<i::WasmApiFunctionRef>(
+ trusted_instance_data->dispatch_table_for_imports()->ref(
+ func_index)),
+ i_isolate));
+ }
#if V8_ENABLE_SANDBOX
uint64_t signature_hash =
```