Avoid one more string copy. [v8/v8 : main]

0 views
Skip to first unread message

Michael Lippautz (Gerrit)

unread,
Jan 12, 2026, 6:18:15 AM (6 days ago) Jan 12
to Jeffrey Yu, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jeffrey Yu

Michael Lippautz voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jeffrey Yu
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I98800a3ca386beadcfebbd9df0cc0691f736f80e
Gerrit-Change-Number: 7421915
Gerrit-PatchSet: 4
Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Jeffrey Yu <yu...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 11:18:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Deepti Gandluri (Gerrit)

unread,
Jan 12, 2026, 4:13:18 PM (5 days ago) Jan 12
to Jeffrey Yu, Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jeffrey Yu

Deepti Gandluri voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jeffrey Yu
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I98800a3ca386beadcfebbd9df0cc0691f736f80e
Gerrit-Change-Number: 7421915
Gerrit-PatchSet: 4
Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Deepti Gandluri <gde...@chromium.org>
Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Jeffrey Yu <yu...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 21:13:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jeffrey Yu (Gerrit)

unread,
Jan 12, 2026, 4:22:21 PM (5 days ago) Jan 12
to Deepti Gandluri, Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com

Jeffrey Yu voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I98800a3ca386beadcfebbd9df0cc0691f736f80e
Gerrit-Change-Number: 7421915
Gerrit-PatchSet: 4
Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Deepti Gandluri <gde...@chromium.org>
Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 21:22:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jeffrey Yu (Gerrit)

unread,
Jan 12, 2026, 9:19:15 PM (5 days ago) Jan 12
to Deepti Gandluri, Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Gerrit-Comment-Date: Tue, 13 Jan 2026 02:19:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Jan 13, 2026, 2:36:27 AM (5 days ago) Jan 13
to Jeffrey Yu, Deepti Gandluri, Michael Lippautz, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
Avoid one more string copy.

Addressing feedback from https://crrev.com/c/7361593.
Change-Id: I98800a3ca386beadcfebbd9df0cc0691f736f80e
Reviewed-by: Deepti Gandluri <gde...@chromium.org>
Commit-Queue: Jeffrey Yu <yu...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104653}
Files:
  • M src/heap/cppgc/name-trait.cc
Change size: XS
Delta: 1 file changed, 3 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michael Lippautz, +1 by Deepti Gandluri
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I98800a3ca386beadcfebbd9df0cc0691f736f80e
Gerrit-Change-Number: 7421915
Gerrit-PatchSet: 5
Gerrit-Owner: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Deepti Gandluri <gde...@chromium.org>
Gerrit-Reviewer: Jeffrey Yu <yu...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages