[api] Port v8::MicrotaskQueue to CppGC [v8/v8 : main]
0 views
Skip to first unread message
Igor Sheludko (Gerrit)
Jun 23, 2026, 11:31:18 AM (11 days ago) Jun 23
to Michael Lippautz, android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, oilpan-r...@chromium.org, was...@google.com, cbruni...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Michael Lippautz
Igor Sheludko voted and added 2 comments![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File src/heap/memory-reducer.cc
Line 49, Patchset 15:
SetCurrentLocalHeapScope thread_local_scope(heap->isolate());Igor Sheludko . unresolved
Required by one of DCHECKs in `GCTracer::Scope`.
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Jun 23, 2026, 11:31:45 AM (11 days ago) Jun 23
to Michael Lippautz, android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, oilpan-r...@chromium.org, was...@google.com, cbruni...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Michael Lippautz
Igor Sheludko added 1 comment![]( "Open in Gerrit")
File gni/v8.gni
Line 95, Patchset 16 (Latest):
v8_cppgc_microtask_queue = trueIgor Sheludko . unresolved
I'll disable it before landing.
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Jun 23, 2026, 2:03:23 PM (11 days ago) Jun 23
to Michael Lippautz, android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, oilpan-r...@chromium.org, was...@google.com, cbruni...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Michael Lippautz
Igor Sheludko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Commit-Queue | +1 |
1 comment
File gni/v8.gni
I'll disable it before landing.
Igor Sheludko
Done
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Jun 24, 2026, 3:37:47 AM (10 days ago) Jun 24
to Igor Sheludko, android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, oilpan-r...@chromium.org, was...@google.com, cbruni...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Igor Sheludko
Michael Lippautz added 4 comments![]( "Open in Gerrit")
File include/v8-isolate.h
Line 457, Patchset 19 (Latest):
cppgc::Persistent<internal::MicrotaskQueue> const microtask_queue_;Michael Lippautz . unresolved
Is this scope always supposed to be used from stack? If so, this can be a raw pointer and we should annotate the scope with `CPPGC_STACK_ALLOCATED`.
File src/execution/execution.cc
Line 87, Patchset 19 (Latest):
cppgc::UntracedMember<MicrotaskQueue> microtask_queue;Michael Lippautz . unresolved
For stack, we should just use a raw pointer, not UntracedMember.
File src/heap/heap.cc
Line 5070, Patchset 19 (Latest):
if (!cpp_heap) {Michael Lippautz . unresolved
We should pass `CppHeap&` from the callers because this cannot be null anymore.
File src/heap/memory-reducer.cc
Line 49, Patchset 15:
SetCurrentLocalHeapScope thread_local_scope(heap->isolate());Igor Sheludko . resolved
Required by one of DCHECKs in `GCTracer::Scope`.
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Jun 24, 2026, 4:12:48 AM (10 days ago) Jun 24
to Igor Sheludko, Michael Lippautz, android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, oilpan-r...@chromium.org, was...@google.com, cbruni...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Igor Sheludko
Omer Katz voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Jun 24, 2026, 4:12:57 AM (10 days ago) Jun 24
to Igor Sheludko, Michael Lippautz, android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, oilpan-r...@chromium.org, was...@google.com, cbruni...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Igor Sheludko
Omer Katz removed a vote from this change![]( "Open in Gerrit")
Removed Code-Review+1 by Omer Katz <omer...@chromium.org>
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Jun 24, 2026, 5:22:07 AM (10 days ago) Jun 24
to Michael Lippautz, android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, jgrube...@chromium.org, oilpan-r...@chromium.org, was...@google.com, cbruni...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Michael Lippautz
Igor Sheludko voted and added 3 comments![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Commit-Queue | +1 |
3 comments
File include/v8-isolate.h
Line 457, Patchset 19:
cppgc::Persistent<internal::MicrotaskQueue> const microtask_queue_;Michael Lippautz . resolved
Is this scope always supposed to be used from stack? If so, this can be a raw pointer and we should annotate the scope with `CPPGC_STACK_ALLOCATED`.
Igor Sheludko
Done
File src/execution/execution.cc
Line 87, Patchset 19:
cppgc::UntracedMember<MicrotaskQueue> microtask_queue;Michael Lippautz . resolved
For stack, we should just use a raw pointer, not UntracedMember.
Igor Sheludko
Done
File src/heap/heap.cc
We should pass `CppHeap&` from the callers because this cannot be null anymore.
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Jun 24, 2026, 3:08:30 PM (10 days ago) Jun 24
to Igor Sheludko, android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, jgrube...@chromium.org, oilpan-r...@chromium.org, was...@google.com, cbruni...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Igor Sheludko
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Jun 24, 2026, 3:24:59 PM (10 days ago) Jun 24
to Michael Lippautz, android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, jgrube...@chromium.org, oilpan-r...@chromium.org, was...@google.com, cbruni...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Igor Sheludko voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 24, 2026, 3:27:21 PM (10 days ago) Jun 24
to Igor Sheludko, Michael Lippautz, android-bu...@system.gserviceaccount.com, Hannes Payer, jgrube...@chromium.org, oilpan-r...@chromium.org, was...@google.com, cbruni...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[api] Port v8::MicrotaskQueue to CppGC
This CL ports v8::MicrotaskQueue to CppGC (unified heap) behind the
v8_cppgc_microtask_queue build flag and initiates deprecation of
the non-CppGC MicrotaskQueue Api. The flag is currently disabled.
TAG=agy
CONV=4bb71540-afc9-4de3-8c14-b9a4b213d916
Bug: 515252150
Change-Id: Ic3e5b7be00bd6610f86c2b46844bb6b231324f90
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108233}
Files:
- M BUILD.bazel
- M BUILD.gn
- M gni/v8.gni
- M include/DEPS
- M include/v8-isolate.h
- M include/v8-microtask-queue.h
- M src/api/api.cc
- M src/execution/execution.cc
- M src/execution/isolate-data.h
- M src/execution/isolate-inl.h
- M src/execution/isolate.cc
- M src/execution/isolate.h
- M src/execution/microtask-queue.cc
- M src/execution/microtask-queue.h
- M src/heap/finalization-registry-cleanup-task.cc
- M src/heap/heap.cc
- M src/heap/heap.h
- M src/heap/memory-reducer.cc
- M src/snapshot/snapshot.cc
- M src/snapshot/snapshot.h
- M src/wasm/wasm-memory-map-descriptor.cc
- M test/cctest/test-api.cc
- M test/cctest/test-js-weak-refs.cc
- M test/unittests/execution/microtask-queue-unittest.cc
- M test/unittests/heap/gc-tracer-unittest.cc
- M tools/gcmole/test-expectations.txt
Change size: L
Delta: 26 files changed, 296 insertions(+), 53 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages