[gin] Move parts of blink::Persistent and blink::WeakCell to gin [chromium/src : main]
0 views
Skip to first unread message
Andreas Haas (Gerrit)
Aug 8, 2025, 5:18:32 AMAug 8
to chrome-family...@google.com, Tomek Jurkiewicz, Kentaro Hara, Omer Katz, AyeAye, Chromium LUCI CQ, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Kentaro Hara, Omer Katz and Tomek Jurkiewicz
Andreas Haas added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 10:
Tomek Jurkiewicz . resolved
Andreas HaasHey,
Can you be a more specific, why c/r/supervised_user is elected to use weak cell? This change looks like it's introducing weak cell, and immediately makes only one specific error page to use it.
Tomek JurkiewiczIn https://crrev.com/c/6703729, `SupervisedUserErrorPageController` was migrated to a more secure implementation of `gin::Wrappable`. As part of this migration, `SupervisedUserErrorPageController` became an oilpan object, i.e. its memory is managed by a GC. Due to that, `base::WeakPtrFactory` is not allowed to be used anymore. This change should have already been done as part of the original migration, but it was missed.
`gin::WeakCellFactory` is the Oilpan equivalent to `base::WeakPtrFactory`.
Andreas HaasI see, thanks.
But I think my argument is still valid; that's two changes in one CL. Do you think you could split out infra change from supervised user change?
Related details
Attention is currently required from:
- Kentaro Hara
- Omer Katz
- Tomek Jurkiewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andreas Haas (Gerrit)
Aug 8, 2025, 5:20:44 AMAug 8
to chrome-family...@google.com, Kentaro Hara, Omer Katz, AyeAye, Chromium LUCI CQ, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Kentaro Hara and Omer Katz
Andreas Haas voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Kentaro Hara
- Omer Katz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kentaro Hara (Gerrit)
Aug 8, 2025, 6:10:33 AMAug 8
to Andreas Haas, chrome-family...@google.com, Omer Katz, AyeAye, Chromium LUCI CQ, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Andreas Haas and Omer Katz
Kentaro Hara voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kentaro Hara
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Andreas Haas
- Omer Katz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Aug 8, 2025, 6:43:34 AMAug 8
to Andreas Haas, Kentaro Hara, chrome-family...@google.com, AyeAye, Chromium LUCI CQ, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Andreas Haas
Omer Katz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Omer Katz
| Code-Review | +1 |
1 comment
Patchset-level comments
Omer Katz . resolved
lgtm
Related details
Attention is currently required from:
- Andreas Haas
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andreas Haas (Gerrit)
Aug 8, 2025, 6:49:21 AMAug 8
to Omer Katz, Kentaro Hara, chrome-family...@google.com, AyeAye, Chromium LUCI CQ, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Andreas Haas voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 8, 2025, 8:09:26 AMAug 8
to Andreas Haas, Omer Katz, Kentaro Hara, chrome-family...@google.com, AyeAye, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[gin] Move parts of blink::Persistent and blink::WeakCell to gin
By making gin::Wrappable an oilpan object, oilpan infrastructure is
needed for gin::Wrappable users. This CL moves some infrastructure to
gin to make it usable for gin::Wrappable users.
Bug: 345640553
Change-Id: Iaad5df2dc893e78652d019df4613f86a473e2d6f
Commit-Queue: Andreas Haas <ah...@chromium.org>
Reviewed-by: Omer Katz <omer...@chromium.org>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1498685}
Files:
- M gin/BUILD.gn
- A gin/persistent.h
- A gin/weak_cell.h
- M third_party/blink/renderer/platform/heap/DEPS
- M third_party/blink/renderer/platform/heap/weak_cell.h
- M third_party/blink/renderer/platform/wtf/hash_functions.h
Change size: L
Delta: 6 files changed, 210 insertions(+), 132 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Omer Katz, +1 by Kentaro Hara
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages