[unittests][compile-time] Make unittests concatenable. [v8/v8 : main]

0 views
Skip to first unread message

Erik Corry (Gerrit)

unread,
Feb 11, 2026, 8:11:59 AMFeb 11
to V8 LUCI CQ, Leszek Swirski, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Leszek Swirski

Erik Corry voted and added 1 comment

Votes added by Erik Corry

Commit-Queue+1

1 comment

File test/unittests/wasm/module-decoder-unittest.cc
Line 4219, Patchset 2 (Parent):#undef SECTION
Erik Corry . resolved

These are defined in .h files, not .cc files, so they should not be undeffed.

Open in Gerrit

Related details

Attention is currently required from:
  • Leszek Swirski
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I759e9a0d23f457fff72aeab16b7037a1b7044256
Gerrit-Change-Number: 7564409
Gerrit-PatchSet: 2
Gerrit-Owner: Erik Corry <erik...@chromium.org>
Gerrit-Reviewer: Erik Corry <erik...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Wed, 11 Feb 2026 13:11:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages