heap: Fix inconsistencies in HeapObserverList [chromium/src : main]
0 views
Skip to first unread message
Michael Lippautz (Gerrit)
Aug 18, 2025, 5:09:50 PMAug 18
to Anton Bikineev, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Anton Bikineev
Michael Lippautz voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bikineev (Gerrit)
Aug 19, 2025, 8:52:11 AMAug 19
to Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Michael Lippautz
Anton Bikineev voted and added 1 comment![]( "Open in Gerrit")
Votes added by Anton Bikineev
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Aug 19, 2025, 10:01:27 AMAug 19
to Anton Bikineev, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Michael Lippautz voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 19, 2025, 10:04:34 AMAug 19
to Michael Lippautz, Anton Bikineev, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
heap: Fix inconsistencies in HeapObserverList
The observer list is both weak (implicitly managed) and allows for
removing observers. If observers are removed while at the same time
multiple other observers die, and the removal call triggers GC, this may
lead to CHECK() failures where the index retrieved on `RemoveObserver`
is too large for the `observers_` array.
Bug: 438569732, 438916130
Change-Id: I6731ad38e96f01a47258bc8f8f5a0b1b41e736a3
Commit-Queue: Michael Lippautz <mlip...@chromium.org>
Reviewed-by: Anton Bikineev <biki...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1503316}
Files:
- M third_party/blink/renderer/platform/heap_observer_list.h
Change size: S
Delta: 1 file changed, 11 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Anton Bikineev
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages