Reland "[heap] Refactor new space containment calls" [v8/v8 : main]
0 views
Skip to first unread message
Michael Lippautz (Gerrit)
Aug 26, 2025, 4:24:11 AMAug 26
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, AyeAye, oilpan-r...@chromium.org, mlippau...@chromium.org
Attention needed from Dominik Inführ
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Michael Lippautz . resolved
ptal, fixes here: https://chromium-review.googlesource.com/c/v8/v8/+/6883751/1..2
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Aug 26, 2025, 5:45:15 AMAug 26
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, AyeAye, oilpan-r...@chromium.org, mlippau...@chromium.org
Attention needed from Michael Lippautz
Dominik Inführ voted and added 2 comments![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Code-Review | +1 |
2 comments
Patchset-level comments
Dominik Inführ . resolved
LGTM with comment
File src/heap/cppgc-js/unified-heap-marking-visitor.cc
Line 141, Patchset 2 (Latest):
IsolateGroup::set_current(saved_isolate_group_);Dominik Inführ . unresolved
Should we make this cleanup conditional as well? E.g. using `current_isolate_scope_has_value()`. Not sure this can cause any trouble though.
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Aug 26, 2025, 6:45:37 AMAug 26
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, AyeAye, oilpan-r...@chromium.org, mlippau...@chromium.org
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Commit-Queue | +2 |
1 comment
File src/heap/cppgc-js/unified-heap-marking-visitor.cc
Line 141, Patchset 2 (Latest):
IsolateGroup::set_current(saved_isolate_group_);Dominik Inführ . resolved
Should we make this cleanup conditional as well? E.g. using `current_isolate_scope_has_value()`. Not sure this can cause any trouble though.
Michael Lippautz
It's not an officially supported configuration and we don't have real testing for this here. I'd rather not touch it.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Aug 26, 2025, 6:47:39 AMAug 26
to Michael Lippautz, Dominik Inführ, Hannes Payer, AyeAye, oilpan-r...@chromium.org, mlippau...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reland "[heap] Refactor new space containment calls"
This is a reland of commit e42ce24ddcf5075586e5c1f2c56677245658bb43
Original change's description:
> [heap] Refactor new space containment calls
>
> Relay them to MemoryChunkMetadata::owner() instead of using the chunk
> flags. The calls are not as hot and this way is consistent with
> PagedSpace.
>
> Bug: 429538831
> Change-Id: I2fb533ca5f2490312cefb7a17c576b539a8fd7e3
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6879446
> Reviewed-by: Dominik Inführ <dinf...@chromium.org>
> Commit-Queue: Michael Lippautz <mlip...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#102022}
Bug: 429538831
Change-Id: I6f004d697a0ab93e70d1fb073e9d2b37402d2ebc
Commit-Queue: Michael Lippautz <mlip...@chromium.org>
Reviewed-by: Dominik Inführ <dinf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102040}
Files:
- M src/heap/cppgc-js/unified-heap-marking-visitor.cc
- M src/heap/cppgc-js/unified-heap-marking-visitor.h
- M src/heap/new-spaces-inl.h
- M src/heap/new-spaces.cc
- M src/heap/new-spaces.h
Change size: M
Delta: 5 files changed, 33 insertions(+), 53 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dominik Inführ
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages