[base] Introduce v8_logging_level GN arg [v8/v8 : main]
0 views
Skip to first unread message
Clemens Backes (Gerrit)
Mar 31, 2026, 11:02:20 AMMar 31
to Darius Mercadier, Michael Lippautz, V8 LUCI CQ, Jakob Kummerow, Hannes Payer, dmercadi...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Darius Mercadier, Jakob Kummerow and Michael Lippautz
Clemens Backes added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2:
Clemens Backes . resolved
Jakob as main reviewer (because we discussed this before).
Darius for src/compiler (a cleanup).
Michael for src/heap and for a second (or third) pair of eyes generally.
Related details
Attention is currently required from:
- Darius Mercadier
- Jakob Kummerow
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Mar 31, 2026, 1:08:51 PMMar 31
to Clemens Backes, Darius Mercadier, V8 LUCI CQ, Jakob Kummerow, Hannes Payer, dmercadi...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Clemens Backes, Darius Mercadier and Jakob Kummerow
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Clemens Backes
- Darius Mercadier
- Jakob Kummerow
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
Mar 31, 2026, 1:15:11 PMMar 31
to Clemens Backes, Jakob Kummerow, Michael Lippautz, Darius Mercadier, V8 LUCI CQ, Hannes Payer, dmercadi...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Clemens Backes and Darius Mercadier
Jakob Kummerow voted and added 2 comments![]( "Open in Gerrit")
Votes added by Jakob Kummerow
| Code-Review | +1 |
2 comments
Patchset-level comments
Jakob Kummerow . resolved
LGTM with a nit.
File BUILD.gn
Line 519, Patchset 3 (Latest):
# 0: No file and line and message only if args are provided (matches official release builds).Jakob Kummerow . unresolved
nit: 80col would be nice
Related details
Attention is currently required from:
- Clemens Backes
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Mar 31, 2026, 1:32:57 PMMar 31
to Jakob Kummerow, Michael Lippautz, Darius Mercadier, V8 LUCI CQ, Hannes Payer, dmercadi...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Darius Mercadier
Clemens Backes added 1 comment![]( "Open in Gerrit")
File BUILD.gn
Line 519, Patchset 3:
# 0: No file and line and message only if args are provided (matches official release builds).Jakob Kummerow . resolved
nit: 80col would be nice
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Apr 1, 2026, 3:28:39 AMApr 1
to Clemens Backes, Jakob Kummerow, Michael Lippautz, V8 LUCI CQ, Hannes Payer, dmercadi...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Clemens Backes
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Clemens Backes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Apr 1, 2026, 3:31:20 AMApr 1
to Darius Mercadier, Jakob Kummerow, Michael Lippautz, V8 LUCI CQ, Hannes Payer, dmercadi...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Clemens Backes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Clemens Backes
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Darius Mercadier . resolved
Cool change, lgtm :)
Clemens Backes
Ack, I could have used this multiple times already :)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Apr 1, 2026, 4:12:46 AMApr 1
to Clemens Backes, Darius Mercadier, Jakob Kummerow, Michael Lippautz, Hannes Payer, dmercadi...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[base] Introduce v8_logging_level GN arg
Instead of deriving the logging detail (file, line, and message) for
failed checks and unreachable code from DEBUG and OFFICIAL_BUILD, this
CL introduces a new v8_logging_level GN argument.
The new argument supports three levels:
0: No file/line info; message only if provided (matches official
release builds).
1: message but no file or line.
2: everything (file, line, message).
The default value is derived from existing GN args to match the current
behaviour.
Binary size can be saved by using level 1 even in debug builds, or
more detail can be enabled in release builds if needed.
R=jkum...@chromium.org
Change-Id: Ifb0ba281d04332ec38afe38bf3e6bb6970fcaa1c
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106199}
Files:
- M BUILD.gn
- M src/base/logging.cc
- M src/base/logging.h
- M src/compiler/turboshaft/assembler.h
- M src/heap/cppgc/logging.cc
- M src/heap/cppgc/platform.cc
- M test/unittests/base/logging-unittest.cc
Change size: M
Delta: 7 files changed, 112 insertions(+), 94 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darius Mercadier, +1 by Jakob Kummerow, +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages