Revert "Make Uncompress(Compress(ptr)) into a no-op." [v8/v8 : main]
0 views
Skip to first unread message
Rubber Stamper (Gerrit)
Jan 16, 2026, 5:23:15 AM (2 days ago) Jan 16
to Steinar H Gunderson, AyeAye, Michael Lippautz, V8 LUCI CQ, Anton Bikineev, chrom...@appspot.gserviceaccount.com, Leszek Swirski, cbruni...@chromium.org, oilpan-r...@chromium.org
Attention needed from Anton Bikineev and Michael Lippautz
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Anton Bikineev
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Steinar H Gunderson (Gerrit)
Jan 16, 2026, 5:23:24 AM (2 days ago) Jan 16
to Rubber Stamper, AyeAye, Michael Lippautz, V8 LUCI CQ, Anton Bikineev, chrom...@appspot.gserviceaccount.com, Leszek Swirski, cbruni...@chromium.org, oilpan-r...@chromium.org
Attention needed from Anton Bikineev and Michael Lippautz
Steinar H Gunderson voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Anton Bikineev
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Jan 16, 2026, 5:24:08 AM (2 days ago) Jan 16
to Steinar H Gunderson, AyeAye, Michael Lippautz, V8 LUCI CQ, Anton Bikineev, chrom...@appspot.gserviceaccount.com, Leszek Swirski, cbruni...@chromium.org, oilpan-r...@chromium.org
Attention needed from Anton Bikineev, Michael Lippautz and Steinar H Gunderson
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
Attention is currently required from:
- Anton Bikineev
- Michael Lippautz
- Steinar H Gunderson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Jan 16, 2026, 5:34:51 AM (2 days ago) Jan 16
to Steinar H Gunderson, Rubber Stamper, AyeAye, V8 LUCI CQ, Anton Bikineev, chrom...@appspot.gserviceaccount.com, Leszek Swirski, cbruni...@chromium.org, oilpan-r...@chromium.org
Attention needed from Anton Bikineev and Steinar H Gunderson
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Anton Bikineev
- Steinar H Gunderson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Steinar H Gunderson (Gerrit)
Jan 16, 2026, 8:01:17 AM (2 days ago) Jan 16
to Michael Lippautz, Rubber Stamper, AyeAye, V8 LUCI CQ, Anton Bikineev, chrom...@appspot.gserviceaccount.com, Leszek Swirski, cbruni...@chromium.org, oilpan-r...@chromium.org
Attention needed from Anton Bikineev
Steinar H Gunderson voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 16, 2026, 8:02:49 AM (2 days ago) Jan 16
to Steinar H Gunderson, Michael Lippautz, Rubber Stamper, AyeAye, Anton Bikineev, chrom...@appspot.gserviceaccount.com, Leszek Swirski, cbruni...@chromium.org, oilpan-r...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "Make Uncompress(Compress(ptr)) into a no-op."
This reverts commit b284c48c161be9f0739c5d82d0872eb85d5dc5b5.
Reason for revert: Performance regressions in event dispatch, presumably from LLVM [[assume]] weaknesses; since we don't see any clear wins anywhere else (besides a bit in size), it's easier to just revert.
Original change's description:
> Make Uncompress(Compress(ptr)) into a no-op.
>
> Add an [[assume]] annotation so that Clang understands this; it doesn't
> by itself (because it requires information about high bits in the
> uncompressed pointer that we've found it hard to teach it).
>
> Doesn't give a Speedometer win by itself, but it reduces the APK size
> of 64-bit Chrome by ~11 kB.
>
> Change-Id: I1480f0032e3733972553b1e34eb4a7def5f157ed
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7277326
> Reviewed-by: Anton Bikineev <biki...@chromium.org>
> Reviewed-by: Michael Lippautz <mlip...@chromium.org>
> Commit-Queue: Michael Lippautz <mlip...@chromium.org>
> Commit-Queue: Steinar H Gunderson <se...@chromium.org>
> Auto-Submit: Steinar H Gunderson <se...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#104529}
Fixed: 474389112
Change-Id: I924a6613291a7f422736b3b914e7cc8dd58b2676
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Steinar H Gunderson <se...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104742}
Files:
- M include/cppgc/internal/member-storage.h
Change size: XS
Delta: 1 file changed, 0 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz, Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages