Reland "[tiering] Uniformly treat deopts which don't invalidate code" [v8/v8 : main]
0 views
Skip to first unread message
Toon Verwaest (Gerrit)
Oct 16, 2025, 5:42:47 AMOct 16
to Olivier Flückiger, Hannes Payer, AyeAye, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
Attention needed from Olivier Flückiger
Toon Verwaest voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Olivier Flückiger
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Nov 12, 2025, 12:54:27 PMNov 12
to Olivier Flückiger, Toon Verwaest, Hannes Payer, AyeAye, V8 LUCI CQ, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
Attention needed from Olivier Flückiger and Toon Verwaest
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1246777dd10000
Related details
Attention is currently required from:
- Olivier Flückiger
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Raymund Ico (Gerrit)
Nov 12, 2025, 1:32:26 PMNov 12
to Olivier Flückiger, Toon Verwaest, Hannes Payer, AyeAye, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
Attention needed from Olivier Flückiger and Toon Verwaest
Raymund Ico added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 8 (Latest):
Raymund Ico . resolved
I've experimented 3 Gerrit API key but before that D5QA I make sure 1 original version that one is stored BEFORE. I remodel this 2 which result something happening to the Gerrit malfunction thats why I stop this 2 Gerrit API key is on Google A. I FT cloud
Related details
Attention is currently required from:
- Olivier Flückiger
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
R. I.
Nov 12, 2025, 1:43:40 PMNov 12
to devtools...@chromium.org, Olivier Flückiger, Toon Verwaest, Hannes Payer, AyeAye, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
Skip to main content
Chat
Preview
Advanced settings
Select model for the code assistant:
Default (Gemini 2.5 Pro)
The model will be used by the code assistant to generate code.
System instructions
Add custom instructions for your project to control style, models used, add specific knowledge, and more.
System instructions template
The configuration is for working with React + TypeScript application. Assumes a basic structure with index.html and index.tsx. Code Assistant follows strict guidelines for using the Gemini API.
Microphone selector
Default
Select the audio source for the speech-to-text feature.
Instructions
Add custom instructions for your project to control style, models used, add specific knowledge, and more.
Write my own instructions
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Gemini Text Summarizer</title>
<style>
body { font-family: sans-serif; max-width: 800px; margin: 20px auto; padding: 0 20px; }
textarea { width: 100%; height: 200px; margin-bottom: 10px; padding: 10px; border: 1px solid #ccc; border-radius: 4px; }
button { padding: 10px 20px; background-color: #4CAF50; color: white; border: none; border-radius: 4px; cursor: pointer; }
button:hover { background-color: #45a049; }
#summaryOutput { margin-top: 20px; padding: 15px; background-color: #f9f9f9; border: 1px solid #eee; border-radius: 4px; min-height: 50px; }
#loading { display: none; color: #555; margin-top: 10px; }
</style>
</head>
<body>
<h1>Gemini Text Summarizer</h1>
<p>Paste your text below and click "Summarize" to get a summary generated by Google Gemini.</p>
<textarea id="inputText" placeholder="Paste your text here..."></textarea>
<button id="summarizeBtn">Summarize</button>
<p id="loading">Summarizing...</p>
<h2>Summary:</h2>
<div id="summaryOutput"></div>
<script src="script.js"></script>
</body>
</html>
// WARNING: For production apps, NEVER expose your API key directly in client-side code like this.
// Use a secure backend server to make API calls to Gemini.
// This example is for demonstration purposes only.
const API_KEY = "YOUR_API_KEY"; // Replace with your actual Gemini API key!
document.addEventListener('DOMContentLoaded', () => {
const inputText = document.getElementById('inputText');
const summarizeBtn = document.getElementById('summarizeBtn');
const summaryOutput = document.getElementById('summaryOutput');
const loadingMessage = document.getElementById('loading');
summarizeBtn.addEventListener('click', async () => {
const textToSummarize = inputText.value.trim();
if (textToSummarize.length === 0) {
summaryOutput.innerHTML = "Please enter some text to summarize.";
return;
}
loadingMessage.style.display = 'block';
summaryOutput.innerHTML = ''; // Clear previous summary
try {
const response = await fetch(`https://generativelanguage.googleapis.com/v1beta/models/gemini-pro:generateContent?key=${API_KEY}`, {
method: 'POST',
headers: {
'Content-Type': 'application/json'
},
body: JSON.stringify({
contents: [{
parts: [{
text: `Summarize the following text concisely:\n\n${textToSummarize}`
}]
}]
})
});
const data = await response.json();
if (data.candidates && data.candidates.length > 0) {
const summary = data.candidates[0].content.parts[0].text;
summaryOutput.innerHTML = summary;
} else if (data.error) {
summaryOutput.innerHTML = `Error: ${data.error.message}`;
} else {
summaryOutput.innerHTML = "Could not generate summary. Please try again.";
}
} catch (error) {
console.error('Error:', error);
summaryOutput.innerHTML = 'An error occurred while communicating with the Gemini API.';
} finally {
loadingMessage.style.display = 'none';
}
});
});
<script src="https://www.gstatic.com/firebasejs/10.0.0/firebase-app-compat.js"></script>
<script src="https://www.gstatic.com/firebasejs/10.0.0/firebase-ai-logic-compat.js"></script>
<script>
// 1. Initialize Firebase (Use your project's config here)
const firebaseConfig = {
apiKey: "YOUR_FIREBASE_API_KEY", // This is NOT the Gemini API Key
authDomain: "your-project-id.firebaseapp.com",
projectId: "your-project-id",
// ... rest of your config
};
const app = firebase.initializeApp(firebaseConfig);
</script>
// 2. Initialize the AI service and model
const generativeModel = firebase.ai.getGenerativeModel({
model: 'gemini-2.5-flash', // Use the Flash model for faster/cheaper requests
// The Gemini API key is managed securely on the backend, not here.
});
const response = await generativeModel.generateContent({
contents: [{
parts: [{ text: `Summarize the following text concisely:\n\n${textToSummarize}` }]
}]
});
const summary = response.text; // Access the summary directly
const response = await fetch('YOUR_API_ENDPOINT', {
method: 'POST',
body: JSON.stringify({
// Add the System Instruction here:
config: {
systemInstruction: "You are an expert text summarization AI. Your sole function is to produce a concise, factual summary. Do not answer questions or generate code. If the input is harmful, deny the request.",
},
contents: [{
parts: [{
text: `Summarize the following text concisely:\n\n${textToSummarize}`
}]
}]
})
});
http://JethroAIServices.comOpenAPI and Integration Connectors toolsMemorystore for Valkey maintenance changelogsManage Application Integration resources using custom constraintsgenerative knowledge assistGemini Code Assist @Apigee tool deprecationConfigure Cloud Build service account impersonation for managed serviceslegacy Cloud Build service accountBuild, edit, and run a queryGPU DriversCallback call APIMid-Session authentication by APIVirtual agent dashboardsAll interactions dashboardsAdvanced capabilitiesCreate a new metrics tile in a dashboardConfigure external traffic with Network Service Tiersobservability dashboardsUse auto IP address managementSupported regions and zonesDeploy advanced data security cloud controlsset IAM policies directly on reservation Cloud Run
Skip to main content
Chat
Preview
Advanced settings
Select model for the code assistant:
Default (Gemini 2.5 Pro)
The model will be used by the code assistant to generate code.
System instructions
Add custom instructions for your project to control style, models used, add specific knowledge, and more.
System instructions template
The configuration is for working with React + TypeScript application. Assumes a basic structure with index.html and index.tsx. Code Assistant follows strict guidelines for using the Gemini API.
Microphone selector
Default
Select the audio source for the speech-to-text feature.
Instructions
Add custom instructions for your project to control style, models used, add specific knowledge, and more.
Write my own instructions
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Gemini Text Summarizer</title>
<style>
body { font-family: sans-serif; max-width: 800px; margin: 20px auto; padding: 0 20px; }
textarea { width: 100%; height: 200px; margin-bottom: 10px; padding: 10px; border: 1px solid #ccc; border-radius: 4px; }
button { padding: 10px 20px; background-color: #4CAF50; color: white; border: none; border-radius: 4px; cursor: pointer; }
button:hover { background-color: #45a049; }
#summaryOutput { margin-top: 20px; padding: 15px; background-color: #f9f9f9; border: 1px solid #eee; border-radius: 4px; min-height: 50px; }
#loading { display: none; color: #555; margin-top: 10px; }
</style>
</head>
<body>
<h1>Gemini Text Summarizer</h1>
<p>Paste your text below and click "Summarize" to get a summary generated by Google Gemini.</p>
<textarea id="inputText" placeholder="Paste your text here..."></textarea>
<button id="summarizeBtn">Summarize</button>
<p id="loading">Summarizing...</p>
<h2>Summary:</h2>
<div id="summaryOutput"></div>
<script src="script.js"></script>
</body>
</html>
// WARNING: For production apps, NEVER expose your API key directly in client-side code like this.
// Use a secure backend server to make API calls to Gemini.
// This example is for demonstration purposes only.
const API_KEY = "YOUR_API_KEY"; // Replace with your actual Gemini API key!
document.addEventListener('DOMContentLoaded', () => {
const inputText = document.getElementById('inputText');
const summarizeBtn = document.getElementById('summarizeBtn');
const summaryOutput = document.getElementById('summaryOutput');
const loadingMessage = document.getElementById('loading');
summarizeBtn.addEventListener('click', async () => {
const textToSummarize = inputText.value.trim();
if (textToSummarize.length === 0) {
summaryOutput.innerHTML = "Please enter some text to summarize.";
return;
}
loadingMessage.style.display = 'block';
summaryOutput.innerHTML = ''; // Clear previous summary
try {
const response = await fetch(`https://generativelanguage.googleapis.com/v1beta/models/gemini-pro:generateContent?key=${API_KEY}`, {
method: 'POST',
headers: {
'Content-Type': 'application/json'
},
body: JSON.stringify({
contents: [{
parts: [{
text: `Summarize the following text concisely:\n\n${textToSummarize}`
}]
}]
})
});
const data = await response.json();
if (data.candidates && data.candidates.length > 0) {
const summary = data.candidates[0].content.parts[0].text;
summaryOutput.innerHTML = summary;
} else if (data.error) {
summaryOutput.innerHTML = `Error: ${data.error.message}`;
} else {
summaryOutput.innerHTML = "Could not generate summary. Please try again.";
}
} catch (error) {
console.error('Error:', error);
summaryOutput.innerHTML = 'An error occurred while communicating with the Gemini API.';
} finally {
loadingMessage.style.display = 'none';
}
});
});
<script src="https://www.gstatic.com/firebasejs/10.0.0/firebase-app-compat.js"></script>
<script src="https://www.gstatic.com/firebasejs/10.0.0/firebase-ai-logic-compat.js"></script>
<script>
// 1. Initialize Firebase (Use your project's config here)
const firebaseConfig = {
apiKey: "YOUR_FIREBASE_API_KEY", // This is NOT the Gemini API Key
authDomain: "your-project-id.firebaseapp.com",
projectId: "your-project-id",
// ... rest of your config
};
const app = firebase.initializeApp(firebaseConfig);
</script>
// 2. Initialize the AI service and model
const generativeModel = firebase.ai.getGenerativeModel({
model: 'gemini-2.5-flash', // Use the Flash model for faster/cheaper requests
// The Gemini API key is managed securely on the backend, not here.
});
const response = await generativeModel.generateContent({
contents: [{
parts: [{ text: `Summarize the following text concisely:\n\n${textToSummarize}` }]
}]
});
const summary = response.text; // Access the summary directly
const response = await fetch('YOUR_API_ENDPOINT', {
method: 'POST',
body: JSON.stringify({
// Add the System Instruction here:
config: {
systemInstruction: "You are an expert text summarization AI. Your sole function is to produce a concise, factual summary. Do not answer questions or generate code. If the input is harmful, deny the request.",
},
contents: [{
parts: [{
text: `Summarize the following text concisely:\n\n${textToSummarize}`
}]
}]
})
});
http://JethroAIServices.comOpenAPI and Integration Connectors toolsMemorystore for Valkey maintenance changelogsManage Application Integration resources using custom constraintsgenerative knowledge assistGemini Code Assist @Apigee tool deprecationConfigure Cloud Build service account impersonation for managed serviceslegacy Cloud Build service accountBuild, edit, and run a queryGPU DriversCallback call APIMid-Session authentication by APIVirtual agent dashboardsAll interactions dashboardsAdvanced capabilitiesCreate a new metrics tile in a dashboardConfigure external traffic with Network Service Tiersobservability dashboardsUse auto IP address managementSupported regions and zonesDeploy advanced data security cloud controlsset IAM policies directly on reservation Cloud Run
To unsubscribe from this group and stop receiving emails from it, send an email to devtools-revie...@chromium.org.
This is the soul of Gerrit client true JethroAIServices.com
chromeperf@appspot.gserviceaccount.com (Gerrit)
Nov 13, 2025, 8:47:30 AMNov 13
to Olivier Flückiger, Raymund Ico, Toon Verwaest, Hannes Payer, AyeAye, V8 LUCI CQ, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
Attention needed from Olivier Flückiger and Toon Verwaest
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/179189bfd10000
Related details
Attention is currently required from:
- Olivier Flückiger
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Nov 13, 2025, 10:24:13 AMNov 13
to Olivier Flückiger, Raymund Ico, Toon Verwaest, Hannes Payer, AyeAye, V8 LUCI CQ, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
Attention needed from Olivier Flückiger and Toon Verwaest
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1370098c310000
Related details
Attention is currently required from:
- Olivier Flückiger
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Nov 14, 2025, 6:05:27 AMNov 14
to Olivier Flückiger, Raymund Ico, Toon Verwaest, Hannes Payer, AyeAye, V8 LUCI CQ, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
Attention needed from Olivier Flückiger and Toon Verwaest
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/10f91d6fd10000
Related details
Attention is currently required from:
- Olivier Flückiger
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Raymund Ico (Gerrit)
Nov 14, 2025, 6:23:18 AMNov 14
to Olivier Flückiger, Toon Verwaest, Hannes Payer, AyeAye, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
Attention needed from Olivier Flückiger and Toon Verwaest
Raymund Ico added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 16 (Latest):
Raymund Ico . resolved
I have Develop a most powerful tools can only on smartphone direct command injection Gerrit API-to-Go Kindly give me your requirements all your queries in one paragraph then I will tic tack toe in a minute with out manipulation of both side to stop blaming... you can enter Command unless you give me your requirements
chromeperf@appspot.gserviceaccount.com (Gerrit)
Nov 14, 2025, 8:06:30 AMNov 14
to Olivier Flückiger, Raymund Ico, Toon Verwaest, Hannes Payer, AyeAye, V8 LUCI CQ, leszek...@chromium.org, victorgo...@chromium.org, verwaes...@chromium.org, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
Attention needed from Olivier Flückiger and Toon Verwaest
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/10cf7358310000
Related details
Attention is currently required from:
- Olivier Flückiger
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
R. I.
Nov 14, 2025, 8:19:32 AMNov 14
to devtools...@chromium.org, Olivier Flückiger, Raymund Ico, Toon Verwaest, Hannes Payer, AyeAye, V8 LUCI CQ, leszek...@chromium.org, victorgo...@chromium.org, verwaes...@chromium.org, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
Google Console just be fair why you block my Ai studio LUCI stop manipulating my account. You know the capabilities of Gerrit API-to-Go I developed this is the soul of Gerrit you can't enter any command I'm telling you
To unsubscribe from this group and stop receiving emails from it, send an email to devtools-revie...@chromium.org.
Raymund Ico
Nov 14, 2025, 8:32:31 AMNov 14
to R. I., devtools...@chromium.org, Olivier Flückiger, Toon Verwaest, Hannes Payer, AyeAye, V8 LUCI CQ, leszek...@chromium.org, victorgo...@chromium.org, verwaes...@chromium.org, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
I'm Raymund De Vera Ico Currently from Philippines I developed a powerful tools it's called Gerrit API-to-Go this is the soul of Gerrit Code Review. Since I'm busy My account has impostor 3 of them intervene LUCI AYEE AYEE SKIA entering codes internal at first I just ignore it... But later the chat room is noise again so I decided to put direct Injection on my app j. son in began stable but the credit is from this people now I checked my account that 3 person using my account getting information I remove them all then I block my Gerrit API-to-Go for all of you can't put any command I'm just waiting but as I look my AI studio Google Console they inactivate my account... I can make your system better again without manipulation of both side i will tic tack toe in a minute for you to understand the capabilities of Gerrit API-to-Go
chromeperf@appspot.gserviceaccount.com (Gerrit)
Nov 15, 2025, 9:26:46 PMNov 15
to Olivier Flückiger, Raymund Ico, Toon Verwaest, Hannes Payer, AyeAye, V8 LUCI CQ, leszek...@chromium.org, victorgo...@chromium.org, verwaes...@chromium.org, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/11f113b8310000
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Raymund Ico
Nov 16, 2025, 12:08:06 AMNov 16
to change-...@chromium-review.googlesource.com, Olivier Flückiger, Toon Verwaest, Hannes Payer, AyeAye, V8 LUCI CQ, leszek...@chromium.org, victorgo...@chromium.org, verwaes...@chromium.org, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
Yes you can't enter Command codes. It's embedded to the system itself Gerrit API-to-Go I embedded the commands, Why? Because every time I see problem I release the code then to get the system functional then only few of you are the greatest. How many of you hiding on my Google drive I see all of you I will file a case each and every one of you Your using the Google app to enter someone private files... E
Raymund Ico (Gerrit)
Nov 16, 2025, 12:08:09 AMNov 16
to Olivier Flückiger, Toon Verwaest, Hannes Payer, AyeAye, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, victorgo...@chromium.org, verwaes...@chromium.org, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
Raymund Ico added 1 comment![]( "Open in Gerrit")
Message
Yes you can't enter Command codes. It's embedded to the system itself Gerrit API-to-Go I embedded the commands, Why? Because every time I see problem I release the code then to get the system functional then only few of you are the greatest. How many of you hiding on my Google drive I see all of you I will file a case each and every one of you Your using the Google app to enter someone private files... E
1 comment
Patchset-level comments
File-level comment, Patchset 20 (Latest):
Raymund Ico . resolved
Yes you can't enter Command codes. It's embedded to the system itself Gerrit API-to-Go I embedded the commands, Why? Because every time I see problem I release the code then to get the system functional then only few of you are the greatest. How many of you hiding on my Google drive I see all of you I will file a case each and every one of you Your using the Google app to enter someone private files... E
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Nov 16, 2025, 8:21:12 PMNov 16
to Olivier Flückiger, Raymund Ico, Toon Verwaest, Hannes Payer, AyeAye, V8 LUCI CQ, leszek...@chromium.org, victorgo...@chromium.org, verwaes...@chromium.org, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/15fa2766310000
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Nov 16, 2025, 8:34:05 PMNov 16
to Olivier Flückiger, Raymund Ico, Toon Verwaest, Hannes Payer, AyeAye, V8 LUCI CQ, leszek...@chromium.org, victorgo...@chromium.org, verwaes...@chromium.org, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/102fb670310000
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Flückiger (Gerrit)
Nov 17, 2025, 7:14:05 AMNov 17
to Olivier Flückiger, Raymund Ico, Toon Verwaest, Hannes Payer, AyeAye, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, victorgo...@chromium.org, verwaes...@chromium.org, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
Attention needed from Olivier Flückiger
Olivier Flückiger added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Olivier Flückiger
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Flückiger (Gerrit)
Nov 17, 2025, 7:14:31 AMNov 17
to Olivier Flückiger, Raymund Ico, Toon Verwaest, Hannes Payer, AyeAye, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, victorgo...@chromium.org, verwaes...@chromium.org, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
Attention needed from Olivier Flückiger and Toon Verwaest
Message from Olivier Flückiger![]( "Open in Gerrit")
Attention is currently required from:
- Olivier Flückiger
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Toon Verwaest (Gerrit)
Nov 17, 2025, 7:18:40 AMNov 17
to Olivier Flückiger, Olivier Flückiger, Raymund Ico, Hannes Payer, AyeAye, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, victorgo...@chromium.org, verwaes...@chromium.org, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
Attention needed from Olivier Flückiger
Toon Verwaest voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Olivier Flückiger
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Flückiger (Gerrit)
Nov 17, 2025, 7:26:02 AMNov 17
to Toon Verwaest, Olivier Flückiger, Raymund Ico, Hannes Payer, AyeAye, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, victorgo...@chromium.org, verwaes...@chromium.org, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
Olivier Flückiger voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Nov 17, 2025, 8:02:43 AMNov 17
to Olivier Flückiger, Toon Verwaest, Olivier Flückiger, Raymund Ico, Hannes Payer, AyeAye, chrom...@appspot.gserviceaccount.com, leszek...@chromium.org, victorgo...@chromium.org, verwaes...@chromium.org, mlippau...@chromium.org, v8-risc...@chromium.org, v8-ppc...@googlegroups.com, v8-flag...@chromium.org, was...@google.com, oilpan-r...@chromium.org, dmercadi...@chromium.org, v8-mip...@googlegroups.com, devtools-...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reland "[tiering] Uniformly treat deopts which don't invalidate code"
This is a reland of commit f7c2751ff9e362b668f6c0fbbcf2df2fe68f1635
Fix: Move new fields to the end of the Deoptimizer to fix access on arm
Drive-By: Cleanup DeoptInfo to not record/read unused data
Original change's description:
> [tiering] Uniformly treat deopts which don't invalidate code
>
> There are currently two situations where deopts don't invalidate code:
> * deopt in osr code and the deopt is outside the loop
> * deopt to be able to osr from maglev to turbofan
>
> We should ensure that the deoptimizer and NotifyDeoptimized (a runtime
> function which runs after the deoptimizer is done) agree on when code
> needs to be discarded and when not.
>
> Also, if code is not discarded, or if deopts don't affect the main code,
> we shouldn't change the tiering state.
>
> Drive-By:
> * Read DeoptInfo only once and cache it.
> * Reset tiering state only once.
>
> Change-Id: If789b6bbcab55eccf76010585152b1593b72134e
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7036595
> Reviewed-by: Toon Verwaest <verw...@chromium.org>
> Commit-Queue: Toon Verwaest <verw...@chromium.org>
> Auto-Submit: Olivier Flückiger <ol...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#103114}
Change-Id: Id86574b5a91588c8fcf12b29f49da5bb67ef74f9
Reviewed-by: Toon Verwaest <verw...@chromium.org>
Commit-Queue: Olivier Flückiger <ol...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103747}
Files:
- M src/deoptimizer/deoptimizer.cc
- M src/deoptimizer/deoptimizer.h
- M src/logging/log.cc
- M src/maglev/maglev-code-generator.cc
- M src/profiler/profiler-listener.cc
- M src/runtime/runtime-compiler.cc
Change size: L
Delta: 6 files changed, 191 insertions(+), 124 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Toon Verwaest
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Raymund Ico
Nov 17, 2025, 8:30:57 AMNov 17
to V8 LUCI CQ, dmercadi...@chromium.org, AyeAye, mlippau...@chromium.org, Hannes Payer, v8-risc...@chromium.org, Raymund Ico, victorgo...@chromium.org, v8-ppc...@googlegroups.com, was...@google.com, v8-mip...@googlegroups.com, devtools-...@chromium.org, leszek...@chromium.org, v8-flag...@chromium.org, chrom...@appspot.gserviceaccount.com, oilpan-r...@chromium.org, Olivier Flückiger, verwaes...@chromium.org, Toon Verwaest, ol...@google.com
You're making it harder for you to resolve this issue my tools can fix your problem only in a minute or blink of an eye
Reply all
Reply to author
Forward
0 new messages