[profiler, heap] Unify ephemeron edges across JS and cppgc [v8/v8 : main]
0 views
Skip to first unread message
Dominik Inführ (Gerrit)
May 13, 2026, 9:02:05 AMMay 13
to Michael Lippautz, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, cbruni...@chromium.org, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
May 18, 2026, 8:38:57 AM (13 days ago) May 18
to Code Review Nudger, Michael Lippautz, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, cbruni...@chromium.org, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Dominik Inführ added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Dominik Inführ . resolved
PTAL
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
May 19, 2026, 5:58:02 AM (12 days ago) May 19
to Dominik Inführ, Code Review Nudger, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, cbruni...@chromium.org, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Michael Lippautz voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
May 19, 2026, 6:34:33 AM (12 days ago) May 19
to Michael Lippautz, Code Review Nudger, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, cbruni...@chromium.org, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Dominik Inführ voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
May 19, 2026, 6:34:44 AM (12 days ago) May 19
to Michael Lippautz, Code Review Nudger, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, cbruni...@chromium.org, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Dominik Inführ added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
May 19, 2026, 6:36:07 AM (12 days ago) May 19
to Dominik Inführ, Michael Lippautz, Code Review Nudger, Hannes Payer, cbruni...@chromium.org, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[profiler, heap] Unify ephemeron edges across JS and cppgc
This CL unifies the emitted WeakMap ephemeron edges for both JS and
cppgc. DevTools already has special code for handling JS ephemeron
edges and with that CL cppgc will be automatically handled as well.
Bug: 497855658
Change-Id: I06e5b747d1bfb34da51d660f5a6c85b565e76a69
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#107413}
Files:
- M src/heap/cppgc-js/cpp-snapshot.cc
- M src/profiler/heap-snapshot-generator.cc
- M src/profiler/heap-snapshot-generator.h
- M test/unittests/heap/cppgc-js/unified-heap-snapshot-unittest.cc
Change size: M
Delta: 4 files changed, 72 insertions(+), 20 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages