Prepare CrossThreadSourceLocation for the removal of CrossThreadCopier [chromium/src : main]

0 views
Skip to first unread message

Daniel Cheng (Gerrit)

unread,
Nov 21, 2025, 3:17:58 PMNov 21
to Daniel Cheng, Andrey Kosyakov, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Kentaro Hara, Hirokazu Honda, Hongchan Choi, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, Stephen Chenney, srirama chandra sekhar, Xida Chen, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, devtools-re...@chromium.org, dom+...@chromium.org, drott+bl...@chromium.org, emircan+watch...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kouhei...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, oilpan-rev...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com
Attention needed from Andrey Kosyakov

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia690901ae221ee267465747342eb34ca1818926a
Gerrit-Change-Number: 7186410
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Hirokazu Honda <hi...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Xida Chen <xida...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Comment-Date: Fri, 21 Nov 2025 20:17:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrey Kosyakov (Gerrit)

unread,
Nov 24, 2025, 12:48:41 PMNov 24
to Daniel Cheng, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Kentaro Hara, Hirokazu Honda, Hongchan Choi, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, Stephen Chenney, srirama chandra sekhar, Xida Chen, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, devtools-re...@chromium.org, dom+...@chromium.org, drott+bl...@chromium.org, emircan+watch...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kouhei...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, oilpan-rev...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com
Attention needed from Daniel Cheng

Andrey Kosyakov voted and added 1 comment

Votes added by Andrey Kosyakov

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Andrey Kosyakov . resolved

Thanks, lgtm!

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia690901ae221ee267465747342eb34ca1818926a
    Gerrit-Change-Number: 7186410
    Gerrit-PatchSet: 4
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Hirokazu Honda <hi...@chromium.org>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Hongchan Choi <hong...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: Xida Chen <xida...@chromium.org>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Mon, 24 Nov 2025 17:48:28 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Nov 24, 2025, 12:50:39 PMNov 24
    to Daniel Cheng, Andrey Kosyakov, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Kentaro Hara, Hirokazu Honda, Hongchan Choi, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, Stephen Chenney, srirama chandra sekhar, Xida Chen, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, devtools-re...@chromium.org, dom+...@chromium.org, drott+bl...@chromium.org, emircan+watch...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kouhei...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, oilpan-rev...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com

    Daniel Cheng voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Gerrit-Comment-Date: Mon, 24 Nov 2025 17:50:27 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Nov 24, 2025, 1:49:00 PM (14 days ago) Nov 24
    to Daniel Cheng, Andrey Kosyakov, Menard, Alexis, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Kentaro Hara, Hirokazu Honda, Hongchan Choi, Nate Chapin, Raphael Kubo da Costa, Hiroki Nakagawa, Stephen Chenney, srirama chandra sekhar, Xida Chen, apavlo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, devtools-re...@chromium.org, dom+...@chromium.org, drott+bl...@chromium.org, emircan+watch...@chromium.org, eric.c...@apple.com, erickun...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jophba...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kouhei...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, oilpan-rev...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shimazu...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Prepare CrossThreadSourceLocation for the removal of CrossThreadCopier

    CrossThreadSourceLocation is now guaranteed to be safe to move across
    threads: it no longer exposes a constructor that relies on the caller to
    pass a thread-safe clone of `v8_inspector::V8StackTrace`. This also
    deletes the now-unused constructor, as well as the unused `Clone()`
    method, and adds some comments documenting thread-safety.

    Change CrossThreadCopier to pass by move and use std::move() to bind
    CrossThreadSourceLocation objects; this is slightly more efficient than
    before, since it drops one call to clone the V8 stack trace.

    Finally, add an idealistic CHECK-but-not-fatal-until-M150 "source
    location should never be null" check; from casual inspection, this
    invariant should always hold, but there might be weird edge cases...
    Bug: 462588571
    Bug: 460743390
    Change-Id: Ia690901ae221ee267465747342eb34ca1818926a
    Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
    Commit-Queue: Daniel Cheng <dch...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1549307}
    Files:
    • M third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.cc
    • M third_party/blink/renderer/core/workers/dedicated_worker_object_proxy.cc
    • M third_party/blink/renderer/core/workers/dedicated_worker_object_proxy.h
    • M third_party/blink/renderer/core/workers/shared_worker_reporting_proxy.cc
    • M third_party/blink/renderer/core/workers/shared_worker_reporting_proxy.h
    • M third_party/blink/renderer/core/workers/threaded_messaging_proxy_base.cc
    • M third_party/blink/renderer/core/workers/threaded_object_proxy_base.cc
    • M third_party/blink/renderer/core/workers/threaded_object_proxy_base.h
    • M third_party/blink/renderer/core/workers/worker_reporting_proxy.h
    • M third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc
    • M third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.h
    • M third_party/blink/renderer/platform/BUILD.gn
    • A third_party/blink/renderer/platform/bindings/cross_thread_source_location.cc
    • M third_party/blink/renderer/platform/bindings/cross_thread_source_location.h
    • M third_party/blink/renderer/platform/bindings/source_location_copier.h
    Change size: M
    Delta: 15 files changed, 78 insertions(+), 69 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Andrey Kosyakov
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia690901ae221ee267465747342eb34ca1818926a
    Gerrit-Change-Number: 7186410
    Gerrit-PatchSet: 5
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages