[wtf] Enable active iterator checks for HeapVector by default [chromium/src : main]

2 views

Skip to first unread message

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,

Jun 19, 2026, 5:13:36 AM (13 days ago) Jun 19

to Keishi Hattori, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org

Attention needed from Keishi Hattori

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m4-mini-perf/speedometer3 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1105c96ac90000

Open in Gerrit

Related details

Attention is currently required from:

Keishi Hattori

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Stephen Nusko (Gerrit)

unread,

Jun 29, 2026, 9:50:34 PM (2 days ago) Jun 29

to Keishi Hattori, chrom...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org

Attention needed from Keishi Hattori

Stephen Nusko added 1 comment

File third_party/blink/renderer/platform/wtf/vector.cc

Line 19, Patchset 2 (Latest):

  static std::atomic<bool> has_dumped{false};
  if (has_dumped.load(std::memory_order_relaxed)) {
    return;
  }
  if (!has_dumped.exchange(true, std::memory_order_relaxed)) {
    base::debug::DumpWithoutCrashing();
  }

Stephen Nusko . unresolved

2 questions

1) Do we need this to be atomic? can blink vectors be used on multiple threads?

2) If we do could we just make this a single exchange?

```
if (!has_dumped.exchange(true, std::memory_order_relaxed)) {
  base::debug::DumpWithoutCrashing();
}
```

This is because exchange returns the old value before the call, thus is the same as has_dumped.load when it will eventually just become true. Worst case a couple threads see the old value while setting it to true, but that could still occur here with certain threading sequences