[api] Refactor v8::SourceLocation to wrap std::source_location [v8/v8 : main]
0 views
Skip to first unread message
Leszek Swirski (Gerrit)
Aug 26, 2025, 8:26:26 AMAug 26
to Michael Lippautz, AyeAye, V8 LUCI CQ, oilpan-r...@chromium.org, cbruni...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Leszek Swirski added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Leszek Swirski . resolved
WDYT? It slightly changes the printed function name (it adds the full signature and not just the function name) but it's aligning more with the standard
No reason to do this other than code health
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Aug 26, 2025, 8:37:09 AMAug 26
to Leszek Swirski, AyeAye, V8 LUCI CQ, oilpan-r...@chromium.org, cbruni...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Michael Lippautz voted and added 2 comments![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
2 comments
Patchset-level comments
Leszek Swirski . resolved
WDYT? It slightly changes the printed function name (it adds the full signature and not just the function name) but it's aligning more with the standard
No reason to do this other than code health
Michael Lippautz
sg
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Aug 26, 2025, 8:38:45 AMAug 26
to Michael Lippautz, AyeAye, V8 LUCI CQ, oilpan-r...@chromium.org, cbruni...@chromium.org, v8-re...@googlegroups.com
Leszek Swirski voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Aug 26, 2025, 9:04:14 AMAug 26
to Leszek Swirski, Michael Lippautz, AyeAye, oilpan-r...@chromium.org, cbruni...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[api] Refactor v8::SourceLocation to wrap std::source_location
This patch updates `v8::SourceLocation` to wrap `std::source_location`
from C++20. This replaces the previous implementation that relied on
compiler-specific built-ins to do the same job.
Change-Id: Ia9afac7ab89f7cc67b2e2f2b782a6afd98fbeb22
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Leszek Swirski <les...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102043}
Files:
- M include/v8-source-location.h
- M src/codegen/assembler.h
- M test/unittests/heap/cppgc/logging-unittest.cc
- M test/unittests/heap/cppgc/persistent-family-unittest.cc
- M test/unittests/heap/cppgc/source-location-unittest.cc
Change size: M
Delta: 5 files changed, 23 insertions(+), 62 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages