Added `GenerateStandardShadesFromHue` function [chromium/src : main]

0 views
Skip to first unread message

Jay Kapadia (Gerrit)

unread,
Jul 24, 2025, 1:32:51 PMJul 24
to Mathias Bynens, Peter Collingbourne, Yoav Weiss (@Shopify), ningxin hu, Hans Wennborg, Mirko Bonadei, Raphael Kubo da Costa, Arnaud Mandy, Robert Kroeger, Rijubrata Bhaumik, Kevin Babbitt, Ilya Biryukov, Nate Chapin, Fredrik Söderquist, Andrew Williams, Wanming Lin, Thiabaud Engelbrecht, Alex Keng, Christian Biesinger, Kaan Icer, Alexis Menard, Peter Williamson, Kentaro Hara, Andrew Rayskiy, Kenneth Rohde Christiansen, Kevin McNee, Jiewei Qian, Nikhil Nayunigari, Mike Taylor, Sam Zackrisson, Peter Beverloo, Reid Kleckner, Ale Bzk, Hiroki Nakagawa, Luna Lu, Ryan Sultanem, Sadrul Chowdhury, Xida Chen, Zijie He, Ian Vollick, Jerome Jiang, Lei Zhang, (Julie)Jeongeun Kim, Dustin Mitchell, srirama chandra sekhar, Simon Hangl, David Bokan, Kenneth R Christiansen, Hongchan Choi, Enterprise Policy Reviews, Urvang Joshi, Daniel Andersson, Tommy Li, Olga Gerchikov, Nico Weber, Sarah Krakowiak, James Maclean, Chromium Metrics Reviews, Per Åhgren, Javier Fernandez, Daniel Cheng, Victor Tan, Hirokazu Honda, Stephen Chenney, Dirk Schulze, James Su, Wei4 Wang, David Worsham, AyeAye, AyeAye Python Dispatcher, Tom Lukaszewicz, Alison Gale, David Pennington, Daniel Soromou, Chromium LUCI CQ, chromium...@chromium.org, knollr+wat...@chromium.org, cros-setti...@google.com, lucasrada...@google.com, cambickel+watch-shor...@google.com, mfoltz...@chromium.org, network-ser...@chromium.org, shend...@chromium.org, sp...@chromium.org, yyhyyh+fee...@google.com, dibyapal+wa...@chromium.org, kenjibah...@chromium.org, thegreenf...@chromium.org, crmulli...@chromium.org, hansberry+w...@chromium.org, wangdanny+watch-in...@google.com, wychen...@chromium.org, asvitkine...@chromium.org, zol...@webkit.org, spang...@chromium.org, mdjone...@chromium.org, aleventhal...@chromium.org, dimich...@chromium.org, rsesek...@chromium.org, shuche...@chromium.org, cros-report...@google.com, ortuno+w...@chromium.org, kinuko+...@chromium.org, chromium-a...@chromium.org, kouhe...@chromium.org, siyua+aut...@chromium.org, steimel+watch...@chromium.org, lcwu+...@chromium.org, gavin...@chromium.org, web-schedulin...@chromium.org, pdf-r...@chromium.org, nwoked...@chromium.org, katie...@chromium.org, roblia...@chromium.org, mbarowsky+watc...@chromium.org, jackshira+wa...@google.com, fenced-fra...@chromium.org, mickeybu...@chromium.org, dmurph+wat...@chromium.org, crisrael+w...@google.com, hansberry+wa...@chromium.org, khorimoto+w...@chromium.org, yfriedm...@chromium.org, chikamu...@chromium.org, blink-revie...@chromium.org, gavindodd+watch-...@google.com, servicewor...@chromium.org, gavinwill+watch-...@chromium.org, gavinwill+dia...@chromium.org, crost...@chromium.org, dmurph+watch...@chromium.org, longbowei+fe...@google.com, creis...@chromium.org, browser-comp...@chromium.org, gavinp+p...@chromium.org, jinsukk...@chromium.org, headless...@chromium.org, rkgibso...@chromium.org, scheduler-...@chromium.org, kouhei...@chromium.org, chromeos-gfx-...@google.com, hansberry+wa...@chromium.org, horo+...@chromium.org, svend+w...@chromium.org, blink-revi...@chromium.org, tbarzi...@chromium.org, wangdanny+fe...@google.com, tommyw+w...@chromium.org, gangwu...@chromium.org, aakalla...@chromium.org, feature-me...@chromium.org, jbrom...@chromium.org, gavin...@chromium.org, chasej...@chromium.org, ashleydp+fe...@google.com, ejcaruso+wa...@chromium.org, kinuko...@chromium.org, bcb+watch-pl...@chromium.org, ajayramamurthy...@google.com, oilpan-rev...@chromium.org, jophba...@chromium.org, armalhotra+a...@google.com, toyosh...@chromium.org, andreaor...@chromium.org, ntp-dev...@chromium.org, zhangwenyu+f...@google.com, njeunje+...@chromium.org, moqati-team+chr...@google.com, dtapuska+ch...@chromium.org, enne...@chromium.org, kainin...@chromium.org, druber...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, max+watc...@igalia.com, halliwe...@chromium.org, joeantonetti+wa...@google.com, sky+...@chromium.org, ashleydp+diag...@google.com, yuezhang...@chromium.org, chili...@chromium.org, chfreme...@chromium.org, jmedle...@chromium.org, rsleev...@chromium.org, eric.c...@apple.com, vasilii+watchlis...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, rlp+...@chromium.org, cbe-cep-eng...@google.com, stevenjb+wa...@chromium.org, jackshira+w...@google.com, nikhilcn+wat...@google.com, rginda...@chromium.org, loading-rev...@chromium.org, crostin...@chromium.org, yhiran...@chromium.org, vsavu...@google.com, iclella...@chromium.org, loading...@chromium.org, yhanad...@chromium.org, chrome-intelligence-te...@google.com, bfcach...@chromium.org, performance-m...@chromium.org, hiroshig...@chromium.org, yigu+...@chromium.org, nona+...@chromium.org, pushi+wat...@google.com, shimazu+se...@chromium.org, npm+...@chromium.org, antoniosarto...@chromium.org, hsuregan+wa...@chromium.org, blink-re...@chromium.org, peter+watch...@chromium.org, lizeb...@chromium.org, dominicc+...@chromium.org, fmalit...@chromium.org, cambickel...@google.com, niharm...@google.com, chrome-waff...@google.com, tluk+...@chromium.org, blink-rev...@chromium.org, xlythe+wa...@google.com, rmcelra...@chromium.org, drott...@chromium.org, shgar+aut...@google.com, dom+...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, ananyasee...@google.com, devtools...@chromium.org, michaelcheco+...@google.com, keithle...@chromium.org, crisrael+...@google.com, silv...@chromium.org, yhanada...@chromium.org, estali...@chromium.org, kuragin+web-ap...@chromium.org, phoglun...@chromium.org, rrsilva+wat...@google.com, bmcquad...@chromium.org, cambickel+watc...@google.com, cros-essential...@chromium.org, devtools-re...@chromium.org, jkeitel+watch-...@google.com, longbowei+watc...@google.com, mreichhoff+watc...@chromium.org, speed-metr...@chromium.org, chadduffin+w...@chromium.org, jonmann+wat...@chromium.org, chromeos-kio...@google.com, blink-rev...@chromium.org, kinuko+ser...@chromium.org, fgorsk...@chromium.org, toshikikikuch...@chromium.org, jimmyxgong+w...@chromium.org, dmurph+watch...@chromium.org, fuchsia...@chromium.org, gavinp...@chromium.org, dtraino...@chromium.org, dkrahn...@chromium.org, cfredri...@chromium.org, webap...@microsoft.com, zackha...@chromium.org, blink-isola...@chromium.org, ffred...@chromium.org, gl...@chromium.org, language...@chromium.org, iwells...@chromium.org, rouslan+au...@chromium.org, bici...@google.com, subresource-f...@chromium.org, jonmann+w...@chromium.org, hsuregan+wat...@chromium.org, mschillaci...@google.com, dclasson+w...@google.com, edgesto...@microsoft.com, chromotin...@chromium.org, dmurph+watching...@chromium.org, cros-print...@google.com, dfried...@chromium.org, sloboda...@chromium.org, ydago...@chromium.org, blink-reviews-p...@chromium.org, jimmyxgong+watch-shor...@chromium.org, longbowei+watch-shor...@google.com, mattreyno...@chromium.org, lize...@chromium.org, blink-revie...@chromium.org, jdonnel...@chromium.org, davidj...@chromium.org, siashah+au...@chromium.org, hidehik...@chromium.org, cblume...@chromium.org, omnibox-...@chromium.org, ayman...@chromium.org, dtseng...@chromium.org, jdh+wa...@chromium.org, yyhyyh+watch-inpu...@google.com, asumane...@google.com, nyquis...@chromium.org, media-wi...@chromium.org, ricea...@chromium.org, video-networking...@google.com, hirokisa...@chromium.org, harringt...@chromium.org, nator...@chromium.org, stanfie...@google.com, msrame...@chromium.org, lens-chrome...@google.com, blink-revi...@chromium.org, hashimo...@chromium.org, jbauma...@chromium.org, vscode...@chromium.org, martijn...@martijnc.be, michaelchec...@google.com, dmurph+watchi...@chromium.org, dullweb...@chromium.org, tgupta...@chromium.org, gavindodd+dia...@google.com, filesapp...@chromium.org, nektar...@chromium.org, erickun...@chromium.org, jiajunz+wat...@google.com, danakj...@chromium.org, jorgel...@chromium.org, ddrone...@google.com, core-timi...@chromium.org, kouhe...@chromium.org, chrome-gr...@chromium.org, meilian...@chromium.org, tmartino+tran...@chromium.org, tbansal+...@chromium.org, ajwong...@chromium.org, extension...@chromium.org, scheduler-b...@chromium.org, rayanka...@chromium.org, dfalcant...@chromium.org, cambickel+fe...@google.com, hais+wat...@google.com, kinuko...@chromium.org, rainhar...@chromium.org, marimatthew+watc...@google.com, crisrael+wa...@google.com, pdr+svgw...@chromium.org, zhangwenyu+wat...@google.com, khmel...@chromium.org, ios-rev...@chromium.org, mtomas...@chromium.org, roagarw...@chromium.org, pushi+wa...@google.com, tburkar...@chromium.org, pkotwic...@chromium.org, abigailbk...@google.com, amaliev+...@chromium.org, lingqi...@chromium.org, mpdento...@chromium.org, gavinwill+sc...@chromium.org, minap+watch-p...@google.com, permissio...@chromium.org, chromeos-ca...@google.com, loading-rev...@chromium.org, tedcho...@chromium.org, jackshira+...@google.com, vakh+safe_br...@chromium.org, geoffla...@chromium.org, cwp-review...@google.com, andysjl...@chromium.org, peilinwa...@google.com, chrome-b...@google.com, ajayramamurthy...@google.com, chrome-intell...@chromium.org, lwinston+watc...@google.com, cblum...@chromium.org, jackshira+wat...@google.com, security-...@chromium.org, chlily...@chromium.org, penghuan...@chromium.org, mattsimm...@chromium.org, core-web-vita...@chromium.org, zhangwenyu+watch...@google.com, feature-v...@chromium.org, mercer...@google.com, oshima...@chromium.org, tote-eng...@google.com, philli...@chromium.org, tracing...@chromium.org, liu+wa...@chromium.org, cc-...@chromium.org, trewin...@google.com, aleventh...@chromium.org, marinacio...@chromium.org, jimmyxgong+wat...@chromium.org, webauthn...@chromium.org, dcheng+c...@chromium.org, chadduffin+wa...@chromium.org, hansberry+wat...@chromium.org, jackshira+wa...@google.com, jackshira+w...@google.com, hansberry+wa...@chromium.org, michaelcheco+watch-i...@google.com, mkwst+w...@chromium.org, translat...@chromium.org, emi...@google.com, grt+...@chromium.org, eugeni...@chromium.org, jonmann+watc...@chromium.org, rousla...@chromium.org, xinghui...@chromium.org, srahim...@chromium.org, yhanada+...@chromium.org, agriev...@chromium.org, joeantonetti+...@google.com, jz...@chromium.org, asvitki...@chromium.org, olka+...@chromium.org, jeffreycohen+watc...@chromium.org, yusufo...@chromium.org, dougste...@chromium.org, android-web...@chromium.org, arc-review...@google.com, gogerald+pa...@chromium.org, nickdiego+wa...@igalia.com, twelling...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, arthursonzog...@chromium.org, ryanchu...@chromium.org, akingsb+wat...@google.com, loading-re...@chromium.org, gogeral...@chromium.org, petewi...@chromium.org, vinnypersky+...@google.com, giovax...@chromium.org, glider...@chromium.org, christia...@chromium.org, telemetr...@chromium.org, gavinp...@chromium.org, odejesu...@chromium.org, vaapi-...@chromium.org, dewitt...@chromium.org, marq+...@chromium.org, blink-re...@chromium.org, ajayramamurth...@google.com, lighthouse-eng-extern...@google.com, mcasas+med...@chromium.org, tranbaod...@chromium.org, jasonrobe...@google.com, dmurph+watchin...@chromium.org, ajayramamurthy+w...@google.com, wnwen...@chromium.org, caitkp...@chromium.org, dmurph+watc...@chromium.org, shannc...@chromium.org, apaselti...@chromium.org, ios-revie...@chromium.org, alandin...@chromium.org, jessemcke...@google.com, ender...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, mbarowsky+watc...@chromium.org, osaul+aut...@google.com, josiah...@chromium.org, dtapuska+...@chromium.org, gayane...@chromium.org, blink-rev...@chromium.org, jhawkins+...@google.com, yongshun+...@google.com, antoniosartori+wa...@chromium.org, scheduler...@chromium.org, speed-metrics...@chromium.org, michaelcheco+...@google.com, webapks-...@chromium.org, zhangwen...@google.com, cros-enterpris...@chromium.org, djacob...@chromium.org, eme-r...@chromium.org, xiangdongkong+...@google.com, ashleynewson+w...@chromium.org, pushi+watc...@google.com, chrome-tab-group-en...@google.com, hansenmichael...@google.com, fgal...@chromium.org, zhangwenyu+dia...@google.com, torne...@chromium.org, yhanada+...@chromium.org, zelin+watch-we...@chromium.org, glazuno...@chromium.org, wfh+...@chromium.org, mac-r...@chromium.org, cwalle...@chromium.org, dmurph+wa...@chromium.org, ukai+...@chromium.org, rhalava...@chromium.org, navigation...@chromium.org, pasko...@chromium.org, milicau+watchlis...@google.com, michaelcheco+watc...@google.com, droger+w...@chromium.org, rouslan+...@chromium.org, chromium-...@engflow.com, ozone-...@chromium.org, media-cro...@chromium.org, ios-web-view...@google.com, net-r...@chromium.org, shimazu...@chromium.org, blink-work...@chromium.org, ramyagopa...@google.com, fuzzin...@chromium.org, ios-r...@chromium.org, jiajunz+wa...@google.com, npnavarro+p...@chromium.org, michaelcheco+di...@google.com, jbroma...@chromium.org, jimmyxgong+watch...@chromium.org, csharris...@chromium.org, mgiuca...@chromium.org, prerenderi...@chromium.org, loyso...@chromium.org, cros-ed...@google.com, blink-revie...@chromium.org, mar...@chromium.org, julietlevesque...@google.com, jonmann+wa...@chromium.org, gab+...@chromium.org, kaklilu+watch-...@chromium.org, jackshira+wa...@google.com, michaelcheco+wa...@google.com, penghu...@chromium.org, khorimoto+wa...@chromium.org, francisjp...@google.com, drott+bl...@chromium.org, dtseng+c...@chromium.org, pmonett...@chromium.org, croissant-...@chromium.org, gcasto+w...@chromium.org, jshin...@chromium.org, lizeb+watch...@chromium.org, yuzo+...@chromium.org, fserb...@chromium.org, donnd...@chromium.org, emircan+watch...@chromium.org, nicolas...@chromium.org, kyungjunle...@google.com, hayato...@chromium.org, jimmyxgong+f...@chromium.org, crisrael+wa...@google.com, suetfei+wa...@google.com, twifka...@chromium.org, jdeblas...@chromium.org, bartek...@chromium.org, apavlo...@chromium.org, anastas...@google.com, ashleydp+watch-...@google.com, hanxi...@chromium.org, print-rev...@chromium.org, ajayramamurt...@google.com
Attention needed from Tom Lukaszewicz

Jay Kapadia added 1 comment

File ui/color/dynamic_color/palette_factory.h
Line 32, Patchset 24:void GenerateStandardShadesFromHue(
Tom Lukaszewicz . unresolved

Could we add a little more detail to this comment?

It would be helpful to comment on the intended use of this function (generically), on what basis are chroma and tone values predefined, what a standard shade is (perhaps there is a link to docs that cover standard shades as a concept).

Jay Kapadia

I hope the comment is more clear now. I just call them standard shades because each shade has a standard property, specifically a fixed Chroma and Tone value.

The logic used in the function can be used to make a generic function to generate individual shades instead of an array of shades. However, this function has a specific use case to populate the shades array.

Also, this is the issue tracking this project which will provide you a lot of context - https://issues.chromium.org/issues/427908562. This also has the document that explains the pre-defined Chroma and Tone values.

Tom Lukaszewicz

The comment helps alot - thanks for adding.

Do you know if it's possible to shift the hue range to be [0, 360], with 0 indicating the absence of a hue or shades of grey? This would align with the expected range of hues elsewhere in ui/color/dynamic_color (such as `palette_factor.cc:53-54`)

Jay Kapadia

Actually HCT is a well established color space with the hue = 0 representing a pink-ish color. And this is what the user expects too when making the theme. So, we cannot use 0 for shades of grey.

For context, hue is circular(https://miro.medium.com/v2/resize:fit:1100/format:webp/1*XMBMM57oM5IaSQ2wUv95VA.png) - meaning it starts at 0 and returns to the same color at 360 (So, it's actual range is [0,360]). So, that is why I have used -1 to indicate absence of hue.

Tom Lukaszewicz

I see, could we use a `std::optional<int> hue` and use `std::nullopt` to indicate we want shades of grey / an absence of hue?

I still think we should keep the range to [0, 360] for consistency above (material_color_utilities uses this range also).

Jay Kapadia

I think it is possible. Also, I am thinking to allow 360 as an input hue from the user as it is valid. So, for the user the range is [-1,360], and internally we interpret -1 as std::nullopt. So, yes it will work.

I will have to make changes to multiple Cls including the one which is merged. How, will I change the merged CL?

Tom Lukaszewicz

We can do this as a follow-up once the chain lands - could we however add a TODO tagging the issue and summarizing the planned changes?

I would suggest using [0,360] as valid hue ranges, with `std::optional<int> hue` + `std::nullopt` indicating grey (optional is better than -1 as a sentinel value per [abseil.io/tips/171](abseil.io/tips/171)).

Jay Kapadia

Ok, I agree on using `std::optional<int> hue` + `std::nullopt`. But how would the user define grey in the manifest.json? Is it fine if we take -1 there as we already do?

Open in Gerrit

Related details

Attention is currently required from:
  • Tom Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If8405c7213cdea536779a2ba64a46016d466c96a
Gerrit-Change-Number: 6669514
Gerrit-PatchSet: 29
Gerrit-Owner: Jay Kapadia <jaykap...@gmail.com>
Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
Gerrit-Reviewer: Daniel Soromou <koreta...@chromium.org>
Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
Gerrit-Reviewer: Jay Kapadia <jaykap...@gmail.com>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Ale Bzk <ales...@chromium.org>
Gerrit-CC: Alex Keng <shi...@microsoft.com>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Andrew Williams <awi...@chromium.org>
Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Daniel Andersson <dande...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Dustin Mitchell <djmi...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Hirokazu Honda <hi...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: Ilya Biryukov <ibir...@google.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-CC: Jerome Jiang <ji...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>
Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Mike Taylor <mike...@chromium.org>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Nico Weber <tha...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Per Åhgren <pe...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Peter Collingbourne <p...@chromium.org>
Gerrit-CC: Peter Williamson <pet...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Reid Kleckner <r...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Ryan Sultanem <rs...@google.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Sam Zackrisson <sa...@chromium.org>
Gerrit-CC: Sarah Krakowiak <skra...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-CC: Tommy Li <tomm...@chromium.org>
Gerrit-CC: Urvang Joshi <urv...@chromium.org>
Gerrit-CC: Victor Tan <vict...@chromium.org>
Gerrit-CC: Wanming Lin <wanmi...@intel.com>
Gerrit-CC: Wei4 Wang <wei4...@intel.com>
Gerrit-CC: Xida Chen <xida...@chromium.org>
Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: ningxin hu <ningx...@intel.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Thu, 24 Jul 2025 17:32:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tom Lukaszewicz <tl...@chromium.org>
Comment-In-Reply-To: Jay Kapadia <jaykap...@gmail.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Tom Lukaszewicz (Gerrit)

unread,
Jul 24, 2025, 2:57:16 PMJul 24
to Jay Kapadia, Mathias Bynens, Peter Collingbourne, Yoav Weiss (@Shopify), ningxin hu, Hans Wennborg, Mirko Bonadei, Raphael Kubo da Costa, Arnaud Mandy, Robert Kroeger, Rijubrata Bhaumik, Kevin Babbitt, Ilya Biryukov, Nate Chapin, Fredrik Söderquist, Andrew Williams, Wanming Lin, Thiabaud Engelbrecht, Alex Keng, Christian Biesinger, Kaan Icer, Alexis Menard, Peter Williamson, Kentaro Hara, Andrew Rayskiy, Kenneth Rohde Christiansen, Kevin McNee, Jiewei Qian, Nikhil Nayunigari, Mike Taylor, Sam Zackrisson, Peter Beverloo, Reid Kleckner, Ale Bzk, Hiroki Nakagawa, Luna Lu, Ryan Sultanem, Sadrul Chowdhury, Xida Chen, Zijie He, Ian Vollick, Jerome Jiang, Lei Zhang, (Julie)Jeongeun Kim, Dustin Mitchell, srirama chandra sekhar, Simon Hangl, David Bokan, Kenneth R Christiansen, Hongchan Choi, Enterprise Policy Reviews, Urvang Joshi, Daniel Andersson, Tommy Li, Olga Gerchikov, Nico Weber, Sarah Krakowiak, James Maclean, Chromium Metrics Reviews, Per Åhgren, Javier Fernandez, Daniel Cheng, Victor Tan, Hirokazu Honda, Stephen Chenney, Dirk Schulze, James Su, Wei4 Wang, David Worsham, AyeAye, AyeAye Python Dispatcher, Alison Gale, David Pennington, Daniel Soromou, Chromium LUCI CQ, chromium...@chromium.org, knollr+wat...@chromium.org, cros-setti...@google.com, lucasrada...@google.com, cambickel+watch-shor...@google.com, mfoltz...@chromium.org, network-ser...@chromium.org, shend...@chromium.org, sp...@chromium.org, yyhyyh+fee...@google.com, dibyapal+wa...@chromium.org, kenjibah...@chromium.org, thegreenf...@chromium.org, crmulli...@chromium.org, hansberry+w...@chromium.org, wangdanny+watch-in...@google.com, wychen...@chromium.org, asvitkine...@chromium.org, zol...@webkit.org, spang...@chromium.org, mdjone...@chromium.org, aleventhal...@chromium.org, dimich...@chromium.org, rsesek...@chromium.org, shuche...@chromium.org, cros-report...@google.com, ortuno+w...@chromium.org, kinuko+...@chromium.org, chromium-a...@chromium.org, kouhe...@chromium.org, siyua+aut...@chromium.org, steimel+watch...@chromium.org, lcwu+...@chromium.org, gavin...@chromium.org, web-schedulin...@chromium.org, pdf-r...@chromium.org, nwoked...@chromium.org, katie...@chromium.org, roblia...@chromium.org, mbarowsky+watc...@chromium.org, jackshira+wa...@google.com, fenced-fra...@chromium.org, mickeybu...@chromium.org, dmurph+wat...@chromium.org, crisrael+w...@google.com, hansberry+wa...@chromium.org, khorimoto+w...@chromium.org, yfriedm...@chromium.org, chikamu...@chromium.org, blink-revie...@chromium.org, gavindodd+watch-...@google.com, servicewor...@chromium.org, gavinwill+watch-...@chromium.org, gavinwill+dia...@chromium.org, crost...@chromium.org, dmurph+watch...@chromium.org, longbowei+fe...@google.com, creis...@chromium.org, browser-comp...@chromium.org, gavinp+p...@chromium.org, jinsukk...@chromium.org, headless...@chromium.org, rkgibso...@chromium.org, scheduler-...@chromium.org, kouhei...@chromium.org, chromeos-gfx-...@google.com, hansberry+wa...@chromium.org, horo+...@chromium.org, svend+w...@chromium.org, blink-revi...@chromium.org, tbarzi...@chromium.org, wangdanny+fe...@google.com, tommyw+w...@chromium.org, gangwu...@chromium.org, aakalla...@chromium.org, feature-me...@chromium.org, jbrom...@chromium.org, gavin...@chromium.org, chasej...@chromium.org, ashleydp+fe...@google.com, ejcaruso+wa...@chromium.org, kinuko...@chromium.org, bcb+watch-pl...@chromium.org, ajayramamurthy...@google.com, oilpan-rev...@chromium.org, jophba...@chromium.org, armalhotra+a...@google.com, toyosh...@chromium.org, andreaor...@chromium.org, ntp-dev...@chromium.org, zhangwenyu+f...@google.com, njeunje+...@chromium.org, moqati-team+chr...@google.com, dtapuska+ch...@chromium.org, enne...@chromium.org, kainin...@chromium.org, druber...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, max+watc...@igalia.com, halliwe...@chromium.org, joeantonetti+wa...@google.com, sky+...@chromium.org, ashleydp+diag...@google.com, yuezhang...@chromium.org, chili...@chromium.org, chfreme...@chromium.org, jmedle...@chromium.org, rsleev...@chromium.org, eric.c...@apple.com, vasilii+watchlis...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, rlp+...@chromium.org, cbe-cep-eng...@google.com, stevenjb+wa...@chromium.org, jackshira+w...@google.com, nikhilcn+wat...@google.com, rginda...@chromium.org, loading-rev...@chromium.org, crostin...@chromium.org, yhiran...@chromium.org, vsavu...@google.com, iclella...@chromium.org, loading...@chromium.org, yhanad...@chromium.org, chrome-intelligence-te...@google.com, bfcach...@chromium.org, performance-m...@chromium.org, hiroshig...@chromium.org, yigu+...@chromium.org, nona+...@chromium.org, pushi+wat...@google.com, shimazu+se...@chromium.org, npm+...@chromium.org, antoniosarto...@chromium.org, hsuregan+wa...@chromium.org, blink-re...@chromium.org, peter+watch...@chromium.org, lizeb...@chromium.org, dominicc+...@chromium.org, fmalit...@chromium.org, cambickel...@google.com, niharm...@google.com, chrome-waff...@google.com, tluk+...@chromium.org, blink-rev...@chromium.org, xlythe+wa...@google.com, rmcelra...@chromium.org, drott...@chromium.org, shgar+aut...@google.com, dom+...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, ananyasee...@google.com, devtools...@chromium.org, michaelcheco+...@google.com, keithle...@chromium.org, crisrael+...@google.com, silv...@chromium.org, yhanada...@chromium.org, estali...@chromium.org, kuragin+web-ap...@chromium.org, phoglun...@chromium.org, rrsilva+wat...@google.com, bmcquad...@chromium.org, cambickel+watc...@google.com, cros-essential...@chromium.org, devtools-re...@chromium.org, jkeitel+watch-...@google.com, longbowei+watc...@google.com, mreichhoff+watc...@chromium.org, speed-metr...@chromium.org, chadduffin+w...@chromium.org, jonmann+wat...@chromium.org, chromeos-kio...@google.com, blink-rev...@chromium.org, kinuko+ser...@chromium.org, fgorsk...@chromium.org, toshikikikuch...@chromium.org, jimmyxgong+w...@chromium.org, dmurph+watch...@chromium.org, fuchsia...@chromium.org, gavinp...@chromium.org, dtraino...@chromium.org, dkrahn...@chromium.org, cfredri...@chromium.org, webap...@microsoft.com, zackha...@chromium.org, blink-isola...@chromium.org, ffred...@chromium.org, gl...@chromium.org, language...@chromium.org, iwells...@chromium.org, rouslan+au...@chromium.org, bici...@google.com, subresource-f...@chromium.org, jonmann+w...@chromium.org, hsuregan+wat...@chromium.org, mschillaci...@google.com, dclasson+w...@google.com, edgesto...@microsoft.com, chromotin...@chromium.org, dmurph+watching...@chromium.org, cros-print...@google.com, dfried...@chromium.org, sloboda...@chromium.org, ydago...@chromium.org, blink-reviews-p...@chromium.org, jimmyxgong+watch-shor...@chromium.org, longbowei+watch-shor...@google.com, mattreyno...@chromium.org, lize...@chromium.org, blink-revie...@chromium.org, jdonnel...@chromium.org, davidj...@chromium.org, siashah+au...@chromium.org, hidehik...@chromium.org, cblume...@chromium.org, omnibox-...@chromium.org, ayman...@chromium.org, dtseng...@chromium.org, jdh+wa...@chromium.org, yyhyyh+watch-inpu...@google.com, asumane...@google.com, nyquis...@chromium.org, media-wi...@chromium.org, ricea...@chromium.org, video-networking...@google.com, hirokisa...@chromium.org, harringt...@chromium.org, nator...@chromium.org, stanfie...@google.com, msrame...@chromium.org, lens-chrome...@google.com, blink-revi...@chromium.org, hashimo...@chromium.org, jbauma...@chromium.org, vscode...@chromium.org, martijn...@martijnc.be, michaelchec...@google.com, dmurph+watchi...@chromium.org, dullweb...@chromium.org, tgupta...@chromium.org, gavindodd+dia...@google.com, filesapp...@chromium.org, nektar...@chromium.org, erickun...@chromium.org, jiajunz+wat...@google.com, danakj...@chromium.org, jorgel...@chromium.org, ddrone...@google.com, core-timi...@chromium.org, kouhe...@chromium.org, chrome-gr...@chromium.org, meilian...@chromium.org, tmartino+tran...@chromium.org, tbansal+...@chromium.org, ajwong...@chromium.org, extension...@chromium.org, scheduler-b...@chromium.org, rayanka...@chromium.org, dfalcant...@chromium.org, cambickel+fe...@google.com, hais+wat...@google.com, kinuko...@chromium.org, rainhar...@chromium.org, marimatthew+watc...@google.com, crisrael+wa...@google.com, pdr+svgw...@chromium.org, zhangwenyu+wat...@google.com, khmel...@chromium.org, ios-rev...@chromium.org, mtomas...@chromium.org, roagarw...@chromium.org, pushi+wa...@google.com, tburkar...@chromium.org, pkotwic...@chromium.org, abigailbk...@google.com, amaliev+...@chromium.org, lingqi...@chromium.org, mpdento...@chromium.org, gavinwill+sc...@chromium.org, minap+watch-p...@google.com, permissio...@chromium.org, chromeos-ca...@google.com, loading-rev...@chromium.org, tedcho...@chromium.org, jackshira+...@google.com, vakh+safe_br...@chromium.org, geoffla...@chromium.org, cwp-review...@google.com, andysjl...@chromium.org, peilinwa...@google.com, chrome-b...@google.com, ajayramamurthy...@google.com, chrome-intell...@chromium.org, lwinston+watc...@google.com, cblum...@chromium.org, jackshira+wat...@google.com, security-...@chromium.org, chlily...@chromium.org, penghuan...@chromium.org, mattsimm...@chromium.org, core-web-vita...@chromium.org, zhangwenyu+watch...@google.com, feature-v...@chromium.org, mercer...@google.com, oshima...@chromium.org, tote-eng...@google.com, philli...@chromium.org, tracing...@chromium.org, liu+wa...@chromium.org, cc-...@chromium.org, trewin...@google.com, aleventh...@chromium.org, marinacio...@chromium.org, jimmyxgong+wat...@chromium.org, webauthn...@chromium.org, dcheng+c...@chromium.org, chadduffin+wa...@chromium.org, hansberry+wat...@chromium.org, jackshira+wa...@google.com, jackshira+w...@google.com, hansberry+wa...@chromium.org, michaelcheco+watch-i...@google.com, mkwst+w...@chromium.org, translat...@chromium.org, emi...@google.com, grt+...@chromium.org, eugeni...@chromium.org, jonmann+watc...@chromium.org, rousla...@chromium.org, xinghui...@chromium.org, srahim...@chromium.org, yhanada+...@chromium.org, agriev...@chromium.org, joeantonetti+...@google.com, jz...@chromium.org, asvitki...@chromium.org, olka+...@chromium.org, jeffreycohen+watc...@chromium.org, yusufo...@chromium.org, dougste...@chromium.org, android-web...@chromium.org, arc-review...@google.com, gogerald+pa...@chromium.org, nickdiego+wa...@igalia.com, twelling...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, arthursonzog...@chromium.org, ryanchu...@chromium.org, akingsb+wat...@google.com, loading-re...@chromium.org, gogeral...@chromium.org, petewi...@chromium.org, vinnypersky+...@google.com, giovax...@chromium.org, glider...@chromium.org, christia...@chromium.org, telemetr...@chromium.org, gavinp...@chromium.org, odejesu...@chromium.org, vaapi-...@chromium.org, dewitt...@chromium.org, marq+...@chromium.org, blink-re...@chromium.org, ajayramamurth...@google.com, lighthouse-eng-extern...@google.com, mcasas+med...@chromium.org, tranbaod...@chromium.org, jasonrobe...@google.com, dmurph+watchin...@chromium.org, ajayramamurthy+w...@google.com, wnwen...@chromium.org, caitkp...@chromium.org, dmurph+watc...@chromium.org, shannc...@chromium.org, apaselti...@chromium.org, ios-revie...@chromium.org, alandin...@chromium.org, jessemcke...@google.com, ender...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, mbarowsky+watc...@chromium.org, osaul+aut...@google.com, josiah...@chromium.org, dtapuska+...@chromium.org, gayane...@chromium.org, blink-rev...@chromium.org, jhawkins+...@google.com, yongshun+...@google.com, antoniosartori+wa...@chromium.org, scheduler...@chromium.org, speed-metrics...@chromium.org, michaelcheco+...@google.com, webapks-...@chromium.org, zhangwen...@google.com, cros-enterpris...@chromium.org, djacob...@chromium.org, eme-r...@chromium.org, xiangdongkong+...@google.com, ashleynewson+w...@chromium.org, pushi+watc...@google.com, chrome-tab-group-en...@google.com, hansenmichael...@google.com, fgal...@chromium.org, zhangwenyu+dia...@google.com, torne...@chromium.org, yhanada+...@chromium.org, zelin+watch-we...@chromium.org, glazuno...@chromium.org, wfh+...@chromium.org, mac-r...@chromium.org, cwalle...@chromium.org, dmurph+wa...@chromium.org, ukai+...@chromium.org, rhalava...@chromium.org, navigation...@chromium.org, pasko...@chromium.org, milicau+watchlis...@google.com, michaelcheco+watc...@google.com, droger+w...@chromium.org, rouslan+...@chromium.org, chromium-...@engflow.com, ozone-...@chromium.org, media-cro...@chromium.org, ios-web-view...@google.com, net-r...@chromium.org, shimazu...@chromium.org, blink-work...@chromium.org, ramyagopa...@google.com, fuzzin...@chromium.org, ios-r...@chromium.org, jiajunz+wa...@google.com, npnavarro+p...@chromium.org, michaelcheco+di...@google.com, jbroma...@chromium.org, jimmyxgong+watch...@chromium.org, csharris...@chromium.org, mgiuca...@chromium.org, prerenderi...@chromium.org, loyso...@chromium.org, cros-ed...@google.com, blink-revie...@chromium.org, mar...@chromium.org, julietlevesque...@google.com, jonmann+wa...@chromium.org, gab+...@chromium.org, kaklilu+watch-...@chromium.org, jackshira+wa...@google.com, michaelcheco+wa...@google.com, penghu...@chromium.org, khorimoto+wa...@chromium.org, francisjp...@google.com, drott+bl...@chromium.org, dtseng+c...@chromium.org, pmonett...@chromium.org, croissant-...@chromium.org, gcasto+w...@chromium.org, jshin...@chromium.org, lizeb+watch...@chromium.org, yuzo+...@chromium.org, fserb...@chromium.org, donnd...@chromium.org, emircan+watch...@chromium.org, nicolas...@chromium.org, kyungjunle...@google.com, hayato...@chromium.org, jimmyxgong+f...@chromium.org, crisrael+wa...@google.com, suetfei+wa...@google.com, twifka...@chromium.org, jdeblas...@chromium.org, bartek...@chromium.org, apavlo...@chromium.org, anastas...@google.com, ashleydp+watch-...@google.com, hanxi...@chromium.org, print-rev...@chromium.org, ajayramamurt...@google.com
Attention needed from Jay Kapadia

Tom Lukaszewicz added 1 comment

File ui/color/dynamic_color/palette_factory.h
Tom Lukaszewicz

If you've got agreement to use -1 in the manifest that's fine, you can just test for it and pass nullopt here if that's the case.

Open in Gerrit

Related details

Attention is currently required from:
  • Jay Kapadia
Gerrit-Attention: Jay Kapadia <jaykap...@gmail.com>
Gerrit-Comment-Date: Thu, 24 Jul 2025 18:56:43 +0000
satisfied_requirement
unsatisfied_requirement
open
diffy

Jay Kapadia (Gerrit)

unread,
Jul 27, 2025, 2:27:03 PMJul 27
to Mathias Bynens, Peter Collingbourne, Yoav Weiss (@Shopify), ningxin hu, Hans Wennborg, Mirko Bonadei, Raphael Kubo da Costa, Arnaud Mandy, Robert Kroeger, Rijubrata Bhaumik, Kevin Babbitt, Ilya Biryukov, Nate Chapin, Fredrik Söderquist, Andrew Williams, Wanming Lin, Thiabaud Engelbrecht, Alex Keng, Christian Biesinger, Kaan Icer, Alexis Menard, Peter Williamson, Kentaro Hara, Andrew Rayskiy, Kenneth Rohde Christiansen, Kevin McNee, Jiewei Qian, Nikhil Nayunigari, Mike Taylor, Sam Zackrisson, Peter Beverloo, Reid Kleckner, Ale Bzk, Hiroki Nakagawa, Luna Lu, Ryan Sultanem, Sadrul Chowdhury, Xida Chen, Zijie He, Ian Vollick, Jerome Jiang, Lei Zhang, (Julie)Jeongeun Kim, Dustin Mitchell, srirama chandra sekhar, Simon Hangl, David Bokan, Kenneth R Christiansen, Hongchan Choi, Enterprise Policy Reviews, Urvang Joshi, Daniel Andersson, Tommy Li, Olga Gerchikov, Nico Weber, Sarah Krakowiak, James Maclean, Chromium Metrics Reviews, Per Åhgren, Javier Fernandez, Daniel Cheng, Victor Tan, Hirokazu Honda, Stephen Chenney, Dirk Schulze, James Su, Wei4 Wang, David Worsham, AyeAye, AyeAye Python Dispatcher, Tom Lukaszewicz, Alison Gale, David Pennington, Daniel Soromou, Chromium LUCI CQ, chromium...@chromium.org, knollr+wat...@chromium.org, cros-setti...@google.com, lucasrada...@google.com, cambickel+watch-shor...@google.com, mfoltz...@chromium.org, network-ser...@chromium.org, shend...@chromium.org, sp...@chromium.org, yyhyyh+fee...@google.com, dibyapal+wa...@chromium.org, kenjibah...@chromium.org, thegreenf...@chromium.org, crmulli...@chromium.org, hansberry+w...@chromium.org, wangdanny+watch-in...@google.com, wychen...@chromium.org, asvitkine...@chromium.org, zol...@webkit.org, spang...@chromium.org, mdjone...@chromium.org, aleventhal...@chromium.org, dimich...@chromium.org, rsesek...@chromium.org, shuche...@chromium.org, cros-report...@google.com, ortuno+w...@chromium.org, kinuko+...@chromium.org, chromium-a...@chromium.org, kouhe...@chromium.org, siyua+aut...@chromium.org, steimel+watch...@chromium.org, lcwu+...@chromium.org, gavin...@chromium.org, web-schedulin...@chromium.org, pdf-r...@chromium.org, nwoked...@chromium.org, katie...@chromium.org, roblia...@chromium.org, mbarowsky+watc...@chromium.org, jackshira+wa...@google.com, fenced-fra...@chromium.org, mickeybu...@chromium.org, dmurph+wat...@chromium.org, crisrael+w...@google.com, hansberry+wa...@chromium.org, khorimoto+w...@chromium.org, yfriedm...@chromium.org, chikamu...@chromium.org, blink-revie...@chromium.org, gavindodd+watch-...@google.com, servicewor...@chromium.org, gavinwill+watch-...@chromium.org, gavinwill+dia...@chromium.org, crost...@chromium.org, dmurph+watch...@chromium.org, longbowei+fe...@google.com, creis...@chromium.org, browser-comp...@chromium.org, gavinp+p...@chromium.org, jinsukk...@chromium.org, headless...@chromium.org, rkgibso...@chromium.org, scheduler-...@chromium.org, kouhei...@chromium.org, chromeos-gfx-...@google.com, hansberry+wa...@chromium.org, horo+...@chromium.org, svend+w...@chromium.org, blink-revi...@chromium.org, tbarzi...@chromium.org, wangdanny+fe...@google.com, tommyw+w...@chromium.org, gangwu...@chromium.org, aakalla...@chromium.org, feature-me...@chromium.org, jbrom...@chromium.org, gavin...@chromium.org, chasej...@chromium.org, ashleydp+fe...@google.com, ejcaruso+wa...@chromium.org, kinuko...@chromium.org, bcb+watch-pl...@chromium.org, ajayramamurthy...@google.com, oilpan-rev...@chromium.org, jophba...@chromium.org, armalhotra+a...@google.com, toyosh...@chromium.org, andreaor...@chromium.org, ntp-dev...@chromium.org, zhangwenyu+f...@google.com, njeunje+...@chromium.org, moqati-team+chr...@google.com, dtapuska+ch...@chromium.org, enne...@chromium.org, kainin...@chromium.org, druber...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, max+watc...@igalia.com, halliwe...@chromium.org, joeantonetti+wa...@google.com, sky+...@chromium.org, ashleydp+diag...@google.com, yuezhang...@chromium.org, chili...@chromium.org, chfreme...@chromium.org, jmedle...@chromium.org, rsleev...@chromium.org, eric.c...@apple.com, vasilii+watchlis...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, rlp+...@chromium.org, cbe-cep-eng...@google.com, stevenjb+wa...@chromium.org, jackshira+w...@google.com, nikhilcn+wat...@google.com, rginda...@chromium.org, loading-rev...@chromium.org, crostin...@chromium.org, yhiran...@chromium.org, vsavu...@google.com, iclella...@chromium.org, loading...@chromium.org, yhanad...@chromium.org, chrome-intelligence-te...@google.com, bfcach...@chromium.org, performance-m...@chromium.org, hiroshig...@chromium.org, yigu+...@chromium.org, nona+...@chromium.org, pushi+wat...@google.com, shimazu+se...@chromium.org, npm+...@chromium.org, antoniosarto...@chromium.org, hsuregan+wa...@chromium.org, blink-re...@chromium.org, peter+watch...@chromium.org, lizeb...@chromium.org, dominicc+...@chromium.org, fmalit...@chromium.org, cambickel...@google.com, niharm...@google.com, chrome-waff...@google.com, tluk+...@chromium.org, blink-rev...@chromium.org, xlythe+wa...@google.com, rmcelra...@chromium.org, drott...@chromium.org, shgar+aut...@google.com, dom+...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, ananyasee...@google.com, devtools...@chromium.org, michaelcheco+...@google.com, keithle...@chromium.org, crisrael+...@google.com, silv...@chromium.org, yhanada...@chromium.org, estali...@chromium.org, kuragin+web-ap...@chromium.org, phoglun...@chromium.org, rrsilva+wat...@google.com, bmcquad...@chromium.org, cambickel+watc...@google.com, cros-essential...@chromium.org, devtools-re...@chromium.org, jkeitel+watch-...@google.com, longbowei+watc...@google.com, mreichhoff+watc...@chromium.org, speed-metr...@chromium.org, chadduffin+w...@chromium.org, jonmann+wat...@chromium.org, chromeos-kio...@google.com, blink-rev...@chromium.org, kinuko+ser...@chromium.org, fgorsk...@chromium.org, toshikikikuch...@chromium.org, jimmyxgong+w...@chromium.org, dmurph+watch...@chromium.org, fuchsia...@chromium.org, gavinp...@chromium.org, dtraino...@chromium.org, dkrahn...@chromium.org, cfredri...@chromium.org, webap...@microsoft.com, zackha...@chromium.org, blink-isola...@chromium.org, ffred...@chromium.org, gl...@chromium.org, language...@chromium.org, iwells...@chromium.org, rouslan+au...@chromium.org, bici...@google.com, subresource-f...@chromium.org, jonmann+w...@chromium.org, hsuregan+wat...@chromium.org, mschillaci...@google.com, dclasson+w...@google.com, edgesto...@microsoft.com, chromotin...@chromium.org, dmurph+watching...@chromium.org, cros-print...@google.com, dfried...@chromium.org, sloboda...@chromium.org, ydago...@chromium.org, blink-reviews-p...@chromium.org, jimmyxgong+watch-shor...@chromium.org, longbowei+watch-shor...@google.com, mattreyno...@chromium.org, lize...@chromium.org, blink-revie...@chromium.org, jdonnel...@chromium.org, davidj...@chromium.org, siashah+au...@chromium.org, hidehik...@chromium.org, cblume...@chromium.org, omnibox-...@chromium.org, ayman...@chromium.org, dtseng...@chromium.org, jdh+wa...@chromium.org, yyhyyh+watch-inpu...@google.com, asumane...@google.com, nyquis...@chromium.org, media-wi...@chromium.org, ricea...@chromium.org, video-networking...@google.com, hirokisa...@chromium.org, harringt...@chromium.org, nator...@chromium.org, stanfie...@google.com, msrame...@chromium.org, lens-chrome...@google.com, blink-revi...@chromium.org, hashimo...@chromium.org, jbauma...@chromium.org, vscode...@chromium.org, martijn...@martijnc.be, michaelchec...@google.com, dmurph+watchi...@chromium.org, dullweb...@chromium.org, tgupta...@chromium.org, gavindodd+dia...@google.com, filesapp...@chromium.org, nektar...@chromium.org, erickun...@chromium.org, jiajunz+wat...@google.com, danakj...@chromium.org, jorgel...@chromium.org, ddrone...@google.com, core-timi...@chromium.org, kouhe...@chromium.org, chrome-gr...@chromium.org, meilian...@chromium.org, tmartino+tran...@chromium.org, tbansal+...@chromium.org, ajwong...@chromium.org, extension...@chromium.org, scheduler-b...@chromium.org, rayanka...@chromium.org, dfalcant...@chromium.org, cambickel+fe...@google.com, hais+wat...@google.com, kinuko...@chromium.org, rainhar...@chromium.org, marimatthew+watc...@google.com, crisrael+wa...@google.com, pdr+svgw...@chromium.org, zhangwenyu+wat...@google.com, khmel...@chromium.org, ios-rev...@chromium.org, mtomas...@chromium.org, roagarw...@chromium.org, pushi+wa...@google.com, tburkar...@chromium.org, pkotwic...@chromium.org, abigailbk...@google.com, amaliev+...@chromium.org, lingqi...@chromium.org, mpdento...@chromium.org, gavinwill+sc...@chromium.org, minap+watch-p...@google.com, permissio...@chromium.org, chromeos-ca...@google.com, loading-rev...@chromium.org, tedcho...@chromium.org, jackshira+...@google.com, vakh+safe_br...@chromium.org, geoffla...@chromium.org, cwp-review...@google.com, andysjl...@chromium.org, peilinwa...@google.com, chrome-b...@google.com, ajayramamurthy...@google.com, chrome-intell...@chromium.org, lwinston+watc...@google.com, cblum...@chromium.org, jackshira+wat...@google.com, security-...@chromium.org, chlily...@chromium.org, penghuan...@chromium.org, mattsimm...@chromium.org, core-web-vita...@chromium.org, zhangwenyu+watch...@google.com, feature-v...@chromium.org, mercer...@google.com, oshima...@chromium.org, tote-eng...@google.com, philli...@chromium.org, tracing...@chromium.org, liu+wa...@chromium.org, cc-...@chromium.org, trewin...@google.com, aleventh...@chromium.org, marinacio...@chromium.org, jimmyxgong+wat...@chromium.org, webauthn...@chromium.org, dcheng+c...@chromium.org, chadduffin+wa...@chromium.org, hansberry+wat...@chromium.org, jackshira+wa...@google.com, jackshira+w...@google.com, hansberry+wa...@chromium.org, michaelcheco+watch-i...@google.com, mkwst+w...@chromium.org, translat...@chromium.org, emi...@google.com, grt+...@chromium.org, eugeni...@chromium.org, jonmann+watc...@chromium.org, rousla...@chromium.org, xinghui...@chromium.org, srahim...@chromium.org, yhanada+...@chromium.org, agriev...@chromium.org, joeantonetti+...@google.com, jz...@chromium.org, asvitki...@chromium.org, olka+...@chromium.org, jeffreycohen+watc...@chromium.org, yusufo...@chromium.org, dougste...@chromium.org, android-web...@chromium.org, arc-review...@google.com, gogerald+pa...@chromium.org, nickdiego+wa...@igalia.com, twelling...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, arthursonzog...@chromium.org, ryanchu...@chromium.org, akingsb+wat...@google.com, loading-re...@chromium.org, gogeral...@chromium.org, petewi...@chromium.org, vinnypersky+...@google.com, giovax...@chromium.org, glider...@chromium.org, christia...@chromium.org, telemetr...@chromium.org, gavinp...@chromium.org, odejesu...@chromium.org, vaapi-...@chromium.org, dewitt...@chromium.org, marq+...@chromium.org, blink-re...@chromium.org, ajayramamurth...@google.com, lighthouse-eng-extern...@google.com, mcasas+med...@chromium.org, tranbaod...@chromium.org, jasonrobe...@google.com, dmurph+watchin...@chromium.org, ajayramamurthy+w...@google.com, wnwen...@chromium.org, caitkp...@chromium.org, dmurph+watc...@chromium.org, shannc...@chromium.org, apaselti...@chromium.org, ios-revie...@chromium.org, alandin...@chromium.org, jessemcke...@google.com, ender...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, mbarowsky+watc...@chromium.org, osaul+aut...@google.com, josiah...@chromium.org, dtapuska+...@chromium.org, gayane...@chromium.org, blink-rev...@chromium.org, jhawkins+...@google.com, yongshun+...@google.com, antoniosartori+wa...@chromium.org, scheduler...@chromium.org, speed-metrics...@chromium.org, michaelcheco+...@google.com, webapks-...@chromium.org, zhangwen...@google.com, cros-enterpris...@chromium.org, djacob...@chromium.org, eme-r...@chromium.org, xiangdongkong+...@google.com, ashleynewson+w...@chromium.org, pushi+watc...@google.com, chrome-tab-group-en...@google.com, hansenmichael...@google.com, fgal...@chromium.org, zhangwenyu+dia...@google.com, torne...@chromium.org, yhanada+...@chromium.org, zelin+watch-we...@chromium.org, glazuno...@chromium.org, wfh+...@chromium.org, mac-r...@chromium.org, cwalle...@chromium.org, dmurph+wa...@chromium.org, ukai+...@chromium.org, rhalava...@chromium.org, navigation...@chromium.org, pasko...@chromium.org, milicau+watchlis...@google.com, michaelcheco+watc...@google.com, droger+w...@chromium.org, rouslan+...@chromium.org, chromium-...@engflow.com, ozone-...@chromium.org, media-cro...@chromium.org, ios-web-view...@google.com, net-r...@chromium.org, shimazu...@chromium.org, blink-work...@chromium.org, ramyagopa...@google.com, fuzzin...@chromium.org, ios-r...@chromium.org, jiajunz+wa...@google.com, npnavarro+p...@chromium.org, michaelcheco+di...@google.com, jbroma...@chromium.org, jimmyxgong+watch...@chromium.org, csharris...@chromium.org, mgiuca...@chromium.org, prerenderi...@chromium.org, loyso...@chromium.org, cros-ed...@google.com, blink-revie...@chromium.org, mar...@chromium.org, julietlevesque...@google.com, jonmann+wa...@chromium.org, gab+...@chromium.org, kaklilu+watch-...@chromium.org, jackshira+wa...@google.com, michaelcheco+wa...@google.com, penghu...@chromium.org, khorimoto+wa...@chromium.org, francisjp...@google.com, drott+bl...@chromium.org, dtseng+c...@chromium.org, pmonett...@chromium.org, croissant-...@chromium.org, gcasto+w...@chromium.org, jshin...@chromium.org, lizeb+watch...@chromium.org, yuzo+...@chromium.org, fserb...@chromium.org, donnd...@chromium.org, emircan+watch...@chromium.org, nicolas...@chromium.org, kyungjunle...@google.com, hayato...@chromium.org, jimmyxgong+f...@chromium.org, crisrael+wa...@google.com, suetfei+wa...@google.com, twifka...@chromium.org, jdeblas...@chromium.org, bartek...@chromium.org, apavlo...@chromium.org, anastas...@google.com, ashleydp+watch-...@google.com, hanxi...@chromium.org, print-rev...@chromium.org, ajayramamurt...@google.com
Attention needed from Alison Gale, David Pennington and Tom Lukaszewicz

Jay Kapadia added 1 comment

File ui/color/dynamic_color/palette_factory.h
Line 32, Patchset 24:void GenerateStandardShadesFromHue(
Tom Lukaszewicz . resolved
Jay Kapadia

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Alison Gale
  • David Pennington
  • Tom Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If8405c7213cdea536779a2ba64a46016d466c96a
Gerrit-Change-Number: 6669514
Gerrit-PatchSet: 30
Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Attention: Alison Gale <ag...@chromium.org>
Gerrit-Attention: David Pennington <dpen...@chromium.org>
Gerrit-Comment-Date: Sun, 27 Jul 2025 18:26:22 +0000
satisfied_requirement
unsatisfied_requirement
open
diffy

fabian athayde (Gerrit)

unread,
Jul 27, 2025, 2:28:28 PMJul 27
to Jay Kapadia, Mathias Bynens, Peter Collingbourne, Yoav Weiss (@Shopify), ningxin hu, Hans Wennborg, Mirko Bonadei, Raphael Kubo da Costa, Arnaud Mandy, Robert Kroeger, Rijubrata Bhaumik, Kevin Babbitt, Ilya Biryukov, Nate Chapin, Fredrik Söderquist, Andrew Williams, Wanming Lin, Thiabaud Engelbrecht, Alex Keng, Christian Biesinger, Kaan Icer, Alexis Menard, Peter Williamson, Kentaro Hara, Andrew Rayskiy, Kenneth Rohde Christiansen, Kevin McNee, Jiewei Qian, Nikhil Nayunigari, Mike Taylor, Sam Zackrisson, Peter Beverloo, Reid Kleckner, Ale Bzk, Hiroki Nakagawa, Luna Lu, Ryan Sultanem, Sadrul Chowdhury, Xida Chen, Zijie He, Ian Vollick, Jerome Jiang, Lei Zhang, (Julie)Jeongeun Kim, Dustin Mitchell, srirama chandra sekhar, Simon Hangl, David Bokan, Kenneth R Christiansen, Hongchan Choi, Enterprise Policy Reviews, Urvang Joshi, Daniel Andersson, Tommy Li, Olga Gerchikov, Nico Weber, Sarah Krakowiak, James Maclean, Chromium Metrics Reviews, Per Åhgren, Javier Fernandez, Daniel Cheng, Victor Tan, Hirokazu Honda, Stephen Chenney, Dirk Schulze, James Su, Wei4 Wang, David Worsham, AyeAye, AyeAye Python Dispatcher, Tom Lukaszewicz, Alison Gale, David Pennington, Daniel Soromou, Chromium LUCI CQ, chromium...@chromium.org, knollr+wat...@chromium.org, cros-setti...@google.com, lucasrada...@google.com, cambickel+watch-shor...@google.com, mfoltz...@chromium.org, network-ser...@chromium.org, shend...@chromium.org, sp...@chromium.org, yyhyyh+fee...@google.com, dibyapal+wa...@chromium.org, kenjibah...@chromium.org, thegreenf...@chromium.org, crmulli...@chromium.org, hansberry+w...@chromium.org, wangdanny+watch-in...@google.com, wychen...@chromium.org, asvitkine...@chromium.org, zol...@webkit.org, spang...@chromium.org, mdjone...@chromium.org, aleventhal...@chromium.org, dimich...@chromium.org, rsesek...@chromium.org, shuche...@chromium.org, cros-report...@google.com, ortuno+w...@chromium.org, kinuko+...@chromium.org, chromium-a...@chromium.org, kouhe...@chromium.org, siyua+aut...@chromium.org, steimel+watch...@chromium.org, lcwu+...@chromium.org, gavin...@chromium.org, web-schedulin...@chromium.org, pdf-r...@chromium.org, nwoked...@chromium.org, katie...@chromium.org, roblia...@chromium.org, mbarowsky+watc...@chromium.org, jackshira+wa...@google.com, fenced-fra...@chromium.org, mickeybu...@chromium.org, dmurph+wat...@chromium.org, crisrael+w...@google.com, hansberry+wa...@chromium.org, khorimoto+w...@chromium.org, yfriedm...@chromium.org, chikamu...@chromium.org, blink-revie...@chromium.org, gavindodd+watch-...@google.com, servicewor...@chromium.org, gavinwill+watch-...@chromium.org, gavinwill+dia...@chromium.org, crost...@chromium.org, dmurph+watch...@chromium.org, longbowei+fe...@google.com, creis...@chromium.org, browser-comp...@chromium.org, gavinp+p...@chromium.org, jinsukk...@chromium.org, headless...@chromium.org, rkgibso...@chromium.org, scheduler-...@chromium.org, kouhei...@chromium.org, chromeos-gfx-...@google.com, hansberry+wa...@chromium.org, horo+...@chromium.org, svend+w...@chromium.org, blink-revi...@chromium.org, tbarzi...@chromium.org, wangdanny+fe...@google.com, tommyw+w...@chromium.org, gangwu...@chromium.org, aakalla...@chromium.org, feature-me...@chromium.org, jbrom...@chromium.org, gavin...@chromium.org, chasej...@chromium.org, ashleydp+fe...@google.com, ejcaruso+wa...@chromium.org, kinuko...@chromium.org, bcb+watch-pl...@chromium.org, ajayramamurthy...@google.com, oilpan-rev...@chromium.org, jophba...@chromium.org, armalhotra+a...@google.com, toyosh...@chromium.org, andreaor...@chromium.org, ntp-dev...@chromium.org, zhangwenyu+f...@google.com, njeunje+...@chromium.org, moqati-team+chr...@google.com, dtapuska+ch...@chromium.org, enne...@chromium.org, kainin...@chromium.org, druber...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, max+watc...@igalia.com, halliwe...@chromium.org, joeantonetti+wa...@google.com, sky+...@chromium.org, ashleydp+diag...@google.com, yuezhang...@chromium.org, chili...@chromium.org, chfreme...@chromium.org, jmedle...@chromium.org, rsleev...@chromium.org, eric.c...@apple.com, vasilii+watchlis...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, rlp+...@chromium.org, cbe-cep-eng...@google.com, stevenjb+wa...@chromium.org, jackshira+w...@google.com, nikhilcn+wat...@google.com, rginda...@chromium.org, loading-rev...@chromium.org, crostin...@chromium.org, yhiran...@chromium.org, vsavu...@google.com, iclella...@chromium.org, loading...@chromium.org, yhanad...@chromium.org, chrome-intelligence-te...@google.com, bfcach...@chromium.org, performance-m...@chromium.org, hiroshig...@chromium.org, yigu+...@chromium.org, nona+...@chromium.org, pushi+wat...@google.com, shimazu+se...@chromium.org, npm+...@chromium.org, antoniosarto...@chromium.org, hsuregan+wa...@chromium.org, blink-re...@chromium.org, peter+watch...@chromium.org, lizeb...@chromium.org, dominicc+...@chromium.org, fmalit...@chromium.org, cambickel...@google.com, niharm...@google.com, chrome-waff...@google.com, tluk+...@chromium.org, blink-rev...@chromium.org, xlythe+wa...@google.com, rmcelra...@chromium.org, drott...@chromium.org, shgar+aut...@google.com, dom+...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, ananyasee...@google.com, devtools...@chromium.org, michaelcheco+...@google.com, keithle...@chromium.org, crisrael+...@google.com, silv...@chromium.org, yhanada...@chromium.org, estali...@chromium.org, kuragin+web-ap...@chromium.org, phoglun...@chromium.org, rrsilva+wat...@google.com, bmcquad...@chromium.org, cambickel+watc...@google.com, cros-essential...@chromium.org, devtools-re...@chromium.org, jkeitel+watch-...@google.com, longbowei+watc...@google.com, mreichhoff+watc...@chromium.org, speed-metr...@chromium.org, chadduffin+w...@chromium.org, jonmann+wat...@chromium.org, chromeos-kio...@google.com, blink-rev...@chromium.org, kinuko+ser...@chromium.org, fgorsk...@chromium.org, toshikikikuch...@chromium.org, jimmyxgong+w...@chromium.org, dmurph+watch...@chromium.org, fuchsia...@chromium.org, gavinp...@chromium.org, dtraino...@chromium.org, dkrahn...@chromium.org, cfredri...@chromium.org, webap...@microsoft.com, zackha...@chromium.org, blink-isola...@chromium.org, ffred...@chromium.org, gl...@chromium.org, language...@chromium.org, iwells...@chromium.org, rouslan+au...@chromium.org, bici...@google.com, subresource-f...@chromium.org, jonmann+w...@chromium.org, hsuregan+wat...@chromium.org, mschillaci...@google.com, dclasson+w...@google.com, edgesto...@microsoft.com, chromotin...@chromium.org, dmurph+watching...@chromium.org, cros-print...@google.com, dfried...@chromium.org, sloboda...@chromium.org, ydago...@chromium.org, blink-reviews-p...@chromium.org, jimmyxgong+watch-shor...@chromium.org, longbowei+watch-shor...@google.com, mattreyno...@chromium.org, lize...@chromium.org, blink-revie...@chromium.org, jdonnel...@chromium.org, davidj...@chromium.org, siashah+au...@chromium.org, hidehik...@chromium.org, cblume...@chromium.org, omnibox-...@chromium.org, ayman...@chromium.org, dtseng...@chromium.org, jdh+wa...@chromium.org, yyhyyh+watch-inpu...@google.com, asumane...@google.com, nyquis...@chromium.org, media-wi...@chromium.org, ricea...@chromium.org, video-networking...@google.com, hirokisa...@chromium.org, harringt...@chromium.org, nator...@chromium.org, stanfie...@google.com, msrame...@chromium.org, lens-chrome...@google.com, blink-revi...@chromium.org, hashimo...@chromium.org, jbauma...@chromium.org, vscode...@chromium.org, martijn...@martijnc.be, michaelchec...@google.com, dmurph+watchi...@chromium.org, dullweb...@chromium.org, tgupta...@chromium.org, gavindodd+dia...@google.com, filesapp...@chromium.org, nektar...@chromium.org, erickun...@chromium.org, jiajunz+wat...@google.com, danakj...@chromium.org, jorgel...@chromium.org, ddrone...@google.com, core-timi...@chromium.org, kouhe...@chromium.org, chrome-gr...@chromium.org, meilian...@chromium.org, tmartino+tran...@chromium.org, tbansal+...@chromium.org, ajwong...@chromium.org, extension...@chromium.org, scheduler-b...@chromium.org, rayanka...@chromium.org, dfalcant...@chromium.org, cambickel+fe...@google.com, hais+wat...@google.com, kinuko...@chromium.org, rainhar...@chromium.org, marimatthew+watc...@google.com, crisrael+wa...@google.com, pdr+svgw...@chromium.org, zhangwenyu+wat...@google.com, khmel...@chromium.org, ios-rev...@chromium.org, mtomas...@chromium.org, roagarw...@chromium.org, pushi+wa...@google.com, tburkar...@chromium.org, pkotwic...@chromium.org, abigailbk...@google.com, amaliev+...@chromium.org, lingqi...@chromium.org, mpdento...@chromium.org, gavinwill+sc...@chromium.org, minap+watch-p...@google.com, permissio...@chromium.org, chromeos-ca...@google.com, loading-rev...@chromium.org, tedcho...@chromium.org, jackshira+...@google.com, vakh+safe_br...@chromium.org, geoffla...@chromium.org, cwp-review...@google.com, andysjl...@chromium.org, peilinwa...@google.com, chrome-b...@google.com, ajayramamurthy...@google.com, chrome-intell...@chromium.org, lwinston+watc...@google.com, cblum...@chromium.org, jackshira+wat...@google.com, security-...@chromium.org, chlily...@chromium.org, penghuan...@chromium.org, mattsimm...@chromium.org, core-web-vita...@chromium.org, zhangwenyu+watch...@google.com, feature-v...@chromium.org, mercer...@google.com, oshima...@chromium.org, tote-eng...@google.com, philli...@chromium.org, tracing...@chromium.org, liu+wa...@chromium.org, cc-...@chromium.org, trewin...@google.com, aleventh...@chromium.org, marinacio...@chromium.org, jimmyxgong+wat...@chromium.org, webauthn...@chromium.org, dcheng+c...@chromium.org, chadduffin+wa...@chromium.org, hansberry+wat...@chromium.org, jackshira+wa...@google.com, jackshira+w...@google.com, hansberry+wa...@chromium.org, michaelcheco+watch-i...@google.com, mkwst+w...@chromium.org, translat...@chromium.org, emi...@google.com, grt+...@chromium.org, eugeni...@chromium.org, jonmann+watc...@chromium.org, rousla...@chromium.org, xinghui...@chromium.org, srahim...@chromium.org, yhanada+...@chromium.org, agriev...@chromium.org, joeantonetti+...@google.com, jz...@chromium.org, asvitki...@chromium.org, olka+...@chromium.org, jeffreycohen+watc...@chromium.org, yusufo...@chromium.org, dougste...@chromium.org, android-web...@chromium.org, arc-review...@google.com, gogerald+pa...@chromium.org, nickdiego+wa...@igalia.com, twelling...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, arthursonzog...@chromium.org, ryanchu...@chromium.org, akingsb+wat...@google.com, loading-re...@chromium.org, gogeral...@chromium.org, petewi...@chromium.org, vinnypersky+...@google.com, giovax...@chromium.org, glider...@chromium.org, christia...@chromium.org, telemetr...@chromium.org, gavinp...@chromium.org, odejesu...@chromium.org, vaapi-...@chromium.org, dewitt...@chromium.org, marq+...@chromium.org, blink-re...@chromium.org, ajayramamurth...@google.com, lighthouse-eng-extern...@google.com, mcasas+med...@chromium.org, tranbaod...@chromium.org, jasonrobe...@google.com, dmurph+watchin...@chromium.org, ajayramamurthy+w...@google.com, wnwen...@chromium.org, caitkp...@chromium.org, dmurph+watc...@chromium.org, shannc...@chromium.org, apaselti...@chromium.org, ios-revie...@chromium.org, alandin...@chromium.org, jessemcke...@google.com, ender...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, mbarowsky+watc...@chromium.org, osaul+aut...@google.com, josiah...@chromium.org, dtapuska+...@chromium.org, gayane...@chromium.org, blink-rev...@chromium.org, jhawkins+...@google.com, yongshun+...@google.com, antoniosartori+wa...@chromium.org, scheduler...@chromium.org, speed-metrics...@chromium.org, michaelcheco+...@google.com, webapks-...@chromium.org, zhangwen...@google.com, cros-enterpris...@chromium.org, djacob...@chromium.org, eme-r...@chromium.org, xiangdongkong+...@google.com, ashleynewson+w...@chromium.org, pushi+watc...@google.com, chrome-tab-group-en...@google.com, hansenmichael...@google.com, fgal...@chromium.org, zhangwenyu+dia...@google.com, torne...@chromium.org, yhanada+...@chromium.org, zelin+watch-we...@chromium.org, glazuno...@chromium.org, wfh+...@chromium.org, mac-r...@chromium.org, cwalle...@chromium.org, dmurph+wa...@chromium.org, ukai+...@chromium.org, rhalava...@chromium.org, navigation...@chromium.org, pasko...@chromium.org, milicau+watchlis...@google.com, michaelcheco+watc...@google.com, droger+w...@chromium.org, rouslan+...@chromium.org, chromium-...@engflow.com, ozone-...@chromium.org, media-cro...@chromium.org, ios-web-view...@google.com, net-r...@chromium.org, shimazu...@chromium.org, blink-work...@chromium.org, ramyagopa...@google.com, fuzzin...@chromium.org, ios-r...@chromium.org, jiajunz+wa...@google.com, npnavarro+p...@chromium.org, michaelcheco+di...@google.com, jbroma...@chromium.org, jimmyxgong+watch...@chromium.org, csharris...@chromium.org, mgiuca...@chromium.org, prerenderi...@chromium.org, loyso...@chromium.org, cros-ed...@google.com, blink-revie...@chromium.org, mar...@chromium.org, julietlevesque...@google.com, jonmann+wa...@chromium.org, gab+...@chromium.org, kaklilu+watch-...@chromium.org, jackshira+wa...@google.com, michaelcheco+wa...@google.com, penghu...@chromium.org, khorimoto+wa...@chromium.org, francisjp...@google.com, drott+bl...@chromium.org, dtseng+c...@chromium.org, pmonett...@chromium.org, croissant-...@chromium.org, gcasto+w...@chromium.org, jshin...@chromium.org, lizeb+watch...@chromium.org, yuzo+...@chromium.org, fserb...@chromium.org, donnd...@chromium.org, emircan+watch...@chromium.org, nicolas...@chromium.org, kyungjunle...@google.com, hayato...@chromium.org, jimmyxgong+f...@chromium.org, crisrael+wa...@google.com, suetfei+wa...@google.com, twifka...@chromium.org, jdeblas...@chromium.org, bartek...@chromium.org, apavlo...@chromium.org, anastas...@google.com, ashleydp+watch-...@google.com, hanxi...@chromium.org, print-rev...@chromium.org, ajayramamurt...@google.com
Attention needed from Alison Gale, David Pennington and Tom Lukaszewicz

fabian athayde added 1 comment

Message

Our playing games again Jay

On Sun, Jul 27, 2025, 1:27 PM Jay Kapadia (Gerrit) <noreply-gerritcodereview+EcyVY9_GQ3sOJOpnzleD4A==@> wrote: chromium.org

1 comment

Patchset-level comments
File-level comment, Patchset 30 (Latest):
fabian athayde . resolved

Our playing games again Jay

On Sun, Jul 27, 2025, 1:27 PM Jay Kapadia (Gerrit) <noreply-gerritcodereview+EcyVY9_GQ3sOJOpnzleD4A==@> wrote: chromium.org

Gerrit-Comment-Date: Sun, 27 Jul 2025 18:28:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Tom Lukaszewicz (Gerrit)

unread,
Jul 27, 2025, 2:42:02 PMJul 27
to Jay Kapadia, Mathias Bynens, Peter Collingbourne, Yoav Weiss (@Shopify), ningxin hu, Hans Wennborg, Mirko Bonadei, Raphael Kubo da Costa, Arnaud Mandy, Robert Kroeger, Rijubrata Bhaumik, Kevin Babbitt, Ilya Biryukov, Nate Chapin, Fredrik Söderquist, Andrew Williams, Wanming Lin, Thiabaud Engelbrecht, Alex Keng, Christian Biesinger, Kaan Icer, Alexis Menard, Peter Williamson, Kentaro Hara, Andrew Rayskiy, Kenneth Rohde Christiansen, Kevin McNee, Jiewei Qian, Nikhil Nayunigari, Mike Taylor, Sam Zackrisson, Peter Beverloo, Reid Kleckner, Ale Bzk, Hiroki Nakagawa, Luna Lu, Ryan Sultanem, Sadrul Chowdhury, Xida Chen, Zijie He, Ian Vollick, Jerome Jiang, Lei Zhang, (Julie)Jeongeun Kim, Dustin Mitchell, srirama chandra sekhar, Simon Hangl, David Bokan, Kenneth R Christiansen, Hongchan Choi, Enterprise Policy Reviews, Urvang Joshi, Daniel Andersson, Tommy Li, Olga Gerchikov, Nico Weber, Sarah Krakowiak, James Maclean, Chromium Metrics Reviews, Per Åhgren, Javier Fernandez, Daniel Cheng, Victor Tan, Hirokazu Honda, Stephen Chenney, Dirk Schulze, James Su, Wei4 Wang, David Worsham, AyeAye, AyeAye Python Dispatcher, Alison Gale, David Pennington, Daniel Soromou, Chromium LUCI CQ, chromium...@chromium.org, knollr+wat...@chromium.org, cros-setti...@google.com, lucasrada...@google.com, cambickel+watch-shor...@google.com, mfoltz...@chromium.org, network-ser...@chromium.org, shend...@chromium.org, sp...@chromium.org, yyhyyh+fee...@google.com, dibyapal+wa...@chromium.org, kenjibah...@chromium.org, thegreenf...@chromium.org, crmulli...@chromium.org, hansberry+w...@chromium.org, wangdanny+watch-in...@google.com, wychen...@chromium.org, asvitkine...@chromium.org, zol...@webkit.org, spang...@chromium.org, mdjone...@chromium.org, aleventhal...@chromium.org, dimich...@chromium.org, rsesek...@chromium.org, shuche...@chromium.org, cros-report...@google.com, ortuno+w...@chromium.org, kinuko+...@chromium.org, chromium-a...@chromium.org, kouhe...@chromium.org, siyua+aut...@chromium.org, steimel+watch...@chromium.org, lcwu+...@chromium.org, gavin...@chromium.org, web-schedulin...@chromium.org, pdf-r...@chromium.org, nwoked...@chromium.org, katie...@chromium.org, roblia...@chromium.org, mbarowsky+watc...@chromium.org, jackshira+wa...@google.com, fenced-fra...@chromium.org, mickeybu...@chromium.org, dmurph+wat...@chromium.org, crisrael+w...@google.com, hansberry+wa...@chromium.org, khorimoto+w...@chromium.org, yfriedm...@chromium.org, chikamu...@chromium.org, blink-revie...@chromium.org, gavindodd+watch-...@google.com, servicewor...@chromium.org, gavinwill+watch-...@chromium.org, gavinwill+dia...@chromium.org, crost...@chromium.org, dmurph+watch...@chromium.org, longbowei+fe...@google.com, creis...@chromium.org, browser-comp...@chromium.org, gavinp+p...@chromium.org, jinsukk...@chromium.org, headless...@chromium.org, rkgibso...@chromium.org, scheduler-...@chromium.org, kouhei...@chromium.org, chromeos-gfx-...@google.com, hansberry+wa...@chromium.org, horo+...@chromium.org, svend+w...@chromium.org, blink-revi...@chromium.org, tbarzi...@chromium.org, wangdanny+fe...@google.com, tommyw+w...@chromium.org, gangwu...@chromium.org, aakalla...@chromium.org, feature-me...@chromium.org, jbrom...@chromium.org, gavin...@chromium.org, chasej...@chromium.org, ashleydp+fe...@google.com, ejcaruso+wa...@chromium.org, kinuko...@chromium.org, bcb+watch-pl...@chromium.org, ajayramamurthy...@google.com, oilpan-rev...@chromium.org, jophba...@chromium.org, armalhotra+a...@google.com, toyosh...@chromium.org, andreaor...@chromium.org, ntp-dev...@chromium.org, zhangwenyu+f...@google.com, njeunje+...@chromium.org, moqati-team+chr...@google.com, dtapuska+ch...@chromium.org, enne...@chromium.org, kainin...@chromium.org, druber...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, max+watc...@igalia.com, halliwe...@chromium.org, joeantonetti+wa...@google.com, sky+...@chromium.org, ashleydp+diag...@google.com, yuezhang...@chromium.org, chili...@chromium.org, chfreme...@chromium.org, jmedle...@chromium.org, rsleev...@chromium.org, eric.c...@apple.com, vasilii+watchlis...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, rlp+...@chromium.org, cbe-cep-eng...@google.com, stevenjb+wa...@chromium.org, jackshira+w...@google.com, nikhilcn+wat...@google.com, rginda...@chromium.org, loading-rev...@chromium.org, crostin...@chromium.org, yhiran...@chromium.org, vsavu...@google.com, iclella...@chromium.org, loading...@chromium.org, yhanad...@chromium.org, chrome-intelligence-te...@google.com, bfcach...@chromium.org, performance-m...@chromium.org, hiroshig...@chromium.org, yigu+...@chromium.org, nona+...@chromium.org, pushi+wat...@google.com, shimazu+se...@chromium.org, npm+...@chromium.org, antoniosarto...@chromium.org, hsuregan+wa...@chromium.org, blink-re...@chromium.org, peter+watch...@chromium.org, lizeb...@chromium.org, dominicc+...@chromium.org, fmalit...@chromium.org, cambickel...@google.com, niharm...@google.com, chrome-waff...@google.com, tluk+...@chromium.org, blink-rev...@chromium.org, xlythe+wa...@google.com, rmcelra...@chromium.org, drott...@chromium.org, shgar+aut...@google.com, dom+...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, ananyasee...@google.com, devtools...@chromium.org, michaelcheco+...@google.com, keithle...@chromium.org, crisrael+...@google.com, silv...@chromium.org, yhanada...@chromium.org, estali...@chromium.org, kuragin+web-ap...@chromium.org, phoglun...@chromium.org, rrsilva+wat...@google.com, bmcquad...@chromium.org, cambickel+watc...@google.com, cros-essential...@chromium.org, devtools-re...@chromium.org, jkeitel+watch-...@google.com, longbowei+watc...@google.com, mreichhoff+watc...@chromium.org, speed-metr...@chromium.org, chadduffin+w...@chromium.org, jonmann+wat...@chromium.org, chromeos-kio...@google.com, blink-rev...@chromium.org, kinuko+ser...@chromium.org, fgorsk...@chromium.org, toshikikikuch...@chromium.org, jimmyxgong+w...@chromium.org, dmurph+watch...@chromium.org, fuchsia...@chromium.org, gavinp...@chromium.org, dtraino...@chromium.org, dkrahn...@chromium.org, cfredri...@chromium.org, webap...@microsoft.com, zackha...@chromium.org, blink-isola...@chromium.org, ffred...@chromium.org, gl...@chromium.org, language...@chromium.org, iwells...@chromium.org, rouslan+au...@chromium.org, bici...@google.com, subresource-f...@chromium.org, jonmann+w...@chromium.org, hsuregan+wat...@chromium.org, mschillaci...@google.com, dclasson+w...@google.com, edgesto...@microsoft.com, chromotin...@chromium.org, dmurph+watching...@chromium.org, cros-print...@google.com, dfried...@chromium.org, sloboda...@chromium.org, ydago...@chromium.org, blink-reviews-p...@chromium.org, jimmyxgong+watch-shor...@chromium.org, longbowei+watch-shor...@google.com, mattreyno...@chromium.org, lize...@chromium.org, blink-revie...@chromium.org, jdonnel...@chromium.org, davidj...@chromium.org, siashah+au...@chromium.org, hidehik...@chromium.org, cblume...@chromium.org, omnibox-...@chromium.org, ayman...@chromium.org, dtseng...@chromium.org, jdh+wa...@chromium.org, yyhyyh+watch-inpu...@google.com, asumane...@google.com, nyquis...@chromium.org, media-wi...@chromium.org, ricea...@chromium.org, video-networking...@google.com, hirokisa...@chromium.org, harringt...@chromium.org, nator...@chromium.org, stanfie...@google.com, msrame...@chromium.org, lens-chrome...@google.com, blink-revi...@chromium.org, hashimo...@chromium.org, jbauma...@chromium.org, vscode...@chromium.org, martijn...@martijnc.be, michaelchec...@google.com, dmurph+watchi...@chromium.org, dullweb...@chromium.org, tgupta...@chromium.org, gavindodd+dia...@google.com, filesapp...@chromium.org, nektar...@chromium.org, erickun...@chromium.org, jiajunz+wat...@google.com, danakj...@chromium.org, jorgel...@chromium.org, ddrone...@google.com, core-timi...@chromium.org, kouhe...@chromium.org, chrome-gr...@chromium.org, meilian...@chromium.org, tmartino+tran...@chromium.org, tbansal+...@chromium.org, ajwong...@chromium.org, extension...@chromium.org, scheduler-b...@chromium.org, rayanka...@chromium.org, dfalcant...@chromium.org, cambickel+fe...@google.com, hais+wat...@google.com, kinuko...@chromium.org, rainhar...@chromium.org, marimatthew+watc...@google.com, crisrael+wa...@google.com, pdr+svgw...@chromium.org, zhangwenyu+wat...@google.com, khmel...@chromium.org, ios-rev...@chromium.org, mtomas...@chromium.org, roagarw...@chromium.org, pushi+wa...@google.com, tburkar...@chromium.org, pkotwic...@chromium.org, abigailbk...@google.com, amaliev+...@chromium.org, lingqi...@chromium.org, mpdento...@chromium.org, gavinwill+sc...@chromium.org, minap+watch-p...@google.com, permissio...@chromium.org, chromeos-ca...@google.com, loading-rev...@chromium.org, tedcho...@chromium.org, jackshira+...@google.com, vakh+safe_br...@chromium.org, geoffla...@chromium.org, cwp-review...@google.com, andysjl...@chromium.org, peilinwa...@google.com, chrome-b...@google.com, ajayramamurthy...@google.com, chrome-intell...@chromium.org, lwinston+watc...@google.com, cblum...@chromium.org, jackshira+wat...@google.com, security-...@chromium.org, chlily...@chromium.org, penghuan...@chromium.org, mattsimm...@chromium.org, core-web-vita...@chromium.org, zhangwenyu+watch...@google.com, feature-v...@chromium.org, mercer...@google.com, oshima...@chromium.org, tote-eng...@google.com, philli...@chromium.org, tracing...@chromium.org, liu+wa...@chromium.org, cc-...@chromium.org, trewin...@google.com, aleventh...@chromium.org, marinacio...@chromium.org, jimmyxgong+wat...@chromium.org, webauthn...@chromium.org, dcheng+c...@chromium.org, chadduffin+wa...@chromium.org, hansberry+wat...@chromium.org, jackshira+wa...@google.com, jackshira+w...@google.com, hansberry+wa...@chromium.org, michaelcheco+watch-i...@google.com, mkwst+w...@chromium.org, translat...@chromium.org, emi...@google.com, grt+...@chromium.org, eugeni...@chromium.org, jonmann+watc...@chromium.org, rousla...@chromium.org, xinghui...@chromium.org, srahim...@chromium.org, yhanada+...@chromium.org, agriev...@chromium.org, joeantonetti+...@google.com, jz...@chromium.org, asvitki...@chromium.org, olka+...@chromium.org, jeffreycohen+watc...@chromium.org, yusufo...@chromium.org, dougste...@chromium.org, android-web...@chromium.org, arc-review...@google.com, gogerald+pa...@chromium.org, nickdiego+wa...@igalia.com, twelling...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, arthursonzog...@chromium.org, ryanchu...@chromium.org, akingsb+wat...@google.com, loading-re...@chromium.org, gogeral...@chromium.org, petewi...@chromium.org, vinnypersky+...@google.com, giovax...@chromium.org, glider...@chromium.org, christia...@chromium.org, telemetr...@chromium.org, gavinp...@chromium.org, odejesu...@chromium.org, vaapi-...@chromium.org, dewitt...@chromium.org, marq+...@chromium.org, blink-re...@chromium.org, ajayramamurth...@google.com, lighthouse-eng-extern...@google.com, mcasas+med...@chromium.org, tranbaod...@chromium.org, jasonrobe...@google.com, dmurph+watchin...@chromium.org, ajayramamurthy+w...@google.com, wnwen...@chromium.org, caitkp...@chromium.org, dmurph+watc...@chromium.org, shannc...@chromium.org, apaselti...@chromium.org, ios-revie...@chromium.org, alandin...@chromium.org, jessemcke...@google.com, ender...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, mbarowsky+watc...@chromium.org, osaul+aut...@google.com, josiah...@chromium.org, dtapuska+...@chromium.org, gayane...@chromium.org, blink-rev...@chromium.org, jhawkins+...@google.com, yongshun+...@google.com, antoniosartori+wa...@chromium.org, scheduler...@chromium.org, speed-metrics...@chromium.org, michaelcheco+...@google.com, webapks-...@chromium.org, zhangwen...@google.com, cros-enterpris...@chromium.org, djacob...@chromium.org, eme-r...@chromium.org, xiangdongkong+...@google.com, ashleynewson+w...@chromium.org, pushi+watc...@google.com, chrome-tab-group-en...@google.com, hansenmichael...@google.com, fgal...@chromium.org, zhangwenyu+dia...@google.com, torne...@chromium.org, yhanada+...@chromium.org, zelin+watch-we...@chromium.org, glazuno...@chromium.org, wfh+...@chromium.org, mac-r...@chromium.org, cwalle...@chromium.org, dmurph+wa...@chromium.org, ukai+...@chromium.org, rhalava...@chromium.org, navigation...@chromium.org, pasko...@chromium.org, milicau+watchlis...@google.com, michaelcheco+watc...@google.com, droger+w...@chromium.org, rouslan+...@chromium.org, chromium-...@engflow.com, ozone-...@chromium.org, media-cro...@chromium.org, ios-web-view...@google.com, net-r...@chromium.org, shimazu...@chromium.org, blink-work...@chromium.org, ramyagopa...@google.com, fuzzin...@chromium.org, ios-r...@chromium.org, jiajunz+wa...@google.com, npnavarro+p...@chromium.org, michaelcheco+di...@google.com, jbroma...@chromium.org, jimmyxgong+watch...@chromium.org, csharris...@chromium.org, mgiuca...@chromium.org, prerenderi...@chromium.org, loyso...@chromium.org, cros-ed...@google.com, blink-revie...@chromium.org, mar...@chromium.org, julietlevesque...@google.com, jonmann+wa...@chromium.org, gab+...@chromium.org, kaklilu+watch-...@chromium.org, jackshira+wa...@google.com, michaelcheco+wa...@google.com, penghu...@chromium.org, khorimoto+wa...@chromium.org, francisjp...@google.com, drott+bl...@chromium.org, dtseng+c...@chromium.org, pmonett...@chromium.org, croissant-...@chromium.org, gcasto+w...@chromium.org, jshin...@chromium.org, lizeb+watch...@chromium.org, yuzo+...@chromium.org, fserb...@chromium.org, donnd...@chromium.org, emircan+watch...@chromium.org, nicolas...@chromium.org, kyungjunle...@google.com, hayato...@chromium.org, jimmyxgong+f...@chromium.org, crisrael+wa...@google.com, suetfei+wa...@google.com, twifka...@chromium.org, jdeblas...@chromium.org, bartek...@chromium.org, apavlo...@chromium.org, anastas...@google.com, ashleydp+watch-...@google.com, hanxi...@chromium.org, print-rev...@chromium.org, ajayramamurt...@google.com
Attention needed from Alison Gale, David Pennington and Jay Kapadia

Tom Lukaszewicz voted and added 1 comment

Votes added by Tom Lukaszewicz

Code-Review+1

1 comment

Patchset-level comments
Tom Lukaszewicz . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Alison Gale
  • David Pennington
  • Jay Kapadia
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
Gerrit-Attention: Alison Gale <ag...@chromium.org>
Gerrit-Attention: David Pennington <dpen...@chromium.org>
Gerrit-Attention: Jay Kapadia <jaykap...@gmail.com>
Gerrit-Comment-Date: Sun, 27 Jul 2025 18:41:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

David Pennington (Gerrit)

unread,
Jul 28, 2025, 12:10:22 PMJul 28
to Jay Kapadia, Tom Lukaszewicz, Mathias Bynens, Peter Collingbourne, Yoav Weiss (@Shopify), ningxin hu, Hans Wennborg, Mirko Bonadei, Raphael Kubo da Costa, Arnaud Mandy, Robert Kroeger, Rijubrata Bhaumik, Kevin Babbitt, Ilya Biryukov, Nate Chapin, Fredrik Söderquist, Andrew Williams, Wanming Lin, Thiabaud Engelbrecht, Alex Keng, Christian Biesinger, Kaan Icer, Alexis Menard, Peter Williamson, Kentaro Hara, Andrew Rayskiy, Kenneth Rohde Christiansen, Kevin McNee, Jiewei Qian, Nikhil Nayunigari, Mike Taylor, Sam Zackrisson, Peter Beverloo, Reid Kleckner, Ale Bzk, Hiroki Nakagawa, Luna Lu, Ryan Sultanem, Sadrul Chowdhury, Xida Chen, Zijie He, Ian Vollick, Jerome Jiang, Lei Zhang, (Julie)Jeongeun Kim, Dustin Mitchell, srirama chandra sekhar, Simon Hangl, David Bokan, Kenneth R Christiansen, Hongchan Choi, Enterprise Policy Reviews, Urvang Joshi, Daniel Andersson, Tommy Li, Olga Gerchikov, Nico Weber, Sarah Krakowiak, James Maclean, Chromium Metrics Reviews, Per Åhgren, Javier Fernandez, Daniel Cheng, Victor Tan, Hirokazu Honda, Stephen Chenney, Dirk Schulze, James Su, Wei4 Wang, David Worsham, AyeAye, AyeAye Python Dispatcher, Alison Gale, Daniel Soromou, Chromium LUCI CQ, chromium...@chromium.org, knollr+wat...@chromium.org, cros-setti...@google.com, lucasrada...@google.com, cambickel+watch-shor...@google.com, mfoltz...@chromium.org, network-ser...@chromium.org, shend...@chromium.org, sp...@chromium.org, yyhyyh+fee...@google.com, dibyapal+wa...@chromium.org, kenjibah...@chromium.org, thegreenf...@chromium.org, crmulli...@chromium.org, hansberry+w...@chromium.org, wangdanny+watch-in...@google.com, wychen...@chromium.org, asvitkine...@chromium.org, zol...@webkit.org, spang...@chromium.org, mdjone...@chromium.org, aleventhal...@chromium.org, dimich...@chromium.org, rsesek...@chromium.org, shuche...@chromium.org, cros-report...@google.com, ortuno+w...@chromium.org, kinuko+...@chromium.org, chromium-a...@chromium.org, kouhe...@chromium.org, siyua+aut...@chromium.org, steimel+watch...@chromium.org, lcwu+...@chromium.org, gavin...@chromium.org, web-schedulin...@chromium.org, pdf-r...@chromium.org, nwoked...@chromium.org, katie...@chromium.org, roblia...@chromium.org, mbarowsky+watc...@chromium.org, jackshira+wa...@google.com, fenced-fra...@chromium.org, mickeybu...@chromium.org, dmurph+wat...@chromium.org, crisrael+w...@google.com, hansberry+wa...@chromium.org, khorimoto+w...@chromium.org, yfriedm...@chromium.org, chikamu...@chromium.org, blink-revie...@chromium.org, gavindodd+watch-...@google.com, servicewor...@chromium.org, gavinwill+watch-...@chromium.org, gavinwill+dia...@chromium.org, crost...@chromium.org, dmurph+watch...@chromium.org, longbowei+fe...@google.com, creis...@chromium.org, browser-comp...@chromium.org, gavinp+p...@chromium.org, jinsukk...@chromium.org, headless...@chromium.org, rkgibso...@chromium.org, scheduler-...@chromium.org, kouhei...@chromium.org, chromeos-gfx-...@google.com, hansberry+wa...@chromium.org, horo+...@chromium.org, svend+w...@chromium.org, blink-revi...@chromium.org, tbarzi...@chromium.org, wangdanny+fe...@google.com, tommyw+w...@chromium.org, gangwu...@chromium.org, aakalla...@chromium.org, feature-me...@chromium.org, jbrom...@chromium.org, gavin...@chromium.org, chasej...@chromium.org, ashleydp+fe...@google.com, ejcaruso+wa...@chromium.org, kinuko...@chromium.org, bcb+watch-pl...@chromium.org, ajayramamurthy...@google.com, oilpan-rev...@chromium.org, jophba...@chromium.org, armalhotra+a...@google.com, toyosh...@chromium.org, andreaor...@chromium.org, ntp-dev...@chromium.org, zhangwenyu+f...@google.com, njeunje+...@chromium.org, moqati-team+chr...@google.com, dtapuska+ch...@chromium.org, enne...@chromium.org, kainin...@chromium.org, druber...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, max+watc...@igalia.com, halliwe...@chromium.org, joeantonetti+wa...@google.com, sky+...@chromium.org, ashleydp+diag...@google.com, yuezhang...@chromium.org, chili...@chromium.org, chfreme...@chromium.org, jmedle...@chromium.org, rsleev...@chromium.org, eric.c...@apple.com, vasilii+watchlis...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, rlp+...@chromium.org, cbe-cep-eng...@google.com, stevenjb+wa...@chromium.org, jackshira+w...@google.com, nikhilcn+wat...@google.com, rginda...@chromium.org, loading-rev...@chromium.org, crostin...@chromium.org, yhiran...@chromium.org, vsavu...@google.com, iclella...@chromium.org, loading...@chromium.org, yhanad...@chromium.org, chrome-intelligence-te...@google.com, bfcach...@chromium.org, performance-m...@chromium.org, hiroshig...@chromium.org, yigu+...@chromium.org, nona+...@chromium.org, pushi+wat...@google.com, shimazu+se...@chromium.org, npm+...@chromium.org, antoniosarto...@chromium.org, hsuregan+wa...@chromium.org, blink-re...@chromium.org, peter+watch...@chromium.org, lizeb...@chromium.org, dominicc+...@chromium.org, fmalit...@chromium.org, cambickel...@google.com, niharm...@google.com, chrome-waff...@google.com, tluk+...@chromium.org, blink-rev...@chromium.org, xlythe+wa...@google.com, rmcelra...@chromium.org, drott...@chromium.org, shgar+aut...@google.com, dom+...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, ananyasee...@google.com, devtools...@chromium.org, michaelcheco+...@google.com, keithle...@chromium.org, crisrael+...@google.com, silv...@chromium.org, yhanada...@chromium.org, estali...@chromium.org, kuragin+web-ap...@chromium.org, phoglun...@chromium.org, rrsilva+wat...@google.com, bmcquad...@chromium.org, cambickel+watc...@google.com, cros-essential...@chromium.org, devtools-re...@chromium.org, jkeitel+watch-...@google.com, longbowei+watc...@google.com, mreichhoff+watc...@chromium.org, speed-metr...@chromium.org, chadduffin+w...@chromium.org, jonmann+wat...@chromium.org, chromeos-kio...@google.com, blink-rev...@chromium.org, kinuko+ser...@chromium.org, fgorsk...@chromium.org, toshikikikuch...@chromium.org, jimmyxgong+w...@chromium.org, dmurph+watch...@chromium.org, fuchsia...@chromium.org, gavinp...@chromium.org, dtraino...@chromium.org, dkrahn...@chromium.org, cfredri...@chromium.org, webap...@microsoft.com, zackha...@chromium.org, blink-isola...@chromium.org, ffred...@chromium.org, gl...@chromium.org, language...@chromium.org, iwells...@chromium.org, rouslan+au...@chromium.org, bici...@google.com, subresource-f...@chromium.org, jonmann+w...@chromium.org, hsuregan+wat...@chromium.org, mschillaci...@google.com, dclasson+w...@google.com, edgesto...@microsoft.com, chromotin...@chromium.org, dmurph+watching...@chromium.org, cros-print...@google.com, dfried...@chromium.org, sloboda...@chromium.org, ydago...@chromium.org, blink-reviews-p...@chromium.org, jimmyxgong+watch-shor...@chromium.org, longbowei+watch-shor...@google.com, mattreyno...@chromium.org, lize...@chromium.org, blink-revie...@chromium.org, jdonnel...@chromium.org, davidj...@chromium.org, siashah+au...@chromium.org, hidehik...@chromium.org, cblume...@chromium.org, omnibox-...@chromium.org, ayman...@chromium.org, dtseng...@chromium.org, jdh+wa...@chromium.org, yyhyyh+watch-inpu...@google.com, asumane...@google.com, nyquis...@chromium.org, media-wi...@chromium.org, ricea...@chromium.org, video-networking...@google.com, hirokisa...@chromium.org, harringt...@chromium.org, nator...@chromium.org, stanfie...@google.com, msrame...@chromium.org, lens-chrome...@google.com, blink-revi...@chromium.org, hashimo...@chromium.org, jbauma...@chromium.org, vscode...@chromium.org, martijn...@martijnc.be, michaelchec...@google.com, dmurph+watchi...@chromium.org, dullweb...@chromium.org, tgupta...@chromium.org, gavindodd+dia...@google.com, filesapp...@chromium.org, nektar...@chromium.org, erickun...@chromium.org, jiajunz+wat...@google.com, danakj...@chromium.org, jorgel...@chromium.org, ddrone...@google.com, core-timi...@chromium.org, kouhe...@chromium.org, chrome-gr...@chromium.org, meilian...@chromium.org, tmartino+tran...@chromium.org, tbansal+...@chromium.org, ajwong...@chromium.org, extension...@chromium.org, scheduler-b...@chromium.org, rayanka...@chromium.org, dfalcant...@chromium.org, cambickel+fe...@google.com, hais+wat...@google.com, kinuko...@chromium.org, rainhar...@chromium.org, marimatthew+watc...@google.com, crisrael+wa...@google.com, pdr+svgw...@chromium.org, zhangwenyu+wat...@google.com, khmel...@chromium.org, ios-rev...@chromium.org, mtomas...@chromium.org, roagarw...@chromium.org, pushi+wa...@google.com, tburkar...@chromium.org, pkotwic...@chromium.org, abigailbk...@google.com, amaliev+...@chromium.org, lingqi...@chromium.org, mpdento...@chromium.org, gavinwill+sc...@chromium.org, minap+watch-p...@google.com, permissio...@chromium.org, chromeos-ca...@google.com, loading-rev...@chromium.org, tedcho...@chromium.org, jackshira+...@google.com, vakh+safe_br...@chromium.org, geoffla...@chromium.org, cwp-review...@google.com, andysjl...@chromium.org, peilinwa...@google.com, chrome-b...@google.com, ajayramamurthy...@google.com, chrome-intell...@chromium.org, lwinston+watc...@google.com, cblum...@chromium.org, jackshira+wat...@google.com, security-...@chromium.org, chlily...@chromium.org, penghuan...@chromium.org, mattsimm...@chromium.org, core-web-vita...@chromium.org, zhangwenyu+watch...@google.com, feature-v...@chromium.org, mercer...@google.com, oshima...@chromium.org, tote-eng...@google.com, philli...@chromium.org, tracing...@chromium.org, liu+wa...@chromium.org, cc-...@chromium.org, trewin...@google.com, aleventh...@chromium.org, marinacio...@chromium.org, jimmyxgong+wat...@chromium.org, webauthn...@chromium.org, dcheng+c...@chromium.org, chadduffin+wa...@chromium.org, hansberry+wat...@chromium.org, jackshira+wa...@google.com, jackshira+w...@google.com, hansberry+wa...@chromium.org, michaelcheco+watch-i...@google.com, mkwst+w...@chromium.org, translat...@chromium.org, emi...@google.com, grt+...@chromium.org, eugeni...@chromium.org, jonmann+watc...@chromium.org, rousla...@chromium.org, xinghui...@chromium.org, srahim...@chromium.org, yhanada+...@chromium.org, agriev...@chromium.org, joeantonetti+...@google.com, jz...@chromium.org, asvitki...@chromium.org, olka+...@chromium.org, jeffreycohen+watc...@chromium.org, yusufo...@chromium.org, dougste...@chromium.org, android-web...@chromium.org, arc-review...@google.com, gogerald+pa...@chromium.org, nickdiego+wa...@igalia.com, twelling...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, arthursonzog...@chromium.org, ryanchu...@chromium.org, akingsb+wat...@google.com, loading-re...@chromium.org, gogeral...@chromium.org, petewi...@chromium.org, vinnypersky+...@google.com, giovax...@chromium.org, glider...@chromium.org, christia...@chromium.org, telemetr...@chromium.org, gavinp...@chromium.org, odejesu...@chromium.org, vaapi-...@chromium.org, dewitt...@chromium.org, marq+...@chromium.org, blink-re...@chromium.org, ajayramamurth...@google.com, lighthouse-eng-extern...@google.com, mcasas+med...@chromium.org, tranbaod...@chromium.org, jasonrobe...@google.com, dmurph+watchin...@chromium.org, ajayramamurthy+w...@google.com, wnwen...@chromium.org, caitkp...@chromium.org, dmurph+watc...@chromium.org, shannc...@chromium.org, apaselti...@chromium.org, ios-revie...@chromium.org, alandin...@chromium.org, jessemcke...@google.com, ender...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, mbarowsky+watc...@chromium.org, osaul+aut...@google.com, josiah...@chromium.org, dtapuska+...@chromium.org, gayane...@chromium.org, blink-rev...@chromium.org, jhawkins+...@google.com, yongshun+...@google.com, antoniosartori+wa...@chromium.org, scheduler...@chromium.org, speed-metrics...@chromium.org, michaelcheco+...@google.com, webapks-...@chromium.org, zhangwen...@google.com, cros-enterpris...@chromium.org, djacob...@chromium.org, eme-r...@chromium.org, xiangdongkong+...@google.com, ashleynewson+w...@chromium.org, pushi+watc...@google.com, chrome-tab-group-en...@google.com, hansenmichael...@google.com, fgal...@chromium.org, zhangwenyu+dia...@google.com, torne...@chromium.org, yhanada+...@chromium.org, zelin+watch-we...@chromium.org, glazuno...@chromium.org, wfh+...@chromium.org, mac-r...@chromium.org, cwalle...@chromium.org, dmurph+wa...@chromium.org, ukai+...@chromium.org, rhalava...@chromium.org, navigation...@chromium.org, pasko...@chromium.org, milicau+watchlis...@google.com, michaelcheco+watc...@google.com, droger+w...@chromium.org, rouslan+...@chromium.org, chromium-...@engflow.com, ozone-...@chromium.org, media-cro...@chromium.org, ios-web-view...@google.com, net-r...@chromium.org, shimazu...@chromium.org, blink-work...@chromium.org, ramyagopa...@google.com, fuzzin...@chromium.org, ios-r...@chromium.org, jiajunz+wa...@google.com, npnavarro+p...@chromium.org, michaelcheco+di...@google.com, jbroma...@chromium.org, jimmyxgong+watch...@chromium.org, csharris...@chromium.org, mgiuca...@chromium.org, prerenderi...@chromium.org, loyso...@chromium.org, cros-ed...@google.com, blink-revie...@chromium.org, mar...@chromium.org, julietlevesque...@google.com, jonmann+wa...@chromium.org, gab+...@chromium.org, kaklilu+watch-...@chromium.org, jackshira+wa...@google.com, michaelcheco+wa...@google.com, penghu...@chromium.org, khorimoto+wa...@chromium.org, francisjp...@google.com, drott+bl...@chromium.org, dtseng+c...@chromium.org, pmonett...@chromium.org, croissant-...@chromium.org, gcasto+w...@chromium.org, jshin...@chromium.org, lizeb+watch...@chromium.org, yuzo+...@chromium.org, fserb...@chromium.org, donnd...@chromium.org, emircan+watch...@chromium.org, nicolas...@chromium.org, kyungjunle...@google.com, hayato...@chromium.org, jimmyxgong+f...@chromium.org, crisrael+wa...@google.com, suetfei+wa...@google.com, twifka...@chromium.org, jdeblas...@chromium.org, bartek...@chromium.org, apavlo...@chromium.org, anastas...@google.com, ashleydp+watch-...@google.com, hanxi...@chromium.org, print-rev...@chromium.org, ajayramamurt...@google.com
Attention needed from Alison Gale and Jay Kapadia

David Pennington voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alison Gale
  • Jay Kapadia
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Gerrit-Attention: Jay Kapadia <jaykap...@gmail.com>
    Gerrit-Comment-Date: Mon, 28 Jul 2025 16:10:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Alison Gale (Gerrit)

    unread,
    Jul 28, 2025, 2:51:28 PMJul 28
    to Jay Kapadia, David Pennington, Tom Lukaszewicz, Mathias Bynens, Peter Collingbourne, Yoav Weiss (@Shopify), ningxin hu, Hans Wennborg, Mirko Bonadei, Raphael Kubo da Costa, Arnaud Mandy, Robert Kroeger, Rijubrata Bhaumik, Kevin Babbitt, Ilya Biryukov, Nate Chapin, Fredrik Söderquist, Andrew Williams, Wanming Lin, Thiabaud Engelbrecht, Alex Keng, Christian Biesinger, Kaan Icer, Alexis Menard, Peter Williamson, Kentaro Hara, Andrew Rayskiy, Kenneth Rohde Christiansen, Kevin McNee, Jiewei Qian, Nikhil Nayunigari, Mike Taylor, Sam Zackrisson, Peter Beverloo, Reid Kleckner, Ale Bzk, Hiroki Nakagawa, Luna Lu, Ryan Sultanem, Sadrul Chowdhury, Xida Chen, Zijie He, Ian Vollick, Jerome Jiang, Lei Zhang, (Julie)Jeongeun Kim, Dustin Mitchell, srirama chandra sekhar, Simon Hangl, David Bokan, Kenneth R Christiansen, Hongchan Choi, Enterprise Policy Reviews, Urvang Joshi, Daniel Andersson, Tommy Li, Olga Gerchikov, Nico Weber, Sarah Krakowiak, James Maclean, Chromium Metrics Reviews, Per Åhgren, Javier Fernandez, Daniel Cheng, Victor Tan, Hirokazu Honda, Stephen Chenney, Dirk Schulze, James Su, Wei4 Wang, David Worsham, AyeAye, AyeAye Python Dispatcher, Daniel Soromou, Chromium LUCI CQ, chromium...@chromium.org, knollr+wat...@chromium.org, cros-setti...@google.com, lucasrada...@google.com, cambickel+watch-shor...@google.com, mfoltz...@chromium.org, network-ser...@chromium.org, shend...@chromium.org, sp...@chromium.org, yyhyyh+fee...@google.com, dibyapal+wa...@chromium.org, kenjibah...@chromium.org, thegreenf...@chromium.org, crmulli...@chromium.org, hansberry+w...@chromium.org, wangdanny+watch-in...@google.com, wychen...@chromium.org, asvitkine...@chromium.org, zol...@webkit.org, spang...@chromium.org, mdjone...@chromium.org, aleventhal...@chromium.org, dimich...@chromium.org, rsesek...@chromium.org, shuche...@chromium.org, cros-report...@google.com, ortuno+w...@chromium.org, kinuko+...@chromium.org, chromium-a...@chromium.org, kouhe...@chromium.org, siyua+aut...@chromium.org, steimel+watch...@chromium.org, lcwu+...@chromium.org, gavin...@chromium.org, web-schedulin...@chromium.org, pdf-r...@chromium.org, nwoked...@chromium.org, katie...@chromium.org, roblia...@chromium.org, mbarowsky+watc...@chromium.org, jackshira+wa...@google.com, fenced-fra...@chromium.org, mickeybu...@chromium.org, dmurph+wat...@chromium.org, crisrael+w...@google.com, hansberry+wa...@chromium.org, khorimoto+w...@chromium.org, yfriedm...@chromium.org, chikamu...@chromium.org, blink-revie...@chromium.org, gavindodd+watch-...@google.com, servicewor...@chromium.org, gavinwill+watch-...@chromium.org, gavinwill+dia...@chromium.org, crost...@chromium.org, dmurph+watch...@chromium.org, longbowei+fe...@google.com, creis...@chromium.org, browser-comp...@chromium.org, gavinp+p...@chromium.org, jinsukk...@chromium.org, headless...@chromium.org, rkgibso...@chromium.org, scheduler-...@chromium.org, kouhei...@chromium.org, chromeos-gfx-...@google.com, hansberry+wa...@chromium.org, horo+...@chromium.org, svend+w...@chromium.org, blink-revi...@chromium.org, tbarzi...@chromium.org, wangdanny+fe...@google.com, tommyw+w...@chromium.org, gangwu...@chromium.org, aakalla...@chromium.org, feature-me...@chromium.org, jbrom...@chromium.org, gavin...@chromium.org, chasej...@chromium.org, ashleydp+fe...@google.com, ejcaruso+wa...@chromium.org, kinuko...@chromium.org, bcb+watch-pl...@chromium.org, ajayramamurthy...@google.com, oilpan-rev...@chromium.org, jophba...@chromium.org, armalhotra+a...@google.com, toyosh...@chromium.org, andreaor...@chromium.org, ntp-dev...@chromium.org, zhangwenyu+f...@google.com, njeunje+...@chromium.org, moqati-team+chr...@google.com, dtapuska+ch...@chromium.org, enne...@chromium.org, kainin...@chromium.org, druber...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, max+watc...@igalia.com, halliwe...@chromium.org, joeantonetti+wa...@google.com, sky+...@chromium.org, ashleydp+diag...@google.com, yuezhang...@chromium.org, chili...@chromium.org, chfreme...@chromium.org, jmedle...@chromium.org, rsleev...@chromium.org, eric.c...@apple.com, vasilii+watchlis...@chromium.org, bnc+...@chromium.org, cblume+im...@chromium.org, rlp+...@chromium.org, cbe-cep-eng...@google.com, stevenjb+wa...@chromium.org, jackshira+w...@google.com, nikhilcn+wat...@google.com, rginda...@chromium.org, loading-rev...@chromium.org, crostin...@chromium.org, yhiran...@chromium.org, vsavu...@google.com, iclella...@chromium.org, loading...@chromium.org, yhanad...@chromium.org, chrome-intelligence-te...@google.com, bfcach...@chromium.org, performance-m...@chromium.org, hiroshig...@chromium.org, yigu+...@chromium.org, nona+...@chromium.org, pushi+wat...@google.com, shimazu+se...@chromium.org, npm+...@chromium.org, antoniosarto...@chromium.org, hsuregan+wa...@chromium.org, blink-re...@chromium.org, peter+watch...@chromium.org, lizeb...@chromium.org, dominicc+...@chromium.org, fmalit...@chromium.org, cambickel...@google.com, niharm...@google.com, chrome-waff...@google.com, tluk+...@chromium.org, blink-rev...@chromium.org, xlythe+wa...@google.com, rmcelra...@chromium.org, drott...@chromium.org, shgar+aut...@google.com, dom+...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, ananyasee...@google.com, devtools...@chromium.org, michaelcheco+...@google.com, keithle...@chromium.org, crisrael+...@google.com, silv...@chromium.org, yhanada...@chromium.org, estali...@chromium.org, kuragin+web-ap...@chromium.org, phoglun...@chromium.org, rrsilva+wat...@google.com, bmcquad...@chromium.org, cambickel+watc...@google.com, cros-essential...@chromium.org, devtools-re...@chromium.org, jkeitel+watch-...@google.com, longbowei+watc...@google.com, mreichhoff+watc...@chromium.org, speed-metr...@chromium.org, chadduffin+w...@chromium.org, jonmann+wat...@chromium.org, chromeos-kio...@google.com, blink-rev...@chromium.org, kinuko+ser...@chromium.org, fgorsk...@chromium.org, toshikikikuch...@chromium.org, jimmyxgong+w...@chromium.org, dmurph+watch...@chromium.org, fuchsia...@chromium.org, gavinp...@chromium.org, dtraino...@chromium.org, dkrahn...@chromium.org, cfredri...@chromium.org, webap...@microsoft.com, zackha...@chromium.org, blink-isola...@chromium.org, ffred...@chromium.org, gl...@chromium.org, language...@chromium.org, iwells...@chromium.org, rouslan+au...@chromium.org, bici...@google.com, subresource-f...@chromium.org, jonmann+w...@chromium.org, hsuregan+wat...@chromium.org, mschillaci...@google.com, dclasson+w...@google.com, edgesto...@microsoft.com, chromotin...@chromium.org, dmurph+watching...@chromium.org, cros-print...@google.com, dfried...@chromium.org, sloboda...@chromium.org, ydago...@chromium.org, blink-reviews-p...@chromium.org, jimmyxgong+watch-shor...@chromium.org, longbowei+watch-shor...@google.com, mattreyno...@chromium.org, lize...@chromium.org, blink-revie...@chromium.org, jdonnel...@chromium.org, davidj...@chromium.org, siashah+au...@chromium.org, hidehik...@chromium.org, cblume...@chromium.org, omnibox-...@chromium.org, ayman...@chromium.org, dtseng...@chromium.org, jdh+wa...@chromium.org, yyhyyh+watch-inpu...@google.com, asumane...@google.com, nyquis...@chromium.org, media-wi...@chromium.org, ricea...@chromium.org, video-networking...@google.com, hirokisa...@chromium.org, harringt...@chromium.org, nator...@chromium.org, stanfie...@google.com, msrame...@chromium.org, lens-chrome...@google.com, blink-revi...@chromium.org, hashimo...@chromium.org, jbauma...@chromium.org, vscode...@chromium.org, martijn...@martijnc.be, michaelchec...@google.com, dmurph+watchi...@chromium.org, dullweb...@chromium.org, tgupta...@chromium.org, gavindodd+dia...@google.com, filesapp...@chromium.org, nektar...@chromium.org, erickun...@chromium.org, jiajunz+wat...@google.com, danakj...@chromium.org, jorgel...@chromium.org, ddrone...@google.com, core-timi...@chromium.org, kouhe...@chromium.org, chrome-gr...@chromium.org, meilian...@chromium.org, tmartino+tran...@chromium.org, tbansal+...@chromium.org, ajwong...@chromium.org, extension...@chromium.org, scheduler-b...@chromium.org, rayanka...@chromium.org, dfalcant...@chromium.org, cambickel+fe...@google.com, hais+wat...@google.com, kinuko...@chromium.org, rainhar...@chromium.org, marimatthew+watc...@google.com, crisrael+wa...@google.com, pdr+svgw...@chromium.org, zhangwenyu+wat...@google.com, khmel...@chromium.org, ios-rev...@chromium.org, mtomas...@chromium.org, roagarw...@chromium.org, pushi+wa...@google.com, tburkar...@chromium.org, pkotwic...@chromium.org, abigailbk...@google.com, amaliev+...@chromium.org, lingqi...@chromium.org, mpdento...@chromium.org, gavinwill+sc...@chromium.org, minap+watch-p...@google.com, permissio...@chromium.org, chromeos-ca...@google.com, loading-rev...@chromium.org, tedcho...@chromium.org, jackshira+...@google.com, vakh+safe_br...@chromium.org, geoffla...@chromium.org, cwp-review...@google.com, andysjl...@chromium.org, peilinwa...@google.com, chrome-b...@google.com, ajayramamurthy...@google.com, chrome-intell...@chromium.org, lwinston+watc...@google.com, cblum...@chromium.org, jackshira+wat...@google.com, security-...@chromium.org, chlily...@chromium.org, penghuan...@chromium.org, mattsimm...@chromium.org, core-web-vita...@chromium.org, zhangwenyu+watch...@google.com, feature-v...@chromium.org, mercer...@google.com, oshima...@chromium.org, tote-eng...@google.com, philli...@chromium.org, tracing...@chromium.org, liu+wa...@chromium.org, cc-...@chromium.org, trewin...@google.com, aleventh...@chromium.org, marinacio...@chromium.org, jimmyxgong+wat...@chromium.org, webauthn...@chromium.org, dcheng+c...@chromium.org, chadduffin+wa...@chromium.org, hansberry+wat...@chromium.org, jackshira+wa...@google.com, jackshira+w...@google.com, hansberry+wa...@chromium.org, michaelcheco+watch-i...@google.com, mkwst+w...@chromium.org, translat...@chromium.org, emi...@google.com, grt+...@chromium.org, eugeni...@chromium.org, jonmann+watc...@chromium.org, rousla...@chromium.org, xinghui...@chromium.org, srahim...@chromium.org, yhanada+...@chromium.org, agriev...@chromium.org, joeantonetti+...@google.com, jz...@chromium.org, asvitki...@chromium.org, olka+...@chromium.org, jeffreycohen+watc...@chromium.org, yusufo...@chromium.org, dougste...@chromium.org, android-web...@chromium.org, arc-review...@google.com, gogerald+pa...@chromium.org, nickdiego+wa...@igalia.com, twelling...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, arthursonzog...@chromium.org, ryanchu...@chromium.org, akingsb+wat...@google.com, loading-re...@chromium.org, gogeral...@chromium.org, petewi...@chromium.org, vinnypersky+...@google.com, giovax...@chromium.org, glider...@chromium.org, christia...@chromium.org, telemetr...@chromium.org, gavinp...@chromium.org, odejesu...@chromium.org, vaapi-...@chromium.org, dewitt...@chromium.org, marq+...@chromium.org, blink-re...@chromium.org, ajayramamurth...@google.com, lighthouse-eng-extern...@google.com, mcasas+med...@chromium.org, tranbaod...@chromium.org, jasonrobe...@google.com, dmurph+watchin...@chromium.org, ajayramamurthy+w...@google.com, wnwen...@chromium.org, caitkp...@chromium.org, dmurph+watc...@chromium.org, shannc...@chromium.org, apaselti...@chromium.org, ios-revie...@chromium.org, alandin...@chromium.org, jessemcke...@google.com, ender...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, mbarowsky+watc...@chromium.org, osaul+aut...@google.com, josiah...@chromium.org, dtapuska+...@chromium.org, gayane...@chromium.org, blink-rev...@chromium.org, jhawkins+...@google.com, yongshun+...@google.com, antoniosartori+wa...@chromium.org, scheduler...@chromium.org, speed-metrics...@chromium.org, michaelcheco+...@google.com, webapks-...@chromium.org, zhangwen...@google.com, cros-enterpris...@chromium.org, djacob...@chromium.org, eme-r...@chromium.org, xiangdongkong+...@google.com, ashleynewson+w...@chromium.org, pushi+watc...@google.com, chrome-tab-group-en...@google.com, hansenmichael...@google.com, fgal...@chromium.org, zhangwenyu+dia...@google.com, torne...@chromium.org, yhanada+...@chromium.org, zelin+watch-we...@chromium.org, glazuno...@chromium.org, wfh+...@chromium.org, mac-r...@chromium.org, cwalle...@chromium.org, dmurph+wa...@chromium.org, ukai+...@chromium.org, rhalava...@chromium.org, navigation...@chromium.org, pasko...@chromium.org, milicau+watchlis...@google.com, michaelcheco+watc...@google.com, droger+w...@chromium.org, rouslan+...@chromium.org, chromium-...@engflow.com, ozone-...@chromium.org, media-cro...@chromium.org, ios-web-view...@google.com, net-r...@chromium.org, shimazu...@chromium.org, blink-work...@chromium.org, ramyagopa...@google.com, fuzzin...@chromium.org, ios-r...@chromium.org, jiajunz+wa...@google.com, npnavarro+p...@chromium.org, michaelcheco+di...@google.com, jbroma...@chromium.org, jimmyxgong+watch...@chromium.org, csharris...@chromium.org, mgiuca...@chromium.org, prerenderi...@chromium.org, loyso...@chromium.org, cros-ed...@google.com, blink-revie...@chromium.org, mar...@chromium.org, julietlevesque...@google.com, jonmann+wa...@chromium.org, gab+...@chromium.org, kaklilu+watch-...@chromium.org, jackshira+wa...@google.com, michaelcheco+wa...@google.com, penghu...@chromium.org, khorimoto+wa...@chromium.org, francisjp...@google.com, drott+bl...@chromium.org, dtseng+c...@chromium.org, pmonett...@chromium.org, croissant-...@chromium.org, gcasto+w...@chromium.org, jshin...@chromium.org, lizeb+watch...@chromium.org, yuzo+...@chromium.org, fserb...@chromium.org, donnd...@chromium.org, emircan+watch...@chromium.org, nicolas...@chromium.org, kyungjunle...@google.com, hayato...@chromium.org, jimmyxgong+f...@chromium.org, crisrael+wa...@google.com, suetfei+wa...@google.com, twifka...@chromium.org, jdeblas...@chromium.org, bartek...@chromium.org, apavlo...@chromium.org, anastas...@google.com, ashleydp+watch-...@google.com, hanxi...@chromium.org, print-rev...@chromium.org, ajayramamurt...@google.com
    Attention needed from Jay Kapadia

    Alison Gale voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jay Kapadia
    Gerrit-Attention: Jay Kapadia <jaykap...@gmail.com>
    Gerrit-Comment-Date: Mon, 28 Jul 2025 18:51:15 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Jay Kapadia (Gerrit)

    unread,
    Jul 29, 2025, 1:18:34 PMJul 29
    to Alison Gale, David Pennington, Tom Lukaszewicz, Mathias Bynens, Peter Collingbourne, Yoav Weiss (@Shopify), ningxin hu, Hans Wennborg, Mirko Bonadei, Raphael Kubo da Costa, Arnaud Mandy, Robert Kroeger, Rijubrata Bhaumik, Kevin Babbitt, Ilya Biryukov, Nate Chapin, Fredrik Söderquist, Andrew Williams, Wanming Lin, Thiabaud Engelbrecht, Alex Keng, Christian Biesinger, Kaan Icer, Alexis Menard, Peter Williamson, Kentaro Hara, Andrew Rayskiy, Kenneth Rohde Christiansen, Kevin McNee, Jiewei Qian, Nikhil Nayunigari, Mike Taylor, Sam Zackrisson, Peter Beverloo, Reid Kleckner, Ale Bzk, Hiroki Nakagawa, Luna Lu, Ryan Sultanem, Sadrul Chowdhury, Xida Chen, Zijie He, Ian Vollick, Jerome Jiang, Lei Zhang, (Julie)Jeongeun Kim, Dustin Mitchell, srirama chandra sekhar, Simon Hangl, David Bokan, Kenneth R Christiansen, Hongchan Choi, Enterprise Policy Reviews, Urvang Joshi, Daniel Andersson, Tommy Li, Olga Gerchikov, Nico Weber, Sarah Krakowiak, James Maclean, Chromium Metrics Reviews, Per Åhgren, Javier Fernandez, Daniel Cheng, Victor Tan, Hirokazu Honda, Stephen Chenney, Dirk Schulze, James Su, Wei4 Wang, David Worsham, AyeAye, AyeAye Python Dispatcher, Daniel Soromou, Chromium LUCI CQ, chromium...@chromium.org, knollr+wat...@chromium.org, cros-setti...@google.com, lucasrada...@google.com, cambickel+watch-shor...@google.com, mfoltz...@chromium.org, network-ser...@chromium.org, dibyapal+wa...@chromium.org, kenjibah...@chromium.org, crmulli...@chromium.org, hansberry+w...@chromium.org, asvitkine...@chromium.org, mdjone...@chromium.org, aleventhal...@chromium.org, dimich...@chromium.org, cros-report...@google.com, ortuno+w...@chromium.org, kinuko+...@chromium.org, chromium-a...@chromium.org, kouhe...@chromium.org, lcwu+...@chromium.org, gavin...@chromium.org, pdf-r...@chromium.org, nwoked...@chromium.org, katie...@chromium.org, mbarowsky+watc...@chromium.org, jackshira+wa...@google.com, fenced-fra...@chromium.org, mickeybu...@chromium.org, dmurph+wat...@chromium.org, crisrael+w...@google.com, hansberry+wa...@chromium.org, khorimoto+w...@chromium.org, chikamu...@chromium.org, blink-revie...@chromium.org, gavindodd+watch-...@google.com, gavinwill+watch-...@chromium.org, gavinwill+dia...@chromium.org, crost...@chromium.org, dmurph+watch...@chromium.org, longbowei+fe...@google.com, creis...@chromium.org, browser-comp...@chromium.org, gavinp+p...@chromium.org, jinsukk...@chromium.org, headless...@chromium.org, kouhei...@chromium.org, chromeos-gfx-...@google.com, hansberry+wa...@chromium.org, horo+...@chromium.org, blink-revi...@chromium.org, gangwu...@chromium.org, aakalla...@chromium.org, feature-me...@chromium.org, jbrom...@chromium.org, gavin...@chromium.org, chasej...@chromium.org, ashleydp+fe...@google.com, ejcaruso+wa...@chromium.org, kinuko...@chromium.org, bcb+watch-pl...@chromium.org, ajayramamurthy...@google.com, oilpan-rev...@chromium.org, jophba...@chromium.org, armalhotra+a...@google.com, andreaor...@chromium.org, ntp-dev...@chromium.org, njeunje+...@chromium.org, moqati-team+chr...@google.com, dtapuska+ch...@chromium.org, enne...@chromium.org, kainin...@chromium.org, druber...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, max+watc...@igalia.com, halliwe...@chromium.org, joeantonetti+wa...@google.com, ashleydp+diag...@google.com, chili...@chromium.org, chfreme...@chromium.org, jmedle...@chromium.org, eric.c...@apple.com, bnc+...@chromium.org, cblume+im...@chromium.org, cbe-cep-eng...@google.com, jackshira+w...@google.com, nikhilcn+wat...@google.com, loading-rev...@chromium.org, crostin...@chromium.org, iclella...@chromium.org, loading...@chromium.org, chrome-intelligence-te...@google.com, bfcach...@chromium.org, performance-m...@chromium.org, hiroshig...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, antoniosarto...@chromium.org, hsuregan+wa...@chromium.org, blink-re...@chromium.org, peter+watch...@chromium.org, lizeb...@chromium.org, dominicc+...@chromium.org, fmalit...@chromium.org, cambickel...@google.com, niharm...@google.com, chrome-waff...@google.com, blink-rev...@chromium.org, drott...@chromium.org, dom+...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, ananyasee...@google.com, devtools...@chromium.org, michaelcheco+...@google.com, keithle...@chromium.org, crisrael+...@google.com, estali...@chromium.org, kuragin+web-ap...@chromium.org, phoglun...@chromium.org, bmcquad...@chromium.org, cambickel+watc...@google.com, cros-essential...@chromium.org, devtools-re...@chromium.org, jkeitel+watch-...@google.com, longbowei+watc...@google.com, mreichhoff+watc...@chromium.org, chadduffin+w...@chromium.org, jonmann+wat...@chromium.org, chromeos-kio...@google.com, blink-rev...@chromium.org, kinuko+ser...@chromium.org, fgorsk...@chromium.org, jimmyxgong+w...@chromium.org, dmurph+watch...@chromium.org, fuchsia...@chromium.org, gavinp...@chromium.org, dtraino...@chromium.org, dkrahn...@chromium.org, cfredri...@chromium.org, blink-isola...@chromium.org, ffred...@chromium.org, gl...@chromium.org, language...@chromium.org, iwells...@chromium.org, bici...@google.com, jonmann+w...@chromium.org, hsuregan+wat...@chromium.org, mschillaci...@google.com, dclasson+w...@google.com, edgesto...@microsoft.com, chromotin...@chromium.org, dmurph+watching...@chromium.org, cros-print...@google.com, dfried...@chromium.org, blink-reviews-p...@chromium.org, jimmyxgong+watch-shor...@chromium.org, longbowei+watch-shor...@google.com, mattreyno...@chromium.org, lize...@chromium.org, blink-revie...@chromium.org, jdonnel...@chromium.org, davidj...@chromium.org, hidehik...@chromium.org, cblume...@chromium.org, omnibox-...@chromium.org, ayman...@chromium.org, dtseng...@chromium.org, jdh+wa...@chromium.org, asumane...@google.com, nyquis...@chromium.org, media-wi...@chromium.org, hirokisa...@chromium.org, harringt...@chromium.org, nator...@chromium.org, msrame...@chromium.org, lens-chrome...@google.com, blink-revi...@chromium.org, hashimo...@chromium.org, jbauma...@chromium.org, martijn...@martijnc.be, michaelchec...@google.com, dmurph+watchi...@chromium.org, dullweb...@chromium.org, gavindodd+dia...@google.com, filesapp...@chromium.org, nektar...@chromium.org, erickun...@chromium.org, jiajunz+wat...@google.com, danakj...@chromium.org, jorgel...@chromium.org, ddrone...@google.com, core-timi...@chromium.org, kouhe...@chromium.org, chrome-gr...@chromium.org, meilian...@chromium.org, ajwong...@chromium.org, extension...@chromium.org, dfalcant...@chromium.org, cambickel+fe...@google.com, hais+wat...@google.com, kinuko...@chromium.org, marimatthew+watc...@google.com, crisrael+wa...@google.com, pdr+svgw...@chromium.org, khmel...@chromium.org, ios-rev...@chromium.org, mtomas...@chromium.org, pushi+wa...@google.com, pkotwic...@chromium.org, abigailbk...@google.com, amaliev+...@chromium.org, lingqi...@chromium.org, mpdento...@chromium.org, gavinwill+sc...@chromium.org, minap+watch-p...@google.com, permissio...@chromium.org, chromeos-ca...@google.com, loading-rev...@chromium.org, jackshira+...@google.com, geoffla...@chromium.org, cwp-review...@google.com, andysjl...@chromium.org, peilinwa...@google.com, chrome-b...@google.com, ajayramamurthy...@google.com, chrome-intell...@chromium.org, lwinston+watc...@google.com, cblum...@chromium.org, jackshira+wat...@google.com, chlily...@chromium.org, penghuan...@chromium.org, mattsimm...@chromium.org, core-web-vita...@chromium.org, feature-v...@chromium.org, mercer...@google.com, oshima...@chromium.org, philli...@chromium.org, liu+wa...@chromium.org, cc-...@chromium.org, aleventh...@chromium.org, marinacio...@chromium.org, jimmyxgong+wat...@chromium.org, dcheng+c...@chromium.org, chadduffin+wa...@chromium.org, hansberry+wat...@chromium.org, jackshira+wa...@google.com, jackshira+w...@google.com, hansberry+wa...@chromium.org, michaelcheco+watch-i...@google.com, mkwst+w...@chromium.org, emi...@google.com, grt+...@chromium.org, eugeni...@chromium.org, jonmann+watc...@chromium.org, agriev...@chromium.org, joeantonetti+...@google.com, jz...@chromium.org, asvitki...@chromium.org, olka+...@chromium.org, jeffreycohen+watc...@chromium.org, dougste...@chromium.org, android-web...@chromium.org, arc-review...@google.com, gogerald+pa...@chromium.org, nickdiego+wa...@igalia.com, blink-re...@chromium.org, blink-...@chromium.org, arthursonzog...@chromium.org, akingsb+wat...@google.com, loading-re...@chromium.org, gogeral...@chromium.org, petewi...@chromium.org, giovax...@chromium.org, glider...@chromium.org, christia...@chromium.org, gavinp...@chromium.org, odejesu...@chromium.org, dewitt...@chromium.org, marq+...@chromium.org, blink-re...@chromium.org, ajayramamurth...@google.com, lighthouse-eng-extern...@google.com, mcasas+med...@chromium.org, jasonrobe...@google.com, dmurph+watchin...@chromium.org, ajayramamurthy+w...@google.com, caitkp...@chromium.org, dmurph+watc...@chromium.org, apaselti...@chromium.org, ios-revie...@chromium.org, alandin...@chromium.org, jessemcke...@google.com, ender...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, mbarowsky+watc...@chromium.org, osaul+aut...@google.com, josiah...@chromium.org, dtapuska+...@chromium.org, gayane...@chromium.org, blink-rev...@chromium.org, jhawkins+...@google.com, antoniosartori+wa...@chromium.org, michaelcheco+...@google.com, cros-enterpris...@chromium.org, djacob...@chromium.org, eme-r...@chromium.org, ashleynewson+w...@chromium.org, chrome-tab-group-en...@google.com, hansenmichael...@google.com, fgal...@chromium.org, glazuno...@chromium.org, mac-r...@chromium.org, cwalle...@chromium.org, dmurph+wa...@chromium.org, navigation...@chromium.org, pasko...@chromium.org, milicau+watchlis...@google.com, michaelcheco+watc...@google.com, droger+w...@chromium.org, chromium-...@engflow.com, ozone-...@chromium.org, media-cro...@chromium.org, ios-web-view...@google.com, net-r...@chromium.org, blink-work...@chromium.org, fuzzin...@chromium.org, ios-r...@chromium.org, jiajunz+wa...@google.com, npnavarro+p...@chromium.org, michaelcheco+di...@google.com, jbroma...@chromium.org, jimmyxgong+watch...@chromium.org, csharris...@chromium.org, mgiuca...@chromium.org, prerenderi...@chromium.org, loyso...@chromium.org, cros-ed...@google.com, blink-revie...@chromium.org, mar...@chromium.org, julietlevesque...@google.com, jonmann+wa...@chromium.org, gab+...@chromium.org, kaklilu+watch-...@chromium.org, jackshira+wa...@google.com, michaelcheco+wa...@google.com, penghu...@chromium.org, khorimoto+wa...@chromium.org, francisjp...@google.com, drott+bl...@chromium.org, dtseng+c...@chromium.org, pmonett...@chromium.org, croissant-...@chromium.org, gcasto+w...@chromium.org, jshin...@chromium.org, lizeb+watch...@chromium.org, fserb...@chromium.org, donnd...@chromium.org, emircan+watch...@chromium.org, nicolas...@chromium.org, kyungjunle...@google.com, hayato...@chromium.org, jimmyxgong+f...@chromium.org, crisrael+wa...@google.com, jdeblas...@chromium.org, bartek...@chromium.org, apavlo...@chromium.org, anastas...@google.com, ashleydp+watch-...@google.com, hanxi...@chromium.org, print-rev...@chromium.org, ajayramamurt...@google.com

    Jay Kapadia voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If8405c7213cdea536779a2ba64a46016d466c96a
    Gerrit-Change-Number: 6669514
    Gerrit-PatchSet: 31
    Gerrit-Comment-Date: Tue, 29 Jul 2025 17:17:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Andrew Paseltiner (Gerrit)

    unread,
    Jul 29, 2025, 1:19:30 PMJul 29
    to Jay Kapadia, apaselti...@chromium.org, Alison Gale, David Pennington, Tom Lukaszewicz, Mathias Bynens, Peter Collingbourne, Yoav Weiss (@Shopify), ningxin hu, Hans Wennborg, Mirko Bonadei, Raphael Kubo da Costa, Arnaud Mandy, Robert Kroeger, Rijubrata Bhaumik, Kevin Babbitt, Ilya Biryukov, Nate Chapin, Fredrik Söderquist, Andrew Williams, Wanming Lin, Thiabaud Engelbrecht, Alex Keng, Christian Biesinger, Kaan Icer, Alexis Menard, Peter Williamson, Kentaro Hara, Andrew Rayskiy, Kenneth Rohde Christiansen, Kevin McNee, Jiewei Qian, Nikhil Nayunigari, Mike Taylor, Sam Zackrisson, Peter Beverloo, Reid Kleckner, Ale Bzk, Hiroki Nakagawa, Luna Lu, Ryan Sultanem, Sadrul Chowdhury, Xida Chen, Zijie He, Ian Vollick, Jerome Jiang, Lei Zhang, (Julie)Jeongeun Kim, Dustin Mitchell, srirama chandra sekhar, Simon Hangl, David Bokan, Kenneth R Christiansen, Hongchan Choi, Enterprise Policy Reviews, Urvang Joshi, Daniel Andersson, Tommy Li, Olga Gerchikov, Nico Weber, Sarah Krakowiak, James Maclean, Chromium Metrics Reviews, Per Åhgren, Javier Fernandez, Daniel Cheng, Victor Tan, Hirokazu Honda, Stephen Chenney, Dirk Schulze, James Su, Wei4 Wang, David Worsham, AyeAye, AyeAye Python Dispatcher, Daniel Soromou, Chromium LUCI CQ, chromium...@chromium.org, knollr+wat...@chromium.org, cros-setti...@google.com, lucasrada...@google.com, cambickel+watch-shor...@google.com, mfoltz...@chromium.org, network-ser...@chromium.org, dibyapal+wa...@chromium.org, kenjibah...@chromium.org, crmulli...@chromium.org, hansberry+w...@chromium.org, asvitkine...@chromium.org, mdjone...@chromium.org, aleventhal...@chromium.org, dimich...@chromium.org, cros-report...@google.com, ortuno+w...@chromium.org, kinuko+...@chromium.org, chromium-a...@chromium.org, kouhe...@chromium.org, lcwu+...@chromium.org, gavin...@chromium.org, pdf-r...@chromium.org, nwoked...@chromium.org, katie...@chromium.org, mbarowsky+watc...@chromium.org, jackshira+wa...@google.com, fenced-fra...@chromium.org, mickeybu...@chromium.org, dmurph+wat...@chromium.org, crisrael+w...@google.com, hansberry+wa...@chromium.org, khorimoto+w...@chromium.org, chikamu...@chromium.org, blink-revie...@chromium.org, gavindodd+watch-...@google.com, gavinwill+watch-...@chromium.org, gavinwill+dia...@chromium.org, crost...@chromium.org, dmurph+watch...@chromium.org, longbowei+fe...@google.com, creis...@chromium.org, browser-comp...@chromium.org, gavinp+p...@chromium.org, jinsukk...@chromium.org, headless...@chromium.org, kouhei...@chromium.org, chromeos-gfx-...@google.com, hansberry+wa...@chromium.org, horo+...@chromium.org, blink-revi...@chromium.org, gangwu...@chromium.org, aakalla...@chromium.org, feature-me...@chromium.org, jbrom...@chromium.org, gavin...@chromium.org, chasej...@chromium.org, ashleydp+fe...@google.com, ejcaruso+wa...@chromium.org, kinuko...@chromium.org, bcb+watch-pl...@chromium.org, ajayramamurthy...@google.com, oilpan-rev...@chromium.org, jophba...@chromium.org, armalhotra+a...@google.com, andreaor...@chromium.org, ntp-dev...@chromium.org, njeunje+...@chromium.org, moqati-team+chr...@google.com, dtapuska+ch...@chromium.org, enne...@chromium.org, kainin...@chromium.org, druber...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, max+watc...@igalia.com, halliwe...@chromium.org, joeantonetti+wa...@google.com, ashleydp+diag...@google.com, chili...@chromium.org, chfreme...@chromium.org, jmedle...@chromium.org, eric.c...@apple.com, bnc+...@chromium.org, cblume+im...@chromium.org, cbe-cep-eng...@google.com, jackshira+w...@google.com, nikhilcn+wat...@google.com, loading-rev...@chromium.org, crostin...@chromium.org, iclella...@chromium.org, loading...@chromium.org, chrome-intelligence-te...@google.com, bfcach...@chromium.org, performance-m...@chromium.org, hiroshig...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, antoniosarto...@chromium.org, hsuregan+wa...@chromium.org, blink-re...@chromium.org, peter+watch...@chromium.org, lizeb...@chromium.org, dominicc+...@chromium.org, fmalit...@chromium.org, cambickel...@google.com, niharm...@google.com, chrome-waff...@google.com, blink-rev...@chromium.org, drott...@chromium.org, dom+...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, ananyasee...@google.com, devtools...@chromium.org, michaelcheco+...@google.com, keithle...@chromium.org, crisrael+...@google.com, estali...@chromium.org, kuragin+web-ap...@chromium.org, phoglun...@chromium.org, bmcquad...@chromium.org, cambickel+watc...@google.com, cros-essential...@chromium.org, devtools-re...@chromium.org, jkeitel+watch-...@google.com, longbowei+watc...@google.com, mreichhoff+watc...@chromium.org, chadduffin+w...@chromium.org, jonmann+wat...@chromium.org, chromeos-kio...@google.com, blink-rev...@chromium.org, kinuko+ser...@chromium.org, fgorsk...@chromium.org, jimmyxgong+w...@chromium.org, dmurph+watch...@chromium.org, fuchsia...@chromium.org, gavinp...@chromium.org, dtraino...@chromium.org, dkrahn...@chromium.org, cfredri...@chromium.org, blink-isola...@chromium.org, ffred...@chromium.org, gl...@chromium.org, language...@chromium.org, iwells...@chromium.org, bici...@google.com, jonmann+w...@chromium.org, hsuregan+wat...@chromium.org, mschillaci...@google.com, dclasson+w...@google.com, edgesto...@microsoft.com, chromotin...@chromium.org, dmurph+watching...@chromium.org, cros-print...@google.com, dfried...@chromium.org, blink-reviews-p...@chromium.org, jimmyxgong+watch-shor...@chromium.org, longbowei+watch-shor...@google.com, mattreyno...@chromium.org, lize...@chromium.org, blink-revie...@chromium.org, jdonnel...@chromium.org, davidj...@chromium.org, hidehik...@chromium.org, cblume...@chromium.org, omnibox-...@chromium.org, ayman...@chromium.org, dtseng...@chromium.org, jdh+wa...@chromium.org, asumane...@google.com, nyquis...@chromium.org, media-wi...@chromium.org, hirokisa...@chromium.org, harringt...@chromium.org, nator...@chromium.org, msrame...@chromium.org, lens-chrome...@google.com, blink-revi...@chromium.org, hashimo...@chromium.org, jbauma...@chromium.org, martijn...@martijnc.be, michaelchec...@google.com, dmurph+watchi...@chromium.org, dullweb...@chromium.org, gavindodd+dia...@google.com, filesapp...@chromium.org, nektar...@chromium.org, erickun...@chromium.org, jiajunz+wat...@google.com, danakj...@chromium.org, jorgel...@chromium.org, ddrone...@google.com, core-timi...@chromium.org, kouhe...@chromium.org, chrome-gr...@chromium.org, meilian...@chromium.org, ajwong...@chromium.org, extension...@chromium.org, dfalcant...@chromium.org, cambickel+fe...@google.com, hais+wat...@google.com, kinuko...@chromium.org, marimatthew+watc...@google.com, crisrael+wa...@google.com, pdr+svgw...@chromium.org, khmel...@chromium.org, ios-rev...@chromium.org, mtomas...@chromium.org, pushi+wa...@google.com, pkotwic...@chromium.org, abigailbk...@google.com, amaliev+...@chromium.org, lingqi...@chromium.org, mpdento...@chromium.org, gavinwill+sc...@chromium.org, minap+watch-p...@google.com, permissio...@chromium.org, chromeos-ca...@google.com, loading-rev...@chromium.org, jackshira+...@google.com, geoffla...@chromium.org, cwp-review...@google.com, andysjl...@chromium.org, peilinwa...@google.com, ajayramamurthy...@google.com, chrome-intell...@chromium.org, lwinston+watc...@google.com, cblum...@chromium.org, jackshira+wat...@google.com, chlily...@chromium.org, penghuan...@chromium.org, mattsimm...@chromium.org, core-web-vita...@chromium.org, feature-v...@chromium.org, mercer...@google.com, oshima...@chromium.org, philli...@chromium.org, liu+wa...@chromium.org, cc-...@chromium.org, aleventh...@chromium.org, marinacio...@chromium.org, jimmyxgong+wat...@chromium.org, dcheng+c...@chromium.org, chadduffin+wa...@chromium.org, hansberry+wat...@chromium.org, jackshira+wa...@google.com, jackshira+w...@google.com, hansberry+wa...@chromium.org, michaelcheco+watch-i...@google.com, mkwst+w...@chromium.org, emi...@google.com, grt+...@chromium.org, eugeni...@chromium.org, jonmann+watc...@chromium.org, agriev...@chromium.org, joeantonetti+...@google.com, jz...@chromium.org, asvitki...@chromium.org, olka+...@chromium.org, jeffreycohen+watc...@chromium.org, dougste...@chromium.org, android-web...@chromium.org, arc-review...@google.com, gogerald+pa...@chromium.org, nickdiego+wa...@igalia.com, blink-re...@chromium.org, blink-...@chromium.org, arthursonzog...@chromium.org, akingsb+wat...@google.com, loading-re...@chromium.org, gogeral...@chromium.org, petewi...@chromium.org, giovax...@chromium.org, glider...@chromium.org, christia...@chromium.org, gavinp...@chromium.org, odejesu...@chromium.org, dewitt...@chromium.org, marq+...@chromium.org, blink-re...@chromium.org, ajayramamurth...@google.com, lighthouse-eng-extern...@google.com, mcasas+med...@chromium.org, jasonrobe...@google.com, dmurph+watchin...@chromium.org, ajayramamurthy+w...@google.com, caitkp...@chromium.org, dmurph+watc...@chromium.org, ios-revie...@chromium.org, alandin...@chromium.org, jessemcke...@google.com, ender...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, mbarowsky+watc...@chromium.org, osaul+aut...@google.com, josiah...@chromium.org, dtapuska+...@chromium.org, gayane...@chromium.org, blink-rev...@chromium.org, jhawkins+...@google.com, antoniosartori+wa...@chromium.org, michaelcheco+...@google.com, cros-enterpris...@chromium.org, djacob...@chromium.org, eme-r...@chromium.org, ashleynewson+w...@chromium.org, chrome-tab-group-en...@google.com, hansenmichael...@google.com, fgal...@chromium.org, glazuno...@chromium.org, mac-r...@chromium.org, cwalle...@chromium.org, dmurph+wa...@chromium.org, navigation...@chromium.org, pasko...@chromium.org, milicau+watchlis...@google.com, michaelcheco+watc...@google.com, droger+w...@chromium.org, chromium-...@engflow.com, ozone-...@chromium.org, media-cro...@chromium.org, ios-web-view...@google.com, net-r...@chromium.org, blink-work...@chromium.org, fuzzin...@chromium.org, ios-r...@chromium.org, jiajunz+wa...@google.com, npnavarro+p...@chromium.org, michaelcheco+di...@google.com, jbroma...@chromium.org, jimmyxgong+watch...@chromium.org, csharris...@chromium.org, mgiuca...@chromium.org, prerenderi...@chromium.org, loyso...@chromium.org, cros-ed...@google.com, blink-revie...@chromium.org, mar...@chromium.org, julietlevesque...@google.com, jonmann+wa...@chromium.org, gab+...@chromium.org, kaklilu+watch-...@chromium.org, jackshira+wa...@google.com, michaelcheco+wa...@google.com, penghu...@chromium.org, khorimoto+wa...@chromium.org, francisjp...@google.com, drott+bl...@chromium.org, dtseng+c...@chromium.org, pmonett...@chromium.org, croissant-...@chromium.org, gcasto+w...@chromium.org, jshin...@chromium.org, lizeb+watch...@chromium.org, fserb...@chromium.org, donnd...@chromium.org, emircan+watch...@chromium.org, nicolas...@chromium.org, kyungjunle...@google.com, hayato...@chromium.org, jimmyxgong+f...@chromium.org, crisrael+wa...@google.com, jdeblas...@chromium.org, bartek...@chromium.org, apavlo...@chromium.org, anastas...@google.com, ashleydp+watch-...@google.com, hanxi...@chromium.org, print-rev...@chromium.org, ajayramamurt...@google.com

    Andrew Paseltiner removed apaselti...@chromium.org from this change

    Deleted Reviewers:
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: deleteReviewer
    satisfied_requirement
    open
    diffy

    Takuto Ikuta (Gerrit)

    unread,
    Jul 29, 2025, 1:19:41 PMJul 29
    to Jay Kapadia, chrome-b...@google.com, Alison Gale, David Pennington, Tom Lukaszewicz, Mathias Bynens, Peter Collingbourne, Yoav Weiss (@Shopify), ningxin hu, Hans Wennborg, Mirko Bonadei, Raphael Kubo da Costa, Arnaud Mandy, Robert Kroeger, Rijubrata Bhaumik, Kevin Babbitt, Ilya Biryukov, Nate Chapin, Fredrik Söderquist, Andrew Williams, Wanming Lin, Thiabaud Engelbrecht, Alex Keng, Christian Biesinger, Kaan Icer, Alexis Menard, Peter Williamson, Kentaro Hara, Andrew Rayskiy, Kenneth Rohde Christiansen, Kevin McNee, Jiewei Qian, Nikhil Nayunigari, Mike Taylor, Sam Zackrisson, Peter Beverloo, Reid Kleckner, Ale Bzk, Hiroki Nakagawa, Luna Lu, Ryan Sultanem, Sadrul Chowdhury, Xida Chen, Zijie He, Ian Vollick, Jerome Jiang, Lei Zhang, (Julie)Jeongeun Kim, Dustin Mitchell, srirama chandra sekhar, Simon Hangl, David Bokan, Kenneth R Christiansen, Hongchan Choi, Enterprise Policy Reviews, Urvang Joshi, Daniel Andersson, Tommy Li, Olga Gerchikov, Nico Weber, Sarah Krakowiak, James Maclean, Chromium Metrics Reviews, Per Åhgren, Javier Fernandez, Daniel Cheng, Victor Tan, Hirokazu Honda, Stephen Chenney, Dirk Schulze, James Su, Wei4 Wang, David Worsham, AyeAye, AyeAye Python Dispatcher, Daniel Soromou, Chromium LUCI CQ, chromium...@chromium.org, knollr+wat...@chromium.org, cros-setti...@google.com, lucasrada...@google.com, cambickel+watch-shor...@google.com, mfoltz...@chromium.org, network-ser...@chromium.org, dibyapal+wa...@chromium.org, kenjibah...@chromium.org, crmulli...@chromium.org, hansberry+w...@chromium.org, asvitkine...@chromium.org, mdjone...@chromium.org, aleventhal...@chromium.org, dimich...@chromium.org, cros-report...@google.com, ortuno+w...@chromium.org, kinuko+...@chromium.org, chromium-a...@chromium.org, kouhe...@chromium.org, lcwu+...@chromium.org, gavin...@chromium.org, pdf-r...@chromium.org, nwoked...@chromium.org, katie...@chromium.org, mbarowsky+watc...@chromium.org, jackshira+wa...@google.com, fenced-fra...@chromium.org, mickeybu...@chromium.org, dmurph+wat...@chromium.org, crisrael+w...@google.com, hansberry+wa...@chromium.org, khorimoto+w...@chromium.org, chikamu...@chromium.org, blink-revie...@chromium.org, gavindodd+watch-...@google.com, gavinwill+watch-...@chromium.org, gavinwill+dia...@chromium.org, crost...@chromium.org, dmurph+watch...@chromium.org, longbowei+fe...@google.com, creis...@chromium.org, browser-comp...@chromium.org, gavinp+p...@chromium.org, jinsukk...@chromium.org, headless...@chromium.org, kouhei...@chromium.org, chromeos-gfx-...@google.com, hansberry+wa...@chromium.org, horo+...@chromium.org, blink-revi...@chromium.org, gangwu...@chromium.org, aakalla...@chromium.org, feature-me...@chromium.org, jbrom...@chromium.org, gavin...@chromium.org, chasej...@chromium.org, ashleydp+fe...@google.com, ejcaruso+wa...@chromium.org, kinuko...@chromium.org, bcb+watch-pl...@chromium.org, ajayramamurthy...@google.com, oilpan-rev...@chromium.org, jophba...@chromium.org, armalhotra+a...@google.com, andreaor...@chromium.org, ntp-dev...@chromium.org, njeunje+...@chromium.org, moqati-team+chr...@google.com, dtapuska+ch...@chromium.org, enne...@chromium.org, kainin...@chromium.org, druber...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, max+watc...@igalia.com, halliwe...@chromium.org, joeantonetti+wa...@google.com, ashleydp+diag...@google.com, chili...@chromium.org, chfreme...@chromium.org, jmedle...@chromium.org, eric.c...@apple.com, bnc+...@chromium.org, cblume+im...@chromium.org, cbe-cep-eng...@google.com, jackshira+w...@google.com, nikhilcn+wat...@google.com, loading-rev...@chromium.org, crostin...@chromium.org, iclella...@chromium.org, loading...@chromium.org, chrome-intelligence-te...@google.com, bfcach...@chromium.org, performance-m...@chromium.org, hiroshig...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, antoniosarto...@chromium.org, hsuregan+wa...@chromium.org, blink-re...@chromium.org, peter+watch...@chromium.org, lizeb...@chromium.org, dominicc+...@chromium.org, fmalit...@chromium.org, cambickel...@google.com, niharm...@google.com, chrome-waff...@google.com, blink-rev...@chromium.org, drott...@chromium.org, dom+...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, ananyasee...@google.com, devtools...@chromium.org, michaelcheco+...@google.com, keithle...@chromium.org, crisrael+...@google.com, estali...@chromium.org, kuragin+web-ap...@chromium.org, phoglun...@chromium.org, bmcquad...@chromium.org, cambickel+watc...@google.com, cros-essential...@chromium.org, devtools-re...@chromium.org, jkeitel+watch-...@google.com, longbowei+watc...@google.com, mreichhoff+watc...@chromium.org, chadduffin+w...@chromium.org, jonmann+wat...@chromium.org, chromeos-kio...@google.com, blink-rev...@chromium.org, kinuko+ser...@chromium.org, fgorsk...@chromium.org, jimmyxgong+w...@chromium.org, dmurph+watch...@chromium.org, fuchsia...@chromium.org, gavinp...@chromium.org, dtraino...@chromium.org, dkrahn...@chromium.org, cfredri...@chromium.org, blink-isola...@chromium.org, ffred...@chromium.org, gl...@chromium.org, language...@chromium.org, iwells...@chromium.org, bici...@google.com, jonmann+w...@chromium.org, hsuregan+wat...@chromium.org, mschillaci...@google.com, dclasson+w...@google.com, edgesto...@microsoft.com, chromotin...@chromium.org, dmurph+watching...@chromium.org, cros-print...@google.com, dfried...@chromium.org, blink-reviews-p...@chromium.org, jimmyxgong+watch-shor...@chromium.org, longbowei+watch-shor...@google.com, mattreyno...@chromium.org, lize...@chromium.org, blink-revie...@chromium.org, jdonnel...@chromium.org, davidj...@chromium.org, hidehik...@chromium.org, cblume...@chromium.org, omnibox-...@chromium.org, ayman...@chromium.org, dtseng...@chromium.org, jdh+wa...@chromium.org, asumane...@google.com, nyquis...@chromium.org, media-wi...@chromium.org, hirokisa...@chromium.org, harringt...@chromium.org, nator...@chromium.org, msrame...@chromium.org, lens-chrome...@google.com, blink-revi...@chromium.org, hashimo...@chromium.org, jbauma...@chromium.org, martijn...@martijnc.be, michaelchec...@google.com, dmurph+watchi...@chromium.org, dullweb...@chromium.org, gavindodd+dia...@google.com, filesapp...@chromium.org, nektar...@chromium.org, erickun...@chromium.org, jiajunz+wat...@google.com, danakj...@chromium.org, jorgel...@chromium.org, ddrone...@google.com, core-timi...@chromium.org, kouhe...@chromium.org, chrome-gr...@chromium.org, meilian...@chromium.org, ajwong...@chromium.org, extension...@chromium.org, dfalcant...@chromium.org, cambickel+fe...@google.com, hais+wat...@google.com, kinuko...@chromium.org, marimatthew+watc...@google.com, crisrael+wa...@google.com, pdr+svgw...@chromium.org, khmel...@chromium.org, ios-rev...@chromium.org, mtomas...@chromium.org, pushi+wa...@google.com, pkotwic...@chromium.org, abigailbk...@google.com, amaliev+...@chromium.org, lingqi...@chromium.org, mpdento...@chromium.org, gavinwill+sc...@chromium.org, minap+watch-p...@google.com, permissio...@chromium.org, chromeos-ca...@google.com, loading-rev...@chromium.org, jackshira+...@google.com, geoffla...@chromium.org, cwp-review...@google.com, andysjl...@chromium.org, peilinwa...@google.com, ajayramamurthy...@google.com, chrome-intell...@chromium.org, lwinston+watc...@google.com, cblum...@chromium.org, jackshira+wat...@google.com, chlily...@chromium.org, penghuan...@chromium.org, mattsimm...@chromium.org, core-web-vita...@chromium.org, feature-v...@chromium.org, mercer...@google.com, oshima...@chromium.org, philli...@chromium.org, liu+wa...@chromium.org, cc-...@chromium.org, aleventh...@chromium.org, marinacio...@chromium.org, jimmyxgong+wat...@chromium.org, dcheng+c...@chromium.org, chadduffin+wa...@chromium.org, hansberry+wat...@chromium.org, jackshira+wa...@google.com, jackshira+w...@google.com, hansberry+wa...@chromium.org, michaelcheco+watch-i...@google.com, mkwst+w...@chromium.org, emi...@google.com, grt+...@chromium.org, eugeni...@chromium.org, jonmann+watc...@chromium.org, agriev...@chromium.org, joeantonetti+...@google.com, jz...@chromium.org, asvitki...@chromium.org, olka+...@chromium.org, jeffreycohen+watc...@chromium.org, dougste...@chromium.org, android-web...@chromium.org, arc-review...@google.com, gogerald+pa...@chromium.org, nickdiego+wa...@igalia.com, blink-re...@chromium.org, blink-...@chromium.org, arthursonzog...@chromium.org, akingsb+wat...@google.com, loading-re...@chromium.org, gogeral...@chromium.org, petewi...@chromium.org, giovax...@chromium.org, glider...@chromium.org, christia...@chromium.org, gavinp...@chromium.org, odejesu...@chromium.org, dewitt...@chromium.org, marq+...@chromium.org, blink-re...@chromium.org, ajayramamurth...@google.com, lighthouse-eng-extern...@google.com, mcasas+med...@chromium.org, jasonrobe...@google.com, dmurph+watchin...@chromium.org, ajayramamurthy+w...@google.com, caitkp...@chromium.org, dmurph+watc...@chromium.org, apaselti...@chromium.org, ios-revie...@chromium.org, alandin...@chromium.org, jessemcke...@google.com, ender...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, mbarowsky+watc...@chromium.org, osaul+aut...@google.com, josiah...@chromium.org, dtapuska+...@chromium.org, gayane...@chromium.org, blink-rev...@chromium.org, jhawkins+...@google.com, antoniosartori+wa...@chromium.org, michaelcheco+...@google.com, cros-enterpris...@chromium.org, djacob...@chromium.org, eme-r...@chromium.org, ashleynewson+w...@chromium.org, chrome-tab-group-en...@google.com, hansenmichael...@google.com, fgal...@chromium.org, glazuno...@chromium.org, mac-r...@chromium.org, cwalle...@chromium.org, dmurph+wa...@chromium.org, navigation...@chromium.org, pasko...@chromium.org, milicau+watchlis...@google.com, michaelcheco+watc...@google.com, droger+w...@chromium.org, chromium-...@engflow.com, ozone-...@chromium.org, media-cro...@chromium.org, ios-web-view...@google.com, net-r...@chromium.org, blink-work...@chromium.org, fuzzin...@chromium.org, ios-r...@chromium.org, jiajunz+wa...@google.com, npnavarro+p...@chromium.org, michaelcheco+di...@google.com, jbroma...@chromium.org, jimmyxgong+watch...@chromium.org, csharris...@chromium.org, mgiuca...@chromium.org, prerenderi...@chromium.org, loyso...@chromium.org, cros-ed...@google.com, blink-revie...@chromium.org, mar...@chromium.org, julietlevesque...@google.com, jonmann+wa...@chromium.org, gab+...@chromium.org, kaklilu+watch-...@chromium.org, jackshira+wa...@google.com, michaelcheco+wa...@google.com, penghu...@chromium.org, khorimoto+wa...@chromium.org, francisjp...@google.com, drott+bl...@chromium.org, dtseng+c...@chromium.org, pmonett...@chromium.org, croissant-...@chromium.org, gcasto+w...@chromium.org, jshin...@chromium.org, lizeb+watch...@chromium.org, fserb...@chromium.org, donnd...@chromium.org, emircan+watch...@chromium.org, nicolas...@chromium.org, kyungjunle...@google.com, hayato...@chromium.org, jimmyxgong+f...@chromium.org, crisrael+wa...@google.com, jdeblas...@chromium.org, bartek...@chromium.org, apavlo...@chromium.org, anastas...@google.com, ashleydp+watch-...@google.com, hanxi...@chromium.org, print-rev...@chromium.org, ajayramamurt...@google.com, Takuto Ikuta

    Takuto Ikuta removed chrome-b...@google.com from this change

    Deleted Reviewers:
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 29, 2025, 2:08:00 PMJul 29
    to Jay Kapadia, Alison Gale, David Pennington, Tom Lukaszewicz, Mathias Bynens, Peter Collingbourne, Yoav Weiss (@Shopify), ningxin hu, Hans Wennborg, Mirko Bonadei, Raphael Kubo da Costa, Arnaud Mandy, Robert Kroeger, Rijubrata Bhaumik, Kevin Babbitt, Ilya Biryukov, Nate Chapin, Fredrik Söderquist, Andrew Williams, Wanming Lin, Thiabaud Engelbrecht, Alex Keng, Christian Biesinger, Kaan Icer, Alexis Menard, Peter Williamson, Kentaro Hara, Andrew Rayskiy, Kenneth Rohde Christiansen, Kevin McNee, Jiewei Qian, Nikhil Nayunigari, Mike Taylor, Sam Zackrisson, Peter Beverloo, Reid Kleckner, Ale Bzk, Hiroki Nakagawa, Luna Lu, Ryan Sultanem, Sadrul Chowdhury, Xida Chen, Zijie He, Ian Vollick, Jerome Jiang, Lei Zhang, (Julie)Jeongeun Kim, Dustin Mitchell, srirama chandra sekhar, Simon Hangl, David Bokan, Akihiro Ota, Kenneth R Christiansen, Hongchan Choi, Enterprise Policy Reviews, Urvang Joshi, Daniel Andersson, Tommy Li, Olga Gerchikov, Nico Weber, Sarah Krakowiak, James Maclean, Chromium Metrics Reviews, Per Åhgren, Javier Fernandez, Daniel Cheng, Victor Tan, Hirokazu Honda, Stephen Chenney, Dirk Schulze, James Su, Wei4 Wang, David Worsham, AyeAye, AyeAye Python Dispatcher, Daniel Soromou, chromium...@chromium.org, knollr+wat...@chromium.org, cros-setti...@google.com, lucasrada...@google.com, cambickel+watch-shor...@google.com, mfoltz...@chromium.org, network-ser...@chromium.org, dibyapal+wa...@chromium.org, kenjibah...@chromium.org, crmulli...@chromium.org, hansberry+w...@chromium.org, asvitkine...@chromium.org, mdjone...@chromium.org, aleventhal...@chromium.org, dimich...@chromium.org, cros-report...@google.com, ortuno+w...@chromium.org, kinuko+...@chromium.org, chromium-a...@chromium.org, kouhe...@chromium.org, lcwu+...@chromium.org, gavin...@chromium.org, pdf-r...@chromium.org, nwoked...@chromium.org, katie...@chromium.org, mbarowsky+watc...@chromium.org, jackshira+wa...@google.com, fenced-fra...@chromium.org, mickeybu...@chromium.org, dmurph+wat...@chromium.org, crisrael+w...@google.com, hansberry+wa...@chromium.org, khorimoto+w...@chromium.org, chikamu...@chromium.org, blink-revie...@chromium.org, gavindodd+watch-...@google.com, gavinwill+watch-...@chromium.org, gavinwill+dia...@chromium.org, crost...@chromium.org, dmurph+watch...@chromium.org, longbowei+fe...@google.com, creis...@chromium.org, browser-comp...@chromium.org, gavinp+p...@chromium.org, jinsukk...@chromium.org, headless...@chromium.org, kouhei...@chromium.org, chromeos-gfx-...@google.com, hansberry+wa...@chromium.org, horo+...@chromium.org, blink-revi...@chromium.org, gangwu...@chromium.org, aakalla...@chromium.org, feature-me...@chromium.org, jbrom...@chromium.org, gavin...@chromium.org, chasej...@chromium.org, ashleydp+fe...@google.com, ejcaruso+wa...@chromium.org, kinuko...@chromium.org, bcb+watch-pl...@chromium.org, ajayramamurthy...@google.com, oilpan-rev...@chromium.org, jophba...@chromium.org, armalhotra+a...@google.com, andreaor...@chromium.org, ntp-dev...@chromium.org, njeunje+...@chromium.org, moqati-team+chr...@google.com, dtapuska+ch...@chromium.org, enne...@chromium.org, kainin...@chromium.org, druber...@chromium.org, chromiumme...@microsoft.com, fdoray...@chromium.org, max+watc...@igalia.com, halliwe...@chromium.org, joeantonetti+wa...@google.com, ashleydp+diag...@google.com, chili...@chromium.org, chfreme...@chromium.org, jmedle...@chromium.org, eric.c...@apple.com, bnc+...@chromium.org, cblume+im...@chromium.org, cbe-cep-eng...@google.com, jackshira+w...@google.com, nikhilcn+wat...@google.com, loading-rev...@chromium.org, crostin...@chromium.org, iclella...@chromium.org, loading...@chromium.org, chrome-intelligence-te...@google.com, bfcach...@chromium.org, performance-m...@chromium.org, hiroshig...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, antoniosarto...@chromium.org, hsuregan+wa...@chromium.org, blink-re...@chromium.org, peter+watch...@chromium.org, lizeb...@chromium.org, dominicc+...@chromium.org, fmalit...@chromium.org, cambickel...@google.com, niharm...@google.com, chrome-waff...@google.com, blink-rev...@chromium.org, drott...@chromium.org, dom+...@chromium.org, blink-re...@chromium.org, alexmo...@chromium.org, ananyasee...@google.com, devtools...@chromium.org, michaelcheco+...@google.com, keithle...@chromium.org, crisrael+...@google.com, estali...@chromium.org, kuragin+web-ap...@chromium.org, phoglun...@chromium.org, bmcquad...@chromium.org, cambickel+watc...@google.com, cros-essential...@chromium.org, devtools-re...@chromium.org, jkeitel+watch-...@google.com, longbowei+watc...@google.com, mreichhoff+watc...@chromium.org, chadduffin+w...@chromium.org, jonmann+wat...@chromium.org, chromeos-kio...@google.com, blink-rev...@chromium.org, kinuko+ser...@chromium.org, fgorsk...@chromium.org, jimmyxgong+w...@chromium.org, dmurph+watch...@chromium.org, fuchsia...@chromium.org, gavinp...@chromium.org, dtraino...@chromium.org, dkrahn...@chromium.org, cfredri...@chromium.org, blink-isola...@chromium.org, ffred...@chromium.org, gl...@chromium.org, language...@chromium.org, iwells...@chromium.org, bici...@google.com, jonmann+w...@chromium.org, hsuregan+wat...@chromium.org, mschillaci...@google.com, dclasson+w...@google.com, edgesto...@microsoft.com, chromotin...@chromium.org, dmurph+watching...@chromium.org, cros-print...@google.com, dfried...@chromium.org, blink-reviews-p...@chromium.org, jimmyxgong+watch-shor...@chromium.org, longbowei+watch-shor...@google.com, mattreyno...@chromium.org, lize...@chromium.org, blink-revie...@chromium.org, jdonnel...@chromium.org, davidj...@chromium.org, hidehik...@chromium.org, cblume...@chromium.org, omnibox-...@chromium.org, ayman...@chromium.org, dtseng...@chromium.org, jdh+wa...@chromium.org, asumane...@google.com, nyquis...@chromium.org, media-wi...@chromium.org, hirokisa...@chromium.org, harringt...@chromium.org, nator...@chromium.org, msrame...@chromium.org, lens-chrome...@google.com, blink-revi...@chromium.org, hashimo...@chromium.org, jbauma...@chromium.org, martijn...@martijnc.be, michaelchec...@google.com, dmurph+watchi...@chromium.org, dullweb...@chromium.org, gavindodd+dia...@google.com, filesapp...@chromium.org, nektar...@chromium.org, erickun...@chromium.org, jiajunz+wat...@google.com, danakj...@chromium.org, jorgel...@chromium.org, ddrone...@google.com, core-timi...@chromium.org, kouhe...@chromium.org, chrome-gr...@chromium.org, meilian...@chromium.org, ajwong...@chromium.org, extension...@chromium.org, dfalcant...@chromium.org, cambickel+fe...@google.com, hais+wat...@google.com, kinuko...@chromium.org, marimatthew+watc...@google.com, crisrael+wa...@google.com, pdr+svgw...@chromium.org, khmel...@chromium.org, ios-rev...@chromium.org, mtomas...@chromium.org, pushi+wa...@google.com, pkotwic...@chromium.org, abigailbk...@google.com, amaliev+...@chromium.org, lingqi...@chromium.org, mpdento...@chromium.org, gavinwill+sc...@chromium.org, minap+watch-p...@google.com, permissio...@chromium.org, chromeos-ca...@google.com, loading-rev...@chromium.org, jackshira+...@google.com, geoffla...@chromium.org, cwp-review...@google.com, andysjl...@chromium.org, peilinwa...@google.com, ajayramamurthy...@google.com, chrome-intell...@chromium.org, lwinston+watc...@google.com, cblum...@chromium.org, jackshira+wat...@google.com, chlily...@chromium.org, penghuan...@chromium.org, mattsimm...@chromium.org, core-web-vita...@chromium.org, feature-v...@chromium.org, mercer...@google.com, oshima...@chromium.org, philli...@chromium.org, liu+wa...@chromium.org, cc-...@chromium.org, aleventh...@chromium.org, marinacio...@chromium.org, jimmyxgong+wat...@chromium.org, dcheng+c...@chromium.org, chadduffin+wa...@chromium.org, hansberry+wat...@chromium.org, jackshira+wa...@google.com, jackshira+w...@google.com, hansberry+wa...@chromium.org, michaelcheco+watch-i...@google.com, mkwst+w...@chromium.org, emi...@google.com, grt+...@chromium.org, eugeni...@chromium.org, jonmann+watc...@chromium.org, agriev...@chromium.org, joeantonetti+...@google.com, jz...@chromium.org, asvitki...@chromium.org, olka+...@chromium.org, jeffreycohen+watc...@chromium.org, dougste...@chromium.org, android-web...@chromium.org, arc-review...@google.com, gogerald+pa...@chromium.org, nickdiego+wa...@igalia.com, blink-re...@chromium.org, blink-...@chromium.org, arthursonzog...@chromium.org, akingsb+wat...@google.com, loading-re...@chromium.org, gogeral...@chromium.org, petewi...@chromium.org, giovax...@chromium.org, glider...@chromium.org, christia...@chromium.org, gavinp...@chromium.org, odejesu...@chromium.org, dewitt...@chromium.org, marq+...@chromium.org, blink-re...@chromium.org, ajayramamurth...@google.com, lighthouse-eng-extern...@google.com, mcasas+med...@chromium.org, jasonrobe...@google.com, dmurph+watchin...@chromium.org, ajayramamurthy+w...@google.com, caitkp...@chromium.org, dmurph+watc...@chromium.org, ios-revie...@chromium.org, alandin...@chromium.org, jessemcke...@google.com, ender...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, mbarowsky+watc...@chromium.org, osaul+aut...@google.com, josiah...@chromium.org, dtapuska+...@chromium.org, gayane...@chromium.org, blink-rev...@chromium.org, jhawkins+...@google.com, antoniosartori+wa...@chromium.org, michaelcheco+...@google.com, cros-enterpris...@chromium.org, djacob...@chromium.org, eme-r...@chromium.org, ashleynewson+w...@chromium.org, chrome-tab-group-en...@google.com, hansenmichael...@google.com, fgal...@chromium.org, glazuno...@chromium.org, mac-r...@chromium.org, cwalle...@chromium.org, dmurph+wa...@chromium.org, navigation...@chromium.org, pasko...@chromium.org, milicau+watchlis...@google.com, michaelcheco+watc...@google.com, droger+w...@chromium.org, chromium-...@engflow.com, ozone-...@chromium.org, media-cro...@chromium.org, ios-web-view...@google.com, net-r...@chromium.org, blink-work...@chromium.org, fuzzin...@chromium.org, ios-r...@chromium.org, jiajunz+wa...@google.com, npnavarro+p...@chromium.org, michaelcheco+di...@google.com, jbroma...@chromium.org, jimmyxgong+watch...@chromium.org, csharris...@chromium.org, mgiuca...@chromium.org, prerenderi...@chromium.org, loyso...@chromium.org, cros-ed...@google.com, blink-revie...@chromium.org, mar...@chromium.org, julietlevesque...@google.com, jonmann+wa...@chromium.org, gab+...@chromium.org, kaklilu+watch-...@chromium.org, jackshira+wa...@google.com, michaelcheco+wa...@google.com, penghu...@chromium.org, khorimoto+wa...@chromium.org, francisjp...@google.com, drott+bl...@chromium.org, dtseng+c...@chromium.org, pmonett...@chromium.org, croissant-...@chromium.org, gcasto+w...@chromium.org, jshin...@chromium.org, lizeb+watch...@chromium.org, fserb...@chromium.org, donnd...@chromium.org, emircan+watch...@chromium.org, nicolas...@chromium.org, kyungjunle...@google.com, hayato...@chromium.org, jimmyxgong+f...@chromium.org, crisrael+wa...@google.com, jdeblas...@chromium.org, bartek...@chromium.org, apavlo...@chromium.org, anastas...@google.com, ashleydp+watch-...@google.com, hanxi...@chromium.org, print-rev...@chromium.org, ajayramamurt...@google.com

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    30 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Added `GenerateStandardShadesFromHue` function

    Added a struct `ChromaTonePair`. Added an array of `ChromaTonePair`
    called `kChromaToneValuesForStandardShades` which stores the values of
    Chroma and Tone for standard shades (50,100, ...,1000). Added a function
    `GenerateStandardShadesFromHue` that takes in hue and reference to an
    array, it generates the standard shades and poplates the input array.
    Bug: 427908562
    Change-Id: If8405c7213cdea536779a2ba64a46016d466c96a
    Reviewed-by: Alison Gale <ag...@chromium.org>
    Reviewed-by: Tom Lukaszewicz <tl...@chromium.org>
    Reviewed-by: David Pennington <dpen...@chromium.org>
    Commit-Queue: Jay Kapadia <jaykap...@gmail.com>
    Cr-Commit-Position: refs/heads/main@{#1493668}
    Files:
    • M ui/color/BUILD.gn
    • M ui/color/dynamic_color/palette_factory.cc
    • M ui/color/dynamic_color/palette_factory.h
    • A ui/color/dynamic_color/palette_factory_unittest.cc
    Change size: M
    Delta: 4 files changed, 155 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Tom Lukaszewicz, +1 by Alison Gale, +1 by David Pennington
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If8405c7213cdea536779a2ba64a46016d466c96a
    Gerrit-Change-Number: 6669514
    Gerrit-PatchSet: 32
    Gerrit-Owner: Jay Kapadia <jaykap...@gmail.com>
    Gerrit-Reviewer: Alison Gale <ag...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Soromou <koreta...@chromium.org>
    Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
    Gerrit-Reviewer: Jay Kapadia <jaykap...@gmail.com>
    Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Ale Bzk <ales...@chromium.org>
    Gerrit-CC: Alex Keng <shi...@microsoft.com>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Andrew Williams <awi...@chromium.org>
    Gerrit-CC: Arnaud Mandy <arnaud...@intel.com>
    Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages