DONOTCOMMIT Read ExternalString length from resource [v8/v8 : main]
0 views
Skip to first unread message
chromeperf@appspot.gserviceaccount.com (Gerrit)
Dec 9, 2025, 11:05:09 AMDec 9
to Maksim Ivanov, Fadi Meawad, Hannes Payer, AyeAye, V8 LUCI CQ, leszek...@chromium.org, victorgo...@chromium.org, v8-risc...@chromium.org, v8-flag...@chromium.org, was...@google.com, v8-mip...@googlegroups.com, pthier...@chromium.org, mlippau...@chromium.org, verwaes...@chromium.org, dmercadi...@chromium.org, alph+...@chromium.org, jgrube...@chromium.org, v8-ppc...@googlegroups.com, cbruni...@chromium.org, oilpan-r...@chromium.org, lpy+v8...@chromium.org, marja...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Maksim Ivanov
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job win-11-perf/speedometer3.1.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/150a1d27310000
Related details
Attention is currently required from:
- Maksim Ivanov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Dec 9, 2025, 11:16:08 AMDec 9
to Maksim Ivanov, Fadi Meawad, Hannes Payer, AyeAye, V8 LUCI CQ, leszek...@chromium.org, victorgo...@chromium.org, v8-risc...@chromium.org, v8-flag...@chromium.org, was...@google.com, v8-mip...@googlegroups.com, pthier...@chromium.org, mlippau...@chromium.org, verwaes...@chromium.org, dmercadi...@chromium.org, alph+...@chromium.org, jgrube...@chromium.org, v8-ppc...@googlegroups.com, cbruni...@chromium.org, oilpan-r...@chromium.org, lpy+v8...@chromium.org, marja...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Maksim Ivanov
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job win-11-perf/speedometer3.1.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/169886fb310000
Related details
Attention is currently required from:
- Maksim Ivanov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Ivanov (Gerrit)
Dec 15, 2025, 6:20:10 AM (14 days ago) Dec 15
to Fadi Meawad, Hannes Payer, AyeAye, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, leszek...@chromium.org, victorgo...@chromium.org, v8-risc...@chromium.org, v8-flag...@chromium.org, was...@google.com, v8-mip...@googlegroups.com, pthier...@chromium.org, mlippau...@chromium.org, verwaes...@chromium.org, dmercadi...@chromium.org, alph+...@chromium.org, jgrube...@chromium.org, v8-ppc...@googlegroups.com, cbruni...@chromium.org, oilpan-r...@chromium.org, lpy+v8...@chromium.org, marja...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
Maksim Ivanov added 1 comment![]( "Open in Gerrit")
File src/objects/string-inl.h
Line 138, Patchset 3 (Latest):
if (IsExternalOneByteString(this))Maksim Ivanov . unresolved
These are insufficient, since a bunch of places read directly from the |length_| field, e.g.: https://source.chromium.org/chromium/chromium/src/+/main:v8/src/maglev/ppc/maglev-assembler-ppc.cc;l=428;drc=da396567d0880346983ca5051628247b2ea60401
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Ivanov (Gerrit)
Dec 18, 2025, 7:46:44 AM (11 days ago) Dec 18
to Fadi Meawad, Hannes Payer, AyeAye, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, leszek...@chromium.org, victorgo...@chromium.org, v8-risc...@chromium.org, v8-flag...@chromium.org, was...@google.com, v8-mip...@googlegroups.com, pthier...@chromium.org, mlippau...@chromium.org, verwaes...@chromium.org, dmercadi...@chromium.org, alph+...@chromium.org, jgrube...@chromium.org, v8-ppc...@googlegroups.com, cbruni...@chromium.org, oilpan-r...@chromium.org, lpy+v8...@chromium.org, marja...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
Maksim Ivanov abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages