DONOTCOMMIT Read ExternalString length from resource [v8/v8 : main]

0 views
Skip to first unread message

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Dec 9, 2025, 11:05:09 AMDec 9
to Maksim Ivanov, Fadi Meawad, Hannes Payer, AyeAye, V8 LUCI CQ, leszek...@chromium.org, victorgo...@chromium.org, v8-risc...@chromium.org, v8-flag...@chromium.org, was...@google.com, v8-mip...@googlegroups.com, pthier...@chromium.org, mlippau...@chromium.org, verwaes...@chromium.org, dmercadi...@chromium.org, alph+...@chromium.org, jgrube...@chromium.org, v8-ppc...@googlegroups.com, cbruni...@chromium.org, oilpan-r...@chromium.org, lpy+v8...@chromium.org, marja...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Maksim Ivanov

Message from chrom...@appspot.gserviceaccount.com

📍 Job win-11-perf/speedometer3.1.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/150a1d27310000

Open in Gerrit

Related details

Attention is currently required from:
  • Maksim Ivanov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ie3f22804d76b8ed4d8e9146e3de9a9da01d19120
Gerrit-Change-Number: 7226896
Gerrit-PatchSet: 3
Gerrit-Owner: Maksim Ivanov <em...@chromium.org>
Gerrit-Reviewer: Maksim Ivanov <em...@chromium.org>
Gerrit-CC: Fadi Meawad <fme...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Maksim Ivanov <em...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Dec 2025 16:05:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Dec 9, 2025, 11:16:08 AMDec 9
to Maksim Ivanov, Fadi Meawad, Hannes Payer, AyeAye, V8 LUCI CQ, leszek...@chromium.org, victorgo...@chromium.org, v8-risc...@chromium.org, v8-flag...@chromium.org, was...@google.com, v8-mip...@googlegroups.com, pthier...@chromium.org, mlippau...@chromium.org, verwaes...@chromium.org, dmercadi...@chromium.org, alph+...@chromium.org, jgrube...@chromium.org, v8-ppc...@googlegroups.com, cbruni...@chromium.org, oilpan-r...@chromium.org, lpy+v8...@chromium.org, marja...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Maksim Ivanov

Message from chrom...@appspot.gserviceaccount.com

📍 Job win-11-perf/speedometer3.1.crossbench complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/169886fb310000

Open in Gerrit

Related details

Attention is currently required from:
  • Maksim Ivanov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ie3f22804d76b8ed4d8e9146e3de9a9da01d19120
Gerrit-Change-Number: 7226896
Gerrit-PatchSet: 3
Gerrit-Owner: Maksim Ivanov <em...@chromium.org>
Gerrit-Reviewer: Maksim Ivanov <em...@chromium.org>
Gerrit-CC: Fadi Meawad <fme...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Maksim Ivanov <em...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Dec 2025 16:16:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Maksim Ivanov (Gerrit)

unread,
Dec 15, 2025, 6:20:10 AM (14 days ago) Dec 15
to Fadi Meawad, Hannes Payer, AyeAye, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, leszek...@chromium.org, victorgo...@chromium.org, v8-risc...@chromium.org, v8-flag...@chromium.org, was...@google.com, v8-mip...@googlegroups.com, pthier...@chromium.org, mlippau...@chromium.org, verwaes...@chromium.org, dmercadi...@chromium.org, alph+...@chromium.org, jgrube...@chromium.org, v8-ppc...@googlegroups.com, cbruni...@chromium.org, oilpan-r...@chromium.org, lpy+v8...@chromium.org, marja...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com

Maksim Ivanov added 1 comment

File src/objects/string-inl.h
Line 138, Patchset 3 (Latest): if (IsExternalOneByteString(this))
Maksim Ivanov . unresolved
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie3f22804d76b8ed4d8e9146e3de9a9da01d19120
    Gerrit-Change-Number: 7226896
    Gerrit-PatchSet: 3
    Gerrit-Owner: Maksim Ivanov <em...@chromium.org>
    Gerrit-Reviewer: Maksim Ivanov <em...@chromium.org>
    Gerrit-CC: Fadi Meawad <fme...@chromium.org>
    Gerrit-CC: Hannes Payer <hpa...@chromium.org>
    Gerrit-Comment-Date: Mon, 15 Dec 2025 11:20:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy

    Maksim Ivanov (Gerrit)

    unread,
    Dec 18, 2025, 7:46:44 AM (11 days ago) Dec 18
    to Fadi Meawad, Hannes Payer, AyeAye, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, leszek...@chromium.org, victorgo...@chromium.org, v8-risc...@chromium.org, v8-flag...@chromium.org, was...@google.com, v8-mip...@googlegroups.com, pthier...@chromium.org, mlippau...@chromium.org, verwaes...@chromium.org, dmercadi...@chromium.org, alph+...@chromium.org, jgrube...@chromium.org, v8-ppc...@googlegroups.com, cbruni...@chromium.org, oilpan-r...@chromium.org, lpy+v8...@chromium.org, marja...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com

    Maksim Ivanov abandoned this change

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: abandon
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages