Fix HeapVector type constraints [chromium/src : main]
0 views
Skip to first unread message
Omer Katz (Gerrit)
Sep 23, 2025, 4:54:01 AMSep 23
to Kentaro Hara, Michael Lippautz, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Javier Fernandez, blink-re...@chromium.org, oilpan-rev...@chromium.org, kouhe...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Michael Lippautz
Omer Katz added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File third_party/blink/renderer/core/layout/grid/grid_layout_algorithm.cc
Line 3041, Patchset 1:
HeapVector<Member<const GridItemData>, 16> reordered_grid_items;Michael Lippautz . resolved
Omer KatzShouldn't this be caught by a simple static assert? It's pointer to GCed instead of Member.
Good point. I fixed the assert now as well.
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Sep 23, 2025, 5:03:56 AMSep 23
to Omer Katz, Kentaro Hara, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Javier Fernandez, blink-re...@chromium.org, oilpan-rev...@chromium.org, kouhe...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Omer Katz
Michael Lippautz voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Omer Katz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Sep 23, 2025, 5:07:37 AMSep 23
to Michael Lippautz, Kentaro Hara, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Javier Fernandez, blink-re...@chromium.org, oilpan-rev...@chromium.org, kouhe...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Omer Katz voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 23, 2025, 5:46:14 AMSep 23
to Omer Katz, Michael Lippautz, Kentaro Hara, AyeAye, chromium...@chromium.org, Javier Fernandez, blink-re...@chromium.org, oilpan-rev...@chromium.org, kouhe...@chromium.org, kinuko...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix HeapVector type constraints
The assert for pointer to GCed was broken and missed a case in
GridLayoutAlgorithm. This CL fixes the assert and adds an equivalent
one for traceable types.
Drive-by: Fix the GridLayoutAlgorithm case.
Bug: 329102390
Change-Id: Icd04e768d6180fb9da516b95c0d540be97803fac
Commit-Queue: Omer Katz <omer...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1519224}
Files:
- M third_party/blink/renderer/core/layout/grid/grid_layout_algorithm.cc
- M third_party/blink/renderer/platform/heap/collection_support/heap_vector.h
- M third_party/blink/renderer/platform/wtf/type_traits.h
Change size: S
Delta: 3 files changed, 12 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages