[cppgc] Fix ASAN false positive in handle location [v8/v8 : main]
0 views
Skip to first unread message
Dominik Inführ (Gerrit)
May 22, 2026, 1:42:26 AM (9 days ago) May 22
to Michael Lippautz, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org
Attention needed from Michael Lippautz
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Dominik Inführ . resolved
PTAL, I guess it makes sense to make this a separate CL now..
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
May 22, 2026, 3:31:59 AM (9 days ago) May 22
to Dominik Inführ, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org
Attention needed from Dominik Inführ
Michael Lippautz voted and added 2 comments![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
2 comments
Patchset-level comments
Michael Lippautz . resolved
lgtm
File include/cppgc/cross-thread-persistent.h
Line 410, Patchset 3 (Latest):
V8_CLANG_NO_SANITIZE("address")Michael Lippautz . unresolved
Can you describe here more what we need to exclude sanitization.
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
May 22, 2026, 5:05:52 AM (9 days ago) May 22
to Michael Lippautz, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Auto-Submit | +1 |
1 comment
File include/cppgc/cross-thread-persistent.h
Can you describe here more what we need to exclude sanitization.
Dominik Inführ
We don't actually need the V8_CLANG_NO_SANITIZE("address") annotation here. I dropped it and added a comment to the other use. I hope this is what you had in mind.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
May 22, 2026, 5:06:35 AM (9 days ago) May 22
to Michael Lippautz, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
May 22, 2026, 5:07:05 AM (9 days ago) May 22
to Dominik Inführ, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org
Attention needed from Dominik Inführ
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
1 comment
File include/cppgc/cross-thread-persistent.h
Line 410, Patchset 3:
V8_CLANG_NO_SANITIZE("address")Michael Lippautz . resolved
Dominik InführCan you describe here more what we need to exclude sanitization.
We don't actually need the V8_CLANG_NO_SANITIZE("address") annotation here. I dropped it and added a comment to the other use. I hope this is what you had in mind.
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
May 22, 2026, 6:06:08 AM (9 days ago) May 22
to Dominik Inführ, Michael Lippautz, android-bu...@system.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[cppgc] Fix ASAN false positive in handle location
Enabling cppgc_enable_object_names causes ASAN false positives
when iterating cross-thread persistents. This is because of the
access to the location_ field. This CL fixes this by silencing
ASAN for this access similar to what we do for GetNodeFromGC() or
ClearFromGC().
Bug: 497855658
Change-Id: I6af31de5b6273a8cfde835388dbf64e826a65ef9
Auto-Submit: Dominik Inführ <dinf...@chromium.org>
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#107520}
Files:
- M include/cppgc/cross-thread-persistent.h
- M include/cppgc/internal/pointer-policies.h
- M include/cppgc/visitor.h
Change size: S
Delta: 3 files changed, 27 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages