[heap] Cleanup HeapVector type constraints [chromium/src : main]

0 views
Skip to first unread message

Omer Katz (Gerrit)

unread,
Sep 22, 2025, 7:59:52 AMSep 22
to Michael Lippautz, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Michael Lippautz

Omer Katz voted and added 1 comment

Votes added by Omer Katz

Commit-Queue+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8f7801f1100569df72d7303d4d2cbae01c7a0ec3
Gerrit-Change-Number: 6973576
Gerrit-PatchSet: 1
Gerrit-Owner: Omer Katz <omer...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Mon, 22 Sep 2025 11:59:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
Sep 22, 2025, 8:42:32 AMSep 22
to Omer Katz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org
Attention needed from Omer Katz

Michael Lippautz voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Omer Katz
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8f7801f1100569df72d7303d4d2cbae01c7a0ec3
    Gerrit-Change-Number: 6973576
    Gerrit-PatchSet: 1
    Gerrit-Owner: Omer Katz <omer...@chromium.org>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-Attention: Omer Katz <omer...@chromium.org>
    Gerrit-Comment-Date: Mon, 22 Sep 2025 12:42:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Omer Katz (Gerrit)

    unread,
    Sep 22, 2025, 8:54:21 AMSep 22
    to Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org

    Omer Katz voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8f7801f1100569df72d7303d4d2cbae01c7a0ec3
    Gerrit-Change-Number: 6973576
    Gerrit-PatchSet: 1
    Gerrit-Owner: Omer Katz <omer...@chromium.org>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-Comment-Date: Mon, 22 Sep 2025 12:54:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 22, 2025, 8:57:41 AMSep 22
    to Omer Katz, Michael Lippautz, chromium...@chromium.org, Kentaro Hara, blink-...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [heap] Cleanup HeapVector type constraints

    Since the split between HeapVector and GCedHeapVector, the HeapVector
    exception in the type constraints is no longer needed
    Bug: 392817527
    Change-Id: I8f7801f1100569df72d7303d4d2cbae01c7a0ec3
    Reviewed-by: Michael Lippautz <mlip...@chromium.org>
    Commit-Queue: Omer Katz <omer...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1518648}
    Files:
    • M third_party/blink/renderer/platform/heap/collection_support/heap_vector.h
    • M third_party/blink/renderer/platform/heap/test/heap_compact_test.cc
    Change size: M
    Delta: 2 files changed, 20 insertions(+), 33 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Michael Lippautz
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8f7801f1100569df72d7303d4d2cbae01c7a0ec3
    Gerrit-Change-Number: 6973576
    Gerrit-PatchSet: 2
    Gerrit-Owner: Omer Katz <omer...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages