[api] Enforce tag range for v8::Object::Wrap [v8/v8 : main]
1 view
Skip to first unread message
Andreas Haas (Gerrit)
Jun 10, 2026, 3:44:14 AMJun 10
to Michael Lippautz, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, oilpan-r...@chromium.org, cbruni...@chromium.org
Attention needed from Michael Lippautz
Andreas Haas added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Andreas Haas . resolved
PTAL
I don't think we should remove `kDefaultTag`, as it is used by other embedders. For them, a testing tag does not seem correct. But I added a comment that only embedders that don't use the heap sandbox should use it.
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Jun 10, 2026, 9:49:38 AMJun 10
to Andreas Haas, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, oilpan-r...@chromium.org, cbruni...@chromium.org
Attention needed from Andreas Haas
Michael Lippautz voted and added 2 comments![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
2 comments
Patchset-level comments
Michael Lippautz . resolved
lgtm
File include/v8-sandbox.h
Line 67, Patchset 7 (Latest):
kDefaultTag,Michael Lippautz . unresolved
Can we put this behind !V8_ENABLE_SANDBOX? This should be available on the API and avoid future pitfalls our configurations.
Related details
Attention is currently required from:
- Andreas Haas
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andreas Haas (Gerrit)
Jun 11, 2026, 4:01:37 AMJun 11
to Michael Lippautz, v8-s...@luci-project-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, oilpan-r...@chromium.org, cbruni...@chromium.org
Andreas Haas voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andreas Haas
| Commit-Queue | +2 |
Can we put this behind !V8_ENABLE_SANDBOX? This should be available on the API and avoid future pitfalls our configurations.
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 11, 2026, 4:03:35 AMJun 11
to Andreas Haas, Michael Lippautz, android-bu...@system.gserviceaccount.com, oilpan-r...@chromium.org, cbruni...@chromium.org
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
7 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: include/v8-sandbox.h
Insertions: 3, Deletions: 2.
@@ -62,9 +62,10 @@
kInspectorTaskInfoTag,
kLastV8InternalTag,
- // A default tag to be used by embedders that don't use the V8 heap sandbox.
- // If the sandbox is enabled, type-specific tags should be used instead.
+#if !V8_ENABLE_SANDBOX
+ // Embedders that use the sandbox should use specific tags for each type.
kDefaultTag,
+#endif // !V8_ENABLE_SANDBOX
kLastObjectWrappableTag = 0x7ffc,
kZappedEntryTag = 0x7ffd,
```
Change information
Commit message:
[api] Enforce tag range for v8::Object::Wrap
Add static assertions and a DCHECK to ensure that the CppHeapPointerTag
used in v8::Object::Wrap is always within the kObjectWrappableTagRange.
Additionally, this CL removes all uses of
`CppHeapPointerTag::kDefaultTag` in V8.
Bug: 519655841
Change-Id: I42e8a9a0f0ca7c16eb68e44941d1d283af3a7044
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Andreas Haas <ah...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#107902}
Files:
- M include/v8-object.h
- M include/v8-sandbox.h
- M src/api/api.cc
- M test/benchmarks/cpp/bindings.cc
- M test/cctest/test-api.cc
- M test/cctest/test-serialize.cc
- M test/unittests/heap/cppgc-js/embedder-roots-handler-unittest.cc
- M test/unittests/heap/cppgc-js/unified-heap-snapshot-unittest.cc
- M test/unittests/heap/cppgc-js/unified-heap-utils.cc
Change size: M
Delta: 9 files changed, 42 insertions(+), 27 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages