Fix OldToNewRememberedSet being undefined when using v8-gn.h [v8/v8 : main]
0 views
Skip to first unread message
Max Ihlenfeldt (Gerrit)
Jul 16, 2025, 10:23:41 AMJul 16
to Michael Lippautz, Anton Bikineev, Hannes Payer, V8 LUCI CQ, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Anton Bikineev and Michael Lippautz
Max Ihlenfeldt added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Max Ihlenfeldt . resolved
Michael, Anton, PTAL. (Need two CR+1's due to not being a V8 committer.)
Related details
Attention is currently required from:
- Anton Bikineev
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Jul 16, 2025, 10:26:43 AMJul 16
to Anton Bikineev, Hannes Payer, V8 LUCI CQ, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Anton Bikineev and Max Ihlenfeldt
Michael Lippautz voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Anton Bikineev
- Max Ihlenfeldt
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Max Ihlenfeldt (Gerrit)
Jul 21, 2025, 4:47:39 AMJul 21
to Michael Lippautz, Anton Bikineev, Hannes Payer, V8 LUCI CQ, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Anton Bikineev
Max Ihlenfeldt voted and added 1 comment![]( "Open in Gerrit")
Votes added by Max Ihlenfeldt
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Max Ihlenfeldt . resolved
Anton, gentle ping. I need two CR+1's due to not being a V8 committer.
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bikineev (Gerrit)
Jul 22, 2025, 5:02:30 AMJul 22
to Michael Lippautz, Hannes Payer, V8 LUCI CQ, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Max Ihlenfeldt
Anton Bikineev voted and added 1 comment![]( "Open in Gerrit")
Votes added by Anton Bikineev
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Max Ihlenfeldt
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Max Ihlenfeldt (Gerrit)
Jul 23, 2025, 12:28:54 AMJul 23
to Anton Bikineev, Michael Lippautz, Hannes Payer, V8 LUCI CQ, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Max Ihlenfeldt voted and added 1 comment![]( "Open in Gerrit")
Votes added by Max Ihlenfeldt
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jul 23, 2025, 1:10:53 AMJul 23
to Anton Bikineev, Michael Lippautz, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix OldToNewRememberedSet being undefined when using v8-gn.h
Similar to https://crrev.com/c/6732775, we need to include `v8config.h`
before checking if `CPPGC_YOUNG_GENERATION` is defined.
Change-Id: Ib76636ef7e778bfd2bad19b9dbcb550c1e4c1011
Bug: None
Auto-Submit: Max Ihlenfeldt <m...@igalia.com>
Commit-Queue: Max Ihlenfeldt <m...@igalia.com>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Reviewed-by: Anton Bikineev <biki...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#101578}
Files:
- M src/heap/cppgc/remembered-set.cc
- M src/heap/cppgc/remembered-set.h
Change size: XS
Delta: 2 files changed, 4 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz, +1 by Anton Bikineev
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages