[cppgc][test] Fix flakiness in ReuseMemoryFromFreelist [v8/v8 : main]
0 views
Skip to first unread message
Michael Lippautz (Gerrit)
10:06 AM (14 hours ago) 10:06 AM
to Anton Bikineev, V8 LUCI CQ, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Anton Bikineev
Michael Lippautz voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bikineev (Gerrit)
10:13 AM (14 hours ago) 10:13 AM
to Michael Lippautz, V8 LUCI CQ, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Anton Bikineev voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
10:59 AM (13 hours ago) 10:59 AM
to Anton Bikineev, Michael Lippautz, oilpan-r...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[cppgc][test] Fix flakiness in ReuseMemoryFromFreelist
The test used to rely on PreciseGC() which releases pooled pages.
If the virtual memory is released back to the OS (e.g. on 32-bit),
the subsequent allocation might get a different address even if
it is the first one in a new page.
This fix ensures that memory is retained in the pool by using
kRetainMemory free memory handling during the test's GC.
Bug: 487545714
Change-Id: Iadec6163079b519032ac71f49f3fecddbab71a88
Commit-Queue: Anton Bikineev <biki...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105530}
Files:
- M test/unittests/heap/cppgc/allocation-unittest.cc
Change size: S
Delta: 1 file changed, 8 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages