base:: Replace most usages of AsAtomicPtr with std::atomic_ref [v8/v8 : main]
0 views
Skip to first unread message
Michael Lippautz (Gerrit)
Dec 4, 2025, 1:42:31 PM (4 days ago) Dec 4
to Omer Katz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Omer Katz
Michael Lippautz voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Omer Katz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Dec 4, 2025, 2:45:47 PM (4 days ago) Dec 4
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Omer Katz voted and added 2 comments![]( "Open in Gerrit")
Votes added by Omer Katz
| Code-Review | +1 |
2 comments
Patchset-level comments
Commit Message
Line 7, Patchset 6 (Latest):
base:: Replace most usages of AsAtomicPtr with std::atomic_refOmer Katz . unresolved
Why not all?
I think you could also include the instances in `v8/src/heap/cppgc/heap-page.h` in this CL.
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Dec 4, 2025, 3:53:10 PM (4 days ago) Dec 4
to Omer Katz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Omer Katz
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Commit Message
Line 7, Patchset 6:
base:: Replace most usages of AsAtomicPtr with std::atomic_refOmer Katz . resolved
Why not all?
I think you could also include the instances in `v8/src/heap/cppgc/heap-page.h` in this CL.
Michael Lippautz
Added heap-page.h.
Why not all: The remaining uses are non-trivial:
- JS atomic: would require assignment operator which is deleted on the ref.
- Counters: Does expose the atomic ptr to other dependencies and I have not full parsed the necessary APIs for that on atomic_ref yet.
Related details
Attention is currently required from:
- Omer Katz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Dec 4, 2025, 3:55:35 PM (4 days ago) Dec 4
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Omer Katz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Omer Katz
| Code-Review | +1 |
| Commit-Queue | +2 |
Omer Katz . resolved
lgtm
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Dec 4, 2025, 4:56:31 PM (4 days ago) Dec 4
to Michael Lippautz, Omer Katz, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
base:: Replace most usages of AsAtomicPtr with std::atomic_ref
std::atomic_ref is the better primitive and allows avoiding the UB
cast to atomic.
Change-Id: I7c90e0bf313229dcfa5c242c8adff177a3b05986
Reviewed-by: Omer Katz <omer...@chromium.org>
Commit-Queue: Michael Lippautz <mlip...@chromium.org>
Auto-Submit: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Omer Katz <omer...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104127}
Files:
- M src/base/atomic-utils.h
- M src/heap/cppgc/heap-object-header.h
- M src/heap/cppgc/heap-page.h
- M src/heap/cppgc/object-start-bitmap.h
- M src/heap/sweeper.cc
- M test/unittests/heap/cppgc/heap-object-header-unittest.cc
Change size: M
Delta: 6 files changed, 47 insertions(+), 40 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Omer Katz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages