[wtf] Add active iterator checks for Vector [chromium/src : main]
0 views
Skip to first unread message
Keishi Hattori (Gerrit)
Jun 24, 2026, 1:54:44 AM (8 days ago) Jun 24
to Kent Tamura, Kentaro Hara, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, oilpan-rev...@chromium.org, kouhe...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura
Keishi Hattori added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Jun 24, 2026, 2:15:38 AM (8 days ago) Jun 24
to Keishi Hattori, Kent Tamura, Kentaro Hara, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, oilpan-rev...@chromium.org, kouhe...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Keishi Hattori
Kent Tamura voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Keishi Hattori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keishi Hattori (Gerrit)
Jun 24, 2026, 3:00:57 AM (8 days ago) Jun 24
to Kent Tamura, Kentaro Hara, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, oilpan-rev...@chromium.org, kouhe...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Keishi Hattori voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 24, 2026, 3:04:40 AM (8 days ago) Jun 24
to Keishi Hattori, Kent Tamura, Kentaro Hara, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, oilpan-rev...@chromium.org, kouhe...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[wtf] Add active iterator checks for Vector
The plan was to use BRP ref count for Vector but it turned out
that the atomics was a huge performance overhead.
This CL adds active iterator checks that were added for HeapVector
to Vector too.
This CL also changes the CL to DumpWithoutCrash instead of crashing on
detection.
Change-Id: I2d91dc90bb9d084db672b46a79eff9db6fb68b1d
Reviewed-by: Kent Tamura <tk...@chromium.org>
Commit-Queue: Keishi Hattori <kei...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1651533}
Files:
- M third_party/blink/renderer/platform/heap/collection_support/heap_deque.h
- M third_party/blink/renderer/platform/heap/collection_support/heap_linked_hash_set.h
- M third_party/blink/renderer/platform/heap/collection_support/heap_vector.h
- M third_party/blink/renderer/platform/wtf/BUILD.gn
- M third_party/blink/renderer/platform/wtf/size_assertions.cc
- A third_party/blink/renderer/platform/wtf/vector.cc
- M third_party/blink/renderer/platform/wtf/vector.h
Change size: M
Delta: 7 files changed, 91 insertions(+), 27 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kent Tamura
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages